From unknown Sun Jun 22 17:10:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34776 <34776@debbugs.gnu.org> To: bug#34776 <34776@debbugs.gnu.org> Subject: Status: 27.0.50; Some questions about choose-completion-string-functions Reply-To: bug#34776 <34776@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:10:44 +0000 retitle 34776 27.0.50; Some questions about choose-completion-string-functi= ons reassign 34776 emacs submitter 34776 Eric Abrahamsen severity 34776 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 06 18:05:49 2019 Received: (at submit) by debbugs.gnu.org; 6 Mar 2019 23:05:49 +0000 Received: from localhost ([127.0.0.1]:34794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1fbh-0008Js-AK for submit@debbugs.gnu.org; Wed, 06 Mar 2019 18:05:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1fbe-0008Ja-8j for submit@debbugs.gnu.org; Wed, 06 Mar 2019 18:05:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:48641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1fbZ-0002em-6Y for submit@debbugs.gnu.org; Wed, 06 Mar 2019 18:05:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1fbY-0002O5-AY for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2019 18:05:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1fbX-0002dA-CT for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2019 18:05:40 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:44446 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1fbW-0002Wj-Nt for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2019 18:05:39 -0500 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id ED2BEFA17C for ; Wed, 6 Mar 2019 23:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1551913531; bh=4DqEMMGJCGp+DJ80j8ipXsAy6pcKy60XZs1DVgbAtBs=; h=From:To:Subject:Date:From; b=MciYWcklr6acEw9rq+dQN/zznuBSS2p5GIeqskxpjDxEqLnhgzXkNM2dLXdA1LUAy K8kDcIS2PS4Pg52zvFSGCEtNEIo8ajgtsIzBxBlIDgModACo+UuPMJbKl4pWJl4BU7 1NHK11FUMz9StK3+M0UaOFsL4aL9J9qTsh5G3C5g= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Some questions about choose-completion-string-functions Date: Wed, 06 Mar 2019 15:05:29 -0800 Message-ID: <871s3jeh8m.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 52.70.2.18 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) I'm trying to use `choose-completion-string-functions' to do some "stuff" after the user finishes a completion, and have two questions: 1. The docstring of this variable says it is called with three arguments, but in fact it's called with four: the fourth is passed as nil, and is only there for backward compatibility, apparently. But still, you can't use a function that only accepts three args. I can provide a patch for the docstring if this is correct. 2. The code in `choose-completion-string' behaves as though the above variable is buffer local, but it is never declared to be so. I'm not sure if this is a bug (ie, we should be using `defvar-local'), or whether I should be adding functions here using the (local 'SYMBOL) convention of `add-function'. If that's the case, that's probably also a docstring bug, as we should warn users that they'll want to specify a local variable. WDYT? Eric From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 08 19:05:25 2019 Received: (at 34776) by debbugs.gnu.org; 9 Mar 2019 00:05:25 +0000 Received: from localhost ([127.0.0.1]:36846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h2PUT-0004X6-5l for submit@debbugs.gnu.org; Fri, 08 Mar 2019 19:05:25 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:60650 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h2PUR-0004Wq-6X for 34776@debbugs.gnu.org; Fri, 08 Mar 2019 19:05:24 -0500 Received: from localhost (97-126-92-188.tukw.qwest.net [97.126.92.188]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 6229CFA17C for <34776@debbugs.gnu.org>; Sat, 9 Mar 2019 00:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1552089917; bh=UzmGfd7tW4xBpyhSsrxBN77/FWbsR3t/lV5ou0K+wqw=; h=From:To:Subject:In-Reply-To:References:Date:From; b=DCISpNUq4qAOlW3gaMxVVDUOpjaBeHisPzioZDFnp9oPqZI1QzTo8tO/SSZhRZPOh Gy5QO/QvsH35sDA+gwXu3IB5VDhillWs40cLuctWYHYnyazQeYyWJbt1csVx0Oih1+ oK5eUjdcJzajLYjXugF0Bji5PN5fSID405NyApRw= From: Eric Abrahamsen To: 34776@debbugs.gnu.org Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) In-Reply-To: (GNU bug Tracking System's message of "Wed, 06 Mar 2019 23:06:02 +0000") References: <871s3jeh8m.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Fri, 08 Mar 2019 16:05:16 -0800 Message-ID: <87zhq4zzcz.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Actually it looks like I was wrong about using add-function with choose-completion-string-functions, it's just a plain list you stick functions into. I think it has to be an error not to declare it buffer-local... I've worked around this with `make-local-variable', but I'm halfway sure this should be a defvar-local...? From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 08 21:07:41 2019 Received: (at 34776) by debbugs.gnu.org; 9 Mar 2019 02:07:41 +0000 Received: from localhost ([127.0.0.1]:36876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h2ROn-0007R9-5D for submit@debbugs.gnu.org; Fri, 08 Mar 2019 21:07:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h2ROl-0007Qy-Uu for 34776@debbugs.gnu.org; Fri, 08 Mar 2019 21:07:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2ROg-0002Jy-JF; Fri, 08 Mar 2019 21:07:34 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1h2ROe-0007CR-SA; Fri, 08 Mar 2019 21:07:33 -0500 From: Glenn Morris To: Eric Abrahamsen Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> X-Spook: UNSCOM sweep initiative embassy Centro mindwar ammunition X-Ran: Q^-]u?3b1fzq+j2&4T:I8tp&`IUW{!Rg0_42nvrou|IH7U0S+7q"}4,~3qGqB[31PI$Z%} X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 08 Mar 2019 21:07:32 -0500 In-Reply-To: <87zhq4zzcz.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 08 Mar 2019 16:05:16 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: 34776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen wrote: > Actually it looks like I was wrong about using add-function with > choose-completion-string-functions, it's just a plain list you stick > functions into. I think it has to be an error not to declare it > buffer-local... I've worked around this with `make-local-variable', but > I'm halfway sure this should be a defvar-local...? The two uses in the Emacs code-base use add-hook without LOCAL. completing-read-multiple and ido-common-initialization. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 13 12:51:24 2019 Received: (at 34776) by debbugs.gnu.org; 13 Mar 2019 16:51:25 +0000 Received: from localhost ([127.0.0.1]:42421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h476C-0005Gy-Jr for submit@debbugs.gnu.org; Wed, 13 Mar 2019 12:51:24 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:33472 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4767-0005Gg-CH for 34776@debbugs.gnu.org; Wed, 13 Mar 2019 12:51:23 -0400 Received: from localhost (97-126-92-188.tukw.qwest.net [97.126.92.188]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4C32AFA02C; Wed, 13 Mar 2019 16:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1552495873; bh=jCRrbXIoijqhtM+cAzoP4YX0r6Tlp4REfWEgJMfFZVA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=vFhZL/ZBXR+120L6/4MVtgWnmzrdeDxFacmD7HZ2JgTXe1s9BvlIwar+jtMzLvmnq +nBgDEzgb3nHEmtljgw2+LyK8GQKYULwRu9mCY/3uZwj+s1lbmkSJ0b6iR0nz+Nz4c Az9cSb31yYKCcyZiQGroKYQyCGxV3QX1SWeVKqlo= From: Eric Abrahamsen To: Glenn Morris Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> Date: Wed, 13 Mar 2019 09:51:11 -0700 In-Reply-To: (Glenn Morris's message of "Fri, 08 Mar 2019 21:07:32 -0500") Message-ID: <871s3a90qo.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: 34776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 03/08/19 21:07 PM, Glenn Morris wrote: > Eric Abrahamsen wrote: > >> Actually it looks like I was wrong about using add-function with >> choose-completion-string-functions, it's just a plain list you stick >> functions into. I think it has to be an error not to declare it >> buffer-local... I've worked around this with `make-local-variable', but >> I'm halfway sure this should be a defvar-local...? > > The two uses in the Emacs code-base use add-hook without LOCAL. > completing-read-multiple and ido-common-initialization. You're right, I was misinterpreting the code and comments as saying the functions should be buffer local, when it just meant they *could* be buffer local. I'll use add-hook with LOCAL. So never mind! But I'd still like to add something like the attached, as functions following the current docstring will raise an error. Eric --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=patch.txt diff --git a/lisp/simple.el b/lisp/simple.el index d4ae5ebb1f..0274bdb459 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -8188,6 +8188,9 @@ choose-completion-string-functions BUFFER - the buffer in which the choice should be inserted, BASE-POSITION - where to insert the completion. +Functions should also accept and ignore a potential fourth +argument, passed for backwards compatibility. + If a function in the list returns non-nil, that function is supposed to have inserted the CHOICE in the BUFFER, and possibly exited the minibuffer; no further functions will be called. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 20:03:28 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 00:03:28 +0000 Received: from localhost ([127.0.0.1]:52172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE0i8-0007JL-0c for submit@debbugs.gnu.org; Tue, 09 Apr 2019 20:03:28 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:39186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE0i5-0007J7-C1 for 34776@debbugs.gnu.org; Tue, 09 Apr 2019 20:03:26 -0400 Received: by mail-qk1-f176.google.com with SMTP id c189so154222qke.6 for <34776@debbugs.gnu.org>; Tue, 09 Apr 2019 17:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wzDi3CCn9qpRK5G2QEyVYCFLkZHWccr6HUjEVkmxTKE=; b=DNn8hAUYpd4FEKlGAdYBwq0PHfTkDP/BG8Ed9DTMIhIV+BEBAm71Gr8/OBCaHbgkDp RD0QfW0P1B/c8E7sYcDTB+jZu23eEGaMFGeVbVCRKujGjhnQYaAOPVEzNv+ldBagl7Jz NBijeptWyELdXaejuD1JRDybqzR+tPN9PuaUYZQV9AZXj9GLyytO3XqxSTeLAkNWv57A hgli5w0ciTmsXA/nPMbBVXEo6RbcgYS1OfH+O7FazXXFf42PxZy/DXbWcwy0tg6vGKiR 3qS2GcyikDQ3ngPMaxZ4BTfMuzs4tXIX6UCCKicWsrCpvnqwQPGp23L1/VkO94SyUhyG mIGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wzDi3CCn9qpRK5G2QEyVYCFLkZHWccr6HUjEVkmxTKE=; b=rJ4m68HEixqXU4/mHm5y4nSVc0LYJtm7nzT2CtsSQbf0eITQnU9U6DGQwZCpn9+aVx OrqninNumgmw68T/PZQEc5j6jbbFb5WWieTzgMaILEXGD1znrGV3nrH+FsammV+kl1IK vuIfHU9iBErBkw+/Of4dM/JBJgH+c2KZ1/XTyBUqlUSe1gV1EciWyJN1aJUkNtwLx1dU 0gokUQyNyy9/jazlLjhhqM9cjVzvvbQOp6i/jHQKSIltnOajwVi94d9Pi+UwQW4YjIan B3OOMaU9yLpZSVmv61DR7SJOFMIpCyp6ipXDg5sDFm8ZsTS6oEJOZOTGN4N8947cVCaI tiZg== X-Gm-Message-State: APjAAAVjUnm6946+F+0+1qbx5gMAG/z8jMpWQEX1W+EOgNJsn6Ahq+6Z mt5WoWC2cn+7J2tzeoYF/IlZKRIk X-Google-Smtp-Source: APXvYqxmvYsw8RpjiCD7kYTYuZrVFZi6lWEJ3mzOtIe2d0sLv4x34s2HQj8cfz3UrSN5N1pSBC/www== X-Received: by 2002:ae9:e40f:: with SMTP id q15mr30527966qkc.301.1554854599479; Tue, 09 Apr 2019 17:03:19 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g12sm21340613qki.76.2019.04.09.17.03.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 17:03:18 -0700 (PDT) From: Noam Postavsky To: Eric Abrahamsen Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> Date: Tue, 09 Apr 2019 20:03:17 -0400 In-Reply-To: <871s3a90qo.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 13 Mar 2019 09:51:11 -0700") Message-ID: <87imvmbube.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: Glenn Morris , 34776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > So never mind! But I'd still like to add something like the attached, as > functions following the current docstring will raise an error. > > Eric > > diff --git a/lisp/simple.el b/lisp/simple.el > index d4ae5ebb1f..0274bdb459 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -8188,6 +8188,9 @@ choose-completion-string-functions > BUFFER - the buffer in which the choice should be inserted, > BASE-POSITION - where to insert the completion. > > +Functions should also accept and ignore a potential fourth > +argument, passed for backwards compatibility. > + Looks good to me. And it can go to emacs-26 since it's a doc fix. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 23:16:45 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 03:16:45 +0000 Received: from localhost ([127.0.0.1]:52271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE3jB-0003SZ-FU for submit@debbugs.gnu.org; Tue, 09 Apr 2019 23:16:45 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:49500 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE3j9-0003SG-D7; Tue, 09 Apr 2019 23:16:44 -0400 Received: from localhost (97-113-35-98.tukw.qwest.net [97.113.35.98]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 70DABFA028; Wed, 10 Apr 2019 03:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554866197; bh=qw/zFDhEc+WaIovIkG1vzsPrLtbY/RmbrURGaCb3p9A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=qcS9hukP4gpts0+PgPkmpYJKkHsfJADg9SCY2jraTD/10ySIAd5DDldf7jP6Yuws+ lAm3dHVX+dA590GdsCDYo0QaCBUVUv5Ps3rQMWzWRSTkasE0uh3kymCthFUMJ+QQ/H N28AU91f6pb5Y7dBnrNBlHY2SJlaW4NQyYvSM/l0= From: Eric Abrahamsen To: 34776@debbugs.gnu.org Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> Date: Tue, 09 Apr 2019 20:16:36 -0700 In-Reply-To: <87imvmbube.fsf@gmail.com> (Noam Postavsky's message of "Tue, 09 Apr 2019 20:03:17 -0400") Message-ID: <87y34iim7f.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: 34776-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Eric Abrahamsen writes: > >> So never mind! But I'd still like to add something like the attached, as >> functions following the current docstring will raise an error. >> >> Eric >> >> diff --git a/lisp/simple.el b/lisp/simple.el >> index d4ae5ebb1f..0274bdb459 100644 >> --- a/lisp/simple.el >> +++ b/lisp/simple.el >> @@ -8188,6 +8188,9 @@ choose-completion-string-functions >> BUFFER - the buffer in which the choice should be inserted, >> BASE-POSITION - where to insert the completion. >> >> +Functions should also accept and ignore a potential fourth >> +argument, passed for backwards compatibility. >> + > > Looks good to me. And it can go to emacs-26 since it's a doc fix. Done, thanks. Welcome back! E From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 23:29:22 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 03:29:22 +0000 Received: from localhost ([127.0.0.1]:52279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE3vN-0003n7-Nq for submit@debbugs.gnu.org; Tue, 09 Apr 2019 23:29:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE3vM-0003mu-St for 34776@debbugs.gnu.org; Tue, 09 Apr 2019 23:29:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE3vG-0005mZ-SN; Tue, 09 Apr 2019 23:29:14 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hE3vD-0005gV-HI; Tue, 09 Apr 2019 23:29:11 -0400 From: Glenn Morris To: Noam Postavsky Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> X-Spook: Prevention Adriatic Uzi Serbian DHS DNDO Recruitment X-Ran: x!$.iy5kt/#vGOtY/-NQ~`_9QhV{2ur<[M3I_S(v>w{VmO!0BbZa4,AGre;dU]wLRj&sW' X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 09 Apr 2019 23:29:10 -0400 In-Reply-To: <87imvmbube.fsf@gmail.com> (Noam Postavsky's message of "Tue, 09 Apr 2019 20:03:17 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: Eric Abrahamsen , 34776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > And it can go to emacs-26 since it's a doc fix. The RC said Emacs 26.2 was to be released March 27... Part of making a release is for people to stop changing that branch. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 00:33:32 2019 Received: (at submit) by debbugs.gnu.org; 10 Apr 2019 04:33:32 +0000 Received: from localhost ([127.0.0.1]:52294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE4vT-0005QB-PF for submit@debbugs.gnu.org; Wed, 10 Apr 2019 00:33:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE4vQ-0005Pl-Qx for submit@debbugs.gnu.org; Wed, 10 Apr 2019 00:33:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:43528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE4vL-0005mv-LL for submit@debbugs.gnu.org; Wed, 10 Apr 2019 00:33:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE4vK-00015h-Ml for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 00:33:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_20, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE4vK-0005mC-73; Wed, 10 Apr 2019 00:33:22 -0400 Received: from [109.253.166.16] (port=38134 helo=[10.131.121.239]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hE4vG-00059I-UU; Wed, 10 Apr 2019 00:33:19 -0400 Date: Wed, 10 Apr 2019 07:33:14 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) To: bug-gnu-emacs@gnu.org, Glenn Morris , Noam Postavsky From: Eli Zaretskii Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit Cc: Eric Abrahamsen , 34776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On April 10, 2019 6:29:10 AM GMT+03:00, Glenn Morris wrote: >=20 > > And it can go to emacs-26 since it's a doc fix=2E >=20 > The RC said Emacs 26=2E2 was to be released March 27=2E=2E=2E > Part of making a release is for people to stop changing that branch=2E Unfortunately, that ship has sailed, since within an hour of RC release a = new commit was pushed to the release branch, and another one a week later, = without asking=2E So now the RC tarball will not be able to be renamed any= way, and the rationale for withholding doc changes is null and void=2E "Best laid plans" and all that=2E From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 02:36:12 2019 Received: (at submit) by debbugs.gnu.org; 10 Apr 2019 06:36:12 +0000 Received: from localhost ([127.0.0.1]:52319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE6qC-0000B3-Cf for submit@debbugs.gnu.org; Wed, 10 Apr 2019 02:36:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE6qA-0000An-Vc for submit@debbugs.gnu.org; Wed, 10 Apr 2019 02:36:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:55743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE6q5-0002NG-Pv for submit@debbugs.gnu.org; Wed, 10 Apr 2019 02:36:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE6q4-00036V-Ro for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 02:36:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,RDNS_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE6q3-0002Lw-Us for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 02:36:04 -0400 Received: from [195.159.176.226] (port=46372 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE6q3-0002Km-Ja for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 02:36:03 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hE6q0-000jxO-4U for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 08:36:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) Date: Tue, 09 Apr 2019 23:35:47 -0700 Message-ID: <87mukyiczg.fsf@ericabrahamsen.net> References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:mYO+GDsfHUacuDzCo50RGz7bYvA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > On April 10, 2019 6:29:10 AM GMT+03:00, Glenn Morris wrote: >> >> > And it can go to emacs-26 since it's a doc fix. >> >> The RC said Emacs 26.2 was to be released March 27... >> Part of making a release is for people to stop changing that branch. > > Unfortunately, that ship has sailed, since within an hour of RC > release a new commit was pushed to the release branch, and another one > a week later, without asking. So now the RC tarball will not be able > to be renamed anyway, and the rationale for withholding doc changes is > null and void. > > "Best laid plans" and all that. This sounds like a job for a git hook. I pay fairly close attention to emacs.devel for someone who isn't an Emacs dev, and apparently I missed this billboard. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 03:01:16 2019 Received: (at submit) by debbugs.gnu.org; 10 Apr 2019 07:01:16 +0000 Received: from localhost ([127.0.0.1]:52334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE7ES-0000o7-Ju for submit@debbugs.gnu.org; Wed, 10 Apr 2019 03:01:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE7ER-0000nm-6i for submit@debbugs.gnu.org; Wed, 10 Apr 2019 03:01:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:37181) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE7EM-0001Uh-02 for submit@debbugs.gnu.org; Wed, 10 Apr 2019 03:01:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE7EK-0006b7-VH for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 03:01:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED,BAYES_50, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE7EK-0001Tw-As; Wed, 10 Apr 2019 03:01:08 -0400 Received: from [109.253.166.16] (port=38081 helo=[10.131.121.239]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hE7EJ-00041w-Ie; Wed, 10 Apr 2019 03:01:08 -0400 Date: Wed, 10 Apr 2019 10:01:04 +0300 User-Agent: K-9 Mail for Android In-Reply-To: <87mukyiczg.fsf@ericabrahamsen.net> References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> <87mukyiczg.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) To: bug-gnu-emacs@gnu.org, Eric Abrahamsen , 34776@debbugs.gnu.org From: Eli Zaretskii Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On April 10, 2019 9:35:47 AM GMT+03:00, Eric Abrahamsen wrote: > Eli Zaretskii writes: >=20 > > On April 10, 2019 6:29:10 AM GMT+03:00, Glenn Morris > wrote: > >>=20 > >> > And it can go to emacs-26 since it's a doc fix=2E > >>=20 > >> The RC said Emacs 26=2E2 was to be released March 27=2E=2E=2E > >> Part of making a release is for people to stop changing that > branch=2E > > > > Unfortunately, that ship has sailed, since within an hour of RC > > release a new commit was pushed to the release branch, and another > one > > a week later, without asking=2E So now the RC tarball will not be able > > to be renamed anyway, and the rationale for withholding doc changes > is > > null and void=2E > > > > "Best laid plans" and all that=2E >=20 > This sounds like a job for a git hook=2E I pay fairly close attention to > emacs=2Edevel for someone who isn't an Emacs dev, and apparently I > missed > this billboard=2E Not sure which billboard jou think you missed, but in general, I don't see= here any problem for which a commit hook would be a good solution=2E The = existing hooks are already annoying enough, and are too easy to bypass to b= e reliable=2E From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 03:22:24 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 07:22:24 +0000 Received: from localhost ([127.0.0.1]:52340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE7Yu-0001Kg-Ds for submit@debbugs.gnu.org; Wed, 10 Apr 2019 03:22:24 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:50508 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE7Yr-0001KR-HV for 34776@debbugs.gnu.org; Wed, 10 Apr 2019 03:22:22 -0400 Received: from localhost (97-113-35-98.tukw.qwest.net [97.113.35.98]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B0FC3FA05C; Wed, 10 Apr 2019 07:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554880936; bh=YjRQMl9OLHysUe/EMZGXuZ6y9jwKeCONrv/ZTyQVXV0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=rKhDj7jMVf/9XDypTadlMxxyUXlOEeKu9bMfUkmR8exqBpsxOKNsYWf36ZEdu/T37 0w4nVC7PAgNbSWaIqSXrnvddbOkewp+iqkbmt/TfTfr+08t/K7TiMhPDmKj4QdQCyi LrEIBNEFwd9KurD4jgxz+lcUWrLtoDHeMEyraffI= From: Eric Abrahamsen To: Eli Zaretskii Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> <87mukyiczg.fsf@ericabrahamsen.net> Date: Wed, 10 Apr 2019 00:22:14 -0700 In-Reply-To: (Eli Zaretskii's message of "Wed, 10 Apr 2019 10:01:04 +0300") Message-ID: <877ec2iau1.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: 34776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > On April 10, 2019 9:35:47 AM GMT+03:00, Eric Abrahamsen wrote: >> Eli Zaretskii writes: >> >> > On April 10, 2019 6:29:10 AM GMT+03:00, Glenn Morris >> wrote: >> >> >> >> > And it can go to emacs-26 since it's a doc fix. >> >> >> >> The RC said Emacs 26.2 was to be released March 27... >> >> Part of making a release is for people to stop changing that >> branch. >> > >> > Unfortunately, that ship has sailed, since within an hour of RC >> > release a new commit was pushed to the release branch, and another >> one >> > a week later, without asking. So now the RC tarball will not be able >> > to be renamed anyway, and the rationale for withholding doc changes >> is >> > null and void. >> > >> > "Best laid plans" and all that. >> >> This sounds like a job for a git hook. I pay fairly close attention to >> emacs.devel for someone who isn't an Emacs dev, and apparently I >> missed >> this billboard. > > Not sure which billboard jou think you missed, but in general, I don't > see here any problem for which a commit hook would be a good solution. > The existing hooks are already annoying enough, and are too easy to > bypass to be reliable. What I meant was: if 200 people have the ability to push to the repo, but 50 of them aren't checking the mailing lists regularly, then you call a halt to an RC, that's 50 people who don't know they shouldn't push. It seems like a lot more work to chase after those 50 than to close the gate and reject pushes to that particular release. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 03:29:42 2019 Received: (at submit) by debbugs.gnu.org; 10 Apr 2019 07:29:42 +0000 Received: from localhost ([127.0.0.1]:52356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE7fy-0001Wr-0c for submit@debbugs.gnu.org; Wed, 10 Apr 2019 03:29:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE7fv-0001Wb-Hn for submit@debbugs.gnu.org; Wed, 10 Apr 2019 03:29:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:32910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE7fp-0001zw-08 for submit@debbugs.gnu.org; Wed, 10 Apr 2019 03:29:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE7fn-0003bI-Vu for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 03:29:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,RDNS_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE7fm-0001xo-M7 for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 03:29:31 -0400 Received: from [195.159.176.226] (port=32976 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE7fm-0001x3-Dv for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 03:29:30 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hE7fj-000XZV-CX for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 09:29:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) Date: Wed, 10 Apr 2019 00:29:13 -0700 Message-ID: <87tvf6gvxy.fsf@ericabrahamsen.net> References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> <87mukyiczg.fsf@ericabrahamsen.net> <877ec2iau1.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:KOpjuZAm6gss+PdGcrJAEJggNxw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Eli Zaretskii writes: > >> On April 10, 2019 9:35:47 AM GMT+03:00, Eric Abrahamsen wrote: >>> Eli Zaretskii writes: >>> >>> > On April 10, 2019 6:29:10 AM GMT+03:00, Glenn Morris >>> wrote: >>> >> >>> >> > And it can go to emacs-26 since it's a doc fix. >>> >> >>> >> The RC said Emacs 26.2 was to be released March 27... >>> >> Part of making a release is for people to stop changing that >>> branch. >>> > >>> > Unfortunately, that ship has sailed, since within an hour of RC >>> > release a new commit was pushed to the release branch, and another >>> one >>> > a week later, without asking. So now the RC tarball will not be able >>> > to be renamed anyway, and the rationale for withholding doc changes >>> is >>> > null and void. >>> > >>> > "Best laid plans" and all that. >>> >>> This sounds like a job for a git hook. I pay fairly close attention to >>> emacs.devel for someone who isn't an Emacs dev, and apparently I >>> missed >>> this billboard. >> >> Not sure which billboard jou think you missed, but in general, I don't >> see here any problem for which a commit hook would be a good solution. >> The existing hooks are already annoying enough, and are too easy to >> bypass to be reliable. > > What I meant was: if 200 people have the ability to push to the repo, > but 50 of them aren't checking the mailing lists regularly, then you > call a halt to an RC, that's 50 people who don't know they shouldn't > push. It seems like a lot more work to chase after those 50 than to > close the gate and reject pushes to that particular release. I keep hitting C-c C-s (message-send) instead of C-x C-s (which would save a draft), which I hope will explain my slightly rude tone here. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 04:05:11 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 08:05:12 +0000 Received: from localhost ([127.0.0.1]:52371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8EJ-0002Ta-Kn for submit@debbugs.gnu.org; Wed, 10 Apr 2019 04:05:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:54190 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8EG-0002TF-TZ for 34776@debbugs.gnu.org; Wed, 10 Apr 2019 04:05:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3F752B0BD; Wed, 10 Apr 2019 08:05:03 +0000 (UTC) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> X-Yow: MMM-MM!! So THIS is BIO-NEBULATION! Date: Wed, 10 Apr 2019 10:05:02 +0200 In-Reply-To: (Eli Zaretskii's message of "Wed, 10 Apr 2019 07:33:14 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34776 Cc: eric@ericabrahamsen.net, rgm@gnu.org, 34776@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Apr 10 2019, Eli Zaretskii wrote: > Unfortunately, that ship has sailed, since within an hour of RC release a new commit was pushed to the release branch, and another one a week later, without asking. So now the RC tarball will not be able to be renamed anyway, and the rationale for withholding doc changes is null and void. Why not? Just tag the last commit that is contained in the rc release. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 04:22:57 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 08:22:57 +0000 Received: from localhost ([127.0.0.1]:52376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8VV-0002u8-7q for submit@debbugs.gnu.org; Wed, 10 Apr 2019 04:22:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8VT-0002tv-0q for 34776@debbugs.gnu.org; Wed, 10 Apr 2019 04:22:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8VM-0006Rr-No; Wed, 10 Apr 2019 04:22:48 -0400 Received: from [109.253.166.16] (port=38129 helo=[10.131.121.239]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hE8VL-0004F2-Gp; Wed, 10 Apr 2019 04:22:48 -0400 Date: Wed, 10 Apr 2019 11:22:44 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) To: Andreas Schwab From: Eli Zaretskii Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: eric@ericabrahamsen.net, rgm@gnu.org, 34776@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On April 10, 2019 11:05:02 AM GMT+03:00, Andreas Schwab = wrote: > On Apr 10 2019, Eli Zaretskii wrote: >=20 > > Unfortunately, that ship has sailed, since within an hour of RC > release a new commit was pushed to the release branch, and another one > a week later, without asking=2E So now the RC tarball will not be able > to be renamed anyway, and the rationale for withholding doc changes is > null and void=2E >=20 > Why not? Just tag the last commit that is contained in the rc > release=2E >=20 > Andreas=2E The RC contains several uncommitted changes=2E Hopefully won't happen in = the future=2E From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 04:24:57 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 08:24:57 +0000 Received: from localhost ([127.0.0.1]:52380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8XQ-0002xQ-LV for submit@debbugs.gnu.org; Wed, 10 Apr 2019 04:24:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8XO-0002xD-8i for 34776@debbugs.gnu.org; Wed, 10 Apr 2019 04:24:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8XG-0007kM-0Y; Wed, 10 Apr 2019 04:24:47 -0400 Received: from [109.253.166.16] (port=38085 helo=[10.131.121.239]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hE8XE-0004NK-GJ; Wed, 10 Apr 2019 04:24:45 -0400 Date: Wed, 10 Apr 2019 11:24:41 +0300 User-Agent: K-9 Mail for Android In-Reply-To: <877ec2iau1.fsf@ericabrahamsen.net> References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> <87mukyiczg.fsf@ericabrahamsen.net> <877ec2iau1.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) To: Eric Abrahamsen From: Eli Zaretskii Message-ID: <4CAA6D9F-0402-489C-8DD1-CE2ADBAA42C9@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: 34776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On April 10, 2019 10:22:14 AM GMT+03:00, Eric Abrahamsen wrote: > Eli Zaretskii writes: >=20 > > On April 10, 2019 9:35:47 AM GMT+03:00, Eric Abrahamsen > wrote: > >> Eli Zaretskii writes: > >>=20 > >> > On April 10, 2019 6:29:10 AM GMT+03:00, Glenn Morris > > >> wrote: > >> >>=20 > >> >> > And it can go to emacs-26 since it's a doc fix=2E > >> >>=20 > >> >> The RC said Emacs 26=2E2 was to be released March 27=2E=2E=2E > >> >> Part of making a release is for people to stop changing that > >> branch=2E > >> > > >> > Unfortunately, that ship has sailed, since within an hour of RC > >> > release a new commit was pushed to the release branch, and > another > >> one > >> > a week later, without asking=2E So now the RC tarball will not be > able > >> > to be renamed anyway, and the rationale for withholding doc > changes > >> is > >> > null and void=2E > >> > > >> > "Best laid plans" and all that=2E > >>=20 > >> This sounds like a job for a git hook=2E I pay fairly close attention > to > >> emacs=2Edevel for someone who isn't an Emacs dev, and apparently I > >> missed > >> this billboard=2E > > > > Not sure which billboard jou think you missed, but in general, I > don't > > see here any problem for which a commit hook would be a good > solution=2E > > The existing hooks are already annoying enough, and are too easy to > > bypass to be reliable=2E >=20 > What I meant was: if 200 people have the ability to push to the repo, > but 50 of them aren't checking the mailing lists regularly, then you > call a halt to an RC, that's 50 people who don't know they shouldn't > push=2E It seems like a lot more work to chase after those 50 than to > close the gate and reject pushes to that particular release=2E There's no need to check the mailing list, this stuff is in CONTRIBUTE=2E = That's why I never called for any halts=2E From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 04:40:04 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 08:40:04 +0000 Received: from localhost ([127.0.0.1]:52385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8m4-0003L7-3E for submit@debbugs.gnu.org; Wed, 10 Apr 2019 04:40:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:60428 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8m1-0003KV-9A for 34776@debbugs.gnu.org; Wed, 10 Apr 2019 04:40:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7FA4FB168; Wed, 10 Apr 2019 08:39:55 +0000 (UTC) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> X-Yow: I can see you GUYS an' GALS need a LOT of HELP...You're all very STUPID!! I used to be STUPID, too..before I started watching UHF-TV!! Date: Wed, 10 Apr 2019 10:39:55 +0200 In-Reply-To: (Eli Zaretskii's message of "Wed, 10 Apr 2019 11:22:44 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34776 Cc: eric@ericabrahamsen.net, 34776@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Apr 10 2019, Eli Zaretskii wrote: > On April 10, 2019 11:05:02 AM GMT+03:00, Andreas Schwab wrote: >> On Apr 10 2019, Eli Zaretskii wrote: >> >> > Unfortunately, that ship has sailed, since within an hour of RC >> release a new commit was pushed to the release branch, and another one >> a week later, without asking. So now the RC tarball will not be able >> to be renamed anyway, and the rationale for withholding doc changes is >> null and void. >> >> Why not? Just tag the last commit that is contained in the rc >> release. >> >> Andreas. > > The RC contains several uncommitted changes. Hopefully won't happen in the future. That isn't a problem either. They can be put on a local branch, into which upstream is merged after the tag. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 04:48:38 2019 Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 08:48:38 +0000 Received: from localhost ([127.0.0.1]:52393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8uM-0003Yn-Gf for submit@debbugs.gnu.org; Wed, 10 Apr 2019 04:48:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE8uK-0003Yb-TS for 34776@debbugs.gnu.org; Wed, 10 Apr 2019 04:48:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8uF-0005CL-7K; Wed, 10 Apr 2019 04:48:31 -0400 Received: from [109.253.166.16] (port=38081 helo=[10.131.121.239]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hE8uE-0005Iu-IM; Wed, 10 Apr 2019 04:48:31 -0400 Date: Wed, 10 Apr 2019 11:48:27 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) To: Andreas Schwab From: Eli Zaretskii Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34776 Cc: eric@ericabrahamsen.net, 34776@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On April 10, 2019 11:39:55 AM GMT+03:00, Andreas Schwab = wrote: > On Apr 10 2019, Eli Zaretskii wrote: >=20 > > On April 10, 2019 11:05:02 AM GMT+03:00, Andreas Schwab > wrote: > >> On Apr 10 2019, Eli Zaretskii wrote: > >>=20 > >> > Unfortunately, that ship has sailed, since within an hour of RC > >> release a new commit was pushed to the release branch, and another > one > >> a week later, without asking=2E So now the RC tarball will not be > able > >> to be renamed anyway, and the rationale for withholding doc changes > is > >> null and void=2E > >>=20 > >> Why not? Just tag the last commit that is contained in the rc > >> release=2E > >>=20 > >> Andreas=2E > > > > The RC contains several uncommitted changes=2E Hopefully won't happen > in the future=2E >=20 > That isn't a problem either=2E They can be put on a local branch, into > which upstream is merged after the tag=2E >=20 > Andreas=2E I decided it wasn't worth the hassle of releasing 26=2E2 from a side branc= h=2E From unknown Sun Jun 22 17:10:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 May 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator