GNU bug report logs - #34769
Bug in emacs 26.1 gdb-send match-string applied after non-matching string-match

Previous Next

Full log

Message #16 received at 34769-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tobias Zawada <i_inbox <at> tn-home.de>
Cc: 34769-done <at> debbugs.gnu.org
Subject: Re: bug#34769: Bug in emacs 26.1 gdb-send match-string applied
 after non-matching string-match
Date: Thu, 07 Mar 2019 17:18:20 +0200

> Date: Wed, 6 Mar 2019 21:10:54 +0100 (CET)
> From: Tobias Zawada <i_inbox <at> tn-home.de>
> Cc: 34769 <at> debbugs.gnu.org
> 
> Dear Eli,
> thanks for looking into this.
> 
> > > It is wrong to call (match-string 3 string) if (string-match gdb-control-commands-regexp string) returned nil.
> > ...
> > That is true, and a cleanup is a good idea. But please note that the
> > undefined results are not used if control-command-p is nil, so the
> > issue is not that serious.
> 
> The match data is that one of the previous successful matching operation.
> One gets an args-out-of-range signal if the indexes in the match data are larger than the width of the string argument to match-string. That is how I discovered the error.

You are right; I've now fixed this on the emacs-26 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.