GNU bug report logs - #34765
26.1; with-temp-buffer should not run buffer-list-update-hook

Previous Next

Package: emacs;

Reported by: Alexander Miller <alexanderm <at> web.de>

Date: Tue, 5 Mar 2019 22:58:02 UTC

Severity: normal

Tags: fixed

Found in version 26.1

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 34765 <at> debbugs.gnu.org, alexanderm <at> web.de, monnier <at> IRO.UMontreal.CA
Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook
Date: Thu, 25 Apr 2019 11:50:57 +0300
> Cc: 34765 <at> debbugs.gnu.org, alexanderm <at> web.de, monnier <at> IRO.UMontreal.CA
> From: martin rudalics <rudalics <at> gmx.at>
> Date: Thu, 25 Apr 2019 10:06:18 +0200
> 
>  > I meant to suggest that get-buffer-create sets this flag when the name
>  > of the buffer fits the template of temporary buffers.  Exactly like it
>  > does for code-conversion buffers now.
> 
> We don't have a "template of temporary buffers".

Of course we do: with-temp-buffer produces buffer names that follow
such a template.

> For example, a buffer specified by the BUFNAME arg of
> 'with-output-to-temp-buffer' should not match such a template.

Such buffers should not necessarily be exempt from running the hooks,
AFAIU.  In any case, one can always bind the hook locally to nil in
the body of the macro, right?

> But I'd favor a solution that skips all buffers whose name starts
> with a space as we do for 'other-buffer' or 'unbury-buffer'.

I think this is too drastic a measure.  We should only disable the
hooks in buffers where no one in their right minds will ever want to
run them.




This bug report was last modified 4 years and 152 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.