GNU bug report logs - #34765
26.1; with-temp-buffer should not run buffer-list-update-hook

Previous Next

Full log

Message #203 received at 34765 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 34765 <at> debbugs.gnu.org, rudalics <at> gmx.at, larsi <at> gnus.org,
 monnier <at> iro.umontreal.ca, alexanderm <at> web.de
Subject: Re: bug#34765: 26.1; with-temp-buffer should not run
 buffer-list-update-hook
Date: Sat, 19 Dec 2020 12:33:36 +0200

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  rudalics <at> gmx.at,  larsi <at> gnus.org,
>   34765 <at> debbugs.gnu.org,  alexanderm <at> web.de
> Date: Fri, 18 Dec 2020 18:49:52 +0000
> 
> * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode policy.

This should be in a separate commit, IMO.

> +By default, undo information (@pxref{Undo}) is not recorded in the
> +buffer created by this macro (but @var{body} can enable that, if
> +needed).  The temporary buffer also does not run the hooks
> +@code{kill-buffer-hook}, @code{kill-buffer-query-functions}
> +(@pxref{Killing Buffers}), and @code{buffer-list-update-hook}
> +(@pxref{Buffer List}).

It would be good to have here index entries about undo and those hooks
not being used by default in temporary buffers.

> +Like @code{with-temp-buffer} (@pxref{Definition of with-temp-buffer,,
                                        ^^^^^^^^^^
I think this word will look better if not capitalized.

> +static void
> +run_buffer_list_update_hook (struct buffer *buf)
> +{
> +  if (! (NILP (Vrun_hooks) || (buf && buf->inhibit_buffer_hooks)))
                                  ^^^
Why this test? is it possible for this function to be called with buf
a NULL pointer?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.