From unknown Tue Aug 19 14:23:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3474 <3474@debbugs.gnu.org> To: bug#3474 <3474@debbugs.gnu.org> Subject: Status: 23.0.94; Emacs.app crashes during typing (with patch) Reply-To: bug#3474 <3474@debbugs.gnu.org> Date: Tue, 19 Aug 2025 21:23:22 +0000 retitle 3474 23.0.94; Emacs.app crashes during typing (with patch) reassign 3474 emacs submitter 3474 Wolfgang Lux severity 3474 normal thanks From wolfgang.lux@gmail.com Fri Jun 5 04:57:56 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 5 Jun 2009 11:57:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n55BvpHv016744 for ; Fri, 5 Jun 2009 04:57:53 -0700 Received: from mail.gnu.org ([199.232.76.166]:52301 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MCY3T-0004vD-3W for emacs-pretest-bug@gnu.org; Fri, 05 Jun 2009 07:57:51 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MCY3S-0001kZ-Ev for emacs-pretest-bug@gnu.org; Fri, 05 Jun 2009 07:57:50 -0400 Received: from mail-bw0-f211.google.com ([209.85.218.211]:63637) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCY3S-0001kH-3M for emacs-pretest-bug@gnu.org; Fri, 05 Jun 2009 07:57:50 -0400 Received: by bwz7 with SMTP id 7so83269bwz.42 for ; Fri, 05 Jun 2009 04:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:to:message-id :content-type:from:subject:date:x-mailer; bh=1BpKNqb3B4kA35jLMJbICa0yRsnYdQc0Ai57jCZgb4I=; b=F6TbcQoWYlEtS0ZIRD3yrqQJumq6WyE/mC4/93Yf9yTmUQpfe1g8g601P9Gn1vczT7 /zwAW89pxWTA0Fx1hJ8fEJSvoe1XUrJPGOdl3wIMz0sUupHPI/0qCW8xOblTQXktIu3h nUtBjTWQmEZU6s4fUs21XBD+FTq9ROL3uSwZM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:to:message-id:content-type:from:subject:date:x-mailer; b=A58UUd0F013Fakz1l0qx8xuQFtnOy2nb2rai7YuNoaO8g7rogFDLZoLFAHKpDlEiMF 4u7XxDxe8pGA43FVmvoOO0GkPm//igIYouLkU1j/i5xcQv1covD6yrsmLI72fULGe/rm axRqLr4zWftWg+Tp0aUhZlxLdR4YsP92Fr/yU= Received: by 10.103.213.19 with SMTP id p19mr1088780muq.91.1244203067686; Fri, 05 Jun 2009 04:57:47 -0700 (PDT) Received: from ?212.144.126.125? (dialin-212-144-126-125.pools.arcor-ip.net [212.144.126.125]) by mx.google.com with ESMTPS id 14sm42198muo.3.2009.06.05.04.57.41 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 05 Jun 2009 04:57:47 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v753.1) To: emacs-pretest-bug@gnu.org Message-Id: <416FFC32-AFAF-4A82-97AD-057D332C37C2@gmail.com> Content-Type: multipart/mixed; boundary=Apple-Mail-2--392120180 From: Wolfgang Lux Subject: 23.0.94; Emacs.app crashes during typing (with patch) Date: Fri, 5 Jun 2009 13:57:31 +0200 X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) --Apple-Mail-2--392120180 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I've encountered a few crashes in Emacs.app, which happened while typing when Emacs was a bit busy. It turns out that these crashes were due to an omitted null-pointer check at line 4165 of keyboard.c in function kbd_buffer_get_event(). The attached patch fixes this problem along with a second omitted null-pointer check in line 4323 of the same function. Wolfgang --Apple-Mail-2--392120180 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name=keyboard.patch Content-Disposition: attachment; filename=keyboard.patch --- src/keyboard.c.~1.1005.~ 2009-05-28 17:08:04.000000000 +0200 +++ src/keyboard.c 2009-06-02 13:39:39.000000000 +0200 @@ -4162,7 +4162,8 @@ else obj = Fcons (intern ("ns-unput-working-text"), Qnil); kbd_fetch_ptr = event + 1; - *used_mouse_menu = 1; + if (used_mouse_menu) + *used_mouse_menu = 1; } #endif @@ -4319,7 +4320,8 @@ #endif #ifdef HAVE_NS /* certain system events are non-key events */ - if (event->kind == NS_NONKEY_EVENT) + if (used_mouse_menu + && event->kind == NS_NONKEY_EVENT) *used_mouse_menu = 1; #endif --Apple-Mail-2--392120180-- From cyd@stupidchicken.com Sun Jun 7 14:49:29 2009 Received: (at 3474) by emacsbugs.donarmstrong.com; 7 Jun 2009 21:49:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.3 required=4.0 tests=AWL,GMAIL,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n57LnQtp004479 for <3474@emacsbugs.donarmstrong.com>; Sun, 7 Jun 2009 14:49:27 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id E5E0757E246; Sun, 7 Jun 2009 17:49:29 -0400 (EDT) From: Chong Yidong To: Adrian Robert Cc: 3474@debbugs.gnu.org Subject: Re: 23.0.94; Emacs.app crashes during typing (with patch) Date: Sun, 07 Jun 2009 17:49:29 -0400 Message-ID: <87vdn7ogt2.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Adrian, could you review this patch? Wolfgang Lux wrote: > I've encountered a few crashes in Emacs.app, which happened while > typing when Emacs was a bit busy. It turns out that these crashes > were due to an omitted null-pointer check at line 4165 of keyboard.c > in function kbd_buffer_get_event(). The attached patch fixes this > problem along with a second omitted null-pointer check in line 4323 > of the same function. --- src/keyboard.c.~1.1005.~ 2009-05-28 17:08:04.000000000 +0200 +++ src/keyboard.c 2009-06-02 13:39:39.000000000 +0200 @@ -4162,7 +4162,8 @@ else obj = Fcons (intern ("ns-unput-working-text"), Qnil); kbd_fetch_ptr = event + 1; - *used_mouse_menu = 1; + if (used_mouse_menu) + *used_mouse_menu = 1; } #endif @@ -4319,7 +4320,8 @@ #endif #ifdef HAVE_NS /* certain system events are non-key events */ - if (event->kind == NS_NONKEY_EVENT) + if (used_mouse_menu + && event->kind == NS_NONKEY_EVENT) *used_mouse_menu = 1; #endif From adrian.b.robert@gmail.com Mon Jun 8 01:27:43 2009 Received: (at 3474) by emacsbugs.donarmstrong.com; 8 Jun 2009 08:27:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.5 required=4.0 tests=AWL,GMAIL,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-pz0-f191.google.com (mail-pz0-f191.google.com [209.85.222.191]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n588RdEX010437 for <3474@emacsbugs.donarmstrong.com>; Mon, 8 Jun 2009 01:27:41 -0700 Received: by pzk29 with SMTP id 29so147019pzk.19 for <3474@emacsbugs.donarmstrong.com>; Mon, 08 Jun 2009 01:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:in-reply-to:references :mime-version:content-type:message-id:cc:content-transfer-encoding :from:subject:date:to:x-mailer; bh=soNYblwUlg18zGkQ0W+JdIVm86yRakVII7cMJvTtf2k=; b=cqd24vre12XNFf2Ua8/BniMXN7hqNqvavWYK/kA8tE3tvCB51V2o3xqrArDeESnNCQ uV+KbXFFmyOalWgJD9cDSH/BJsCjfhBIlNTWVnU7W0qboCJm3XJNxxU6/n6Z7/7uHsIr M3xfMGTxZu2cgNKhCxZj2DteuOtblReT7qdB0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=in-reply-to:references:mime-version:content-type:message-id:cc :content-transfer-encoding:from:subject:date:to:x-mailer; b=ugNgDCSk3+QWeWPbWxF72QdvdLLZVmTwqegf8OnppG9YmN6Om1eeIO6EElnZOBSBWt DJ79pWWn8QE3fD1LeH7X3Ez0GnBBgGlQrj359dXkQPbm5k5kWoVhajq8hx/a23C82csL k69foUWX1WaNZu0WvGhaHOLbU3PXYMUnjKZow= Received: by 10.142.49.4 with SMTP id w4mr2109391wfw.174.1244449653885; Mon, 08 Jun 2009 01:27:33 -0700 (PDT) Received: from ?192.168.1.8? (118.172.29.132.adsl.dynamic.totbb.net [118.172.29.132]) by mx.google.com with ESMTPS id 24sm8465423wfc.17.2009.06.08.01.27.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 08 Jun 2009 01:27:33 -0700 (PDT) In-Reply-To: <87vdn7ogt2.fsf@cyd.mit.edu> References: <87vdn7ogt2.fsf@cyd.mit.edu> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Cc: 3474@debbugs.gnu.org Content-Transfer-Encoding: 7bit From: Adrian Robert Subject: Re: 23.0.94; Emacs.app crashes during typing (with patch) Date: Mon, 8 Jun 2009 15:28:11 +0700 To: Chong Yidong X-Mailer: Apple Mail (2.753.1) On Jun 8, 2009, at 4:49 AM, Chong Yidong wrote: > Adrian, could you review this patch? It looks OK to me, I'm checking it in. Other parts of that function do similar null checks and don't behave specially if they can't set it. -Adrian > > > Wolfgang Lux wrote: > >> I've encountered a few crashes in Emacs.app, which happened while >> typing when Emacs was a bit busy. It turns out that these crashes >> were due to an omitted null-pointer check at line 4165 of keyboard.c >> in function kbd_buffer_get_event(). The attached patch fixes this >> problem along with a second omitted null-pointer check in line 4323 >> of the same function. > > --- src/keyboard.c.~1.1005.~ 2009-05-28 17:08:04.000000000 +0200 > +++ src/keyboard.c 2009-06-02 13:39:39.000000000 +0200 > @@ -4162,7 +4162,8 @@ > else > obj = Fcons (intern ("ns-unput-working-text"), Qnil); > kbd_fetch_ptr = event + 1; > - *used_mouse_menu = 1; > + if (used_mouse_menu) > + *used_mouse_menu = 1; > } > #endif > > @@ -4319,7 +4320,8 @@ > #endif > #ifdef HAVE_NS > /* certain system events are non-key events */ > - if (event->kind == NS_NONKEY_EVENT) > + if (used_mouse_menu > + && event->kind == NS_NONKEY_EVENT) > *used_mouse_menu = 1; > #endif > From cyd@stupidchicken.com Mon Jun 8 07:52:52 2009 Received: (at 3474-done) by emacsbugs.donarmstrong.com; 8 Jun 2009 14:52:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.3 required=4.0 tests=AWL,GMAIL,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n58EqlmZ009583 for <3474-done@emacsbugs.donarmstrong.com>; Mon, 8 Jun 2009 07:52:48 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id B6A1557E24D; Mon, 8 Jun 2009 10:52:51 -0400 (EDT) From: Chong Yidong To: Adrian Robert Cc: 3474-done@debbugs.gnu.org Subject: Re: 23.0.94; Emacs.app crashes during typing (with patch) References: <87vdn7ogt2.fsf@cyd.mit.edu> Date: Mon, 08 Jun 2009 10:52:51 -0400 In-Reply-To: (Adrian Robert's message of "Mon, 8 Jun 2009 15:28:11 +0700") Message-ID: <87d49eaibg.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Adrian Robert writes: >> Adrian, could you review this patch? > > It looks OK to me, I'm checking it in. Other parts of that function > do similar null checks and don't behave specially if they can't set > it. Thanks. From unknown Tue Aug 19 14:23:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Jul 2009 14:24:19 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator