Subject: Re: [bug#34728] [PATCH] Update Wireshark to 3.0.0

From: Nicolas Goaziou <[email-masked]>
Date: Tue, 12 Mar 2019 12:19:22 +0100

Hello,

Thank you for the review.

Ludovic Courtès <[email-masked]> writes:

> Nicolas Goaziou <[email-masked]> skribis:
>
>> +       ;; "CMakeLists.txt" uses $ORIGIN, which seems to confuse
>> +       ;; `validate-runpath' phase.
>> +       ;;
>> +       ;; Errors are like the following:
>> +       ;; "/gnu/store/...wireshark-3.0.0/lib/wireshark/plugins/3.0/epan/ethercat.so:
>> +       ;; error: depends on 'libwireshark.so.12', which cannot be found in
>> +       ;; RUNPATH".  That is, "/gnu/store/...wireshark-3.0.0./lib" doesn't
>> +       ;; seem to belong to RUNPATH.
>
> What’s the RUNPATH on ethercat.so?
>
>   readelf -a ethercat.so | grep RUNPATH

 0x000000000000001d (RUNPATH)            Bibliothèque runpath:[:/gnu/store/...-glibc-2.28/lib:/gnu/store/...-gcc-5.5.0-lib/lib:/gnu/store/...-glib-2.56.3/lib:/gnu/store/...-libpcap-1.9.0/lib:/gnu/store/...-libgcrypt-1.8.3/lib:/gnu/store/...-libgpg-error-1.32/lib:/gnu/store/...-gnutls-3.6.5/lib:/gnu/store/...-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../..]

> And where is libwireshark.so.12?

In "/gnu/store/...wireshark-3.0.0/lib".

I don't understand why this is getting removed.

> ‘validate-runpath’ does interpret $ORIGIN, but maybe there’s a but
> there.

Then my remark about $ORIGIN is wrong. 

Regards,

-- 
Nicolas Goaziou