Subject: bug#34724: closed (Re: [bug#34724] Guix patch: emacs-debpaste)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 11 Mar 2019 22:08:02 +0000

Your bug report

#34724: Guix patch: emacs-debpaste

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34724: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34724
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#34724] Guix patch: emacs-debpaste
From: Ludovic Courtès <[email-masked]>
To: Brian Leung <[email-masked]>
Cc: [email-masked]
Date: Mon, 11 Mar 2019 23:07:29 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Brian,

I applied the first patch with these changes to address issues reported
by ‘guix lint’:

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2e6cb7c627..b15917113b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11363,7 +11363,7 @@ Org-mode.  It features:
         (revision "1"))
     (package
       (name "emacs-xml-rpc")
-      (version (git-version "0" revision commit))
+      (version (git-version "1.6.12" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -11376,13 +11376,13 @@ Org-mode.  It features:
            "0xa54z52rsfl3n0xgmbycj4zazp8ksgdwcq56swzs6wp72zlalmj"))))
       (build-system emacs-build-system)
       (home-page "https://github.com/hexmode/xml-rpc-el")
-      (synopsis "This is an XML-RPC client implementation in Elisp,
-capable of both synchronous and asynchronous method calls using the url
-package's async retrieval functionality.")
-      (description "@file{xml-rpc.el} represents XML-RPC datatypes as Lisp values,
-automatically converting to and from the XML datastructures as needed, both
-for method parameters and return values, making using XML-RPC methods fairly
-transparent to the Lisp code.")
+      (synopsis "XML-RPC client for Emacs")
+      (description "This package provides an XML-RPC client for Emacs capable
+of both synchronous and asynchronous method calls using the @code{url}
+package's async retrieval functionality.  @file{xml-rpc.el} represents XML-RPC
+datatypes as Lisp values, automatically converting to and from the XML
+datastructures as needed, both for method parameters and return values, making
+using XML-RPC methods fairly transparent to the Lisp code.")
       (license license:gpl3+))))
 
 (define-public emacs-fish-completion

Likewise for the second patch:

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8d521cffce..69ea0b3b74 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11362,24 +11362,23 @@ Org-mode.  It features:
   (package
     (name "emacs-debpaste")
     (version "0.1.5")
+    (home-page "https://github.com/alezost/debpaste.el")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append
-             "https://github.com/alezost/debpaste.el/archive/v"
-             version ".tar.gz"))
+       (method git-fetch)
+       (uri (git-reference (url home-page)
+                           (commit (string-append "v" version))))
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "16qqa32ys3gvxf9x1va2cnjcmw1zvbwgc16pqasgrf4mh7qwsd9b"))))
+         "1wi70r56pd5z0x4dp4m58p9asq03j74kdm4fi9vai83vsl2z9amq"))))
     (build-system emacs-build-system)
     (propagated-inputs
      `(("emacs-xml-rpc" ,emacs-xml-rpc)))
-    (home-page "https://github.com/alezost/debpaste.el")
-    (synopsis "This package provides an interface for receiving, posting and
-deleting pastes from the Debian Pastezone.")
-    (description "Debpaste is an Emacs interface for the Debian Pastezone.
-It provides receiving, posting and deleting pastes using XML-RPC.")
+    (synopsis "Manipulate pastes from the Debian Pastezone")
+    (description "Debpaste is an Emacs interface for the Debian Pastezone,
+allowing you to receive, post, and delete pastes.  It communicates with the
+server using XML-RPC.")
     (license license:gpl3+)))
 
 (define-public emacs-xml-rpc

I also tweaked the commit log to follow our conventions.

Please do not miss
<https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>
for your future contributions.

Thank you!

Ludo’.

Subject: Guix patch: emacs-debpaste
From: Brian Leung <[email-masked]>
To: [email-masked]
Date: Mon, 4 Mar 2019 01:46:27 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

See attached.
From 6de902f6b87258530eaba97963393f3ac585b878 Mon Sep 17 00:00:00 2001
From: Brian Leung <[email-masked]>
Date: Mon, 4 Mar 2019 01:40:38 +0100
Subject: [PATCH 3/3] gnu: Add emacs-debpaste.
To: [email-masked]

---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b1a0d99efb..8ee2888948 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11358,6 +11358,30 @@ Org-mode.  It features:
 @end itemize\n")
       (license license:gpl3+))))
 
+(define-public emacs-debpaste
+  (package
+    (name "emacs-debpaste")
+    (version "0.1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/alezost/debpaste.el/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "16qqa32ys3gvxf9x1va2cnjcmw1zvbwgc16pqasgrf4mh7qwsd9b"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-xml-rpc" ,emacs-xml-rpc)))
+    (home-page "https://github.com/alezost/debpaste.el")
+    (synopsis "This package provides an interface for receiving, posting and
+deleting pastes from the Debian Pastezone.")
+    (description "Debpaste is an Emacs interface for the Debian Pastezone.
+It provides receiving, posting and deleting pastes using XML-RPC.")
+    (license license:gpl3+)))
+
 (define-public emacs-xml-rpc
   (let ((commit "8f624f8b964e9145acb504e4457c9510e87dd93c")
         (revision "1"))
-- 
2.21.0

From f789513e7f359540725f93d601d9f17b04eb3243 Mon Sep 17 00:00:00 2001
From: Brian Leung <[email-masked]>
Date: Mon, 4 Mar 2019 01:39:57 +0100
Subject: [PATCH 2/3] gnu: Add emacs-xml-rpc.
To: [email-masked]

---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dda5500f9d..b1a0d99efb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11358,6 +11358,33 @@ Org-mode.  It features:
 @end itemize\n")
       (license license:gpl3+))))
 
+(define-public emacs-xml-rpc
+  (let ((commit "8f624f8b964e9145acb504e4457c9510e87dd93c")
+        (revision "1"))
+    (package
+      (name "emacs-xml-rpc")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/hexmode/xml-rpc-el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0xa54z52rsfl3n0xgmbycj4zazp8ksgdwcq56swzs6wp72zlalmj"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/hexmode/xml-rpc-el")
+      (synopsis "This is an XML-RPC client implementation in Elisp,
+capable of both synchronous and asynchronous method calls using the url
+package's async retrieval functionality.")
+      (description "@file{xml-rpc.el} represents XML-RPC datatypes as Lisp values,
+automatically converting to and from the XML datastructures as needed, both
+for method parameters and return values, making using XML-RPC methods fairly
+transparent to the Lisp code.")
+      (license license:gpl3+))))
+
 (define-public emacs-fish-completion
   (package
     (name "emacs-fish-completion")
-- 
2.21.0