GNU bug report logs - #34657
26.1; Some erc hook names lack the expected suffix

Previous Next

Package: emacs;

Reported by: Phil Sainty <psainty <at> orcon.net.nz>

Date: Mon, 25 Feb 2019 23:56:01 UTC

Severity: wishlist

Tags: fixed

Found in version 26.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "Mingde (Matthew) Zeng" <matthewzmd <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "Mingde \(Matthew\) Zeng" <matthewzmd <at> gmail.com>, 34657 <at> debbugs.gnu.org, bandali <at> gnu.org
Subject: bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121)
Date: Sun, 09 Aug 2020 23:34:31 -0400

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> (Note that I've moved this from emacs-devel to the bug report.)
>
> "Mingde (Matthew) Zeng" <matthewzmd <at> gmail.com> writes:
>
>> * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is
>> always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it
>> will always use the first candidate, resulting in behavior 1.
>
> Is this correct, though?

Incorrect (after our previous discussion), I'll change it in my next patch.

>
> Otherwise I think the patch looks OK, but there's unfortunately been
> further changes to these functions, and your patch no longer applies.
> Can you re-spin the patch?

Sure, but in a day or two, a bit busy at the moment.

Matthew

--
Mingde (Matthew) Zeng
This bug report was last modified 4 years and 137 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.