GNU bug report logs - #34657
26.1; Some erc hook names lack the expected suffix

Previous Next

Package: emacs;

Reported by: Phil Sainty <psainty <at> orcon.net.nz>

Date: Mon, 25 Feb 2019 23:56:01 UTC

Severity: wishlist

Tags: fixed

Found in version 26.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #23 received at 34657 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Mingde (Matthew) Zeng" <matthewzmd <at> gmail.com>
Cc: 34657 <at> debbugs.gnu.org, bandali <at> gnu.org
Subject: Re: [PATCH] erc: fix erc-reuse-buffers (bug#40121)
Date: Sun, 09 Aug 2020 12:48:16 +0200

(Note that I've moved this from emacs-devel to the bug report.)

"Mingde (Matthew) Zeng" <matthewzmd <at> gmail.com> writes:

> * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is
> always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it
> will always use the first candidate, resulting in behavior 1.

Is this correct, though?

Otherwise I think the patch looks OK, but there's unfortunately been
further changes to these functions, and your patch no longer applies.
Can you re-spin the patch?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 136 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.