From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 25 18:55:19 2019 Received: (at submit) by debbugs.gnu.org; 25 Feb 2019 23:55:19 +0000 Received: from localhost ([127.0.0.1]:51932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyQ5e-0004Y3-VJ for submit@debbugs.gnu.org; Mon, 25 Feb 2019 18:55:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyQ5b-0004Xm-8Z for submit@debbugs.gnu.org; Mon, 25 Feb 2019 18:55:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:39538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyQ5V-0004If-Tq for submit@debbugs.gnu.org; Mon, 25 Feb 2019 18:55:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyQ5U-0005CK-SB for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:55:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyQ5T-0004F6-TI for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:55:08 -0500 Received: from smtp-2.orcon.net.nz ([60.234.4.43]:41014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyQ5T-0004B4-H3 for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:55:07 -0500 Received: from [10.253.37.70] (port=52138 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gyQ5J-0003So-Gp for bug-gnu-emacs@gnu.org; Tue, 26 Feb 2019 12:54:58 +1300 Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 26 Feb 2019 12:54:57 +1300 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 26 Feb 2019 12:54:57 +1300 From: Phil Sainty To: bug-gnu-emacs@gnu.org Subject: 26.1; Some erc hook names lack the expected suffix Message-ID: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 60.234.4.43 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) `erc-before-connect' and `erc-after-connect' are abnormal hooks, so I think they should each have the suffix "-functions" for consistency, and so that they are easier to discover. Is is ok to rename them and defvaralias the old names? All other erc hooks have the -hook or -functions suffix, so far as I can see. For reference: (defcustom erc-before-connect nil "Hook called before connecting to a server. This hook gets executed before `erc' actually invokes `erc-mode' with your input data. The functions in here get called with three parameters, SERVER, PORT and NICK." :group 'erc-hooks :type 'hook) (defcustom erc-after-connect nil "Hook called after connecting to a server. This hook gets executed when an end of MOTD has been received. All functions in here get called with the parameters SERVER and NICK." :group 'erc-hooks :type 'hook) In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2019-01-07 built on hal Repository revision: b0b483d714e87ee0a4572f9c541514a1ac1a8226 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.2 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Loading erc...done uncompressing erc.el.gz...done Mark set Configured using: 'configure --prefix=/home/phil/emacs/head/usr/local --with-x-toolkit=lucid --without-sound' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM THREADS LCMS2 GMP Important settings: value of $LANG: en_NZ.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree help-mode easymenu jka-compr find-func erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib thingatpt pp erc-loaddefs dired dired-loaddefs advice elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 119750 7960) (symbols 48 22664 1) (strings 32 36457 2107) (string-bytes 1 986101) (vectors 16 18682) (vector-slots 8 549648 11634) (floats 8 51 66) (intervals 56 588 50) (buffers 992 15)) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 25 22:32:11 2019 Received: (at 34657) by debbugs.gnu.org; 26 Feb 2019 03:32:11 +0000 Received: from localhost ([127.0.0.1]:52113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyTTW-0000kv-WC for submit@debbugs.gnu.org; Mon, 25 Feb 2019 22:32:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyTTV-0000fs-7m for 34657@debbugs.gnu.org; Mon, 25 Feb 2019 22:32:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyTTJ-0003Ge-Id; Mon, 25 Feb 2019 22:32:01 -0500 Received: from [176.228.60.248] (port=3782 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gyTTI-0005sn-EW; Mon, 25 Feb 2019 22:31:57 -0500 Date: Tue, 26 Feb 2019 05:32:09 +0200 Message-Id: <83imx7mdhi.fsf@gnu.org> From: Eli Zaretskii To: Phil Sainty In-reply-to: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> (message from Phil Sainty on Tue, 26 Feb 2019 12:54:57 +1300) Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34657 Cc: 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Tue, 26 Feb 2019 12:54:57 +1300 > From: Phil Sainty > > `erc-before-connect' and `erc-after-connect' are abnormal hooks, > so I think they should each have the suffix "-functions" for > consistency, and so that they are easier to discover. > > Is is ok to rename them and defvaralias the old names? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 27 06:01:07 2019 Received: (at 34657) by debbugs.gnu.org; 27 Feb 2019 11:01:07 +0000 Received: from localhost ([127.0.0.1]:53560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gywxX-0000ci-HQ for submit@debbugs.gnu.org; Wed, 27 Feb 2019 06:01:07 -0500 Received: from smtp-2.orcon.net.nz ([60.234.4.43]:43009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gywxV-0000cZ-E0 for 34657@debbugs.gnu.org; Wed, 27 Feb 2019 06:01:06 -0500 Received: from [150.107.172.32] (port=22222 helo=[192.168.20.103]) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gywxS-0006JE-Oy; Thu, 28 Feb 2019 00:01:03 +1300 Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix To: Eli Zaretskii References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> <83imx7mdhi.fsf@gnu.org> From: Phil Sainty Message-ID: Date: Thu, 28 Feb 2019 00:01:02 +1300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <83imx7mdhi.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34657 Cc: 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I've pushed branch fix/bug-34657-erc-hooks for this, and I've used define-obsolete-variable-alias, but there are problems with the customize behaviour. The first annoyance is that in customize-group erc-hooks the alias is displayed (albeit slightly differently) as well as the renamed option. I feel that it would be cleaner if the alias did not appear in the customize UI, as otherwise it can lead to a weird state where the user edits both of them in the customize UI with different values, and one value clobbers the other. The latter aspect is really a more general problem, though, which we can arrive at more simply: 1. The user has previously customized `erc-before-connect' (for example) such that their custom file contains a value. 2. They NOW customize the option under its new name, and this `erc-before-connect-functions' value is saved *separately* to the custom file. 3. We are now in the same situation as before -- *both* option names exist in the custom file, potentially with different values. 4. When starting Emacs, the first(?) value processed is the one which sticks for both names, which can mean that the user's customization of the new name didn't work in practice. I can think of a possible reason for not deleting the old option from the custom file (being that the user *potentially* uses their config with Emacs 27 and Emacs 26, and 26 would only use the old name). I'm not sure whether switching back and forth like that is a supported case, though? Regardless of that, allowing both options to be written with *different* values seems like a definite bug? -Phil On 26/02/19 4:32 PM, Eli Zaretskii wrote: >> Date: Tue, 26 Feb 2019 12:54:57 +1300 >> From: Phil Sainty >> >> `erc-before-connect' and `erc-after-connect' are abnormal hooks, >> so I think they should each have the suffix "-functions" for >> consistency, and so that they are easier to discover. >> >> Is is ok to rename them and defvaralias the old names? > > Yes, thanks. > From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 27 11:31:13 2019 Received: (at 34657) by debbugs.gnu.org; 27 Feb 2019 16:31:14 +0000 Received: from localhost ([127.0.0.1]:54222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz26z-0003Mm-L8 for submit@debbugs.gnu.org; Wed, 27 Feb 2019 11:31:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz26x-0003GM-88 for 34657@debbugs.gnu.org; Wed, 27 Feb 2019 11:31:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz26m-0000gX-CB; Wed, 27 Feb 2019 11:31:03 -0500 Received: from [176.228.60.248] (port=2252 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gz26T-0002PI-7U; Wed, 27 Feb 2019 11:30:47 -0500 Date: Wed, 27 Feb 2019 18:30:56 +0200 Message-Id: <83bm2xkxbz.fsf@gnu.org> From: Eli Zaretskii To: Phil Sainty In-reply-to: (message from Phil Sainty on Thu, 28 Feb 2019 00:01:02 +1300) Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> <83imx7mdhi.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34657 Cc: 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Cc: 34657@debbugs.gnu.org > From: Phil Sainty > Date: Thu, 28 Feb 2019 00:01:02 +1300 > > I've pushed branch fix/bug-34657-erc-hooks for this, and I've used > define-obsolete-variable-alias, but there are problems with the > customize behaviour. > > The first annoyance is that in customize-group erc-hooks the alias > is displayed (albeit slightly differently) as well as the renamed > option. Isn't there some precedent for handling this? If we never did rename a defcustom before, and no simple solution presents itself, I'd rather drop the idea altogether. ERC is a niche package, so it's not a catastrophe if we have exceptions from the rule here. Thanks. (What is the second annoyance?) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 27 14:31:00 2019 Received: (at 34657) by debbugs.gnu.org; 27 Feb 2019 19:31:00 +0000 Received: from localhost ([127.0.0.1]:54382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz4uy-0001Zd-1h for submit@debbugs.gnu.org; Wed, 27 Feb 2019 14:31:00 -0500 Received: from smtp-2.orcon.net.nz ([60.234.4.43]:32861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz4uv-0001Wd-Ti for 34657@debbugs.gnu.org; Wed, 27 Feb 2019 14:30:58 -0500 Received: from [150.107.172.32] (port=33117 helo=[192.168.20.103]) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gz4ur-0006p7-MU; Thu, 28 Feb 2019 08:30:53 +1300 Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix To: Eli Zaretskii References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> <83imx7mdhi.fsf@gnu.org> <83bm2xkxbz.fsf@gnu.org> From: Phil Sainty Message-ID: <6e831de3-9b20-a015-e859-9c778959c0c2@orcon.net.nz> Date: Thu, 28 Feb 2019 08:30:53 +1300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <83bm2xkxbz.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34657 Cc: 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 28/02/19 5:30 AM, Eli Zaretskii wrote: > Isn't there some precedent for handling this? Hopefully. If not, I guess I'll raise a separate bug for the fact that renaming defcustoms is problematic, and maybe just add a code comment referencing that to erc.el. > (What is the second annoyance?) A proof-reading failure :) I'd initially worded things differently, before deciding that the issues I was seeing were all connected, so I did cover all the problems I'd observed. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 03 04:35:16 2020 Received: (at 34657) by debbugs.gnu.org; 3 Aug 2020 08:35:16 +0000 Received: from localhost ([127.0.0.1]:44203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2VwB-0008FD-Rr for submit@debbugs.gnu.org; Mon, 03 Aug 2020 04:35:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2Vw7-0008Ep-4M for 34657@debbugs.gnu.org; Mon, 03 Aug 2020 04:35:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=olekY5IXV4rPU1ihHC9CU6v3wZrTEMi4zE5uqH3qIC8=; b=r+qa8rTEMgE7JUYyh0nQihebpd WQWsViiIAWwXCf79D3+6h+vEijiCH4C65V+wkcER2vgUx752mCsWs/S6/SoJiOD+d5WPTa6R3wbs4 FyMw9+oYY50XW5W526HNlRg2xfQ6LXKbrIX6NFZhdSepaS4dTnaeRlBgdfJYF4avWnok=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Vvw-0006Mr-F9; Mon, 03 Aug 2020 10:35:03 +0200 From: Lars Ingebrigtsen To: Phil Sainty Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> <83imx7mdhi.fsf@gnu.org> <83bm2xkxbz.fsf@gnu.org> <6e831de3-9b20-a015-e859-9c778959c0c2@orcon.net.nz> Date: Mon, 03 Aug 2020 10:34:59 +0200 In-Reply-To: <6e831de3-9b20-a015-e859-9c778959c0c2@orcon.net.nz> (Phil Sainty's message of "Thu, 28 Feb 2019 08:30:53 +1300") Message-ID: <87v9i0unyk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Phil Sainty writes: > On 28/02/19 5:30 AM, Eli Zaretskii wrote: >> Isn't there some precedent for handling this? > > Hopefully. If not, I guess I'll raise a separate bug for the fact > that renaming defcustoms is problem [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34657 Cc: Eli Zaretskii , 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Phil Sainty writes: > On 28/02/19 5:30 AM, Eli Zaretskii wrote: >> Isn't there some precedent for handling this? > > Hopefully. If not, I guess I'll raise a separate bug for the fact > that renaming defcustoms is problematic, and maybe just add a code > comment referencing that to erc.el. This was over a year ago, and nobody piped up, so I'm guessing that there isn't a way for defcustom to deal with renamed variables? In which case I agree with Eli -- it just isn't worth doing the renaming. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 06:48:32 2020 Received: (at 34657) by debbugs.gnu.org; 9 Aug 2020 10:48:32 +0000 Received: from localhost ([127.0.0.1]:60073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4isS-00067x-IQ for submit@debbugs.gnu.org; Sun, 09 Aug 2020 06:48:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4isR-00067h-IS for 34657@debbugs.gnu.org; Sun, 09 Aug 2020 06:48:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b56BXXXX99rIY7HYKiU+0LZVWHQ8p2qJQZ7NcAO33Mw=; b=HpSAETuZu7HlnTmJ6oy2h8B6aT qBJ7Jg6wfBFBc1wVcwch+W+B7dn9AnfKR6jwy4iHbjiDD49TdJFF3iZ/JYwh0eAL61FXg78/6oyyk rtofwWksNi3ND7/X+cZeR2TjPxTo8oHJ6izcLppqNz63fBf/Bfl212HwKwyOU+mBHS/I=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4isD-0000mb-IN; Sun, 09 Aug 2020 12:48:25 +0200 From: Lars Ingebrigtsen To: "Mingde (Matthew) Zeng" Subject: Re: [PATCH] erc: fix erc-reuse-buffers (bug#40121) References: <87lfitesdn.fsf@gmail.com> Date: Sun, 09 Aug 2020 12:48:16 +0200 In-Reply-To: <87lfitesdn.fsf@gmail.com> (Mingde Zeng's message of "Tue, 04 Aug 2020 22:30:44 -0400") Message-ID: <87k0y8umbz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: (Note that I've moved this from emacs-devel to the bug report.) "Mingde (Matthew) Zeng" writes: > * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is > always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it > will always use the first candidate, resulting in behavior [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34657 Cc: 34657@debbugs.gnu.org, bandali@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) (Note that I've moved this from emacs-devel to the bug report.) "Mingde (Matthew) Zeng" writes: > * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is > always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it > will always use the first candidate, resulting in behavior 1. Is this correct, though? Otherwise I think the patch looks OK, but there's unfortunately been further changes to these functions, and your patch no longer applies. Can you re-spin the patch? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 23:51:39 2020 Received: (at 34657) by debbugs.gnu.org; 10 Aug 2020 03:51:39 +0000 Received: from localhost ([127.0.0.1]:33846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yqX-0008UF-Sh for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:51:38 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:33069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4ya6-00085n-QN for 34657@debbugs.gnu.org; Sun, 09 Aug 2020 23:34:39 -0400 Received: by mail-qk1-f193.google.com with SMTP id p4so7208163qkf.0 for <34657@debbugs.gnu.org>; Sun, 09 Aug 2020 20:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=u7x2SXxgzF1GZe+8QXKHjucWdJCUDq7qnXxNUuEEyT0=; b=C5u3/KXjtb5n0vpzK7FY6aeMZsonqKBPSMWXHXv73cn3nB4FLGDRI0t+qLIn0CyXnw c7n4dDphEh1lr5QwM/uALX8zZBULWPiu3inowofpN2VYJYr0Q3SGL01CRmZEQZJzJFWU 95GwGUho2xSL7+w7PM6JOkgq2jzQkyV84N6dP48AtAQ0QBnri+ZT2mJPF9chy+7X6eT0 ykAUunpu4dQkdcujnrJUS7xdpLvtFnrQOa6BQQyEpoyiXV644fQE8Ja+0vGSYDjOd/1Y 3vm3mhwlIM5BQE4tme8bWjBy3tnbVZN0TY128kFlZMfZ5EAfwagBcwIgAV0p0wDhhFEY eVVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=u7x2SXxgzF1GZe+8QXKHjucWdJCUDq7qnXxNUuEEyT0=; b=KMtGiKgM3m51YAreaDm6w/0klc/LRTdXhw/Dxe/DYCXQiAuGJCbcirpF9YKqfK6wNf dfYQpHDYCFvDb6220h2S0UmMbD4UfV1n7Xe/KbogZOaLzK+lYQadNrWrSN8iZGc2T9UV cTYb9cMdB8G6CSKn8jBFVWa7aCYAnIGE3uItBNDVvVMkyh/HA821k6QZsPIxjwJhMX5d Gbwjp/IbKQo/CEEPvgoLixd3nPLM70pRg+vGT12DBkvHjmNpZe2oR65NoipCkq9MS0Aj eusW3IZv7HPKovD6VRRC5Qu6SRxLN787NUrDhb9ZXSr0EQlaDtgB9x4lL7GCSohRNIIl ILlg== X-Gm-Message-State: AOAM532QyjAU/8/AUiT5SBe0TF/Vj1V6K0I2kq8dBM87ZBKMH+gI0FcJ ZhHCgc8er+ErZKb9g81BekU= X-Google-Smtp-Source: ABdhPJzJFyAe5QY+8tkOwMLolhjSHA9i/jmC3gVgYzyGvEidaaK93BqWfmYYzvDDxD4MEfejrUmIzA== X-Received: by 2002:a05:620a:21cf:: with SMTP id h15mr23599269qka.123.1597030472985; Sun, 09 Aug 2020 20:34:32 -0700 (PDT) Received: from mt-manjaro (216-58-109-18.cpe.distributel.net. [216.58.109.18]) by smtp.gmail.com with ESMTPSA id k11sm12276493qkk.93.2020.08.09.20.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2020 20:34:32 -0700 (PDT) References: <87lfitesdn.fsf@gmail.com> <87k0y8umbz.fsf@gnus.org> User-agent: mu4e 1.4.12; emacs 27.0.91 From: "Mingde (Matthew) Zeng" To: Lars Ingebrigtsen Subject: Re: [PATCH] erc: fix erc-reuse-buffers (bug#40121) In-reply-to: <87k0y8umbz.fsf@gnus.org> Message-ID: <877du7gomw.fsf@gmail.com> Date: Sun, 09 Aug 2020 23:34:31 -0400 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34657 X-Mailman-Approved-At: Sun, 09 Aug 2020 23:51:36 -0400 Cc: "Mingde \(Matthew\) Zeng" , 34657@debbugs.gnu.org, bandali@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > (Note that I've moved this from emacs-devel to the bug report.) > > "Mingde (Matthew) Zeng" writes: > >> * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is >> always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it >> will always use the first candidate, resulting in behavior 1. > > Is this correct, though? Incorrect (after our previous discussion), I'll change it in my next patch. > > Otherwise I think the patch looks OK, but there's unfortunately been > further changes to these functions, and your patch no longer applies. > Can you re-spin the patch? Sure, but in a day or two, a bit busy at the moment. Matthew -- Mingde (Matthew) Zeng From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 05:55:34 2020 Received: (at 34657) by debbugs.gnu.org; 31 Aug 2020 09:55:34 +0000 Received: from localhost ([127.0.0.1]:51581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCgXG-0005Iu-D2 for submit@debbugs.gnu.org; Mon, 31 Aug 2020 05:55:34 -0400 Received: from mail-ej1-f42.google.com ([209.85.218.42]:35174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCgXF-0005Ih-0A for 34657@debbugs.gnu.org; Mon, 31 Aug 2020 05:55:33 -0400 Received: by mail-ej1-f42.google.com with SMTP id a26so7698324ejc.2 for <34657@debbugs.gnu.org>; Mon, 31 Aug 2020 02:55:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=l4XVZ4fu0Lz7dYeRpR7VbPMIEcfohy1QYyXLLy3w4ZA=; b=j61d1iDdf5GMOqYbhhy75yFD9z8v8JiXwFQX/5i/kx58kBlRCRj/pSTStvmX3dsJjn 7cJ17qWhztnEymt5NsAWUejYpRKQouSZK0u+6Tup6OLuZebp1gepWm9c21kDRUtFzZpD jemTnOGu7En/MhN/mdB8FnnEStJvd5DuQrYPHze+PiGg1yvP2GBYyTAZTlsI2Ah3QpDR xY/8IMYKUox2Wxt0up5GVCIVuRLNp7pe5z1cPbGUsDW7kGp/sU9m1qGr6PShUbzFDB0L XAWh5vje614136tVo3z9gL4dhB/Ekv2OX4/I+OUXhJs3ytGb4/QAPCe8kxiImKrTIccT J6AQ== X-Gm-Message-State: AOAM530SfDsvGgwUzftnkWveGa1R6PTYpI9eYAiLCPSO4R6x0FP9ymVs 3EsD6iHTzT8zJLu47Q9pwjUSYfo6fjSi9sxDlD1R7+VB X-Google-Smtp-Source: ABdhPJynFgN2hIgBd70mOz/phv1qUGwRB4/7tOGp+s8CYqepxhQeZIfDFspGX4HXEODxP4uGKJiDb7byxUecST7djUE= X-Received: by 2002:a17:906:3a02:: with SMTP id z2mr335430eje.287.1598867727281; Mon, 31 Aug 2020 02:55:27 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 31 Aug 2020 09:55:26 +0000 From: Stefan Kangas In-Reply-To: <87v9i0unyk.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 03 Aug 2020 10:34:59 +0200") References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> <83imx7mdhi.fsf@gnu.org> <83bm2xkxbz.fsf@gnu.org> <6e831de3-9b20-a015-e859-9c778959c0c2@orcon.net.nz> <87v9i0unyk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 31 Aug 2020 09:55:26 +0000 Message-ID: Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 34657 Cc: Phil Sainty , Eli Zaretskii , 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Lars Ingebrigtsen writes: > Phil Sainty writes: > >> On 28/02/19 5:30 AM, Eli Zaretskii wrote: >>> Isn't there some precedent for handling this? >> >> Hopefully. If not, I guess I'll raise a separate bug for the fact >> that renaming defcustoms is problematic, and maybe just add a code >> comment referencing that to erc.el. > > This was over a year ago, and nobody piped up, so I'm guessing that > there isn't a way for defcustom to deal with renamed variables? > > In which case I agree with Eli -- it just isn't worth doing the > renaming. Shouldn't we just fix defcustom? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 10:31:21 2020 Received: (at 34657) by debbugs.gnu.org; 1 Sep 2020 14:31:21 +0000 Received: from localhost ([127.0.0.1]:56687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7Jh-0003DD-B3 for submit@debbugs.gnu.org; Tue, 01 Sep 2020 10:31:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7Je-0003Cz-Ix for 34657@debbugs.gnu.org; Tue, 01 Sep 2020 10:31:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OqlLqpx8cIJhG9i0AP/RJmnXLwB7N51bX02wiNLERL4=; b=VEsg5LRmo+SacM61Y5wBC4slFe Z3JLr7NiddTHDaPq9R/5mkOlxfX5IoET5kdo6OYy9yjuRqXc5jSkSNpEwjhkzVI7BGDJLXgjrucY5 ZslHiAGul/xVYxGOGnJM8DuQCqDoP7PcutKR3zJMbUGp9xT0ojj/HSerqHWjss/iMZjg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD7JV-0002Ub-Cm; Tue, 01 Sep 2020 16:31:12 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> <83imx7mdhi.fsf@gnu.org> <83bm2xkxbz.fsf@gnu.org> <6e831de3-9b20-a015-e859-9c778959c0c2@orcon.net.nz> <87v9i0unyk.fsf@gnus.org> X-Now-Playing: DACM's =?utf-8?Q?=5FSt=C3=A9r=C3=A9otypie=5F=3A?= "Party" Date: Tue, 01 Sep 2020 16:31:07 +0200 In-Reply-To: (Stefan Kangas's message of "Mon, 31 Aug 2020 09:55:26 +0000") Message-ID: <87ft81d0wk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: >>> Hopefully. If not, I guess I'll raise a separate bug for the fact >>> that renaming defcustoms is problematic, and maybe just add a code >>> comment referencing that to erc.el. >> >> This was over [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34657 Cc: Phil Sainty , Eli Zaretskii , 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: >>> Hopefully. If not, I guess I'll raise a separate bug for the fact >>> that renaming defcustoms is problematic, and maybe just add a code >>> comment referencing that to erc.el. >> >> This was over a year ago, and nobody piped up, so I'm guessing that >> there isn't a way for defcustom to deal with renamed variables? >> >> In which case I agree with Eli -- it just isn't worth doing the >> renaming. > > Shouldn't we just fix defcustom? >From :type 'hook to 'function or something? Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 26 23:43:41 2021 Received: (at 34657) by debbugs.gnu.org; 27 Feb 2021 04:43:42 +0000 Received: from localhost ([127.0.0.1]:42995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFrS9-0004EC-Lk for submit@debbugs.gnu.org; Fri, 26 Feb 2021 23:43:41 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFrS8-0004Dz-CZ for 34657@debbugs.gnu.org; Fri, 26 Feb 2021 23:43:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PiR/sAg1RSLH25aLIdnaIRyXjlMorBqmLXMhEbJRMuw=; b=H7cdrEghQbERUc8q/7q4zrLpjq Yn5vkZ3Zn8XtmyTGvOO9OVGK7MwsAZrVoPWzQGd2DnQrmOwwSh5pxWv/ci1GDZPKnVhGkFcZksPr9 Gin0oeIxL+Rj31kbDiuTuEw36gH9Odx6IsHgtXBkoUJM2CJ50CQ7xk2HxSzL7H3Hn138=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFrRv-0001zS-CW; Sat, 27 Feb 2021 05:43:33 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#34657: 26.1; Some erc hook names lack the expected suffix References: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> <83imx7mdhi.fsf@gnu.org> <83bm2xkxbz.fsf@gnu.org> <6e831de3-9b20-a015-e859-9c778959c0c2@orcon.net.nz> <87v9i0unyk.fsf@gnus.org> <87ft81d0wk.fsf@gnus.org> X-Now-Playing: Tuxedomoon's _Live in London (1982)_: "Blind" Date: Sat, 27 Feb 2021 05:43:25 +0100 In-Reply-To: <87ft81d0wk.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Sep 2020 16:31:07 +0200") Message-ID: <87sg5ijf2q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >>> In which case I agree with Eli -- it just isn't worth doing the >>> renaming. >> >> Shouldn't we just fix defcustom? > >>From :type 'hook to 'function or something? Yup. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34657 Cc: Phil Sainty , Eli Zaretskii , 34657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >>> In which case I agree with Eli -- it just isn't worth doing the >>> renaming. >> >> Shouldn't we just fix defcustom? > >>>From :type 'hook to 'function or something? Yup. Now done in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 26 23:43:46 2021 Received: (at control) by debbugs.gnu.org; 27 Feb 2021 04:43:46 +0000 Received: from localhost ([127.0.0.1]:42998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFrSD-0004EW-VF for submit@debbugs.gnu.org; Fri, 26 Feb 2021 23:43:46 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFrSC-0004E3-B7 for control@debbugs.gnu.org; Fri, 26 Feb 2021 23:43:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=smIutKh9mhK5SuptpjFpwjijorgsjhdtgNXAhiXtt5U=; b=MDh8/GQG6XjotLqgjrGATSHT/C 5q21o3/lGNuqpYcIRZU6j/9trRFzkm/Pq1w/vlfdFDV+7e5IyhpxBELFI44/gZcdMcbQa4EvQ5yAp /VGaiEV2enBP1N2reKJy9kPKvQEGL2dL1TrLQCKSRBJ8hPH/Y5/Y3U4Y31YJq63edhjU=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFrS4-0001zb-MC for control@debbugs.gnu.org; Sat, 27 Feb 2021 05:43:38 +0100 Date: Sat, 27 Feb 2021 05:43:35 +0100 Message-Id: <87r1l2jf2g.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #34657 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 34657 fixed close 34657 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 34657 fixed close 34657 28.1 quit From unknown Sat Aug 09 13:14:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Mar 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator