GNU bug report logs - #34650
[PATCH] ruby-mailcatcher: Draft

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 34650 <at> debbugs.gnu.org
Subject: [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann.
Date: Mon, 04 Mar 2019 21:20:57 +0000

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> * gnu/packages/ruby.scm (ruby-mustermann): New variable.
> ---
>  gnu/packages/ruby.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index f6b6a19d5..1c10a16c2 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -7708,3 +7708,25 @@ systems that support multiple template engines but don't want to code for each
>  of them individually.")
>      (home-page "https://github.com/rtomayko/tilt/")
>      (license license:expat)))
> +
> +(define-public ruby-mustermann
> +  (package
> +    (name "ruby-mustermann")
> +    (version "1.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "mustermann" version))
> +       (sha256
> +        (base32
> +         "0lycgkmnyy0bf29nnd2zql5a6pcf8sp69g9v4xw0gcfcxgpwp7i1"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     ;; TODO: Fix tests.
> +     `(#:tests? #f))

Could you include some details of what is broken about the tests? Even
just a bit of the error message if there is one.

Also, I'd usually use a single quote unless a backtick is necessary.

> +    (synopsis "Library implementing patterns that behave like regular expressions")
> +    (description "Given a string pattern, Mustermann will turn it into an
> +object that behaves like a regular expression and has comparable performance
> +characteristics.")
> +    (home-page "https://github.com/sinatra/mustermann")
> +    (license license:expat)))

I'd recommend trying to avoid inserting packages at the end of modules,
or generally in the same place. This can make rebases difficult, and
increase the chances of conflicts when going to apply patches. I
generally try to fit patches in to modules somewhat alphabetically.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.