GNU bug report logs - #34650
[PATCH] ruby-mailcatcher: Draft

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 34650 <at> debbugs.gnu.org
Subject: [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft)
Date: Mon, 04 Mar 2019 21:06:56 +0000

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> I've eventually figured that many of the dep requirements in the Ruby community
> follow poor practices, so I've lifter all of them to ">=" and Mailcatcher seems
> to work smoothly still (it starts at least).
>
> I've cleanup up the packages, only the tests are missing.  The rest should be
> ready for merge.
>
> Christopher, feel free to merge.  Only ruby-tilt conflicts with your patch.

I've now merged some of the Ruby patches that I was working on,
including ruby-tilt. It would be good if you could rebase your patches
on top of master, and check if they still work.

I also ran guix lint on the packages and got the following warnings:

gnu/packages/ruby.scm:8431:2: ruby-thin <at> 1.7.2: line 8453 is way too long (91 characters)
gnu/packages/ruby.scm:8491:2: mailcatcher <at> 0.6.5: can be upgraded to 0.7.1
gnu/packages/ruby.scm:8491:2: mailcatcher <at> 0.6.5: line 8510 is way too long (92 characters)
gnu/packages/ruby.scm:8491:2: mailcatcher <at> 0.6.5: line 8514: parentheses feel lonely, move to the previous or next line
gnu/packages/ruby.scm:8491:2: mailcatcher <at> 0.6.5: line 8530 is way too long (96 characters)

I'll have a look at the individual patches as well.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.