Subject: [bug#34638] [PATCH v2 4/4] inferior: Add 'open-inferior/container'.

From: Ludovic Courtès <[email-masked]>
Date: Thu, 26 Mar 2020 10:32:27 +0100

Christopher Baines <[email-masked]> skribis:

> ---
>  guix/inferior.scm | 76 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)

[...]

> +(define* (open-inferior/container store guix-store-item
> +                                  #:key
> +                                  (command "bin/guix")
> +                                  (share-host-network? #f)
> +                                  (extra-shared-directories '())
> +                                  (extra-environment-variables '()))

Please add a docstring.  Same comment as before regarding “extras”.  :-)

> +    (start-child-in-container
> +     (list (string-append guix-store-item "/bin/guix")
> +           ;; TODO I'm not sure why "repl" is duplicated in the following
> +           ;; command
> +           "repl" "repl" "-t" "machine")

This is the argv[0] issue mentioned earlier.

I think it’s not really feasible to write a test for this one, or at
least I don’t see how.

Otherwise LGTM, thanks!

Ludo’.