Subject: [bug#34634] [PATCH 1/1] gnu: tryton: Add tryton 5.0.6.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 11 Mar 2019 23:15:39 +0100

Hi Jovany,

Your email client mangled the patch.  In the future could you send
patches as attachments or use ‘git send-email’?

"Jovany Leandro G.C" <[email-masked]> skribis:

> From 693d00d1df68ada3bb43cbaecdd2823976e87bd4 Mon Sep 17 00:00:00 2001
> From: "Jovany Leandro G.C" <[email-masked]>
> Date: Sat, 23 Feb 2019 14:08:01 -0500
> Subject: [PATCH 1/1] gnu: tryton: Add tryton 5.0.6.
>
> * gnu/packages/tryton.scm (tryton-5): New variable.

Do you think we should keep both version 4 and version 5?  Is it
generally useful today to have these two versions available?

> +(define-public tryton-5
> +  (package
> +    (name "tryton")
> +    (version "5.0.6")

Should it inherit from ‘tryton’?

> +    (arguments
> +     `(;;_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix
> will not be created.
> +       #:tests? #f

Could you try adding a phase before ‘check’ that spawns Xvfb?  There are
several examples of this.

> +    (license license:gpl3)))

Version 3 only, or version 3 “or any later version”?

Could you send an updated patch?

Thank you,
Ludo’.