GNU bug report logs - #34621
[PATCH] lisp/progmodes/grep.el (grep-read-files): Add file-directory-p check

Previous Next

Package: emacs;

Reported by: Christopher Thorne <c.thorne <at> reckondigital.com>

Date: Fri, 22 Feb 2019 21:16:01 UTC

Severity: normal

Tags: patch

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: Christopher Thorne <c.thorne <at> reckondigital.com>, 34621 <at> debbugs.gnu.org
Subject: bug#34621: Patch Update
Date: Mon, 4 Mar 2019 07:26:27 -0800 (PST)

> +               (not (eq major-mode 'dired-mode))
> +               (not (eq major-mode 'dired-mode))

I haven't followed this thread at all - dunno
what the problem is that you're trying to solve.
But I'm a bit surprised that Dired needs to be
special-cased for grep in any way.

Anyway, the reasom I'm writing is to suggest
that you probably don't want
(eq major-mode 'dired-mode).  You probably
want (derived-mode-p 'dired-mode).
This bug report was last modified 6 years and 36 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.