Subject: bug#34595: closed (Re: bug#34595: [PATCH] gnu: Add emacs-shroud)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 20 Feb 2019 21:37:03 +0000

Your bug report

#34595: [PATCH] gnu: Add emacs-shroud

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34595: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34595
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#34595: [PATCH] gnu: Add emacs-shroud
From: Ricardo Wurmus <[email-masked]>
To: Amar Singh <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Wed, 20 Feb 2019 22:36:33 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

> Shroud is a password manager written in Guile which uses GnuPG in the
> backend. This package is an Emacs interface to Shroud using the Buffers
> User Interface library.

You have previously already submitted a variant of this:

    https://issues.guix.info/issue/34364

Please don’t open more tickets for this but instead send updates to the
same ticket.  I’m closing this issue, because what you attached is not a
git formatted patch.

> +(define-public nly/emacs-shroud

We don’t use personal prefixes like “nly/” in Guix.

> +  (package
> +   (name "emacs-shroud")
> +   (version "ad5de6d")

A version string must be monotonically increasing over time.  Commit
hashes don’t do that, so we use (git-version last-release revision
commit) instead.

We prefer releases over arbitrary commits.  Since you are the developer,
could you please tell us what the difference is between this version and
the previous release?  Could you make a new release instead?

> +   (build-system emacs-build-system)
> +   (propagated-inputs
> +    `(("emacs-f" ,emacs-f)
> +      ("emacs-s" ,emacs-s)
> +      ("emacs-bui" ,emacs-bui)
> +      ("shroud" ,shroud)))
> +   (home-page "http://nly.info.tm:9001/emacs/shroud.el")
> +   (synopsis "Shroud (gpg) support for Emacs")

Why “(gpg)”?  It’s probably better to say “Shroud password manager
interface for Emacs”.

> +   (description
> +    "This package provides functions for working with shroud password
> manager.")

I’d not say “functions”.  How about

   This package provides an Emacs minor mode for working with the Shroud
   password manager.

Could you please send an updated patch?

--
Ricardo

Subject: [PATCH] gnu: Add emacs-shroud
From: Amar Singh <[email-masked]>
To: [email-masked]
Date: Thu, 21 Feb 2019 02:11:52 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

Shroud is a password manager written in Guile which uses GnuPG in the
backend. This package is an Emacs interface to Shroud using the Buffers
User Interface library.

Beta quality.

Thanks

--------------------------------------------------------------------------------
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cedc1efbc..a498c8012 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2233,6 +2233,31 @@ IRC bouncer with ERC.")
 Emacs shell script.")
     (license license:expat)))
 
+(define-public nly/emacs-shroud
+  (package
+   (name "emacs-shroud")
+   (version "ad5de6d")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/o-nly/emacs-shroud")
+                  (commit version)))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32
+              "1bw7lwssv7my41d8qw9dzzl8k6jwq01ks01dxkkpr6j82bcwlqrd"))))
+   (build-system emacs-build-system)
+   (propagated-inputs
+    `(("emacs-f" ,emacs-f)
+      ("emacs-s" ,emacs-s)
+      ("emacs-bui" ,emacs-bui)
+      ("shroud" ,shroud)))
+   (home-page "http://nly.info.tm:9001/emacs/shroud.el")
+   (synopsis "Shroud (gpg) support for Emacs")
+   (description
+    "This package provides functions for working with shroud password manager.")
+   (license license:gpl3+)))
+
 (define-public emacs-undercover
   (package
     (name "emacs-undercover")