From unknown Sat Aug 16 16:00:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34594 <34594@debbugs.gnu.org> To: bug#34594 <34594@debbugs.gnu.org> Subject: Status: cc-mode needs to support "final" in C++ classes Reply-To: bug#34594 <34594@debbugs.gnu.org> Date: Sat, 16 Aug 2025 23:00:12 +0000 retitle 34594 cc-mode needs to support "final" in C++ classes reassign 34594 emacs,cc-mode submitter 34594 "Daniel Colascione" severity 34594 minor tag 34594 confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 20 13:48:19 2019 Received: (at submit) by debbugs.gnu.org; 20 Feb 2019 18:48:19 +0000 Received: from localhost ([127.0.0.1]:58448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwWup-000120-H7 for submit@debbugs.gnu.org; Wed, 20 Feb 2019 13:48:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwWun-00011k-80 for submit@debbugs.gnu.org; Wed, 20 Feb 2019 13:48:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:34505) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwWuh-0002ol-BV for submit@debbugs.gnu.org; Wed, 20 Feb 2019 13:48:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwWug-00014c-9t for bug-gnu-emacs@gnu.org; Wed, 20 Feb 2019 13:48:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_60,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwWgB-0004du-TI for bug-gnu-emacs@gnu.org; Wed, 20 Feb 2019 13:33:12 -0500 Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:38990) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwWgB-0004WK-3C for bug-gnu-emacs@gnu.org; Wed, 20 Feb 2019 13:33:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:To:From:Subject:Date:Message-ID; bh=4oTDNEn8nT8jPPm9e4kP7O2hgYVPPWkuwHCuBn4qYok=; b=e9MySBVRizGycVY8oFzzesO+wus3htSpOj5TD0/jMZBSTWUDMvECfw+ZXIZZy3sWub5xiyE4JjscCw7v2P8w3pypl6ZH+BXq2vpk6z0mZ8mvTmSScKAghVbbakiN8V4l3STtaK701RCmDHrrS1J/uNkdaygxzmh5e2zeQKYALpFbZZCkJuz+fw7FH99ddwCymxk6J+eMgaCzjMmMvg5iapmnDXFzjTyDmIVZcfve8ia0OTGwiJCzn7PWqcTbpFFdpRyoSYj3i28bETxwN0eJXd6R6Bzxy3m4PycRTBrxdiJtwTg3QvrDf+BUHzGlxyufPhIvuNPJP89N337hXN13DA==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwWg2-0005S2-B3 for bug-gnu-emacs@gnu.org; Wed, 20 Feb 2019 10:33:02 -0800 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 20 Feb 2019 10:33:02 -0800 Message-ID: Date: Wed, 20 Feb 2019 10:33:02 -0800 Subject: cc-mode needs to support "final" in C++ classes From: "Daniel Colascione" To: bug-gnu-emacs@gnu.org User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Consider this: 1 struct QueryCache final : BasePyObject, SupportsGcClear, 2 HasDict, SupportsWeakRefs Without the "final", line 2 is classified as inher-cont. With the "final", it gets topmost-intro-cont and wrong indentation. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 20 14:34:26 2019 Received: (at 34594) by debbugs.gnu.org; 20 Feb 2019 19:34:26 +0000 Received: from localhost ([127.0.0.1]:58566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwXdS-0002Ct-A4 for submit@debbugs.gnu.org; Wed, 20 Feb 2019 14:34:26 -0500 Received: from dancol.org ([96.126.100.184]:44016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwXdO-0002Cj-Nu for 34594@debbugs.gnu.org; Wed, 20 Feb 2019 14:34:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=qvHigOw+flKsGRCTL+MXF35RulQyT1NhSOSx3Gy10/Y=; b=Gx2MX+VUu37gqRwIvIJXC4Ox65DV3hRpZeQ26YmARHML4X5vNR0eZnCM0KoegP48HCPcwzKMo1VR5wo5eBmy9pqQunmc2hBF5s1ppoHe7XWOWUV6QYIET7ZiNXVzOCW1vM7d4zSPB+FlXdRKX2vjxrhSOJexhUYkcY1rKDRKRh/rWR0XgVAq5P4B20rysch1J+zhF4d2powgpDZm5aBxcQDsd68DwilI+DZYfiEp815mShd4ErX1laIzBrviTAq2K/ymS1WfGnqlGbgwWmLfa/anB2G25t5AmpQn/TO5oWQjVO3hY7Gympm4AdE2K2Li7ZZ5+BDUtAtuMl+UJA4BzA==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwXdN-0005lN-1o; Wed, 20 Feb 2019 11:34:21 -0800 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 20 Feb 2019 11:34:21 -0800 Message-ID: In-Reply-To: References: Date: Wed, 20 Feb 2019 11:34:21 -0800 Subject: Re: bug#34594: cc-mode needs to support "final" in C++ classes From: "Daniel Colascione" To: "Daniel Colascione" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34594 Cc: 34594@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Consider this: > > 1 struct QueryCache final : BasePyObject, SupportsGcClear, > 2 HasDict, SupportsWeakRefs > > Without the "final", line 2 is classified as inher-cont. With the > "final", it gets topmost-intro-cont and wrong indentation. Proposed fix: diff --git a/lisp/progmodes/cc-engine.el b/lisp/progmodes/cc-engine.el index b4c12896f3..121888d825 100644 --- a/lisp/progmodes/cc-engine.el +++ b/lisp/progmodes/cc-engine.el @@ -12268,6 +12268,9 @@ c-guess-basic-syntax (if (eq (char-after) ?<) (zerop (c-forward-token-2 1 t indent-point)) t) + (if (looking-at "final\\>[^_]") + (c-forward-token-2 1 nil indent-point) + t) (eq (char-after) ?:)))) (goto-char placeholder) (c-add-syntax 'inher-cont (c-point 'boi))) From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 14:13:50 2019 Received: (at control) by debbugs.gnu.org; 5 Apr 2019 18:13:50 +0000 Received: from localhost ([127.0.0.1]:46278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCTLa-000461-8O for submit@debbugs.gnu.org; Fri, 05 Apr 2019 14:13:50 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:44500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCTLY-00045o-RI for control@debbugs.gnu.org; Fri, 05 Apr 2019 14:13:49 -0400 Received: by mail-pl1-f174.google.com with SMTP id g12so3427769pll.11 for ; Fri, 05 Apr 2019 11:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:openpgp:autocrypt:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=dsMPmTczetOHDaxD93sJVE84UtqFtqMhW7EcdR/HMAw=; b=Og6PaTqdyh+mEe4L2welkSg4YXchLT3rQf3PC4wwhIEo9xu/5mQDucpYEX0YXBwAOr OUjMK55X5f8t5hGAJ/g6NSI9MhjDoFUf1AHJa1y93vd/DrOaKlwrAQAgHhr6IUYjxRMN GMbhVF1E1xG1hKGCXcc4oW5K6Lt+HsSwcyt0N4JfhqhP6IhekMFjVFbgk+yXgdPD4TYo 3QiVD9bFBfvIzfKk0GVHixb5/hod2PO2ufdQ+JSAnjyDshKbRzGUGY3OSsEccHnNQwqd r+ETkZeIlLTdMCpDP6chbUMlu3JTbAz8vwRRb9DcFT/bWr7OspNkFrsYlxBK5qKRfVRy lfvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:openpgp:autocrypt:message-id :date:user-agent:mime-version:content-language :content-transfer-encoding; bh=dsMPmTczetOHDaxD93sJVE84UtqFtqMhW7EcdR/HMAw=; b=YlJchn1wBUVf4ADbJmkmaSi8LV/qlIG+VyRndOu9hK5XSpwFpcIlqaeC4ZeBBfs6/H mFgysVJ3OI6HkPTFMsJut6PaJTGvrO3aIFRIVmhiXeP7V436LjSuR8dnUpUg7pt+mbv8 udFRA0/HtFuMGE0j+EOns3vop6YJCu+/nByd2tnEyPMF2/xX0dK9OfZ6IefHAa7dEj9E HgXmYf7QoxH9JshfWbTSlc1+FKeDv1aeW1jwEuiUGziSxQxvj8DrOtqo1vDll40z7ptP vOyZWNN4tJ1meTEgZbSZAw/6np1j0VUvsmxaeRO/jieL8+rKvdRWr/HYh186cgdYSqVe 62NA== X-Gm-Message-State: APjAAAVokkkw6eDFPz+FeVN+xUc6Q6CBU9JJgaWOg3z1VQ3TGi9aAX4Y dc/cpUKEQEje0V/F0q2X45w1krP0 X-Google-Smtp-Source: APXvYqxu8jTr+x3rSRZjv4WRZ9YmKgjnrku493BB51uYbLWp2Asqr6KQ1NReMF40pni+T0h7r46pLA== X-Received: by 2002:a17:902:a81:: with SMTP id 1mr14101192plp.308.1554488022301; Fri, 05 Apr 2019 11:13:42 -0700 (PDT) Received: from [192.168.1.4] ([123.201.54.128]) by smtp.gmail.com with ESMTPSA id o67sm38409700pga.55.2019.04.05.11.13.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 11:13:41 -0700 (PDT) To: control@debbugs.gnu.org From: Bhavin Gandhi Subject: control message for #34594 Openpgp: preference=signencrypt Autocrypt: addr=bhavin7392@gmail.com; keydata= mQENBFlvYmcBCADMvY6vWW1mlrMaFjR/zfH8F+POSERMwwJbUIjYQZYdXS6Ka0MoGwscBvqX K0ANEz98oiQF4YYOXVRjjXuEHa1McuFBhWytcz8CtK0R+z7NZ+1RCZRnycH699ytSFfhg3TW 393hHciwT4pqtJx/XpMpLa3SUtmwCb0nc6XPN/N54Ma/kQoHaAAmLxgIkJuimUyNeW5nfYeD 2oCuWMp3BrPQusSsnUqXRKeZYr0A/4hFG3Fvrz5JQTSunbnkJsEGcaLx5U8R01EagF2t9Weu dzJEUkuqbgyd32Mvew63HxvzQJ/912i04pbNLJJZWQT7zc/Pq/S8eKTmxJkXuO/8P6D/ABEB AAG0JEJoYXZpbiBHYW5kaGkgPGJoYXZpbjczOTJAZ21haWwuY29tPokBVAQTAQgAPhYhBFhJ I56UHw6ygGNwvbRcxA4XNfShBQJZb2JnAhsDBQkDwmcABQsJCAcCBhUICQoLAgQWAgMBAh4B AheAAAoJELRcxA4XNfShvekH/iJc6mt4UYg74+yJfvlQ1ZIXSgw2+A3meOR9akD0+hxSfJqH 2O+SQ1kJxe6zzkZWhSHrQpNs+EDjreqAJKMFAIbcijsRAQY1rLrz0F3v2jeQqmsFebIOEJyD gVZkP4/PzbEHPjLCqIZZzF4txVIFen0DGa9oQCQ0HiZeU+5uNpT/lmxcYCy5rUNnDExrHMEN ntPRq4n3txqa4XTVMvuMCxZ7OdMExQ/Ss9pa2TNS851sUWYPSFo/7E+9/c1Bhf0Mol5aNNPJ kmafXck9hdlEnww2piA8qpAxadVzZ9EkalkCL9f+jLAwj7CiCWOQntJYOM4Uw16ZBL+enqBi wxl5H1K5AQ0EWW9iZwEIALwi+JkFmwdA3xzPfknVIVdTOUn30JZSrU0svMPA7+RgW1h/6upq 3919VCn9E+IZLJtt2AoSMLFcMasif1+sd2A1Fh+0cXT7A0deBJCuNUBJQQpTVy3iQCR02cRW fC3x2/f7DDZyZJI46pTxSY5fYiYcGf9yVrtLAdGCTNZiVKMpSD73aPUSv9Emt9Aytj6aMHRM I/R2AVaWaXeP5YW5sgmh6ANfXXLDH8epbLBEqg2Ewtt2oqZz8I4AGq+hTvd/hcw2UR/D3SmF QuZWy+A+F77updlz7K+5cUcu5Su/Ad+LZRi86/7mhVMZz+WQKvJlKEkmwgfqCtkgHNpIdHdG BP0AEQEAAYkBPAQYAQgAJhYhBFhJI56UHw6ygGNwvbRcxA4XNfShBQJZb2JnAhsMBQkDwmcA AAoJELRcxA4XNfShZ2IH/RSlP61KkIVLhEnHJkQorh8a/zn+qO9mWcJN67Wze8b5dTZnoUkr cYvtVe4n51nnCNy3qMZYGjZIJuLuB/GFec+9EPhAxaKYlpLKlBMJwXhZ6XCgMNIMTMw23JiR QxIr5rfi/0Y8hybM9Ycu4KNMowW0TbwR78UB8eRQ7dCLFv+b8PjjkJ1dXmE64KYozzxmluor nosxNaL3KGSrxF2FPY8WVizERQ/cju3yDGg4O95wLc4j4B4HurMlOzsOR+jEcWtNBF16T9cf fKYLr5NrS03ffPHgVMasNIYfzniIiPgPpWkgUMasUDIul4XMKPXLMt6Mz9e9WHmIN44DuRYu V24= Message-ID: <369aeecf-9656-8de5-9093-b4197f6e1aa4@gmail.com> Date: Fri, 5 Apr 2019 23:43:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) tags 34594 confirmed From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 22:54:49 2019 Received: (at 34594) by debbugs.gnu.org; 13 Apr 2019 02:54:49 +0000 Received: from localhost ([127.0.0.1]:57416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hF8ob-0006bp-2Q for submit@debbugs.gnu.org; Fri, 12 Apr 2019 22:54:49 -0400 Received: from dancol.org ([96.126.100.184]:33830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hF8oX-0006bc-JT for 34594@debbugs.gnu.org; Fri, 12 Apr 2019 22:54:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:Subject; bh=CRkPjdFAn1TmX+bUtnZGVeoZmQ4vPvqroJYFbHTnsm8=; b=ZTur1jALyZ/DknukJjKqAqi++IfU1MmBpwLs2J4wWgEXn8DE+cbvg7hZ59I+LpZTaDlJHr6uL/6NbgjHpIDaDysJoohZK14MBuW6v5GQZiVR6EJuMh+RvlmGXdIyNhAHRbfBqtfPuA37AXpfsvtM25siMhLgO1HdWmNscDF/8un3AGV8fU9QnZF8U7s+1PoYqh3QzdTbhyHWIAr7jX+yGaeV/p02dXQJPS+af0YZOqum03c2lh3RQclnOORSOeMfPLiy+qK20udbLzZve22xD4kUv+bIzdQmDzGCn5rjpYtgDZP3fj9MTgoLZlyZZRBhB24LbI2x4kr1rg5Nk2rUrg==; Received: from [2604:4080:1321:9a00:fc2a:787c:f84c:2105] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1hF8oV-0003Wo-Fh; Fri, 12 Apr 2019 19:54:43 -0700 Subject: Re: bug#34594: cc-mode needs to support "final" in C++ classes References: From: Daniel Colascione Message-ID: <40982e49-bc1e-5164-bfc7-428860ce6391@dancol.org> Date: Fri, 12 Apr 2019 19:54:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: + Alan On 2/20/19 11:34 AM, Daniel Colascione wrote: >> Consider this: >> >> 1 struct QueryCache final : BasePyObject, SupportsGcClear, >> 2 HasDict, SupportsWeakRefs >> >> Without the "final", line 2 is cla [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: dancol.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.2 MISSING_HEADERS Missing To: header X-Debbugs-Envelope-To: 34594 Cc: Alan Mackenzie , 34594@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) + Alan On 2/20/19 11:34 AM, Daniel Colascione wrote: >> Consider this: >> >> 1 struct QueryCache final : BasePyObject, SupportsGcClear, >> 2 HasDict, SupportsWeakRefs >> >> Without the "final", line 2 is classified as inher-cont. With the >> "final", it gets topmost-intro-cont and wrong indentation. > > Proposed fix: > > diff --git a/lisp/progmodes/cc-engine.el b/lisp/progmodes/cc-engine.el > index b4c12896f3..121888d825 100644 > --- a/lisp/progmodes/cc-engine.el > +++ b/lisp/progmodes/cc-engine.el > @@ -12268,6 +12268,9 @@ c-guess-basic-syntax > (if (eq (char-after) ?<) > (zerop (c-forward-token-2 1 t indent-point)) > t) > + (if (looking-at "final\\>[^_]") > + (c-forward-token-2 1 nil indent-point) > + t) > (eq (char-after) ?:)))) > (goto-char placeholder) > (c-add-syntax 'inher-cont (c-point 'boi))) > From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 09:36:51 2019 Received: (at 34594) by debbugs.gnu.org; 13 Apr 2019 13:36:51 +0000 Received: from localhost ([127.0.0.1]:58359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFIpv-0007rV-0E for submit@debbugs.gnu.org; Sat, 13 Apr 2019 09:36:51 -0400 Received: from colin.muc.de ([193.149.48.1]:56199 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hFIpt-0007rK-5P for 34594@debbugs.gnu.org; Sat, 13 Apr 2019 09:36:49 -0400 Received: (qmail 60228 invoked by uid 3782); 13 Apr 2019 13:36:46 -0000 Received: from acm.muc.de (p2E5D5F4C.dip0.t-ipconnect.de [46.93.95.76]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 13 Apr 2019 15:36:45 +0200 Received: (qmail 25232 invoked by uid 1000); 13 Apr 2019 13:36:45 -0000 Date: Sat, 13 Apr 2019 13:36:45 +0000 To: Daniel Colascione Subject: Re: bug#34594: cc-mode needs to support "final" in C++ classes Message-ID: <20190413133645.GB13636@ACM> References: <40982e49-bc1e-5164-bfc7-428860ce6391@dancol.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40982e49-bc1e-5164-bfc7-428860ce6391@dancol.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34594 Cc: 34594@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Daniel. I've fixed this in master, pretty much as you suggested. Feel free to try out the fix, and to tell me it isn't quite working. ;-) -- Alan Mackenzie (Nuremberg, Germany). On Fri, Apr 12, 2019 at 19:54:36 -0700, Daniel Colascione wrote: > + Alan > On 2/20/19 11:34 AM, Daniel Colascione wrote: > >> Consider this: > >> > >> 1 struct QueryCache final : BasePyObject, SupportsGcClear, > >> 2 HasDict, SupportsWeakRefs > >> > >> Without the "final", line 2 is classified as inher-cont. With the > >> "final", it gets topmost-intro-cont and wrong indentation. > > > > Proposed fix: > > > > diff --git a/lisp/progmodes/cc-engine.el b/lisp/progmodes/cc-engine.el > > index b4c12896f3..121888d825 100644 > > --- a/lisp/progmodes/cc-engine.el > > +++ b/lisp/progmodes/cc-engine.el > > @@ -12268,6 +12268,9 @@ c-guess-basic-syntax > > (if (eq (char-after) ?<) > > (zerop (c-forward-token-2 1 t indent-point)) > > t) > > + (if (looking-at "final\\>[^_]") > > + (c-forward-token-2 1 nil indent-point) > > + t) > > (eq (char-after) ?:)))) > > (goto-char placeholder) > > (c-add-syntax 'inher-cont (c-point 'boi))) > > From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 09:57:52 2019 Received: (at 34594) by debbugs.gnu.org; 13 Apr 2019 13:57:52 +0000 Received: from localhost ([127.0.0.1]:58940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFJAG-0008Uv-86 for submit@debbugs.gnu.org; Sat, 13 Apr 2019 09:57:52 -0400 Received: from mail-lj1-f169.google.com ([209.85.208.169]:39757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFJAF-0008Ui-0I for 34594@debbugs.gnu.org; Sat, 13 Apr 2019 09:57:51 -0400 Received: by mail-lj1-f169.google.com with SMTP id l7so11409025ljg.6 for <34594@debbugs.gnu.org>; Sat, 13 Apr 2019 06:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=np2K6cCeYsk2jDsYQVMXKYRKGIdlwB1ypC/P1aAPuXE=; b=scIFfxxOnCQBcMUQOGytk1xJZcl8RaKVOoPsruEWw4QRaEWGbN9/OuFCqUPWNOWtFl K9Z4QNhotn9JU/hED+llpkpx+fwL/lmeEtpUksnFx2mRR2VZLqaL8m+O19w3xcDSCLgm UHJLwQ7v6WPw2P0ztGtUE4PYNAFfRN+Z3gJBDY1lDL1tudm3xCZEmp6X9ao1rUIrwguG 3zdMW0s0GWG2OxjzcdJ6FV3yGtLz6TZYFsb0C7nmCZVru2hlsnU+jo6tLeaibxHOKeaP Q1HmKZ0QbUspKkdWM+0gjuyHTBhf9U/EFX3f7wAqkMqfYstch4ZcBnadrBW/731iPyoV HrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=np2K6cCeYsk2jDsYQVMXKYRKGIdlwB1ypC/P1aAPuXE=; b=i9Nd0zSM+5OIY/d0PICvnwnoZmiCtgQiq2r4t6KvsYd8T/c1mjrHMmOzLMA9c3/UFn kS+zuF1L4GephXUc4BlzyjTv1omTBhAVsaDt9oqy02sR1GgY0tilH8yLxtXrwQt10wNC moJCUiqhJsTLkegGZJJlBCnyZsUrZk57r/XAGUicdoY0YOupbiuCj3Mv4MtY3mxrdrnt Ru8FpJKRykta0QuD9LaX2BANuYWb55HcUc2z0t6TObi/FaPLCMGvR8u/ws4Lq25ue6oD 4azxHfX5BgyeMln7glOmo1+K8caJhpI7YWb4Otx2HepsxEtRutb8oQFiHqOY7uyjSNdl cp4A== X-Gm-Message-State: APjAAAVZAkaSoJL6JlVOs31GO6ba4llxK1qWrJcINEcjgZZrIlO8+TLY Bbdijb0Wv/oAlBNtkkUcXDMooms5V0q6BQ/shOU= X-Google-Smtp-Source: APXvYqzeHXXb2zStnP5FVDc1BM8z/K4jhfepAjVVsHZLkuaz6VhhlmexiTOMk5UXQaIo/Hn0uOTuWkJyD//fWkWXblg= X-Received: by 2002:a2e:8703:: with SMTP id m3mr33514327lji.107.1555163864806; Sat, 13 Apr 2019 06:57:44 -0700 (PDT) MIME-Version: 1.0 References: <40982e49-bc1e-5164-bfc7-428860ce6391@dancol.org> <20190413133645.GB13636@ACM> In-Reply-To: <20190413133645.GB13636@ACM> From: Mauro Aranda Date: Sat, 13 Apr 2019 10:57:32 -0300 Message-ID: Subject: Re: bug#34594: cc-mode needs to support "final" in C++ classes To: Alan Mackenzie Content-Type: multipart/alternative; boundary="000000000000bab960058669cd62" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34594 Cc: 34594@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bab960058669cd62 Content-Type: text/plain; charset="UTF-8" Hello Alan, Just a minor typo: In c-class-id-suffix-ws-ids-kwds, "syntactially" Best regards, Mauro. --000000000000bab960058669cd62 Content-Type: text/html; charset="UTF-8"
Hello Alan,

Just a minor typo: In c-class-id-suffix-ws-ids-kwds, "syntactially"

Best regards,
Mauro.
--000000000000bab960058669cd62-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 15:43:15 2019 Received: (at 34594) by debbugs.gnu.org; 13 Apr 2019 19:43:15 +0000 Received: from localhost ([127.0.0.1]:59250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFOYU-0000HZ-Op for submit@debbugs.gnu.org; Sat, 13 Apr 2019 15:43:14 -0400 Received: from colin.muc.de ([193.149.48.1]:15631 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hFOYS-0000HQ-Md for 34594@debbugs.gnu.org; Sat, 13 Apr 2019 15:43:13 -0400 Received: (qmail 92166 invoked by uid 3782); 13 Apr 2019 19:43:10 -0000 Received: from acm.muc.de (p2E5D5F4C.dip0.t-ipconnect.de [46.93.95.76]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 13 Apr 2019 21:43:10 +0200 Received: (qmail 30648 invoked by uid 1000); 13 Apr 2019 19:43:10 -0000 Date: Sat, 13 Apr 2019 19:43:10 +0000 To: Mauro Aranda Subject: Re: bug#34594: cc-mode needs to support "final" in C++ classes Message-ID: <20190413194310.GF13636@ACM> References: <40982e49-bc1e-5164-bfc7-428860ce6391@dancol.org> <20190413133645.GB13636@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34594 Cc: 34594@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mauro. On Sat, Apr 13, 2019 at 10:57:32 -0300, Mauro Aranda wrote: > Hello Alan, > Just a minor typo: In c-class-id-suffix-ws-ids-kwds, "syntactially" Yes. I've fixed it now. Thanks for pointing it out. > Best regards, > Mauro. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 26 10:29:07 2019 Received: (at 34594-done) by debbugs.gnu.org; 26 Apr 2019 14:29:07 +0000 Received: from localhost ([127.0.0.1]:33327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hK1qd-0005ss-30 for submit@debbugs.gnu.org; Fri, 26 Apr 2019 10:29:07 -0400 Received: from colin.muc.de ([193.149.48.1]:38703 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hK1qb-0005sj-OI for 34594-done@debbugs.gnu.org; Fri, 26 Apr 2019 10:29:06 -0400 Received: (qmail 88641 invoked by uid 3782); 26 Apr 2019 14:29:03 -0000 Received: from acm.muc.de (p4FE15E52.dip0.t-ipconnect.de [79.225.94.82]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 26 Apr 2019 16:29:03 +0200 Received: (qmail 8932 invoked by uid 1000); 26 Apr 2019 14:29:03 -0000 Date: Fri, 26 Apr 2019 14:29:03 +0000 To: Daniel Colascione Subject: Re: bug#34594: cc-mode needs to support "final" in C++ classes Message-ID: <20190426142903.GB4720@ACM> References: <40982e49-bc1e-5164-bfc7-428860ce6391@dancol.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40982e49-bc1e-5164-bfc7-428860ce6391@dancol.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34594-done Cc: 34594-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Daniel. The bug has been fixed, so I'm closing it. -- Alan Mackenzie (Nuremberg, Germany). On Fri, Apr 12, 2019 at 19:54:36 -0700, Daniel Colascione wrote: > + Alan > On 2/20/19 11:34 AM, Daniel Colascione wrote: > >> Consider this: > >> > >> 1 struct QueryCache final : BasePyObject, SupportsGcClear, > >> 2 HasDict, SupportsWeakRefs > >> > >> Without the "final", line 2 is classified as inher-cont. With the > >> "final", it gets topmost-intro-cont and wrong indentation. > > > > Proposed fix: > > > > diff --git a/lisp/progmodes/cc-engine.el b/lisp/progmodes/cc-engine.el > > index b4c12896f3..121888d825 100644 > > --- a/lisp/progmodes/cc-engine.el > > +++ b/lisp/progmodes/cc-engine.el > > @@ -12268,6 +12268,9 @@ c-guess-basic-syntax > > (if (eq (char-after) ?<) > > (zerop (c-forward-token-2 1 t indent-point)) > > t) > > + (if (looking-at "final\\>[^_]") > > + (c-forward-token-2 1 nil indent-point) > > + t) > > (eq (char-after) ?:)))) > > (goto-char placeholder) > > (c-add-syntax 'inher-cont (c-point 'boi))) > > From unknown Sat Aug 16 16:00:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 May 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator