From unknown Thu Jun 19 14:04:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Feb 2019 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 34576@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches" Received: via spool by submit@debbugs.gnu.org id=B.155060081725729 (code B ref -1); Tue, 19 Feb 2019 18:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Feb 2019 18:26:57 +0000 Received: from localhost ([127.0.0.1]:55529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwA6a-0006gv-NK for submit@debbugs.gnu.org; Tue, 19 Feb 2019 13:26:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwA6Y-0006gj-O7 for submit@debbugs.gnu.org; Tue, 19 Feb 2019 13:26:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:56758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwA6Q-0002oX-LB for submit@debbugs.gnu.org; Tue, 19 Feb 2019 13:26:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwA6P-0002iN-Pt for guix-patches@gnu.org; Tue, 19 Feb 2019 13:26:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwA6O-0002ne-Me for guix-patches@gnu.org; Tue, 19 Feb 2019 13:26:45 -0500 Received: from aibo.runbox.com ([91.220.196.211]:35974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwA6N-0002jg-QD for guix-patches@gnu.org; Tue, 19 Feb 2019 13:26:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Message-Id:Content-Type:Date:Subject:To:From:MIME-Version; bh=/rbKzKm4Fg+F6fE+xvCTwkAmdIbeLqXlIIevt1OHxEU=; b=NDH1zWwwIElYsg9weYE1DZ6Dc ymd4vtwz4qEPiqV997xeHlVj16vcjIj3hryF+q1Rgr0Rvp6/5G20QS+UoS+gyuepMQhxRs84Py5Ot K5XOtMlQN02HyGrf3DpFKJJRcM5TExnFfb6fFSt9ifSL7Bx0AGzEVcjKeOUqD3aIEt/sfc9eGXhzC qXZNoqy9Mnc3l7fVmFBLOGjoxJFfurhNiTrT9xXSEaGuhMb0wwlVr5ovkDt7LB1fTgGRvBMjNnVTB HhN6mJXH9loT5k0JxgPLx9vCbA69Le8nCAKmTvX3XlQKdWeNkO3MY7TGefsvY+CgNW2cEwGOgirMu 6EiZSChnQ==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1gwA67-0004Qf-FW for guix-patches@gnu.org; Tue, 19 Feb 2019 19:26:27 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1gwA67-0001RN-Er for guix-patches@gnu.org; Tue, 19 Feb 2019 19:26:27 +0100 MIME-Version: 1.0 Received: from [Authenticated user (850733)] by runbox.com with http (RMM6); for ; Tue, 19 Feb 2019 18:26:27 GMT From: Date: Tue, 19 Feb 2019 18:26:27 +0000 (GMT) X-Mailer: RMM6 Content-Type: multipart/mixed; boundary="----------=_1550600787-3044-0" Message-Id: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.220.196.211 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This patch adds two phases to the package definition for Calibre that install an icon and install a desktop file. From 894a471083105a182d548c2b80effb0eb70c8fa6 Mon Sep 17 00:00:00 2001 From: Pkill -9 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: runbox.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pkill9[at]runbox.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (pkill9[at]runbox.com) 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=pkill9%40runbox.com; ip=209.51.188.92; r=debbugs.gnu.org] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) This is a multi-part message in MIME format... ------------=_1550600787-3044-0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable This patch adds two phases to the package definition for Calibre that insta= ll an icon and install a desktop file.= ------------=_1550600787-3044-0 Content-Type: text/x-patch; name="=?UTF-8?Q?0001-gnu-calibre-Add-icon-and-desktop-file.patch?=" Content-Disposition: attachment; filename="=?UTF-8?Q?0001-gnu-calibre-Add-icon-and-desktop-file.patch?=" Content-Transfer-Encoding: base64 Content-ID: RnJvbSA4OTRhNDcxMDgzMTA1YTE4MmQ1NDhjMmI4MGVmZmIwZWI3MGM4ZmE2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQa2lsbCAtOSA8cGtp bGw5QHJ1bmJveC5jb20+CkRhdGU6IFR1ZSwgMTkgRmViIDIwMTkgMTg6MjM6 MzcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IGNhbGlicmU6IEFkZCBp Y29uIGFuZCBkZXNrdG9wIGZpbGUuCgoqIGdudS9wYWNrYWdlcy9lYm9vay5z Y20gKGNhbGlicmUpOiBBZGQgaWNvbiBhbmQgZGVza3RvcCBmaWxlLgotLS0K IGdudS9wYWNrYWdlcy9lYm9vay5zY20gfCAyNyArKysrKysrKysrKysrKysr KysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2Vi b29rLnNjbSBiL2dudS9wYWNrYWdlcy9lYm9vay5zY20KaW5kZXggOTllNDli YzE3Li5hZTg5OWUwNGIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lYm9v ay5zY20KKysrIGIvZ251L3BhY2thZ2VzL2Vib29rLnNjbQpAQCAtMTg1LDcg KzE4NSwzMiBAQAogICAgICAgICAgICAgICAoc2V0ZW52ICJQT0RPRk9fSU5D X0RJUiIgKHN0cmluZy1hcHBlbmQgcG9kb2ZvICIvaW5jbHVkZS9wb2RvZm8i KSkKICAgICAgICAgICAgICAgKHNldGVudiAiUE9ET0ZPX0xJQl9ESVIiIChz dHJpbmctYXBwZW5kIHBvZG9mbyAiL2xpYiIpKQogICAgICAgICAgICAgICAj dCkpKQotICAgICAgICAgKGFkZC1hZnRlciAnaW5zdGFsbCAnaW5zdGFsbC1m b250LWxpYmVyYXRpb24KKyAgICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwg J2luc3RhbGwtaWNvbgorICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0 cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAgICAgKGxldCog KChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkpCisgICAgICAgICAg ICAgICAoaW5zdGFsbC1maWxlICJpbWdzcmMvY2FsaWJyZS5zdmciCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kIG91dAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi L3NoYXJlL2ljb25zL2hpY29sb3Ivc2NhbGFibGUvYXBwcyIpKSkKKyAgICAg ICAgICAgICAjdCkpCisgICAgICAgICAoYWRkLWFmdGVyICdpbnN0YWxsLWlj b24gJ2luc3RhbGwtZGVza3RvcC1maWxlCisgICAgICAgICAgIChsYW1iZGEq ICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAg ICAgICAobGV0ICgob3V0IChhc3NvYy1yZWYgb3V0cHV0cyAib3V0IikpKQor ICAgICAgICAgICAgICAgKG1rZGlyLXAgKHN0cmluZy1hcHBlbmQgb3V0ICIv c2hhcmUvYXBwbGljYXRpb25zIikpCisgICAgICAgICAgICAgICAod2l0aC1v dXRwdXQtdG8tZmlsZQorICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBw ZW5kIG91dCAiL3NoYXJlL2FwcGxpY2F0aW9ucy9jYWxpYnJlLmRlc2t0b3Ai KQorICAgICAgICAgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAg ICAgICAoZm9ybWF0ICN0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAi W0Rlc2t0b3AgRW50cnldfkAKKyAgICAgICAgICAgICAgICBOYW1lPUNhbGli cmV+QAorICAgICAgICAgICAgICAgIENvbW1lbnQ9RS1ib29rIG9yZ2FuaXNl ciBhbmQgcmVhZGVyfkAKKyAgICAgICAgICAgICAgICBFeGVjPX5hL2Jpbi9j YWxpYnJlfkAKKyAgICAgICAgICAgICAgICBUcnlFeGVjPX5AKn5hL2Jpbi9j YWxpYnJlfkAKKyAgICAgICAgICAgICAgICBJY29uPWNhbGlicmV+QAorICAg ICAgICAgICAgICAgIENhdGVnb3JpZXM9T2ZmaWNlfkAKKyAgICAgICAgICAg ICAgICBUeXBlPUFwcGxpY2F0aW9ufiUiCisgICAgICAgICAgICAgICAgICAg ICAgICAgICBvdXQpKSkKKyAgICAgICAgICAgICAgICN0KSkpCisgICAgICAg ICAoYWRkLWFmdGVyICdpbnN0YWxsLWRlc2t0b3AtZmlsZSAnaW5zdGFsbC1m b250LWxpYmVyYXRpb24KICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IGlu cHV0cyBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKICAgICAgICAgICAg ICAoZm9yLWVhY2ggKGxhbWJkYSAoZmlsZSkKICAgICAgICAgICAgICAgICAg ICAgICAgICAoaW5zdGFsbC1maWxlIGZpbGUgKHN0cmluZy1hcHBlbmQKLS0g CjIuMjAuMQoK ------------=_1550600787-3044-0-- From unknown Thu Jun 19 14:04:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Feb 2019 21:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: pkill9@runbox.com Cc: 34576@debbugs.gnu.org Received: via spool by 34576-submit@debbugs.gnu.org id=B34576.155061162417968 (code B ref 34576); Tue, 19 Feb 2019 21:28:02 +0000 Received: (at 34576) by debbugs.gnu.org; 19 Feb 2019 21:27:04 +0000 Received: from localhost ([127.0.0.1]:55669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwCuu-0004fk-7P for submit@debbugs.gnu.org; Tue, 19 Feb 2019 16:27:04 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwCup-0004fG-67 for 34576@debbugs.gnu.org; Tue, 19 Feb 2019 16:27:02 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1550611600; cv=none; d=zoho.com; s=zohoarc; b=Yzuvqu/Rkdpe0OByHEBIGEgW8HJFjZ82gsu5bXFzwlu7Ekd1hW1EvTz1yEbfsT+vJssiG5CLKdAjPl7DJ0J5bHQlsmhTnNYLlMHFK4fKTOLABg/LSpK1y7tWUvOHVH6Zp0FESZukoiLt/rLOw8lT6+sSbxFfgan4T1D1iqryQXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1550611600; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=6dB9TkFh4rEQXEtSMqtNCpZrfXaG+pyKOuEaYJX6JGs=; b=GKaD2RS6X/83llpPnIBi5eooWdXYEGMke+f5BQpSOhE3Db8MBmB6GoexwM2XR4Qp1fR0ExlG97dSKHTsDYubOJZpK6f3kyU0Mb4wJSoFsT/Pn/l5zT0cK9kDvTRhLd0lo66Iz3PAIl3aUdkfsBgi9SMDMwklxeje/wy0RqL+YqQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1550611600; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; l=1250; bh=6dB9TkFh4rEQXEtSMqtNCpZrfXaG+pyKOuEaYJX6JGs=; b=OLdJs17j+hqMlWbq0ZWd58md0Tx5a/sR/OmK5wAALHq4LFzd0UzUAzIFuyMVeEdK /+duuUihLFcD9+i/0zp/sL3m7kfD5guM1ytFRsGU/UN6TrXcU8tw5E1vpljxdo7c1Ip tXPTPFHGzO8TirFO9UC+zMfxDAZ7+zH6kor0JFUk= Received: from localhost (p4FD5AD8A.dip0.t-ipconnect.de [79.213.173.138]) by mx.zohomail.com with SMTPS id 1550611598927952.0971315649067; Tue, 19 Feb 2019 13:26:38 -0800 (PST) References: User-agent: mu4e 1.0; emacs 26.1 From: Ricardo Wurmus In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Tue, 19 Feb 2019 22:26:35 +0100 Message-ID: <875ztfv59w.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi pkill9, > + (add-after 'install 'install-icon > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out"))) > + (install-file "imgsrc/calibre.svg" > + (string-append out > + "/share/icons/hicolor/scalab= le/apps"))) > + #t)) You can do without =E2=80=9Clet*=E2=80=9D here. > + (add-after 'install-icon 'install-desktop-file > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (mkdir-p (string-append out "/share/applications")) > + (with-output-to-file > + (string-append out "/share/applications/calibre.deskt= op") > + (lambda _ > + (format #t > + "[Desktop Entry]~@ > + Name=3DCalibre~@ > + Comment=3DE-book organiser and reader~@ > + Exec=3D~a/bin/calibre~@ > + TryExec=3D~@*~a/bin/calibre~@ > + Icon=3Dcalibre~@ > + Categories=3DOffice~@ > + Type=3DApplication~%" > + out))) > + #t))) Does upstream not provide a desktop file? I=E2=80=99d rather see this subm= itted to upstream. Have you contacted the developers about this? Secondly, the indentation is odd. I=E2=80=99d write it like this: (format #t "\ [Desktop Entry]~@ Name=3D=E2=80=A6 Comment=3D=E2=80=A6 =E2=80=A6 Type=3DApplication~%" out) -- Ricardo From unknown Thu Jun 19 14:04:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre References: Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Feb 2019 04:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: "Ricardo Wurmus" Cc: 34576 <34576@debbugs.gnu.org> Received: via spool by 34576-submit@debbugs.gnu.org id=B34576.155063700813356 (code B ref 34576); Wed, 20 Feb 2019 04:31:01 +0000 Received: (at 34576) by debbugs.gnu.org; 20 Feb 2019 04:30:08 +0000 Received: from localhost ([127.0.0.1]:57034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwJWK-0003TL-DL for submit@debbugs.gnu.org; Tue, 19 Feb 2019 23:30:08 -0500 Received: from aibo.runbox.com ([91.220.196.211]:54250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwJWH-0003SI-UP for 34576@debbugs.gnu.org; Tue, 19 Feb 2019 23:30:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Message-Id:In-Reply-To:Date:Subject:CC:To:From:MIME-Version :Content-Transfer-Encoding:Content-Type; bh=hZSc4wLI64XmQdG+qoydrHlb9n4cyngDrnx4Peo/kdU=; b=DH3fYAmoO/D8MtFAYNgxxZdos9 BVR6fgiRFzCTwEAkIdVXDK6jg3u20KNNE4kVEB8AQ/SmJ1F15IugA7qrFGPcgTAMcakrvJVGtIsTh ZGAuc2QSBCeuqv0H98KBhrxdRXURuWtliUzHIIgbXlChMTEJLJ+vIrFhwRUMvvMSDOuB/wJ/GwxV2 i69X4ycuR8XiyIxJGVxoNwCg7S2KYjGSPp7+7cv5Q3Xo2OT2L13OIGmgu37Qz/FSp8AxqwtEMHXpk 6aDjiQruYJ4KlDUL3TVuhkNAZ1Ra5w9a2wOzRm+pjkU8RDunUJYHEH+CKO4kLMTFGaAeKIyG6kEnE 9PomznlQ==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1gwJWF-0007V1-II; Wed, 20 Feb 2019 05:30:03 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1gwJWF-0002re-HA; Wed, 20 Feb 2019 05:30:03 +0100 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received: from [Authenticated user (850733)] by runbox.com with http (RMM6); Wed, 20 Feb 2019 04:30:03 GMT From: Date: Wed, 20 Feb 2019 04:30:03 +0000 (GMT) X-Mailer: RMM6 In-Reply-To: <875ztfv59w.fsf@elephly.net> Message-Id: X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Hi Ricardo, > Does upstream not provide a desktop file? I=E2=80=99d rather see this su= bmitted > to upstream. Have you contacted the developers about this? It looks like it does provide a desktop file looking at this pull request: = https://github.com/kovidgoyal/calibre/pull/739, which modifies this file (l= ink to line showing desktop file): https://github.com/kovidgoyal/calibre/bl= ob/master/src/calibre/linux.py#L1031 It's created using a Python script though, perhaps it doesn't get run durin= g building? I thought the developer wouldn't add it upstream because I remember investi= gating a long time ago and finding the developer writing somewhere that the= y wouldn't add a desktop file upstream and that it was the linux packager's= job to do that, maybe I am mis-remembering or it was in some other context. On Tue, 19 Feb 2019 22:26:35 +0100, Ricardo Wurmus wro= te: >=20 > Hi pkill9, >=20 > > + (add-after 'install 'install-icon > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out"))) > > + (install-file "imgsrc/calibre.svg" > > + (string-append out > > + "/share/icons/hicolor/scal= able/apps"))) > > + #t)) >=20 > You can do without =E2=80=9Clet*=E2=80=9D here. >=20 > > + (add-after 'install-icon 'install-desktop-file > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let ((out (assoc-ref outputs "out"))) > > + (mkdir-p (string-append out "/share/applications")) > > + (with-output-to-file > > + (string-append out "/share/applications/calibre.des= ktop") > > + (lambda _ > > + (format #t > > + "[Desktop Entry]~@ > > + Name=3DCalibre~@ > > + Comment=3DE-book organiser and reader~@ > > + Exec=3D~a/bin/calibre~@ > > + TryExec=3D~@*~a/bin/calibre~@ > > + Icon=3Dcalibre~@ > > + Categories=3DOffice~@ > > + Type=3DApplication~%" > > + out))) > > + #t))) >=20 > Does upstream not provide a desktop file? I=E2=80=99d rather see this su= bmitted > to upstream. Have you contacted the developers about this? >=20 > Secondly, the indentation is odd. I=E2=80=99d write it like this: >=20 > (format #t "\ > [Desktop Entry]~@ > Name=3D=E2=80=A6 > Comment=3D=E2=80=A6 > =E2=80=A6 > Type=3DApplication~%" out) >=20 >=20 > -- > Ricardo From unknown Thu Jun 19 14:04:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Feb 2019 05:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: pkill9@runbox.com Cc: Ricardo Wurmus , 34576 <34576@debbugs.gnu.org> Received: via spool by 34576-submit@debbugs.gnu.org id=B34576.155063884516168 (code B ref 34576); Wed, 20 Feb 2019 05:01:01 +0000 Received: (at 34576) by debbugs.gnu.org; 20 Feb 2019 05:00:45 +0000 Received: from localhost ([127.0.0.1]:57043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwJzw-0004Ch-EH for submit@debbugs.gnu.org; Wed, 20 Feb 2019 00:00:44 -0500 Received: from mout01.posteo.de ([185.67.36.65]:60472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwJzt-0004CS-T5 for 34576@debbugs.gnu.org; Wed, 20 Feb 2019 00:00:43 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 1EBC616005E for <34576@debbugs.gnu.org>; Wed, 20 Feb 2019 06:00:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1550638834; bh=rzKaqPSlMfQNnmxrpt3iy3qd5Y8NwH8piKYFTmN/hVs=; h=From:To:Cc:Subject:Date:From; b=iBw4Q6G/XgwVjQPLtPoggo+VHJMXkQ07QCR0LMGi8BleVyNA8Ntdwtw4TKOz3zWem aMkZ7FdRML+StExW2SOfhBXaW+DKeDXWscZ+tBC/WU9OXZ8mNV70rjtWcpElpPCnKJ +Nf2q0zfSpeAU/ksnq3v5GsHkXbQ1YDJoiuq4taou0cAfzqkBm6rChNO1lTSBKkpPA MtX11RcnpTFC+HP9QPmcqSk0N04hIgBhfA6q1tCwsw3ZZxsuCVowATkNbvuacA/dXL q7r+uQLE3g0m00LilKovzjF6TG4r10/Tprb8YPjLjF1cUyvU1pnmI25h1+EiljPgWx axNKUbDBRdOvQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 44455X3kD5z6tm8; Wed, 20 Feb 2019 06:00:32 +0100 (CET) References: <875ztfv59w.fsf@elephly.net> User-agent: mu4e 1.0; emacs 26.1 From: Brett Gilio In-reply-to: Date: Tue, 19 Feb 2019 23:00:30 -0600 Message-ID: <87k1hvt5ox.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) pkill9@runbox.com writes: > I thought the developer wouldn't add it upstream because I remember investigating a long time ago and finding the developer writing somewhere that they wouldn't add a desktop file upstream and that it was the linux packager's job to do that, maybe I am mis-remembering or it was in some other context. While we are on that topic, the Calibre maintainer can be (said lovingly) stubborn about some things. On a related topic, Calibre (to my knowledge) is going to remain on python2 forever at his choice because of a political disagreement with python3. Correctness aside, that might have some impact on our upcoming "Great Python 2 Purge". Brett Gilio From unknown Thu Jun 19 14:04:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre References: Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Feb 2019 05:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: "Ricardo Wurmus" Cc: 34576 <34576@debbugs.gnu.org> Received: via spool by 34576-submit@debbugs.gnu.org id=B34576.155063919816700 (code B ref 34576); Wed, 20 Feb 2019 05:07:02 +0000 Received: (at 34576) by debbugs.gnu.org; 20 Feb 2019 05:06:38 +0000 Received: from localhost ([127.0.0.1]:57049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwK5e-0004LH-0k for submit@debbugs.gnu.org; Wed, 20 Feb 2019 00:06:38 -0500 Received: from aibo.runbox.com ([91.220.196.211]:52466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwK5a-0004L7-CL for 34576@debbugs.gnu.org; Wed, 20 Feb 2019 00:06:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Message-Id:Content-Type:In-Reply-To:Date:Subject:CC:To:From :MIME-Version; bh=HoC7igzQ4DzvQmtRZRcJT6rfYftsR8GAE5fwnixS7Wk=; b=hlWP1h2tyq7 sQm/2dhT4t7DcqZ1ksSuuTxquLYHGqgwoleOsgmkIBC2C4//vb3VMEdqUODfag0OCtw1WU8X1gPli WwQ782Swt2aD2gtxF50UKMLdfJYpm7AuYqqGIqI74addIYS7HrrGR1nAReoMGSGXVO5nLPZfBvKEn +9XibojR2GgziefjYlJXQYAqaT4t0Y7ju4UAFgS1jlrzlVHgISpIT+wPEVCln8AJNWChps5I4el3V ZI4T1bFNa7uR6Bkr13rphYog6UYUe3RbZMqGM50zLP1ggBmkt1BRGaKiPOnvsSQ995ovVp3daO0RV Zf+I+tFij9IWeHxdHJMlFjg==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1gwK5W-0002GA-GX; Wed, 20 Feb 2019 06:06:31 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1gwK5W-00056Z-Fk; Wed, 20 Feb 2019 06:06:30 +0100 MIME-Version: 1.0 Received: from [Authenticated user (850733)] by runbox.com with http (RMM6); Wed, 20 Feb 2019 05:06:30 GMT From: Date: Wed, 20 Feb 2019 05:06:30 +0000 (GMT) X-Mailer: RMM6 In-Reply-To: <875ztfv59w.fsf@elephly.net> Content-Type: multipart/mixed; boundary="----------=_1550639190-25000-9" Message-Id: X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) This is a multi-part message in MIME format... ------------=_1550639190-25000-9 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I've attached a patch with the 'let' removed from the icon install phase, b= ut I haven't changed the indentation of the desktop file because when I did= that it added a blank line at the beginning of the desktop file and create= d a large indentation before '[Desktop Entry]'. I moved 'out' to be next to= the last line of the desktop file output. > Secondly, the indentation is odd. I=E2=80=99d write it like this: >=20 > (format #t "\ > [Desktop Entry]~@ > Name=3D=E2=80=A6 > Comment=3D=E2=80=A6 > =E2=80=A6 > Type=3DApplication~%" out) >=20 >=20 > -- I used the xonotic package definition as a reference for thi part, and emac= s' `indent-region` indents it like this. I don't know how it should look. I= 've attached a patch for now. On Tue, 19 Feb 2019 22:26:35 +0100, Ricardo Wurmus wro= te: >=20 > Hi pkill9, >=20 > > + (add-after 'install 'install-icon > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out"))) > > + (install-file "imgsrc/calibre.svg" > > + (string-append out > > + "/share/icons/hicolor/scal= able/apps"))) > > + #t)) >=20 > You can do without =E2=80=9Clet*=E2=80=9D here. >=20 > > + (add-after 'install-icon 'install-desktop-file > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let ((out (assoc-ref outputs "out"))) > > + (mkdir-p (string-append out "/share/applications")) > > + (with-output-to-file > > + (string-append out "/share/applications/calibre.des= ktop") > > + (lambda _ > > + (format #t > > + "[Desktop Entry]~@ > > + Name=3DCalibre~@ > > + Comment=3DE-book organiser and reader~@ > > + Exec=3D~a/bin/calibre~@ > > + TryExec=3D~@*~a/bin/calibre~@ > > + Icon=3Dcalibre~@ > > + Categories=3DOffice~@ > > + Type=3DApplication~%" > > + out))) > > + #t))) >=20 > Does upstream not provide a desktop file? I=E2=80=99d rather see this su= bmitted > to upstream. Have you contacted the developers about this? >=20 > Secondly, the indentation is odd. I=E2=80=99d write it like this: >=20 > (format #t "\ > [Desktop Entry]~@ > Name=3D=E2=80=A6 > Comment=3D=E2=80=A6 > =E2=80=A6 > Type=3DApplication~%" out) >=20 >=20 > -- > Ricardo ------------=_1550639190-25000-9 Content-Type: text/x-patch; name="=?UTF-8?Q?0001-gnu-calibre-Add-desktop-file-and-icon.patch?=" Content-Disposition: attachment; filename="=?UTF-8?Q?0001-gnu-calibre-Add-desktop-file-and-icon.patch?=" Content-Transfer-Encoding: base64 Content-ID: <865e5a812b713a7cafd4a6efb5410c2e> RnJvbSAxNGI3YWFjZWM4MTFkZDhmYmJjN2Q4Nzg0NmRjNDcyMmIxMzUyMmM5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQa2lsbCAtOSA8cGtp bGw5QHJ1bmJveC5jb20+CkRhdGU6IFdlZCwgMjAgRmViIDIwMTkgMDU6MDE6 MTMgKzAwMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IGNhbGlicmU6IEFkZCBk ZXNrdG9wIGZpbGUgYW5kIGljb24uCgoqIGdudS9wYWNrYWdlcy9lYm9vay5z Y20gKGNhbGlicmUpOiBBZGQgZGVza3RvcCBmaWxlIGFuZCBpY29uLgotLS0K IGdudS9wYWNrYWdlcy9lYm9vay5zY20gfCAyNSArKysrKysrKysrKysrKysr KysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9lYm9v ay5zY20gYi9nbnUvcGFja2FnZXMvZWJvb2suc2NtCmluZGV4IDk5ZTQ5YmMx Ny4uYTM0NjY0ODYzIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZWJvb2su c2NtCisrKyBiL2dudS9wYWNrYWdlcy9lYm9vay5zY20KQEAgLTE4NSw3ICsx ODUsMzAgQEAKICAgICAgICAgICAgICAgKHNldGVudiAiUE9ET0ZPX0lOQ19E SVIiIChzdHJpbmctYXBwZW5kIHBvZG9mbyAiL2luY2x1ZGUvcG9kb2ZvIikp CiAgICAgICAgICAgICAgIChzZXRlbnYgIlBPRE9GT19MSUJfRElSIiAoc3Ry aW5nLWFwcGVuZCBwb2RvZm8gIi9saWIiKSkKICAgICAgICAgICAgICAgI3Qp KSkKLSAgICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ2luc3RhbGwtZm9u dC1saWJlcmF0aW9uCisgICAgICAgICAoYWRkLWFmdGVyICdpbnN0YWxsICdp bnN0YWxsLWljb24KKyAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1 dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgIChpbnN0YWxs LWZpbGUgImltZ3NyYy9jYWxpYnJlLnN2ZyIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJlZiBvdXRwdXRz ICJvdXQiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiL3NoYXJlL2ljb25zL2hpY29sb3Ivc2NhbGFibGUvYXBwcyIp KQorICAgICAgICAgICAgICN0KSkKKyAgICAgICAgIChhZGQtYWZ0ZXIgJ2lu c3RhbGwtaWNvbiAnaW5zdGFsbC1kZXNrdG9wLWZpbGUKKyAgICAgICAgICAg KGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQor ICAgICAgICAgICAgIChsZXQgKChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJv dXQiKSkpCisgICAgICAgICAgICAgICAobWtkaXItcCAoc3RyaW5nLWFwcGVu ZCBvdXQgIi9zaGFyZS9hcHBsaWNhdGlvbnMiKSkKKyAgICAgICAgICAgICAg ICh3aXRoLW91dHB1dC10by1maWxlCisgICAgICAgICAgICAgICAgICAgKHN0 cmluZy1hcHBlbmQgb3V0ICIvc2hhcmUvYXBwbGljYXRpb25zL2NhbGlicmUu ZGVza3RvcCIpCisgICAgICAgICAgICAgICAgIChsYW1iZGEgXworICAgICAg ICAgICAgICAgICAgIChmb3JtYXQgI3QKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICJbRGVza3RvcCBFbnRyeV1+QAorICAgICAgICAgICAgICAgIE5h bWU9Q2FsaWJyZX5ACisgICAgICAgICAgICAgICAgQ29tbWVudD1FLWJvb2sg b3JnYW5pc2VyIGFuZCByZWFkZXJ+QAorICAgICAgICAgICAgICAgIEV4ZWM9 fmEvYmluL2NhbGlicmV+QAorICAgICAgICAgICAgICAgIFRyeUV4ZWM9fkAq fmEvYmluL2NhbGlicmV+QAorICAgICAgICAgICAgICAgIEljb249Y2FsaWJy ZX5ACisgICAgICAgICAgICAgICAgQ2F0ZWdvcmllcz1PZmZpY2V+QAorICAg ICAgICAgICAgICAgIFR5cGU9QXBwbGljYXRpb25+JSIgb3V0KSkpKQorICAg ICAgICAgICAgICN0KSkKKyAgICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwt ZGVza3RvcC1maWxlICdpbnN0YWxsLWZvbnQtbGliZXJhdGlvbgogICAgICAg ICAgICAobGFtYmRhKiAoIzprZXkgaW5wdXRzIG91dHB1dHMgIzphbGxvdy1v dGhlci1rZXlzKQogICAgICAgICAgICAgIChmb3ItZWFjaCAobGFtYmRhIChm aWxlKQogICAgICAgICAgICAgICAgICAgICAgICAgIChpbnN0YWxsLWZpbGUg ZmlsZSAoc3RyaW5nLWFwcGVuZAotLSAKMi4yMC4xCgo= ------------=_1550639190-25000-9-- From unknown Thu Jun 19 14:04:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Feb 2019 14:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: pkill9@runbox.com Cc: Ricardo Wurmus , 34576 <34576@debbugs.gnu.org> Received: via spool by 34576-submit@debbugs.gnu.org id=B34576.15506717471305 (code B ref 34576); Wed, 20 Feb 2019 14:10:02 +0000 Received: (at 34576) by debbugs.gnu.org; 20 Feb 2019 14:09:07 +0000 Received: from localhost ([127.0.0.1]:57276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwSYc-0000Ky-Pd for submit@debbugs.gnu.org; Wed, 20 Feb 2019 09:09:07 -0500 Received: from tobias.gr ([80.241.217.52]:54962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwSYY-0000KU-Pv for 34576@debbugs.gnu.org; Wed, 20 Feb 2019 09:09:05 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id e477d7a2; Wed, 20 Feb 2019 14:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=16KKXRG9FkBDyOT03/26tQ U2WYLc9UhKD1PjQsZDMCE=; b=hI2AgZrDD9DGYh8aX6HWfW1UZaP7unBAWrlmZM ZxYFU/lyYMqESaL7u87bJfe4V/SEss6vPFHU75+77Eh9frvfTYulgaeW/Epb6Rx5 3l60Wom+JkiswXaQ9OugN0DFsmUIDlOM32kjc5ret9WiYlBYFbIRV0FANza9V44+ Uemb18G8Dx5/8BFCjWayiiM8swnGlx3M6FuAIPuFLUyrBQbU/M59hgMxb3UC0AYa 4JabCNkkSY44++0mAOtdGvF5ivQ04uqId0jC2y93VwqUUnLUkqyp8AIbraKpvI/J J83lIQdzY69phOgWp1h3tS2aHlsjWAVKK5KNB+Wt1RZtVEkQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ab044cde (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 20 Feb 2019 14:08:50 +0000 (UTC) From: Tobias Geerinckx-Rice References: <875ztfv59w.fsf@elephly.net> In-reply-to: Date: Wed, 20 Feb 2019 15:08:37 +0100 Message-ID: <87mumqwo0q.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pkill -9, pkill9 wrote: > I've attached a patch with the 'let' removed from the icon > install phase, but I haven't changed the indentation of the > desktop file because when I did that it added a blank line at > the beginning of the desktop file and created a large > indentation before '[Desktop Entry]'. Zut alors! You had a typo. Use Ricardo's snippet from the quoted message and make sure that there's no trailing whitespace, particularly after "\ (as was probably the case above). Emacs won't touch the indentation inside the format string. Thanks! T G-R From unknown Thu Jun 19 14:04:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Feb 2019 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: pkill9@runbox.com Cc: 34576 <34576@debbugs.gnu.org> Received: via spool by 34576-submit@debbugs.gnu.org id=B34576.15506727312865 (code B ref 34576); Wed, 20 Feb 2019 14:26:02 +0000 Received: (at 34576) by debbugs.gnu.org; 20 Feb 2019 14:25:31 +0000 Received: from localhost ([127.0.0.1]:57281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwSoV-0000k9-C8 for submit@debbugs.gnu.org; Wed, 20 Feb 2019 09:25:31 -0500 Received: from tobias.gr ([80.241.217.52]:55446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwSoT-0000k0-H0 for 34576@debbugs.gnu.org; Wed, 20 Feb 2019 09:25:30 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id 99ada0e0; Wed, 20 Feb 2019 14:25:27 +0000 (UTC) Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 30a5c165 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 20 Feb 2019 14:25:23 +0000 (UTC) From: Tobias Geerinckx-Rice References: <875ztfv59w.fsf@elephly.net> In-reply-to: Date: Wed, 20 Feb 2019 15:25:21 +0100 Message-ID: <87lg2awn8u.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [I sent my previous message to this bug from the wrong address.=20 Oops! And sorry.] Pkill -9, pkill9 wrote: > - (add-after 'install 'install-font-liberation > + (add-after 'install 'install-icon > + (add-after 'install-icon 'install-desktop-file > + (add-after 'install-desktop-file=20 > 'install-font-liberation This is utterly correct and right and good, but=E2=80=A6 In practice, one tends to just (ADD-AFTER 'INSTALL =E2=80=A6) everywhere=20 instead of building up such nice (but brittle) orderings =E2=80=94 unless=20 the phases actually depend on each other. It makes removing them=20 later slightly quicker. (If you're thinking =E2=80=98Wait, doesn't that run them in the reverse=20 order?=E2=80=99 you're 1. paying attention and b. right. It hardly ever=20 matters.) Kind regards, T G-R From unknown Thu Jun 19 14:04:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Subject: bug#34576: closed (Re: [bug#34576] Calibre: Add icon and desktop file to Calibre) Message-ID: References: <87362y7hwj.fsf@rohleder.de> X-Gnu-PR-Message: they-closed 34576 X-Gnu-PR-Package: guix-patches Reply-To: 34576@debbugs.gnu.org Date: Thu, 01 Oct 2020 03:19:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1601522343-20711-1" This is a multi-part message in MIME format... ------------=_1601522343-20711-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #34576: Calibre: Add icon and desktop file to Calibre which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 34576@debbugs.gnu.org. --=20 34576: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34576 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1601522343-20711-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 34576-done) by debbugs.gnu.org; 1 Oct 2020 03:18:59 +0000 Received: from localhost ([127.0.0.1]:33717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNp7T-0005NF-53 for submit@debbugs.gnu.org; Wed, 30 Sep 2020 23:18:59 -0400 Received: from wp224.webpack.hosteurope.de ([80.237.132.231]:60690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNp7Q-0005MR-JV for 34576-done@debbugs.gnu.org; Wed, 30 Sep 2020 23:18:57 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kNp7O-0004xx-SC; Thu, 01 Oct 2020 05:18:54 +0200 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kNp7N-0004rR-Rf; Thu, 01 Oct 2020 05:18:54 +0200 From: Michael Rohleder To: Subject: Re: [bug#34576] Calibre: Add icon and desktop file to Calibre References: X-PGP-Fingerprint: 755E 2DE5 D0D5 85C5 2E78 2830 7C7A FFBE FEF2 CB25 X-PGP-Key: https://www.rohleder.de/~mike/pgpkey.asc Date: Thu, 01 Oct 2020 05:18:52 +0200 In-Reply-To: (pkill9@runbox.com's message of "Tue, 19 Feb 2019 18:26:27 +0000 (GMT)") Message-ID: <87362y7hwj.fsf@rohleder.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1601522336;6d0410c9; X-HE-SMSGID: 1kNp7O-0004xx-SC X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: writes: > This patch adds two phases to the package definition for Calibre that install an icon and install a desktop file. I believe, this is done with 6e1ab5fadbc8fbe5d8d71864c68dd52ddbc732c9 Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.237.132.231 listed in list.dnswl.org] 0.0 T_SPF_PERMERROR SPF: test of record failed (permerror) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.2 DRUGS_ERECTILE Refers to an erectile drug X-Debbugs-Envelope-To: 34576-done Cc: 34576-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable writes: > This patch adds two phases to the package definition for Calibre that ins= tall an icon and install a desktop file. I believe, this is done with 6e1ab5fadbc8fbe5d8d71864c68dd52ddbc732c9 =2D-=20 Linux - Better for your uptime than Viagra --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl91Sp0RHG1pa2VAcm9o bGVkZXIuZGUACgkQfHr/vv7yyyUVpwf/Q+jCjs0JySHzchf9fPYHJYZc7vzpsPCm 7Sw3QJZA5l+a8SkhBX5x+Wyfm3k6KHAQ9/MVaCWpkaXpGu6OKt97XUs29w2Qa1n2 5Oy+EakcUeiyBM4np30/vshHwO6QnalFWQQqJlPU6igsy00hjTQboLiGMX2Ue3ND xhQglSM7gDvOGmai+Q2RYIgLTOYCF890jhKH3aHaZpebnHob/NXPzbA0QhqvwhDv N29cgcM+aiJbX0ncd+iTvqm7riMX1ieNtzz0EmXqRU0WDONHmRlZvV0/WRFfDMND WiJ1BHgKmbEDqfXr+vV0xtO1zlIll9kK2pIkE7bIKSUrGWOhaGLtEw== =P6PR -----END PGP SIGNATURE----- --=-=-=-- ------------=_1601522343-20711-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Feb 2019 18:26:57 +0000 Received: from localhost ([127.0.0.1]:55529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwA6a-0006gv-NK for submit@debbugs.gnu.org; Tue, 19 Feb 2019 13:26:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwA6Y-0006gj-O7 for submit@debbugs.gnu.org; Tue, 19 Feb 2019 13:26:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:56758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwA6Q-0002oX-LB for submit@debbugs.gnu.org; Tue, 19 Feb 2019 13:26:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwA6P-0002iN-Pt for guix-patches@gnu.org; Tue, 19 Feb 2019 13:26:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwA6O-0002ne-Me for guix-patches@gnu.org; Tue, 19 Feb 2019 13:26:45 -0500 Received: from aibo.runbox.com ([91.220.196.211]:35974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwA6N-0002jg-QD for guix-patches@gnu.org; Tue, 19 Feb 2019 13:26:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Message-Id:Content-Type:Date:Subject:To:From:MIME-Version; bh=/rbKzKm4Fg+F6fE+xvCTwkAmdIbeLqXlIIevt1OHxEU=; b=NDH1zWwwIElYsg9weYE1DZ6Dc ymd4vtwz4qEPiqV997xeHlVj16vcjIj3hryF+q1Rgr0Rvp6/5G20QS+UoS+gyuepMQhxRs84Py5Ot K5XOtMlQN02HyGrf3DpFKJJRcM5TExnFfb6fFSt9ifSL7Bx0AGzEVcjKeOUqD3aIEt/sfc9eGXhzC qXZNoqy9Mnc3l7fVmFBLOGjoxJFfurhNiTrT9xXSEaGuhMb0wwlVr5ovkDt7LB1fTgGRvBMjNnVTB HhN6mJXH9loT5k0JxgPLx9vCbA69Le8nCAKmTvX3XlQKdWeNkO3MY7TGefsvY+CgNW2cEwGOgirMu 6EiZSChnQ==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1gwA67-0004Qf-FW for guix-patches@gnu.org; Tue, 19 Feb 2019 19:26:27 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1gwA67-0001RN-Er for guix-patches@gnu.org; Tue, 19 Feb 2019 19:26:27 +0100 MIME-Version: 1.0 Received: from [Authenticated user (850733)] by runbox.com with http (RMM6); for ; Tue, 19 Feb 2019 18:26:27 GMT From: To: "guix-patches" Subject: Calibre: Add icon and desktop file to Calibre Date: Tue, 19 Feb 2019 18:26:27 +0000 (GMT) X-Mailer: RMM6 Content-Type: multipart/mixed; boundary="----------=_1550600787-3044-0" Message-Id: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.220.196.211 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This patch adds two phases to the package definition for Calibre that install an icon and install a desktop file. From 894a471083105a182d548c2b80effb0eb70c8fa6 Mon Sep 17 00:00:00 2001 From: Pkill -9 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: runbox.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pkill9[at]runbox.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (pkill9[at]runbox.com) 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=pkill9%40runbox.com; ip=209.51.188.92; r=debbugs.gnu.org] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) This is a multi-part message in MIME format... ------------=_1550600787-3044-0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable This patch adds two phases to the package definition for Calibre that insta= ll an icon and install a desktop file.= ------------=_1550600787-3044-0 Content-Type: text/x-patch; name="=?UTF-8?Q?0001-gnu-calibre-Add-icon-and-desktop-file.patch?=" Content-Disposition: attachment; filename="=?UTF-8?Q?0001-gnu-calibre-Add-icon-and-desktop-file.patch?=" Content-Transfer-Encoding: base64 Content-ID: RnJvbSA4OTRhNDcxMDgzMTA1YTE4MmQ1NDhjMmI4MGVmZmIwZWI3MGM4ZmE2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQa2lsbCAtOSA8cGtp bGw5QHJ1bmJveC5jb20+CkRhdGU6IFR1ZSwgMTkgRmViIDIwMTkgMTg6MjM6 MzcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IGNhbGlicmU6IEFkZCBp Y29uIGFuZCBkZXNrdG9wIGZpbGUuCgoqIGdudS9wYWNrYWdlcy9lYm9vay5z Y20gKGNhbGlicmUpOiBBZGQgaWNvbiBhbmQgZGVza3RvcCBmaWxlLgotLS0K IGdudS9wYWNrYWdlcy9lYm9vay5zY20gfCAyNyArKysrKysrKysrKysrKysr KysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2Vi b29rLnNjbSBiL2dudS9wYWNrYWdlcy9lYm9vay5zY20KaW5kZXggOTllNDli YzE3Li5hZTg5OWUwNGIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lYm9v ay5zY20KKysrIGIvZ251L3BhY2thZ2VzL2Vib29rLnNjbQpAQCAtMTg1LDcg KzE4NSwzMiBAQAogICAgICAgICAgICAgICAoc2V0ZW52ICJQT0RPRk9fSU5D X0RJUiIgKHN0cmluZy1hcHBlbmQgcG9kb2ZvICIvaW5jbHVkZS9wb2RvZm8i KSkKICAgICAgICAgICAgICAgKHNldGVudiAiUE9ET0ZPX0xJQl9ESVIiIChz dHJpbmctYXBwZW5kIHBvZG9mbyAiL2xpYiIpKQogICAgICAgICAgICAgICAj dCkpKQotICAgICAgICAgKGFkZC1hZnRlciAnaW5zdGFsbCAnaW5zdGFsbC1m b250LWxpYmVyYXRpb24KKyAgICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwg J2luc3RhbGwtaWNvbgorICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0 cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAgICAgKGxldCog KChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkpCisgICAgICAgICAg ICAgICAoaW5zdGFsbC1maWxlICJpbWdzcmMvY2FsaWJyZS5zdmciCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kIG91dAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi L3NoYXJlL2ljb25zL2hpY29sb3Ivc2NhbGFibGUvYXBwcyIpKSkKKyAgICAg ICAgICAgICAjdCkpCisgICAgICAgICAoYWRkLWFmdGVyICdpbnN0YWxsLWlj b24gJ2luc3RhbGwtZGVza3RvcC1maWxlCisgICAgICAgICAgIChsYW1iZGEq ICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAg ICAgICAobGV0ICgob3V0IChhc3NvYy1yZWYgb3V0cHV0cyAib3V0IikpKQor ICAgICAgICAgICAgICAgKG1rZGlyLXAgKHN0cmluZy1hcHBlbmQgb3V0ICIv c2hhcmUvYXBwbGljYXRpb25zIikpCisgICAgICAgICAgICAgICAod2l0aC1v dXRwdXQtdG8tZmlsZQorICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBw ZW5kIG91dCAiL3NoYXJlL2FwcGxpY2F0aW9ucy9jYWxpYnJlLmRlc2t0b3Ai KQorICAgICAgICAgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAg ICAgICAoZm9ybWF0ICN0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAi W0Rlc2t0b3AgRW50cnldfkAKKyAgICAgICAgICAgICAgICBOYW1lPUNhbGli cmV+QAorICAgICAgICAgICAgICAgIENvbW1lbnQ9RS1ib29rIG9yZ2FuaXNl ciBhbmQgcmVhZGVyfkAKKyAgICAgICAgICAgICAgICBFeGVjPX5hL2Jpbi9j YWxpYnJlfkAKKyAgICAgICAgICAgICAgICBUcnlFeGVjPX5AKn5hL2Jpbi9j YWxpYnJlfkAKKyAgICAgICAgICAgICAgICBJY29uPWNhbGlicmV+QAorICAg ICAgICAgICAgICAgIENhdGVnb3JpZXM9T2ZmaWNlfkAKKyAgICAgICAgICAg ICAgICBUeXBlPUFwcGxpY2F0aW9ufiUiCisgICAgICAgICAgICAgICAgICAg ICAgICAgICBvdXQpKSkKKyAgICAgICAgICAgICAgICN0KSkpCisgICAgICAg ICAoYWRkLWFmdGVyICdpbnN0YWxsLWRlc2t0b3AtZmlsZSAnaW5zdGFsbC1m b250LWxpYmVyYXRpb24KICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IGlu cHV0cyBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKICAgICAgICAgICAg ICAoZm9yLWVhY2ggKGxhbWJkYSAoZmlsZSkKICAgICAgICAgICAgICAgICAg ICAgICAgICAoaW5zdGFsbC1maWxlIGZpbGUgKHN0cmluZy1hcHBlbmQKLS0g CjIuMjAuMQoK ------------=_1550600787-3044-0-- ------------=_1601522343-20711-1--