From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 19 07:00:11 2019 Received: (at submit) by debbugs.gnu.org; 19 Feb 2019 12:00:11 +0000 Received: from localhost ([127.0.0.1]:53957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gw44H-0001JP-LP for submit@debbugs.gnu.org; Tue, 19 Feb 2019 07:00:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gw44E-0001Hb-P5 for submit@debbugs.gnu.org; Tue, 19 Feb 2019 07:00:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:41226) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gw449-00047y-Dj for submit@debbugs.gnu.org; Tue, 19 Feb 2019 07:00:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw448-0006Jf-7F for guix-patches@gnu.org; Tue, 19 Feb 2019 07:00:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw444-00044H-Fn for guix-patches@gnu.org; Tue, 19 Feb 2019 06:59:59 -0500 Received: from aibo.runbox.com ([91.220.196.211]:33444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gw440-0003um-6K for guix-patches@gnu.org; Tue, 19 Feb 2019 06:59:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Message-Id:Content-Type:Date:Subject:To:From:MIME-Version; bh=wfYy7CHvittjPJ/5O7+39lRcx16OFEoXuB/AQS8tqVM=; b=NzaPlKbRC2cBK2RecJCtMGvfM 2sXhqMPTZrjo9Bl/z8fFK72S0F8efw2DIzv0AFqoSnxhBVbENa3pWwa9yi36Aid3nFz10CZbH1FD3 PssHjxHa6pFjrXKFLserV0Eiluw9g8i8h22WIYsDDIA0KLHJwUL5sGb9S0I7v0K4ixFm2TSH+3MYE 4sDdXssHwnm+S0adHWQAt1NxMHpSPsoDKJqjMOGh2hVryDHpgYkPKP/Oj5SwVbZsBzaVhCouV3fBz r2mLm4uodf5h3HkaMlxZ3pNpQcI3NsEgVdHpelib0HyV9QnixmVIyVE0GJjhZt8R4ELLzZllxsFUR Nuy7rC/Gw==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1gw43s-0001jG-9j for guix-patches@gnu.org; Tue, 19 Feb 2019 12:59:44 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1gw43s-0007Fe-8u for guix-patches@gnu.org; Tue, 19 Feb 2019 12:59:44 +0100 MIME-Version: 1.0 Received: from [Authenticated user (850733)] by runbox.com with http (RMM6); for ; Tue, 19 Feb 2019 11:59:44 GMT From: To: "guix-patches" Subject: Add Drawpile Date: Tue, 19 Feb 2019 11:59:44 +0000 (GMT) X-Mailer: RMM6 Content-Type: multipart/mixed; boundary="----------=_1550577584-27875-0" Message-Id: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.220.196.211 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Drawpile is a collaborative drawing program - https://drawpile.net From b97d29def74a08af396b562962d558b689b3fc5e Mon Sep 17 00:00:00 2001 From: Pkill -9 Date: Tue, 19 Feb 2019 11:58:09 +0000 Subject [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: runbox.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pkill9[at]runbox.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (pkill9[at]runbox.com) 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=pkill9%40runbox.com; ip=209.51.188.92; r=debbugs.gnu.org] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) This is a multi-part message in MIME format... ------------=_1550577584-27875-0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Drawpile is a collaborative drawing program - https://drawpile.net= ------------=_1550577584-27875-0 Content-Type: text/x-patch; name="=?UTF-8?Q?0001-gnu-Add-drawpile.patch?=" Content-Disposition: attachment; filename="=?UTF-8?Q?0001-gnu-Add-drawpile.patch?=" Content-Transfer-Encoding: base64 Content-ID: <882490d6bf69758c7e9c5a1106078efc> RnJvbSBiOTdkMjlkZWY3NGEwOGFmMzk2YjU2Mjk2MmQ1NThiNjg5YjNmYzVl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQa2lsbCAtOSA8cGtp bGw5QHJ1bmJveC5jb20+CkRhdGU6IFR1ZSwgMTkgRmViIDIwMTkgMTE6NTg6 MDkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFkZCBkcmF3cGlsZS4K CiogZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbSAoZHJhd3BpbGUpOiBOZXcg dmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbSB8IDM5 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9n bnUvcGFja2FnZXMvZ3JhcGhpY3Muc2NtIGIvZ251L3BhY2thZ2VzL2dyYXBo aWNzLnNjbQppbmRleCBiZjRjYzg5YjAuLjFkNGE4NDhkNCAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbQorKysgYi9nbnUvcGFja2Fn ZXMvZ3JhcGhpY3Muc2NtCkBAIC0xMSw2ICsxMSw3IEBACiA7OzsgQ29weXJp Z2h0IMKpIDIwMTggTWF0aGlldSBPdGhhY2VoZSA8bS5vdGhhY2VoZUBnbWFp bC5jb20+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggQWxleCBLb3N0IDxhbGV6 b3N0QGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxOCBLZWkgS2Vi cmVhdSA8a2tlYnJlYXVAcG9zdGVvLm5ldD4KKzs7OyBDb3B5cmlnaHQgwqkg MjAxOSBQa2lsbCAtOSA8cGtpbGw5QHJ1bmJveC5jb20+CiA7OzsKIDs7OyBU aGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtNTEsNiAr NTIsNyBAQAogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBpbWFnZSkK ICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgaW1hZ2VtYWdpY2spCiAg ICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGplbWFsbG9jKQorICAjOnVz ZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBrZGUtZnJhbWV3b3JrcykKICAgIzp1 c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgbXVsdGlwcmVjaXNpb24pCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBkZikKICAgIzp1c2UtbW9kdWxl IChnbnUgcGFja2FnZXMgcGVybCkKQEAgLTg1NiwzICs4NTgsNDAgQEAgeW91 ciB0ZXJtaW5hbC4gIEl0IGNvbWVzIGJ1bmRsZWQgd2l0aCBwcmVkZWZpbmVk IHN0eWxlczoKIGxvb2suICBUaGUgcmVzdWx0IGNhbiBiZSB1cGxvYWRlZCBv biBhbnkgd2ViIHNlcnZlciB3aXRob3V0IGFkZGl0aW9uYWwKIHJlcXVpcmVt ZW50cy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKworKGRl ZmluZS1wdWJsaWMgZHJhd3BpbGUKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAi ZHJhd3BpbGUiKQorICAgICh2ZXJzaW9uICIyLjAuMTEiKQorICAgIChzb3Vy Y2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgdXJsLWZldGNoKQor ICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0dHBzOi8vZHJhd3BpbGUu bmV0L2ZpbGVzL3NyYy9kcmF3cGlsZS0iIHZlcnNpb24gIi50YXIuZ3oiKSkK KyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIKKyAgICAgICAgICIw aDAxOHJ4aGMwbHdwcXdtbGloYWx6NjM0bmQweGFhZms0cDJiNzgyZGpqZDg3 aXJuanBrIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGNtYWtlLWJ1aWxkLXN5 c3RlbSkKKyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgicGtnLWNvbmZp ZyIgLHBrZy1jb25maWcpCisgICAgICAgKCJxdHRvb2xzIiAscXR0b29scykp KQorICAgIChpbnB1dHMKKyAgICAgYCgoInF0YmFzZSIgLHF0YmFzZSkKKyAg ICAgICAoInF0c3ZnIiAscXRzdmcpCisgICAgICAgKCJxdG11bHRpbWVkaWEi ICxxdG11bHRpbWVkaWEpCisgICAgICAgKCJxdGNvbG9yd2lkZ2V0cyIgLHF0 Y29sb3J3aWRnZXRzKQorICAgICAgICgia2FyY2hpdmUiICxrYXJjaGl2ZSkK KyAgICAgICAoImdpZmxpYiIgLGdpZmxpYikgOyBvcHRpb25hbAorICAgICAg ICgia2Ruc3NkIiAsa2Ruc3NkKSA7IG9wdGlvbmFsCisgICAgICAgKCJtaW5p dXBucGMiICwoQCAoZ251IHBhY2thZ2VzIHVwbnApIG1pbml1cG5wYykpIDsg b3B0aW9uYWwKKyAgICAgICAoImxpYm1pY3JvaHR0cGQiICwoQCAoZ251IHBh Y2thZ2VzIGdudW5ldCkgbGlibWljcm9odHRwZCkpIDsgb3B0aW9uYWwKKyAg ICAgICAoImxpYnNvZGl1bSIgLChAIChnbnUgcGFja2FnZXMgY3J5cHRvKSBs aWJzb2RpdW0pKSkpIDsgb3B0aW9uYWwKKyAgICAoYXJndW1lbnRzCisgICAg IGAoIzpjb25maWd1cmUtZmxhZ3MgKGxpc3QgIi1EVEVTVFM9b24iICItRENN QUtFX0JVSUxEX1RZUEU9UmVsZWFzZSIgIi1EVE9PTFM9b24iCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIi1ETElC UVRDT0xPUldJREdFVFNfTElCUkFSWT0iCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFzc29jLXJlZiAlYnVpbGQt aW5wdXRzICJxdGNvbG9yd2lkZ2V0cyIpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIi9saWIvbGliUXRDb2xvcldp ZGdldHMtUXQ1Mi5zbyIpKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9k cmF3cGlsZS5uZXQiKQorICAgIChzeW5vcHNpcyAiQ29sbGFib3JhdGl2ZSBk cmF3aW5nIikKKyAgICAoZGVzY3JpcHRpb24gIkRyYXdwaWxlIGlzIGEgY29s bGFib3JhdGl2ZSBkcmF3aW5nIHByb2dyYW0gdGhhdCBhbGxvd3MKK211bHRp cGxlIHVzZXJzIHRvIHNrZXRjaCBvbiB0aGUgc2FtZSBjYW52YXMgc2ltdWx0 YW5lb3VzbHkuIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMpKSkKLS0g CjIuMjAuMQoK ------------=_1550577584-27875-0-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 20 16:47:44 2019 Received: (at 34572) by debbugs.gnu.org; 20 Feb 2019 21:47:44 +0000 Received: from localhost ([127.0.0.1]:58694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwZiP-0007ie-Em for submit@debbugs.gnu.org; Wed, 20 Feb 2019 16:47:44 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwZiM-0007iS-5y for 34572@debbugs.gnu.org; Wed, 20 Feb 2019 16:47:39 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1550696495; cv=none; d=zoho.com; s=zohoarc; b=PJq9ijfGWYtwX9VeaBAsuAWmTEfE8+cxDz7fu8hROLD0LcQfVJtqr8GCGYBEwbjJ4q8lgOqaPKbEF5FkXmwySg0UuwGdbzlJE1HLPcVqVMTkxM1ZPrx8PyxHzb3zbbPe6afjRzcUF+uuLM9C/6DgPCBJmSbMWRuQ0cWFq7Hggj4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1550696495; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=P9M2OlkkhbfE+fEbwtGne/WMd0I5rr1ImdSoFUU/3iw=; b=gGl0rAGGFXq3ujhBB8ZzOLYCZB6uOdjyNkOet6jX8B8Ohny/7hqpsPEAREA/pNw7VlC7L0kl9fZl1/n3VhQSK4a61S/mFZhMnlOpNbuCX0Tu/7Ry06WKvZkzonIQ0VrUJqSveBh2FEp5c80DudR+Uwp5URjR+OE7wW5juUwcFVI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1550696495; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; l=2079; bh=P9M2OlkkhbfE+fEbwtGne/WMd0I5rr1ImdSoFUU/3iw=; b=BNVF9a3fnT+tG1SfWyUOLofGrEAu0aPm+xJBfWGtp6bPokzCQA6kYVHJHb0POkNg d5YKTl1jIn8GUeIqn/xCTgYryCPUN3tzK4JKuZeyr/tfU9tmry2NqNhxtqmoXfoyWn4 JO75oGXhcY8pVXXgOtD68a5vEvgwL5ya65i+cylI= Received: from localhost (p54AD468B.dip0.t-ipconnect.de [84.173.70.139]) by mx.zohomail.com with SMTPS id 1550696494348752.5265064143383; Wed, 20 Feb 2019 13:01:34 -0800 (PST) References: User-agent: mu4e 1.0; emacs 26.1 From: Ricardo Wurmus To: pkill9@runbox.com Subject: Re: [bug#34572] Add Drawpile In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 20 Feb 2019 22:01:30 +0100 Message-ID: <878sya5g45.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34572 Cc: 34572@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi pkill9, > * gnu/packages/graphics.scm (drawpile): New variable. Thank you for your patch. [=E2=80=A6] > +(define-public drawpile > + (package > + (name "drawpile") > + (version "2.0.11") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://drawpile.net/files/src/drawpile-" ve= rsion ".tar.gz")) Please break this line. > + (sha256 > + (base32 > + "0h018rxhc0lwpqwmlihalz634nd0xaafk4p2b782djjd87irnjpk")))) > + (build-system cmake-build-system) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("qttools" ,qttools))) > + (inputs > + `(("qtbase" ,qtbase) > + ("qtsvg" ,qtsvg) > + ("qtmultimedia" ,qtmultimedia) > + ("qtcolorwidgets" ,qtcolorwidgets) > + ("karchive" ,karchive) > + ("giflib" ,giflib) ; optional > + ("kdnssd" ,kdnssd) ; optional > + ("miniupnpc" ,(@ (gnu packages upnp) miniupnpc)) ; optional > + ("libmicrohttpd" ,(@ (gnu packages gnunet) libmicrohttpd)) ; opti= onal > + ("libsodium" ,(@ (gnu packages crypto) libsodium)))) ; optional Please don=E2=80=99t use these inline module references. > + (arguments > + `(#:configure-flags (list "-DTESTS=3Don" "-DCMAKE_BUILD_TYPE=3DRele= ase" "-DTOOLS=3Don" > + (string-append "-DLIBQTCOLORWIDGETS_LIBRA= RY=3D" > + (assoc-ref %build-inputs "= qtcolorwidgets") > + "/lib/libQtColorWidgets-Qt= 52.so")))) Please put =E2=80=9C(list=E2=80=9D on a new line and then break after every= item, so that you can add comments as to why these flags are required. I don=E2=80=99t think you need "-DCMAKE_BUILD_TYPE=3DRelease" as we=E2=80= =99re building with =E2=80=9CRelWithDebInfo=E2=80=9D by default. > + (home-page "https://drawpile.net") > + (synopsis "Collaborative drawing") =E2=80=9CCollaborative drawing program=E2=80=9D would be better. > + (license license:gpl3))) This looks like gpl3+. See for example: https://github.com/drawpile/Drawpile/blob/master/src/server/initsys_sys= temd.cpp#L9 Please check the licenses more carefully. Could you please send an updated patch? --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 21 07:51:43 2019 Received: (at 34572) by debbugs.gnu.org; 21 Feb 2019 12:51:44 +0000 Received: from localhost ([127.0.0.1]:59011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwnpH-0008UY-Dg for submit@debbugs.gnu.org; Thu, 21 Feb 2019 07:51:43 -0500 Received: from aibo.runbox.com ([91.220.196.211]:39620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwnpD-0008UM-Hy for 34572@debbugs.gnu.org; Thu, 21 Feb 2019 07:51:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Message-Id:Content-Type:In-Reply-To:Date:Subject:CC:To:From :MIME-Version; bh=ZB/jPU5bKfhR+I0eksrV40WG1EvSS3XDsz2n3H1MMgM=; b=KAbRcjdg0d7 +m8EpNek/Rf9qIX4lOcdNXunB0nnNMH79UiuqUbHFoeY7CdNj4BriYe7avlM9QctzU1ogA9ak2cW0 R35a5qUsj6y9vi9kiXVgcdEOYCQxuTz/WGx5gTh1ImwlLAACeoo4I0HM251nTltKeq+/jFxcZ5MPZ UHRZ71TW+MpA27uADsYdZSEIlEQIP3qs/88A9+mSgeG/0Y7KwP5fGfGlPerbexer0ZVr25CJ2OTwY Cq3gGBEWYAWw9ZLS+0WEgz0usa6Fw6QrQSqzGJlKOnrwOwJJ4iU5QD3amxOYqRsYniopk9qQJAfWQ lBf/7Glnz8+SnV73FHGtfVw==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1gwnpA-0006lf-Ny; Thu, 21 Feb 2019 13:51:36 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1gwnpA-0005aL-Mm; Thu, 21 Feb 2019 13:51:36 +0100 MIME-Version: 1.0 Received: from [Authenticated user (850733)] by runbox.com with http (RMM6); Thu, 21 Feb 2019 12:51:36 GMT From: To: "Ricardo Wurmus" Subject: Re: [bug#34572] Add Drawpile Date: Thu, 21 Feb 2019 12:51:36 +0000 (GMT) X-Mailer: RMM6 In-Reply-To: <878sya5g45.fsf@elephly.net> Content-Type: multipart/mixed; boundary="----------=_1550753496-21275-0" Message-Id: X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 34572 Cc: 34572 <34572@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) This is a multi-part message in MIME format... ------------=_1550753496-21275-0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rekado, thanks for looking at this patch. I've updated it. > Please don=E2=80=99t use these inline module references. Sorry, I forgot to remove them (I'm moving my package definitions to Guix u= pstream which have the modules inline). > Please check the licenses more carefully. Will do. On Wed, 20 Feb 2019 22:01:30 +0100, Ricardo Wurmus wro= te: >=20 > Hi pkill9, >=20 > > * gnu/packages/graphics.scm (drawpile): New variable. >=20 > Thank you for your patch. >=20 > [=E2=80=A6] > > +(define-public drawpile > > + (package > > + (name "drawpile") > > + (version "2.0.11") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "https://drawpile.net/files/src/drawpile-" = version ".tar.gz")) >=20 > Please break this line. >=20 > > + (sha256 > > + (base32 > > + "0h018rxhc0lwpqwmlihalz634nd0xaafk4p2b782djjd87irnjpk")))) > > + (build-system cmake-build-system) > > + (native-inputs > > + `(("pkg-config" ,pkg-config) > > + ("qttools" ,qttools))) > > + (inputs > > + `(("qtbase" ,qtbase) > > + ("qtsvg" ,qtsvg) > > + ("qtmultimedia" ,qtmultimedia) > > + ("qtcolorwidgets" ,qtcolorwidgets) > > + ("karchive" ,karchive) > > + ("giflib" ,giflib) ; optional > > + ("kdnssd" ,kdnssd) ; optional > > + ("miniupnpc" ,(@ (gnu packages upnp) miniupnpc)) ; optional > > + ("libmicrohttpd" ,(@ (gnu packages gnunet) libmicrohttpd)) ; op= tional > > + ("libsodium" ,(@ (gnu packages crypto) libsodium)))) ; optional >=20 > Please don=E2=80=99t use these inline module references. >=20 > > + (arguments > > + `(#:configure-flags (list "-DTESTS=3Don" "-DCMAKE_BUILD_TYPE=3DRe= lease" "-DTOOLS=3Don" > > + (string-append "-DLIBQTCOLORWIDGETS_LIB= RARY=3D" > > + (assoc-ref %build-inputs= "qtcolorwidgets") > > + "/lib/libQtColorWidgets-= Qt52.so")))) >=20 > Please put =E2=80=9C(list=E2=80=9D on a new line and then break after eve= ry item, so > that you can add comments as to why these flags are required. >=20 > I don=E2=80=99t think you need "-DCMAKE_BUILD_TYPE=3DRelease" as we=E2=80= =99re building > with =E2=80=9CRelWithDebInfo=E2=80=9D by default. >=20 > > + (home-page "https://drawpile.net") > > + (synopsis "Collaborative drawing") >=20 > =E2=80=9CCollaborative drawing program=E2=80=9D would be better. >=20 > > + (license license:gpl3))) >=20 > This looks like gpl3+. See for example: >=20 > https://github.com/drawpile/Drawpile/blob/master/src/server/initsys_s= ystemd.cpp#L9 >=20 > Please check the licenses more carefully. >=20 > Could you please send an updated patch? >=20 > --=20 > Ricardo ------------=_1550753496-21275-0 Content-Type: text/x-patch; name="=?UTF-8?Q?0001-gnu-Add-drawpile.patch?=" Content-Disposition: attachment; filename="=?UTF-8?Q?0001-gnu-Add-drawpile.patch?=" Content-Transfer-Encoding: base64 Content-ID: <02976c8a8ea60edb480a7784e29d4105> RnJvbSAzMDAzYzgyY2Y5N2UxMjllMTc3MDExZTM0YjVhMjA4Y2Y2YmJmMTg4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQa2lsbCAtOSA8cGtp bGw5QHJ1bmJveC5jb20+CkRhdGU6IFRodSwgMjEgRmViIDIwMTkgMTI6NDc6 MzcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFkZCBkcmF3cGlsZS4K CiogZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbSAoZHJhd3BpbGUpOiBOZXcg dmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbSB8IDQ1 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9n bnUvcGFja2FnZXMvZ3JhcGhpY3Muc2NtIGIvZ251L3BhY2thZ2VzL2dyYXBo aWNzLnNjbQppbmRleCBiZjRjYzg5YjAuLjA3ZjgwMWVmMCAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbQorKysgYi9nbnUvcGFja2Fn ZXMvZ3JhcGhpY3Muc2NtCkBAIC0xMSw2ICsxMSw3IEBACiA7OzsgQ29weXJp Z2h0IMKpIDIwMTggTWF0aGlldSBPdGhhY2VoZSA8bS5vdGhhY2VoZUBnbWFp bC5jb20+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggQWxleCBLb3N0IDxhbGV6 b3N0QGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxOCBLZWkgS2Vi cmVhdSA8a2tlYnJlYXVAcG9zdGVvLm5ldD4KKzs7OyBDb3B5cmlnaHQgwqkg MjAxOSBQa2lsbCAtOSA8cGtpbGw5QHJ1bmJveC5jb20+CiA7OzsKIDs7OyBU aGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtMzcsNiAr MzgsNyBAQAogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBib29zdCkK ICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgY2hlY2spCiAgICM6dXNl LW1vZHVsZSAoZ251IHBhY2thZ2VzIGNvbXByZXNzaW9uKQorICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBjcnlwdG8pIDsgbGlic29kaXVtCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGRvY3VtZW50YXRpb24pCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGZsZXgpCiAgICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIGZvbnRzKQpAQCAtNDUsMTIgKzQ3LDE0IEBACiAg ICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsKQogICAjOnVzZS1tb2R1 bGUgKGdudSBwYWNrYWdlcyBnbGliKQogICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBnbm9tZSkKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMg Z251bmV0KSA7IGxpYm1pY3JvaHR0cGQKICAgIzp1c2UtbW9kdWxlIChnbnUg cGFja2FnZXMgZ3JhcGh2aXopCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIGd0aykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgaGFza2Vs bCkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgaW1hZ2UpCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGltYWdlbWFnaWNrKQogICAjOnVz ZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBqZW1hbGxvYykKKyAgIzp1c2UtbW9k dWxlIChnbnUgcGFja2FnZXMga2RlLWZyYW1ld29ya3MpCiAgICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIG11bHRpcHJlY2lzaW9uKQogICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBwZGYpCiAgICM6dXNlLW1vZHVsZSAoZ251 IHBhY2thZ2VzIHBlcmwpCkBAIC02NCw2ICs2OCw3IEBACiAgICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIHJlYWRsaW5lKQogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyBzZGwpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHN3aWcpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHVwbnAp CiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHZpZGVvKQogICAjOnVz ZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB4bWwpCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIHhvcmcpCkBAIC04NTYsMyArODYxLDQzIEBAIHlvdXIg dGVybWluYWwuICBJdCBjb21lcyBidW5kbGVkIHdpdGggcHJlZGVmaW5lZCBz dHlsZXM6CiBsb29rLiAgVGhlIHJlc3VsdCBjYW4gYmUgdXBsb2FkZWQgb24g YW55IHdlYiBzZXJ2ZXIgd2l0aG91dCBhZGRpdGlvbmFsCiByZXF1aXJlbWVu dHMuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmdwbDIrKSkpCisKKyhkZWZp bmUtcHVibGljIGRyYXdwaWxlCisgIChwYWNrYWdlCisgICAgKG5hbWUgImRy YXdwaWxlIikKKyAgICAodmVyc2lvbiAiMi4wLjExIikKKyAgICAoc291cmNl CisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAg ICAgICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2RyYXdwaWxlLm5l dC9maWxlcy9zcmMvIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgImRy YXdwaWxlLSIgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAgIChzaGEyNTYK KyAgICAgICAgKGJhc2UzMgorICAgICAgICAgIjBoMDE4cnhoYzBsd3Bxd21s aWhhbHo2MzRuZDB4YWFmazRwMmI3ODJkampkODdpcm5qcGsiKSkpKQorICAg IChidWlsZC1zeXN0ZW0gY21ha2UtYnVpbGQtc3lzdGVtKQorICAgIChuYXRp dmUtaW5wdXRzCisgICAgIGAoKCJwa2ctY29uZmlnIiAscGtnLWNvbmZpZykK KyAgICAgICAoInF0dG9vbHMiICxxdHRvb2xzKSkpCisgICAgKGlucHV0cwor ICAgICBgKCgicXRiYXNlIiAscXRiYXNlKQorICAgICAgICgicXRzdmciICxx dHN2ZykKKyAgICAgICAoInF0bXVsdGltZWRpYSIgLHF0bXVsdGltZWRpYSkK KyAgICAgICAoInF0Y29sb3J3aWRnZXRzIiAscXRjb2xvcndpZGdldHMpCisg ICAgICAgKCJrYXJjaGl2ZSIgLGthcmNoaXZlKQorICAgICAgICgiZ2lmbGli IiAsZ2lmbGliKSA7IG9wdGlvbmFsCisgICAgICAgKCJrZG5zc2QiICxrZG5z c2QpIDsgb3B0aW9uYWwKKyAgICAgICAoIm1pbml1cG5wYyIgLG1pbml1cG5w YykgOyBvcHRpb25hbAorICAgICAgICgibGlibWljcm9odHRwZCIgLGxpYm1p Y3JvaHR0cGQpIDsgb3B0aW9uYWwKKyAgICAgICAoImxpYnNvZGl1bSIgLGxp YnNvZGl1bSkpKSA7IG9wdGlvbmFsCisgICAgKGFyZ3VtZW50cworICAgICBg KCM6Y29uZmlndXJlLWZsYWdzCisgICAgICAgKGxpc3QgIi1EVEVTVFM9b24i IDsgYnVpbGQgdW5pdCB0ZXN0cy4KKyAgICAgICAgICAgICAiLURUT09MUz1v biIgOyBidWlsZCBkcHJlYzJ0eHQgY29tbWFuZCBsaW5lIHRvb2wuCisgICAg ICAgICAgICAgKHN0cmluZy1hcHBlbmQgIi1ETElCUVRDT0xPUldJREdFVFNf TElCUkFSWT0iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFzc29j LXJlZiAlYnVpbGQtaW5wdXRzICJxdGNvbG9yd2lkZ2V0cyIpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIi9saWIvbGliUXRDb2xvcldpZGdldHMt UXQ1Mi5zbyIpKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9kcmF3cGls ZS5uZXQiKQorICAgIChzeW5vcHNpcyAiQ29sbGFib3JhdGl2ZSBkcmF3aW5n IHByb2dyYW0iKQorICAgIChkZXNjcmlwdGlvbiAiRHJhd3BpbGUgaXMgYSBj b2xsYWJvcmF0aXZlIGRyYXdpbmcgcHJvZ3JhbSB0aGF0IGFsbG93cworbXVs dGlwbGUgdXNlcnMgdG8gc2tldGNoIG9uIHRoZSBzYW1lIGNhbnZhcyBzaW11 bHRhbmVvdXNseS4iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMyspKSkK LS0gCjIuMjAuMQoK ------------=_1550753496-21275-0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 21 08:58:55 2019 Received: (at 34572) by debbugs.gnu.org; 21 Feb 2019 13:58:55 +0000 Received: from localhost ([127.0.0.1]:59035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwosJ-0001Zg-8z for submit@debbugs.gnu.org; Thu, 21 Feb 2019 08:58:55 -0500 Received: from tobias.gr ([80.241.217.52]:33362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwosE-0001ZR-Td for 34572@debbugs.gnu.org; Thu, 21 Feb 2019 08:58:54 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id b1a89667; Thu, 21 Feb 2019 13:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=yyMSpx9ofcmqdXWN6I4WGz DiKwvlib+T0cl0VvnXwus=; b=eLx91Om/Dagh3RQxebR0BEGe2Q7dPDjnflGWGz ZttYv9FjAasjAYA4fDpPh1bawM8XQLryJOsgVKKE1b3Uy/mki2Vrs4R+W4SPKYo/ eZbpsx4JpMZxtx7nOsqjcYfVbqyI9U8KpMhUvbXncNxZV3FbAtx6ISEbCG+uF3xs HnTB2St5LPoMVXpfUriO0PpJDwsWl6pWqNLQDHOZTchLQIRpDXXptlturuDNYQsy 8gD2e3R1xD93ze2qV6hkOIvXuEDTK0tpjoTb7dfeY71S1CQ81EwAWI403ytIlfme S0pOnzZoM4KZeRzNqmnu8Rz5vAj1C5U2611zfNNF1O64CymQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 162c3bee (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 21 Feb 2019 13:58:39 +0000 (UTC) From: Tobias Geerinckx-Rice To: pkill9@runbox.com Subject: Re: [bug#34572] Add Drawpile References: <878sya5g45.fsf@elephly.net> In-reply-to: Date: Thu, 21 Feb 2019 14:58:33 +0100 Message-ID: <87va1dutti.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34572 Cc: 34572 <34572@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pkill -9, Thanks for this patch, and your many others. pkill9 wrote: > + #:use-module (gnu packages crypto) ; libsodium > + #:use-module (gnu packages gnunet) ; libmicrohttpd In my experience, what little value such comments add is quickly lost. Anyone adding new inputs will not update (or even notice) them. > + ("giflib" ,giflib) ; optional > + ("kdnssd" ,kdnssd) ; optional > + ("miniupnpc" ,miniupnpc) ; optional > + ("libmicrohttpd" ,libmicrohttpd) ; optional > + ("libsodium" ,libsodium))) ; optional Same here: nothing wrong with these, I guess, but *many* package dependencies are optionally detected at build time and this isn't usually pointed out unless there's something more interesting going on. > + (arguments > + `(#:configure-flags > + (list "-DTESTS=on" ; build unit tests. General remark: no full stop after inline comments. ;; Foo bar. (foo bar) ; foo bar > + "-DTOOLS=on" ; build dprec2txt command line tool. > + (string-append "-DLIBQTCOLORWIDGETS_LIBRARY=" > + (assoc-ref %build-inputs > "qtcolorwidgets") > + > "/lib/libQtColorWidgets-Qt52.so")))) What about using FIND-FILES "\*.so$" here instead of hard-coding "52"? Overkill? Kind regards, T G-R From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 22 02:28:31 2019 Received: (at 34572) by debbugs.gnu.org; 22 Feb 2019 07:28:31 +0000 Received: from localhost ([127.0.0.1]:47545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gx5G2-0001pE-4V for submit@debbugs.gnu.org; Fri, 22 Feb 2019 02:28:31 -0500 Received: from aibo.runbox.com ([91.220.196.211]:57786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gx5Fz-0001p3-Kr for 34572@debbugs.gnu.org; Fri, 22 Feb 2019 02:28:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Message-Id:Content-Type:In-Reply-To:Date:Subject:CC:To:From :MIME-Version; bh=w20j+ysvJK7E/FN7qPq5zqroBA8z1QNdJB84yM1U0N0=; b=X6HphUZoGcq TUTEnBQ7YhcMZ2S49cNXr69ebtgWYEtxmhVcZX4ULgo4ORXM5aUAyhBqg6ybTH66f0f+o+nrxY3eU pZjwIEzB+I68hEYmpITaFy8L5x2XNIxi36Su07BzdlmYDeVEdMdrCucCVakMXKwsMh18w6X4m2XAs oRy83VASx80f8Ij5O6+g+n0xN8eRwa2CMAc1em8gkeCfICiiGkIj4mOJdqyDCseQdIFxXoVIulk8z MHTM/YG2a4j4d2WLllDIrcRVnak/62LIzFY3Aoa1q5DZ1xZEDS7RFRKbB+54rGiLT+TvPiHP3CxwI J2L0JV3Pj8dYmVm6Yabby5A==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1gx5Fw-00060W-Nk; Fri, 22 Feb 2019 08:28:24 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1gx5Fw-0005PI-Mt; Fri, 22 Feb 2019 08:28:24 +0100 MIME-Version: 1.0 Received: from [Authenticated user (850733)] by runbox.com with http (RMM6); Fri, 22 Feb 2019 07:28:24 GMT From: To: "Tobias Geerinckx-Rice" Subject: Re: [bug#34572] Add Drawpile Date: Fri, 22 Feb 2019 07:28:24 +0000 (GMT) X-Mailer: RMM6 In-Reply-To: <87va1dutti.fsf@nckx> Content-Type: multipart/mixed; boundary="----------=_1550820504-23349-25" Message-Id: X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 34572 Cc: 34572 <34572@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) This is a multi-part message in MIME format... ------------=_1550820504-23349-25 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks Tobias, I removed those inline comments and removed the full stops a= fter the other inline comments. Haven't changed the qtcolorwidgets library config flag for now, I think dra= wpile upstream needs to improve the code that looks for qtcolorwidgets (htt= ps://github.com/drawpile/Drawpile/blob/master/config/FindQtColorWidgets.cma= ke) but I don't know how. Hardcoding the path isn't ideal but I'll leave it= for now. On Thu, 21 Feb 2019 14:58:33 +0100, Tobias Geerinckx-Rice wr= ote: > Pkill -9, >=20 > Thanks for this patch, and your many others. >=20 > pkill9 wrote: > > + #:use-module (gnu packages crypto) ; libsodium > > + #:use-module (gnu packages gnunet) ; libmicrohttpd >=20 > In my experience, what little value such comments add is quickly=20 > lost. Anyone adding new inputs will not update (or even notice)=20 > them. >=20 > > + ("giflib" ,giflib) ; optional > > + ("kdnssd" ,kdnssd) ; optional > > + ("miniupnpc" ,miniupnpc) ; optional > > + ("libmicrohttpd" ,libmicrohttpd) ; optional > > + ("libsodium" ,libsodium))) ; optional >=20 > Same here: nothing wrong with these, I guess, but *many* package=20 > dependencies are optionally detected at build time and this isn't=20 > usually pointed out unless there's something more interesting=20 > going on. >=20 > > + (arguments > > + `(#:configure-flags > > + (list "-DTESTS=3Don" ; build unit tests. >=20 > General remark: no full stop after inline comments. >=20 > ;; Foo bar. > (foo bar) ; foo bar >=20 > > + "-DTOOLS=3Don" ; build dprec2txt command line tool. > > + (string-append "-DLIBQTCOLORWIDGETS_LIBRARY=3D" > > + (assoc-ref %build-inputs=20 > > "qtcolorwidgets") > > +=20 > > "/lib/libQtColorWidgets-Qt52.so")))) >=20 > What about using FIND-FILES "\*.so$" here instead of hard-coding=20 > "52"? Overkill? >=20 > Kind regards, >=20 > T G-R ------------=_1550820504-23349-25 Content-Type: text/x-patch; name="=?UTF-8?Q?0001-gnu-Add-drawpile.patch?=" Content-Disposition: attachment; filename="=?UTF-8?Q?0001-gnu-Add-drawpile.patch?=" Content-Transfer-Encoding: base64 Content-ID: <128d120f5c5027eeda250744bc1d6279> RnJvbSA5MTY5NjhlNWY0MTllMzM5YWFjZDNiOTFkOWUxNWEzOWFlODdmOWRi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQa2lsbCAtOSA8cGtp bGw5QHJ1bmJveC5jb20+CkRhdGU6IEZyaSwgMjIgRmViIDIwMTkgMDc6MjM6 MzkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFkZCBkcmF3cGlsZS4K CiogZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbSAoZHJhd3BpbGUpOiBOZXcg dmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbSB8IDQ1 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9n bnUvcGFja2FnZXMvZ3JhcGhpY3Muc2NtIGIvZ251L3BhY2thZ2VzL2dyYXBo aWNzLnNjbQppbmRleCBiZjRjYzg5YjAuLmFlMzA2MDdjYiAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL2dyYXBoaWNzLnNjbQorKysgYi9nbnUvcGFja2Fn ZXMvZ3JhcGhpY3Muc2NtCkBAIC0xMSw2ICsxMSw3IEBACiA7OzsgQ29weXJp Z2h0IMKpIDIwMTggTWF0aGlldSBPdGhhY2VoZSA8bS5vdGhhY2VoZUBnbWFp bC5jb20+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggQWxleCBLb3N0IDxhbGV6 b3N0QGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxOCBLZWkgS2Vi cmVhdSA8a2tlYnJlYXVAcG9zdGVvLm5ldD4KKzs7OyBDb3B5cmlnaHQgwqkg MjAxOSBQa2lsbCAtOSA8cGtpbGw5QHJ1bmJveC5jb20+CiA7OzsKIDs7OyBU aGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtMzcsNiAr MzgsNyBAQAogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBib29zdCkK ICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgY2hlY2spCiAgICM6dXNl LW1vZHVsZSAoZ251IHBhY2thZ2VzIGNvbXByZXNzaW9uKQorICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBjcnlwdG8pCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIGRvY3VtZW50YXRpb24pCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIGZsZXgpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIGZvbnRzKQpAQCAtNDUsMTIgKzQ3LDE0IEBACiAgICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIGdsKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBnbGliKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnbm9t ZSkKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ251bmV0KQogICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBncmFwaHZpeikKICAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMgZ3RrKQogICAjOnVzZS1tb2R1bGUgKGdu dSBwYWNrYWdlcyBoYXNrZWxsKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBpbWFnZSkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgaW1h Z2VtYWdpY2spCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGplbWFs bG9jKQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBrZGUtZnJhbWV3 b3JrcykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgbXVsdGlwcmVj aXNpb24pCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBkZikKICAg Izp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcGVybCkKQEAgLTY0LDYgKzY4 LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcmVhZGxpbmUp CiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHNkbCkKICAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMgc3dpZykKKyAgIzp1c2UtbW9kdWxlIChn bnUgcGFja2FnZXMgdXBucCkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgdmlkZW8pCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHhtbCkK ICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgeG9yZykKQEAgLTg1Niwz ICs4NjEsNDMgQEAgeW91ciB0ZXJtaW5hbC4gIEl0IGNvbWVzIGJ1bmRsZWQg d2l0aCBwcmVkZWZpbmVkIHN0eWxlczoKIGxvb2suICBUaGUgcmVzdWx0IGNh biBiZSB1cGxvYWRlZCBvbiBhbnkgd2ViIHNlcnZlciB3aXRob3V0IGFkZGl0 aW9uYWwKIHJlcXVpcmVtZW50cy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6 Z3BsMispKSkKKworKGRlZmluZS1wdWJsaWMgZHJhd3BpbGUKKyAgKHBhY2th Z2UKKyAgICAobmFtZSAiZHJhd3BpbGUiKQorICAgICh2ZXJzaW9uICIyLjAu MTEiKQorICAgIChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRo b2QgdXJsLWZldGNoKQorICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0 dHBzOi8vZHJhd3BpbGUubmV0L2ZpbGVzL3NyYy8iCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAiZHJhd3BpbGUtIiB2ZXJzaW9uICIudGFyLmd6Iikp CisgICAgICAgKHNoYTI1NgorICAgICAgICAoYmFzZTMyCisgICAgICAgICAi MGgwMThyeGhjMGx3cHF3bWxpaGFsejYzNG5kMHhhYWZrNHAyYjc4MmRqamQ4 N2lybmpwayIpKSkpCisgICAgKGJ1aWxkLXN5c3RlbSBjbWFrZS1idWlsZC1z eXN0ZW0pCisgICAgKG5hdGl2ZS1pbnB1dHMKKyAgICAgYCgoInBrZy1jb25m aWciICxwa2ctY29uZmlnKQorICAgICAgICgicXR0b29scyIgLHF0dG9vbHMp KSkKKyAgICAoaW5wdXRzCisgICAgIGAoKCJxdGJhc2UiICxxdGJhc2UpCisg ICAgICAgKCJxdHN2ZyIgLHF0c3ZnKQorICAgICAgICgicXRtdWx0aW1lZGlh IiAscXRtdWx0aW1lZGlhKQorICAgICAgICgicXRjb2xvcndpZGdldHMiICxx dGNvbG9yd2lkZ2V0cykKKyAgICAgICAoImthcmNoaXZlIiAsa2FyY2hpdmUp CisgICAgICAgKCJnaWZsaWIiICxnaWZsaWIpCisgICAgICAgKCJrZG5zc2Qi ICxrZG5zc2QpCisgICAgICAgKCJtaW5pdXBucGMiICxtaW5pdXBucGMpCisg ICAgICAgKCJsaWJtaWNyb2h0dHBkIiAsbGlibWljcm9odHRwZCkKKyAgICAg ICAoImxpYnNvZGl1bSIgLGxpYnNvZGl1bSkpKQorICAgIChhcmd1bWVudHMK KyAgICAgYCgjOmNvbmZpZ3VyZS1mbGFncworICAgICAgIChsaXN0ICItRFRF U1RTPW9uIiA7IGJ1aWxkIHVuaXQgdGVzdHMKKyAgICAgICAgICAgICAiLURU T09MUz1vbiIgOyBidWlsZCBkcHJlYzJ0eHQgY29tbWFuZCBsaW5lIHRvb2wK KyAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiLURMSUJRVENPTE9SV0lE R0VUU19MSUJSQVJZPSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAo YXNzb2MtcmVmICVidWlsZC1pbnB1dHMgInF0Y29sb3J3aWRnZXRzIikKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiL2xpYi9saWJRdENvbG9yV2lk Z2V0cy1RdDUyLnNvIikpKSkKKyAgICAoaG9tZS1wYWdlICJodHRwczovL2Ry YXdwaWxlLm5ldCIpCisgICAgKHN5bm9wc2lzICJDb2xsYWJvcmF0aXZlIGRy YXdpbmcgcHJvZ3JhbSIpCisgICAgKGRlc2NyaXB0aW9uICJEcmF3cGlsZSBp cyBhIGNvbGxhYm9yYXRpdmUgZHJhd2luZyBwcm9ncmFtIHRoYXQgYWxsb3dz CittdWx0aXBsZSB1c2VycyB0byBza2V0Y2ggb24gdGhlIHNhbWUgY2FudmFz IHNpbXVsdGFuZW91c2x5LiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwz KykpKQotLSAKMi4yMC4xCgo= ------------=_1550820504-23349-25-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 06 00:20:17 2021 Received: (at 34572-done) by debbugs.gnu.org; 6 Aug 2021 04:20:17 +0000 Received: from localhost ([127.0.0.1]:48839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBrLF-0001KD-7i for submit@debbugs.gnu.org; Fri, 06 Aug 2021 00:20:17 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:41475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBrLD-0001Jw-O3 for 34572-done@debbugs.gnu.org; Fri, 06 Aug 2021 00:20:15 -0400 Received: by mail-qt1-f175.google.com with SMTP id z24so5583773qtn.8 for <34572-done@debbugs.gnu.org>; Thu, 05 Aug 2021 21:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VzfQZIJVIbI4o7nZ7QyJ1iU5FGdcvuPQhlRyfPzteMo=; b=XwmztM3sWsBHL+4QVqC5m4dfgHRbxIqnHmIU8v7WKkAR2cQq6r4Hn2082mqGuSl0fY nPgqeewnAmT8L3Z/cHzNgBwQH4cVPpN1XeoPyCRrv16dRjDlEJLE+fa1PuFTm2My83sf N40Zn/IOqbcFdNHrAyrNFRf/52xnbp733aZBdRgx1IFYgsJO8YawBQLdRFlm7yDZAhua spW8KXaJee3uiy99HUUezFtU/hup+327ECCaEO4Gl+ip5OXpBnok45hUmQqq0iNvB8p9 bmHr+5SmixPjY4ub+CJWMI/KTF7RdCCAikHbRhpfMebnViPntCXMH4sNRKjVgqd4PmlV rlpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VzfQZIJVIbI4o7nZ7QyJ1iU5FGdcvuPQhlRyfPzteMo=; b=TdjH3h4/ZAFfGh8w0q0HF7QMqgjNrz1tJv8B7WQHCzC1FLt038o/sbz1TtLeviCi0o q5olODAvqRom7W4qjUB+F3g0e0RyttgjUlT6CzZYHgUaoxIwCQAq6SWMciCSlg4rObzY amhRoAx3OQoy+nvg/VegmNOXthDmLIqGu9jEhnUPoaEj5ObpDv0LDMQWvEAusiuQumIf HTaZoH7jwLsmg+abgW2n9Z4+XHb0yj9/zF3+r0gGiSZG+qwXmjcZ+IbvFYMaiDM9hehk nZ9hRJhYETmw0C0kJWv0/dUvGhwmpzDLTNz1bSXW7pNFahaPvwk8jljzGSBQ4Zoyz7fw mf9g== X-Gm-Message-State: AOAM533srqbK/QkEYlMclXYJGoUBuhPgtiOCMBgwIidKzGkttEPWFGA4 a0cqWo1OqrfZA3WVDkBP9X1HeLlKY5ychbbX X-Google-Smtp-Source: ABdhPJzQrBALcI4kYajrcCSqkIUGnezXjFS1g9kuBElafWwwIYFSJgKbB42m5Y2HuxcE+4LdpHAIPw== X-Received: by 2002:ac8:6bc8:: with SMTP id b8mr7473794qtt.129.1628223610220; Thu, 05 Aug 2021 21:20:10 -0700 (PDT) Received: from hurd (dsl-151-109.b2b2c.ca. [66.158.151.109]) by smtp.gmail.com with ESMTPSA id e10sm4022355qkg.18.2021.08.05.21.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 21:20:09 -0700 (PDT) From: Maxim Cournoyer To: Subject: Re: bug#34572: Add Drawpile References: Date: Fri, 06 Aug 2021 00:20:03 -0400 In-Reply-To: (pkill9@runbox.com's message of "Fri, 22 Feb 2019 07:28:24 +0000 (GMT)") Message-ID: <87zgtvjjbg.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34572-done Cc: Tobias Geerinckx-Rice , 34572 <34572-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, We now have drawpile 2.1.17 in Guix. It seems this patch failed between the cracks. Sorry! Closing. Maxim From unknown Mon Aug 18 02:37:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Sep 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator