GNU bug report logs - #34571
[PATCH] Add micropython

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34571 in the body.
You can then email your comments to 34571 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add micropython
Date: Tue, 19 Feb 2019 11:22:16 +0200

[Message part 1 (text/plain, inline)]

I was looking around to see if there was an alternate perl
implementation and I ended up packaging micropython. I have no
preference between it being in python.scm or embedded.scm

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[0001-gnu-Add-micropython.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 34571 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 34571 <at> debbugs.gnu.org
Subject: Re: [bug#34571] [PATCH] Add micropython
Date: Tue, 19 Feb 2019 10:46:40 +0100

[Message part 1 (text/plain, inline)]

Hi Erfraim,

On Tue, 19 Feb 2019 11:22:16 +0200
Efraim Flashner <efraim <at> flashner.co.il> wrote:

> I was looking around to see if there was an alternate perl
> implementation and I ended up packaging micropython. I have no
> preference between it being in python.scm or embedded.scm

Heh :)

There's a bundled version of FreeRTOS in ./ports/cc3200 which is GPLv2
with a modification.

In this case, I suggest to delete FreeRTOS since we don't use it
anyway--and if we ever wanted to, we'd not use the bundled version.
So in a sense I suggest to unbundle it.

We could also just add GPLv2 with exception to the license list,
but in this case I wouldn't--since it doesn't really apply to the
installed version and we don't use it anyhow.

Also, there's a bundled copy of libffi in lib.  Usually, I delete
it to make sure it's not picked up by accident.

Otherwise LGTM!

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 34571 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 34571 <at> debbugs.gnu.org
Subject: Re: [bug#34571] [PATCH] Add micropython
Date: Tue, 19 Feb 2019 12:10:59 +0200

[Message part 1 (text/plain, inline)]

On Tue, Feb 19, 2019 at 10:46:40AM +0100, Danny Milosavljevic wrote:
> Hi Erfraim,
> 
> On Tue, 19 Feb 2019 11:22:16 +0200
> Efraim Flashner <efraim <at> flashner.co.il> wrote:
> 
> > I was looking around to see if there was an alternate perl
> > implementation and I ended up packaging micropython. I have no
> > preference between it being in python.scm or embedded.scm
> 
> Heh :)
> 
> There's a bundled version of FreeRTOS in ./ports/cc3200 which is GPLv2
> with a modification.
> 
> In this case, I suggest to delete FreeRTOS since we don't use it
> anyway--and if we ever wanted to, we'd not use the bundled version.
> So in a sense I suggest to unbundle it.
> 
> We could also just add GPLv2 with exception to the license list,
> but in this case I wouldn't--since it doesn't really apply to the
> installed version and we don't use it anyhow.

I'll go ahead and remove it.

> 
> Also, there's a bundled copy of libffi in lib.  Usually, I delete
> it to make sure it's not picked up by accident.
> 
Looking at the .gitmodules¹ it looks like there's a number of bundled
librarires in the lib folder. With all of them removed it no longer
builds. Looks like I need to take another look at it.

I also switched python-minimal-wrapper -> python-wrapper



¹ https://github.com/micropython/micropython/blob/v1.10/.gitmodules

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 34571 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 34571 <at> debbugs.gnu.org
Subject: Re: [bug#34571] [PATCH] Add micropython
Date: Tue, 19 Feb 2019 12:37:04 +0200

[Message part 1 (text/plain, inline)]

On Tue, Feb 19, 2019 at 12:10:59PM +0200, Efraim Flashner wrote:
> On Tue, Feb 19, 2019 at 10:46:40AM +0100, Danny Milosavljevic wrote:
> > Hi Erfraim,
> > 
> > On Tue, 19 Feb 2019 11:22:16 +0200
> > Efraim Flashner <efraim <at> flashner.co.il> wrote:
> > 
> > > I was looking around to see if there was an alternate perl
> > > implementation and I ended up packaging micropython. I have no
> > > preference between it being in python.scm or embedded.scm
> > 
> > Heh :)
> > 
> > There's a bundled version of FreeRTOS in ./ports/cc3200 which is GPLv2
> > with a modification.
> > 
> > In this case, I suggest to delete FreeRTOS since we don't use it
> > anyway--and if we ever wanted to, we'd not use the bundled version.
> > So in a sense I suggest to unbundle it.
> > 
> > We could also just add GPLv2 with exception to the license list,
> > but in this case I wouldn't--since it doesn't really apply to the
> > installed version and we don't use it anyhow.
> 
> I'll go ahead and remove it.
> 
> > 
> > Also, there's a bundled copy of libffi in lib.  Usually, I delete
> > it to make sure it's not picked up by accident.
> > 
> Looking at the .gitmodules¹ it looks like there's a number of bundled
> librarires in the lib folder. With all of them removed it no longer
> builds. Looks like I need to take another look at it.
> 
> I also switched python-minimal-wrapper -> python-wrapper
> 
> ¹ https://github.com/micropython/micropython/blob/v1.10/.gitmodules
> 

I have a new version attached

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[0001-gnu-Add-micropython.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 34571 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 34571 <at> debbugs.gnu.org
Subject: Re: [bug#34571] [PATCH] Add micropython
Date: Tue, 19 Feb 2019 14:02:36 +0100

Efraim Flashner <efraim <at> flashner.co.il> writes:

> I was looking around to see if there was an alternate perl
> implementation and I ended up packaging micropython. I have no
> preference between it being in python.scm or embedded.scm

“python.scm” seems fine.

> +         (add-before 'build 'preprare-build

Typo: preprare –> prepare

> +           (lambda _
> +             (chdir "ports/unix")
> +             ;; see: https://github.com/micropython/micropython/pull/4246
> +             (substitute* "Makefile"
> +               (("-Os") "-Os -ffp-contract=off"))
> +             #t))
> +         (delete 'configure)) ; no configure
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +                          "V=1")
> +       #:test-target "test"))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("python" ,python-minimal-wrapper)))

Oh, this Python needs Python…?  I think you should be using
python-wrapper here as the python-minimal variants are merely supposed
to be used for breaking a cycle in the build of Python itself.

--
Ricardo

Message #22 received at 34571-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 34571-done <at> debbugs.gnu.org
Subject: Re: [bug#34571] [PATCH] Add micropython
Date: Wed, 20 Feb 2019 09:10:51 +0200

[Message part 1 (text/plain, inline)]

pushed as 20801f9da8cd8669837c4cf6dc633792be53a9f0

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.