From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 19 04:08:34 2019 Received: (at submit) by debbugs.gnu.org; 19 Feb 2019 09:08:34 +0000 Received: from localhost ([127.0.0.1]:53867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gw1OD-0003Vt-UR for submit@debbugs.gnu.org; Tue, 19 Feb 2019 04:08:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gw1OB-0003Vd-KR for submit@debbugs.gnu.org; Tue, 19 Feb 2019 04:08:31 -0500 Received: from lists.gnu.org ([209.51.188.17]:45487) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gw1O5-0007x4-SQ for submit@debbugs.gnu.org; Tue, 19 Feb 2019 04:08:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw1O4-0003gt-MJ for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2019 04:08:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw1O2-0007wd-NK for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2019 04:08:23 -0500 Received: from mout.gmx.net ([212.227.15.18]:43115) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gw1O2-0007wE-Ad for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2019 04:08:22 -0500 Received: from [192.168.1.101] ([213.162.73.134]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MNq8p-1gxQ2J2PiV-007RTn for ; Tue, 19 Feb 2019 10:08:20 +0100 Message-ID: <5C6BC77F.6020104@gmx.at> Date: Tue, 19 Feb 2019 10:08:15 +0100 From: martin rudalics MIME-Version: 1.0 To: Bug-Gnu-Emacs Subject: 26.1.90; Zero wide scroll bars Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Mw2vlXvRNC77TrH242tZ8i7TUGdKvMvsDah2qII5Dwz5Aehe3ql 5O3g98WzQnKZxOhtRCFVnAt66s3GkvBFgVdHzgpwtcNBe4JkcY85dxGz1So7Vl3RA749omd y2BqlrvEHXCTDnxwFbqih6rU6cJK3soQ5Rt2h9k3MoSQcwRAeuE3pYQNKWwIZbVDxX/3TUd YEoIgHTSA6Id25Wmxx1Rw== X-UI-Out-Filterresults: notjunk:1;V03:K0:3XWrpKHxl0c=:fjX+EuydSfum8JU0yOckga /Uz0auEoj17nTKtA6dYdVIJbYfElZZ0yU5zqwzPfAUxguHrYIfpL0xStQK5u9kWvA5NWlX9ip wcTPxgI892vN5ulX0FFzHth4VhSuUM3j6LtnKK4YTODCyFVS0ogyinyJw1d+3EioedPW4uRs3 maaiaUXxo6pRWkOnFBgqL0zhzj7bHlBn0sPA4azmKucONiz2MdmKiYjj7V0fP46poPm5uEXRO B16/wuRV6uQBiuXyG6FHfbRJZG3IY9vO9Nx1x3XiZXBmHRJo3S7CBK17IUPv19Mz3aw2v9GCX V9fc+lFmLNbouML1suj/fqyQQ3ZZQ5WMOme0C3JqiTTHDBu5MksgX9p0nxbjOqQ0p/xVHxLak a7icTytwOfNNqgwlWyyESzTeQgtDARDFtYd2Z5wyYh4+x6WWmFE9xgoPIOzhzKVNmIrpd/RBY /6bur8gplwlq3+rOHWTLPN30OkXUswH/4MdM6F+PEkFVHAhkZBfsApJJud3UGzBTzk7azicaH GXWbz8dhcVyD1O4DDvypiW63g1pXBPGNnPWh4fb8l+FtuEc53IhZY2u6b27HhAb/8K79h5CeU 1Yn9TYwKgZt3yxTPM0V4sabBuUiB1OUUxLeYIWPPL9qt2aCFFQ/sGdU0ww2OGNKAFOzsgfQVU U3qjQYsbD3N+TgE1h4fMMRVDsexVIOETc+SL6JDgH7zAXt+hNINd5a9t053MkO9cmi2/ydYXA okivR25umQqD0fKzpOCQEiP4c7sQQWIget2fRS3/82Rb57ES1F1XnpkQ25f1znuNo/ZtYqJ/f IZMdeyNWdLGlT3t6wx9FjkN+Nco84G6Cayk9pJlo857O/YmufmxnijBYrspzIe45R55olNY2j Y0ud3uqiowQl03iMggDJ2hwkjDqDVczjkxucw9tfhNxNMYpp2UOrOS67wasKazxYwGjL8qJK1 GqmP8yFg3jQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.18 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Setting 'scroll-bar-width' to zero can have unforeseen consequences depending on the toolkit used. To reproduce with Emacs 26 run a Lucid or Motif build as emacs - Q --eval "(setq default-frame-alist '((minibuffer . nil) (vertical-scroll-bars . nil) (scroll-bar-width . 0)))" Then evaluate (set-frame-parameter nil 'vertical-scroll-bars 'left) Emacs aborts with a X protocol error: BadValue (integer parameter out of range for operation) on protocol request 12 GTK builds do not abort but have for example a scroll bar on the left overwrite buffer text. A similar bug can be produced with horizontal scroll bars. It's not entirely trivial to explain why Emacs aborts here. The cause is a combination of contrived logic and the absence of a more cautious initial setting for X builds. For starters, frame.h says that /* Width that a scroll bar in frame F should have, if there is one. Measured in pixels. If scroll bars are turned off, this is still nonzero. */ #define FRAME_CONFIG_SCROLL_BAR_WIDTH(f) ((f)->config_scroll_bar_width) This comment is, unfortunately, wrong because in our example 'frame-notice-user-settings' (setq parms (frame-parameters frame-initial-frame)) 'frame-parameters' creates a zero entry for the 'scroll-bar-width' frame parameter since our initial frame has no scroll bars and 'frame-notice-user-settings' passes that parameter on to 'make-frame'. In frame.c this subsequently bypasses both checks in x_set_scroll_bar_width (struct frame *f, Lisp_Object arg, Lisp_Object oldval) { int unit = FRAME_COLUMN_WIDTH (f); if (NILP (arg)) { x_set_scroll_bar_default_width (f); ... } else if (RANGED_INTEGERP (1, arg, INT_MAX) && XFASTINT (arg) != FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) { FRAME_CONFIG_SCROLL_BAR_WIDTH (f) = XFASTINT (arg); ... since ARG is zero which is neither nil nor a ranged integer > 0. So we continue with the initially zero FRAME_CONFIG_SCROLL_BAR_WIDTH (f) and try to make a window with a zero wide scroll bar produced from the initial w->scroll_bar_width (which equals -1) and these definitions in window.h: /* Width that a scroll bar in window W should have, if there is one. Measured in pixels. If scroll bars are turned off, this is still nonzero. */ #define WINDOW_CONFIG_SCROLL_BAR_WIDTH(W) \ (W->scroll_bar_width >= 0 \ ? W->scroll_bar_width \ : FRAME_CONFIG_SCROLL_BAR_WIDTH (WINDOW_XFRAME (W))) /* Width of scroll bar area in window W, measured in pixels. */ #define WINDOW_SCROLL_BAR_AREA_WIDTH(W) \ (WINDOW_HAS_VERTICAL_SCROLL_BAR (W) \ ? WINDOW_CONFIG_SCROLL_BAR_WIDTH (W) \ : 0) Here the first comment is wrong again, WINDOW_CONFIG_SCROLL_BAR_WIDTH is zero and X is rightfully annoyed. The easisest fix I could come up with is switching the two branches of the if clause in x_set_scroll_bar_width thusly: void x_set_scroll_bar_width (struct frame *f, Lisp_Object arg, Lisp_Object oldval) { int unit = FRAME_COLUMN_WIDTH (f); if (RANGED_INTEGERP (1, arg, INT_MAX) && XFASTINT (arg) != FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) { FRAME_CONFIG_SCROLL_BAR_WIDTH (f) = XFASTINT (arg); FRAME_CONFIG_SCROLL_BAR_COLS (f) = (XFASTINT (arg) + unit - 1) / unit; if (FRAME_X_WINDOW (f)) adjust_frame_size (f, -1, -1, 3, 0, Qscroll_bar_width); SET_FRAME_GARBAGED (f); } else { x_set_scroll_bar_default_width (f); if (FRAME_X_WINDOW (f)) adjust_frame_size (f, -1, -1, 3, 0, Qscroll_bar_width); SET_FRAME_GARBAGED (f); } XWINDOW (FRAME_SELECTED_WINDOW (f))->cursor.hpos = 0; XWINDOW (FRAME_SELECTED_WINDOW (f))->cursor.x = 0; } But maybe someone has a better idea. Note that Windows builds sidestep the problem by unconditionally doing /* By default, make scrollbars the system standard width and height. */ FRAME_CONFIG_SCROLL_BAR_WIDTH (f) = GetSystemMetrics (SM_CXVSCROLL); in 'x-create-frame'. Note also that with emacs 27.1 the bug can be produced more directly by including (setq default-frame-alist '((vertical-scroll-bars . nil) (scroll-bar-width . 0))) in the early-init.el and then enabling vertical scroll bars. The indirection via 'frame-notice-user-settings' is not needed there. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 23 04:51:21 2019 Received: (at 34569) by debbugs.gnu.org; 23 Feb 2019 09:51:21 +0000 Received: from localhost ([127.0.0.1]:48899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxTxp-0006H2-B2 for submit@debbugs.gnu.org; Sat, 23 Feb 2019 04:51:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxTxo-0006Gq-60 for 34569@debbugs.gnu.org; Sat, 23 Feb 2019 04:51:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxTxh-00068V-07; Sat, 23 Feb 2019 04:51:13 -0500 Received: from [176.228.60.248] (port=3022 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxTxg-0007tQ-Ho; Sat, 23 Feb 2019 04:51:12 -0500 Date: Sat, 23 Feb 2019 11:51:17 +0200 Message-Id: <83sgweq1d6.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <5C6BC77F.6020104@gmx.at> (message from martin rudalics on Tue, 19 Feb 2019 10:08:15 +0100) Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Tue, 19 Feb 2019 10:08:15 +0100 > From: martin rudalics > > Setting 'scroll-bar-width' to zero can have unforeseen consequences > depending on the toolkit used. Why would users set 'scroll-bar-width' to zero, instead of turning off scroll-bar-mode? Or are you saying that turning off scroll-bar-mode also produces the same bugs? If turning off scroll-bar-mode does work, then how about disabling the direct setting of 'scroll-bar-width', either silently or noisily? > /* Width that a scroll bar in frame F should have, if there is one. > Measured in pixels. > If scroll bars are turned off, this is still nonzero. */ > #define FRAME_CONFIG_SCROLL_BAR_WIDTH(f) ((f)->config_scroll_bar_width) > > This comment is, unfortunately, wrong But the comment says "disabled", not "width set to zero". is it correct when scroll-bar-mode is turned off? If so, perhaps just qualifying the comment by the method by which the scroll bars are disabled will be good enough? > Note also that with emacs 27.1 the bug can be produced more directly by > including > > (setq default-frame-alist '((vertical-scroll-bars . nil) (scroll-bar-width . 0))) > > in the early-init.el and then enabling vertical scroll bars. The > indirection via 'frame-notice-user-settings' is not needed there. If we disallow setting this parameter directly, or at least setting it to zero, this problem will also go away, right? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 23 09:02:05 2019 Received: (at 34569) by debbugs.gnu.org; 23 Feb 2019 14:02:05 +0000 Received: from localhost ([127.0.0.1]:48991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxXsS-0005nx-Mo for submit@debbugs.gnu.org; Sat, 23 Feb 2019 09:02:04 -0500 Received: from mout.gmx.net ([212.227.15.19]:42373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxXsQ-0005nT-Fx for 34569@debbugs.gnu.org; Sat, 23 Feb 2019 09:02:03 -0500 Received: from [192.168.1.101] ([212.95.5.103]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M4002-1hFlFQ3j8s-00rZFs; Sat, 23 Feb 2019 15:01:54 +0100 Message-ID: <5C715252.1060104@gmx.at> Date: Sat, 23 Feb 2019 15:01:54 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> In-Reply-To: <83sgweq1d6.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:dezASRz/+YEmICerUlp+X25NplcLCYtJEgy/KAtO8Y6Gvigd7vA 4YxWC13jqFzwZaNkEe/qMwoBld0nJGzv+GFiBE3jantWbgKtRyW+dz+ofQNjRVoHB9pYjQ2 Ot1vBB2or7a3SUtdZcJBt0/i7u8fxHSZBvdF7re8h3/TWQIwaQ6QvVKWaVbQpRSz87+m6yN wflR1BFMjOq9gbE/2tr1w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3oc+puUKkV4=:au+ggWSRioyPD4ZupqZ8VX r/BmnfMAfgOegfl2nX9GVjFTxMOVrWAE7plwDunK9z38d2hZaI2bcdJiCc0IQZ6yQAJeCd3F5 LAKI6RMbI8uQc4I4vlPRwPC05Xv2zYQRUDRgQjzBhri1ltxiINN8YqaeAZtcApKyApFL/G646 Rpsu93aDU0HOun65iXz6CoA+JIwIuhsd7uwaUVOXFl7ZuHtuL+Eh4rXeRs2GZnEcThnvhbv5Z ls5gP7GpTtNrSsp5k0Xeq1sOUY2UUXlm7bkknkQFyquZtdpXn2p6JOsbhxn17auWsq5E2FEoO 2VDKgEEBogIr+sEjpcSjLyhmPVe1yEjmReGKZ+cNICA6DS2fmP4w7WjrXMjdXJv9VQOqawsVz /br24CRof6xHVlfbMJLU1iMZF8W3pXkxAILdtrDyoHxBcHOjxTe6ISzbmq0WqdAfYIM35M3zg kYG/MommTgyo13o4R7TSFtzGKVcWl3aYiBXRQpNGGVQ3ly9DRhYn1HZBIlhp1/m/pALeruBFG A6h3EFIuKcweMa1/cFnAXzC6GCNrZ0cUxMtL0wX6xrr8lO9kQ6rlPAj4aUyA6Ux3un7wHqZvq WIVC36e8QUXAe1fgCNk/oTZ4UNaJra1LaeWHAGvcwSbXYM3gAhSpwqGZT10ar2CO6kM1VdsKP we6sgknJUF1CVF4xDw0BT2vDWM/ZgDHUFJNI5GPS2Bl6FfnItLbzNU5G2XMF7b1PqikZW8fn4 PRPnIbFC4b5AIsLk7FftbBuj9PSlXk+8/mRf9ija4Je9JhjVPF4nXxikUtCztlBjeHMyWlFPQ m+6ZVHo0YpO2fe2cm4W9G+ah/2F2IwQkwcLGzKcz/i1PFCKsaysYsEnJbM1CmQAQ20B+ULxjt jCaW1i5Gbs5UESM8ay0lAFTAchF6dsylWQ7wOGX9R5qwFb4Q91Cyg5T6YoQnfHS1A6dlA+MQo BL6CI4Yn5wg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Why would users set 'scroll-bar-width' to zero, instead of turning off > scroll-bar-mode? When they want to turn scroll bars off for a specific frame. Turning scroll bars on later would leave the frame with zero width scroll bars alone. It won't work but it could be the idea. > Or are you saying that turning off scroll-bar-mode > also produces the same bugs? No (otherwise this would have been an issue known ever since). > If turning off scroll-bar-mode does work, then how about disabling the > direct setting of 'scroll-bar-width', either silently or noisily? Setting 'scroll-bar-width' is fragile. With GTK builds you can set it, Emacs will respect it and GTK will either overdraw or leave a gap because you can't change the GTK scroll bar from within Emacs. Note the dual use of this parameter: 'scroll-bar-width' is (1) passed on to the toolkit to draw scroll bars of the desired width and (2) used by Emacs to clear various areas of the window and calculate the width of the text area. But yes: One way to fix the aborts should be to disallow setting the 'scroll-bar-width' frame parameter to zero. >> /* Width that a scroll bar in frame F should have, if there is one. >> Measured in pixels. >> If scroll bars are turned off, this is still nonzero. */ >> #define FRAME_CONFIG_SCROLL_BAR_WIDTH(f) ((f)->config_scroll_bar_width) >> >> This comment is, unfortunately, wrong > > But the comment says "disabled", not "width set to zero". is it > correct when scroll-bar-mode is turned off? If so, perhaps just > qualifying the comment by the method by which the scroll bars are > disabled will be good enough? This hints at another way of fixing the aborts: Handle zero wide scroll bars just as if scroll bars were disabled/turned off. >> Note also that with emacs 27.1 the bug can be produced more directly by >> including >> >> (setq default-frame-alist '((vertical-scroll-bars . nil) (scroll-bar-width . 0))) >> >> in the early-init.el and then enabling vertical scroll bars. The >> indirection via 'frame-notice-user-settings' is not needed there. > > If we disallow setting this parameter directly, or at least setting it > to zero, this problem will also go away, right? Why would we disallow setting this parameter directly? On Windows it works perfectly. On Lucid and Motif all widths but zero work well. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 23 11:50:10 2019 Received: (at 34569) by debbugs.gnu.org; 23 Feb 2019 16:50:10 +0000 Received: from localhost ([127.0.0.1]:49562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxaV8-0001R7-Eb for submit@debbugs.gnu.org; Sat, 23 Feb 2019 11:50:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxaV6-0001Qn-Oq for 34569@debbugs.gnu.org; Sat, 23 Feb 2019 11:50:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxaUv-0005KW-M3; Sat, 23 Feb 2019 11:49:59 -0500 Received: from [176.228.60.248] (port=1352 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxaUr-0002fP-Te; Sat, 23 Feb 2019 11:49:55 -0500 Date: Sat, 23 Feb 2019 18:49:55 +0200 Message-Id: <83lg26phzg.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <5C715252.1060104@gmx.at> (message from martin rudalics on Sat, 23 Feb 2019 15:01:54 +0100) Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Sat, 23 Feb 2019 15:01:54 +0100 > From: martin rudalics > CC: 34569@debbugs.gnu.org > > > If turning off scroll-bar-mode does work, then how about disabling the > > direct setting of 'scroll-bar-width', either silently or noisily? > > Setting 'scroll-bar-width' is fragile. With GTK builds you can set > it, Emacs will respect it and GTK will either overdraw or leave a gap > because you can't change the GTK scroll bar from within Emacs. Note > the dual use of this parameter: 'scroll-bar-width' is (1) passed on to > the toolkit to draw scroll bars of the desired width and (2) used by > Emacs to clear various areas of the window and calculate the width of > the text area. > > But yes: One way to fix the aborts should be to disallow setting the > 'scroll-bar-width' frame parameter to zero. Then I think we should do that. > This hints at another way of fixing the aborts: Handle zero wide > scroll bars just as if scroll bars were disabled/turned off. Yes. > > If we disallow setting this parameter directly, or at least setting it > > to zero, this problem will also go away, right? > > Why would we disallow setting this parameter directly? On Windows it > works perfectly. On Lucid and Motif all widths but zero work well. I said "or at least setting it to zero". From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 24 03:43:47 2019 Received: (at 34569) by debbugs.gnu.org; 24 Feb 2019 08:43:47 +0000 Received: from localhost ([127.0.0.1]:49820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxpNy-0007LB-TE for submit@debbugs.gnu.org; Sun, 24 Feb 2019 03:43:47 -0500 Received: from mout.gmx.net ([212.227.15.18]:47159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxpNx-0007Kx-Gp for 34569@debbugs.gnu.org; Sun, 24 Feb 2019 03:43:45 -0500 Received: from [192.168.1.101] ([213.162.73.91]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M6BKc-1hCirg3E30-00y9iF; Sun, 24 Feb 2019 09:43:38 +0100 Message-ID: <5C725939.5010208@gmx.at> Date: Sun, 24 Feb 2019 09:43:37 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> <83lg26phzg.fsf@gnu.org> In-Reply-To: <83lg26phzg.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:NsqiliAfDW3FbBKi4lkiXkprrFFICen0COndW8b55EFW0xLx8U3 7t+kXWccLvXQ6jVik/M0F1pFf9qrLjXYnsL+9wq6i2eN8WbSPgef9d/alETS5n6C+xpPeNJ TLxxylCO3/MfOYfH5loBhhV/349eQX7UG+qUm62M4TRDZGTD0XvRWBSY1mWIGXsnSKmjrdN ODaswa30/kg4JgUNOrpIg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:pIAwIt8x50o=:eOqpIDOn9D1TRoFvIOck3l KRs6AFhgGhC9xWzE7YDKzZDl2Nn8FujgbYaWWMB0aQkLZwxZl4+cI07/Q7/VNyXTWhckJqxDG PDmyo+U1u4N8EeL8VUaoMBKzVI9BzglQkSBzt4wub4G8tfTDwf0ur57KFkzvz2de0428Lt2uN sZvdv8Dr6wUpwu4ziYeiB3eGjywNxd/07cs9Fx2Sqgz66s0s1ndHl2gKpSHb09N27wghSL0L6 SLpTC+X0bD8GkNlpKq8uiOmc1JS8CqSnNJ0VgPbFvXfXyUNUE3gRkwxA1SCVgt+OUHWZNvd7I V5cWn3N6LZiRJXK+GDUVanDuJF6pXdNzxPUNeJXsFU3iiDkD6g6O6cd7NJBH4gwqesqI0NssT k9mUiaNtx8uCiUHDKCbPmF0OT+w0l4QLHdmF/Dv1ChaL9d0L580dHpk5VAYQG2N0dcPUQ7Jx8 ta2PUCxnLu9Nhnc5fr+Hg0JQsy3oKq9HWtgG85GsGa5lF+pVfwnnyorB/XzIw4e2fzOFDn28l Qs6j/jwoNEi0eq5Q4Pj7/M7DAcckImGzk/zrEN5kBm5FO1UDJMn4WBcXYrJ0RlFUn86UULhpU RpEWiETd1/ZVNrun11G4YolP7rjkw4WTSWI26RtNuSnum8tpAeC93UXKCPD5wzE8uW3M6shu+ ALd8ETu498BOvwpl/9q/Aw6qIAuUAvAjnWx4j/ebtJuC9/0XVIMUneezu6r550qNTryDyyC+n QLeSzHWee/LOtRNw3+8cXe/nrzZbNP4vejrq7msUlaI/yyT2wobTUikyj+prsgy/BiE9AmSdg DwEtsF5e0qVowN8kXuMOWMNVr6RmEQkwGQN12QOzmWqTCWX8BDWPBLFnWN1rItGAwgNf7r4xe OferhfGL6lpnQHZfqxuD2W9PC+gX5xHCxzDsevoufqiakjKFya6DThXBOffNrJOTaNtRY7QSy Lx94wZSf2DA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> But yes: One way to fix the aborts should be to disallow setting the >> 'scroll-bar-width' frame parameter to zero. > > Then I think we should do that. It means though that we have to do some non-standard surgery in the frame parameters area. Note that x_report_frame_params inserts the zero value automatically via store_in_alist (alistptr, Qscroll_bar_width, (! FRAME_HAS_VERTICAL_SCROLL_BARS (f) ? make_fixnum (0) : FRAME_CONFIG_SCROLL_BAR_WIDTH (f) > 0 ? make_fixnum (FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) /* nil means "use default width" for non-toolkit scroll bar. ruler-mode.el depends on this. */ : Qnil)); What should we use instead? martin From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 24 11:09:08 2019 Received: (at 34569) by debbugs.gnu.org; 24 Feb 2019 16:09:08 +0000 Received: from localhost ([127.0.0.1]:50365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxwKy-0002z4-AZ for submit@debbugs.gnu.org; Sun, 24 Feb 2019 11:09:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxwKx-0002yZ-2N for 34569@debbugs.gnu.org; Sun, 24 Feb 2019 11:09:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxwKn-0008Tc-Uc; Sun, 24 Feb 2019 11:09:00 -0500 Received: from [176.228.60.248] (port=4156 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxwKm-0002HJ-C5; Sun, 24 Feb 2019 11:08:57 -0500 Date: Sun, 24 Feb 2019 18:09:05 +0200 Message-Id: <83y365np7i.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <5C725939.5010208@gmx.at> (message from martin rudalics on Sun, 24 Feb 2019 09:43:37 +0100) Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> <83lg26phzg.fsf@gnu.org> <5C725939.5010208@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Sun, 24 Feb 2019 09:43:37 +0100 > From: martin rudalics > CC: 34569@debbugs.gnu.org > > >> But yes: One way to fix the aborts should be to disallow setting the > >> 'scroll-bar-width' frame parameter to zero. > > > > Then I think we should do that. > > It means though that we have to do some non-standard surgery in the > frame parameters area. That's okay, we already do similar things with some parameters. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 24 13:32:00 2019 Received: (at 34569) by debbugs.gnu.org; 24 Feb 2019 18:32:00 +0000 Received: from localhost ([127.0.0.1]:50460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxyZC-0006St-Dv for submit@debbugs.gnu.org; Sun, 24 Feb 2019 13:32:00 -0500 Received: from mout.gmx.net ([212.227.15.19]:36417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxyZA-0006Sc-KK for 34569@debbugs.gnu.org; Sun, 24 Feb 2019 13:31:57 -0500 Received: from [192.168.1.101] ([46.125.250.21]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M7pI0-1hAzEk0Uoy-00vNYK; Sun, 24 Feb 2019 19:31:50 +0100 Message-ID: <5C72E313.8080205@gmx.at> Date: Sun, 24 Feb 2019 19:31:47 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> <83lg26phzg.fsf@gnu.org> <5C725939.5010208@gmx.at> <83y365np7i.fsf@gnu.org> In-Reply-To: <83y365np7i.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:5v/VaNC2d9aHsKxwkHTy55zYAHajgNprSbOd0Qf4GYhuP2ciaQA QVPqOFeuIpnKfwmzSMEQtMQ/FOFzvAo0tiB4qy1hr3vrpe36zOX++h4zj4BiYRdEyNVq+6C 3gjEY33omWUbNWLExfwSk2Yd3IwohkqOTsLwjzMCoACNzO0WId5YsMdcFop6R1amOJuFY2L udLJg2waldGQxrdVuvNdQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UhnBqiPo+aU=:arGCVYdRJlsJPEMWXKmMnN 8u3ImJuTZ8mX9WLJxkEoTFHbTmMADfLa2rqJ8DEsdjOMaiahf9EdxQOk1nN9JmFynVfsdSyf+ vQKjpGbqOrc0rjwxpbvJVi3vN62b9u+mLkkd+S6xCISuLoHemqwXzYGOACfUg876cX2e9IsK1 DINauzKBVtj1/9Fr/p85xSFP37Z0bwvSAXjgTTnACQkGhwp0k9z5rthzOVs1AOqxxyauDNtG/ InBbGCHNe1nOB6XgnWfyLYAgOGe7/KDmXpaoGAAydGKOtihD+1626t63tuXPAzpdfzQ/Vb8Fv XoOMz5tonLeHr8ouugkJ2f7+BRkGzwB/ZqfQTDPuov1NRStT5ahPoO/nGPpo7vgOQqn8bNPEb pHRTsbh92aDBNlFZbEDBhYGhsxS/mcCr3cLZW29tCRH44cLhZOXVxzfZWAajPG7GTgYcYhscg f8UvSbIUciAQzVckTAK/sethkwibAIdgvDFwfygIbDPyI+wzArfkYmNFIo8CCAi5tWlbmhto5 1RSJMpJV1hcQsJNQiTxZ3Mcr12tRlHmUSyMMspAxM2z+I0kz7+gf7zMMt/ok06MmYbYG50RGa /BI+vZ2x8GZHEjcvY5nWdnOwRpCaItpKv9P3iGmgdHeEjNfN4x/hD6jcl+JDZvqieW3xRAIAM iuLcFDTmyufDRscTSy3KifhrJW5e7NTeYDinl3ERgDT5T76N9K1+frtLXjMuxWIEys1ieopYg 598/LHhleKGJhD8Lojuyc5hRqUtx9DpsRAdpw+IJOdVVn7nSw0/dT1JsewPN/hQ/KM9dKiWvu XmM2i+8+YjD7CFaiMFlCmdgB+jnomkn2deihu+uT/j+vBD1Skb1yfaPhKJdCUjhE+oK68pLai tFn3k0ZZdP/rNGFZxgQe903jEoSTKWMcC9rg9SmVql9IBDHVQbMLAdcU166VbTff9YRoxImpG 7ZmUZ0hSvMA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> It means though that we have to do some non-standard surgery in the >> frame parameters area. > > That's okay, we already do similar things with some parameters. You didn't answer that question: > Note that x_report_frame_params inserts the > zero value automatically via > > store_in_alist (alistptr, Qscroll_bar_width, > (! FRAME_HAS_VERTICAL_SCROLL_BARS (f) > ? make_fixnum (0) > : FRAME_CONFIG_SCROLL_BAR_WIDTH (f) > 0 > ? make_fixnum (FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) > /* nil means "use default width" > for non-toolkit scroll bar. > ruler-mode.el depends on this. */ > : Qnil)); > > What should we use instead? martin From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 24 14:04:10 2019 Received: (at 34569) by debbugs.gnu.org; 24 Feb 2019 19:04:11 +0000 Received: from localhost ([127.0.0.1]:50504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxz4M-0007KY-Ls for submit@debbugs.gnu.org; Sun, 24 Feb 2019 14:04:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxz4K-0007KL-Ho for 34569@debbugs.gnu.org; Sun, 24 Feb 2019 14:04:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxz4D-0005SJ-DH; Sun, 24 Feb 2019 14:04:03 -0500 Received: from [176.228.60.248] (port=3152 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxz4C-0003mO-6L; Sun, 24 Feb 2019 14:04:01 -0500 Date: Sun, 24 Feb 2019 21:04:06 +0200 Message-Id: <83d0nhnh3t.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <5C72E313.8080205@gmx.at> (message from martin rudalics on Sun, 24 Feb 2019 19:31:47 +0100) Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> <83lg26phzg.fsf@gnu.org> <5C725939.5010208@gmx.at> <83y365np7i.fsf@gnu.org> <5C72E313.8080205@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Sun, 24 Feb 2019 19:31:47 +0100 > From: martin rudalics > CC: 34569@debbugs.gnu.org > > >> It means though that we have to do some non-standard surgery in the > >> frame parameters area. > > > > That's okay, we already do similar things with some parameters. > > You didn't answer that question: > > > Note that x_report_frame_params inserts the > > zero value automatically via > > > > store_in_alist (alistptr, Qscroll_bar_width, > > (! FRAME_HAS_VERTICAL_SCROLL_BARS (f) > > ? make_fixnum (0) > > : FRAME_CONFIG_SCROLL_BAR_WIDTH (f) > 0 > > ? make_fixnum (FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) > > /* nil means "use default width" > > for non-toolkit scroll bar. > > ruler-mode.el depends on this. */ > > : Qnil)); > > > > What should we use instead? I thought I did. Maybe I didn't understand what exactly you are asking. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 25 05:13:26 2019 Received: (at 34569) by debbugs.gnu.org; 25 Feb 2019 10:13:26 +0000 Received: from localhost ([127.0.0.1]:50848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyDGH-0003dz-SQ for submit@debbugs.gnu.org; Mon, 25 Feb 2019 05:13:26 -0500 Received: from mout.gmx.net ([212.227.15.15]:52219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyDGF-0003dl-Bl for 34569@debbugs.gnu.org; Mon, 25 Feb 2019 05:13:23 -0500 Received: from [192.168.1.101] ([46.125.250.50]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MDhny-1gnhFz0Bji-00H5Y7; Mon, 25 Feb 2019 11:13:17 +0100 Message-ID: <5C73BFB9.8010109@gmx.at> Date: Mon, 25 Feb 2019 11:13:13 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> <83lg26phzg.fsf@gnu.org> <5C725939.5010208@gmx.at> <83y365np7i.fsf@gnu.org> <5C72E313.8080205@gmx.at> <83d0nhnh3t.fsf@gnu.org> In-Reply-To: <83d0nhnh3t.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:zBZQOM6YRhh7wAEauzAFDoULdo1UFDU8ks1xPJyWJ1TioxTTjPr UyZAf9x3d5LRf92+zmbd7wmMAEoKlrl0AOzdprCgNUcAwVRn88KAgsM/lyPp64zurFhK0YR qjGtjfOWsdx2kkCVfYniUyP8C09wtSu6eXKyVUIVeWrgC3ioPqdKePUJxmOZagT18Z8DIQu +KqaKq7PC67UY6CWKFEyQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Jtp2mp+2qA4=:eSHDqitIg1e7R/ydZkLi2x 2K7TwKd/rDGOmefYIeqxwT2uXWqa7Xa6UfMfu4NZ23oR2vZfPaOCErzuCaQCaFSIOFmup4O3X lBqommDRhlGEUd2SPRbNiUhMaiQRDquOzCtLDu/tiG1Ms7enNNV7HneaaKI38rT9CTDZZWppk ymOcNwqObW5VTV2fq1bnvEjq1RqLtV516E43alq0Tn+D0bDGqQWKCJUuvQ8OylY+mDDzrANiB UEUGR0vugg3DraxFpL2gZupiDK7o2RvhZcgg6V0L5W7T7wGCHVPrz1UfeVKHYQj9h2eosYsSo f3YNTSQm9gVlYtANYUl0tFmAUkXIRZjU+jFxyCwM6S1hBvB+XvBWHojHmpUSyfMYJ+QRCnwSD zzLswm3PhEoOVCTn2pQ0uaPWw1i8pMggbUD+9/xufvovheVcgtwqt2x4tkdhR5WgI5ejSGnOP xE/uVC2EQRIiH39Owc5TdUx0b9SSj7+XOchjtm/YMpEdOlUAc1Br38xW4d70GG/OIBQ/U0Aq6 hsSO7jfNsq8Vl3146AjC/M0bPzuAIJG+q4kRniECoZfy3poLylIStnE5LBXCDruTDpgxrsWkx kUzovDhOLyeYVWefE5nMfsXp2bm2ndQngTSKdZOtL0y/gNndWEsiMr0xj0AvkI6fpKk7duwb7 vRCjaWU0dvDChp+G1E/m6uhCyoq6qEZZS9MzfcRVmMixsaLcyJhpoUXBnwLrGSnDlmauGdoGM utZz+5CisJd3th+NvkTxoJBl1wdx5n0RXOguTstPgoo9bo8MVUP+isVSXj/zYeDPE2yIOg8sO 9yab+njh6vSKZWNU2e+lbDizddS5IARfKtTUH5H+YKibLFcIg1A2qZ50oKjxbXCGgJ9ikvGU0 8TMkcer07niCuGz+OyNcYGU6R/levMxd3Xld9mVLutVLqajkz+JAH4RohMmMLfME9eP/WmibP r8gDvNCpxkg== X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) >> You didn't answer that question: >> >> > Note that x_report_frame_params inserts the >> > zero value automatically via >> > >> > store_in_alist (alistptr, Qscroll_bar_width, >> > (! FRAME_HAS_VERTICAL_SCROLL_BARS (f) >> > ? make_fixnum (0) >> > : FRAME_CONFIG_SCROLL_BAR_WIDTH (f) > 0 >> > ? make_fixnum (FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) >> > /* nil means "use default width" >> > for non-toolkit scroll bar. >> > ruler-mode.el depends on this. */ >> > : Qnil)); >> > >> > What should we use instead? > > I thought I did. Maybe I didn't understand what exactly you are > asking. I wanted to know which value to assign when a frame does not have vertical scroll bars. We could try with store_in_alist (alistptr, Qscroll_bar_width, (FRAME_CONFIG_SCROLL_BAR_WIDTH (f) > 0 ? make_fixnum (FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) /* nil means "use default width" for non-toolkit scroll bar. ruler-mode.el depends on this. */ : Qnil)); but I'm not sure whether that's what you meant. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 26 11:07:07 2019 Received: (at 34569) by debbugs.gnu.org; 26 Feb 2019 16:07:07 +0000 Received: from localhost ([127.0.0.1]:53236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyfG7-0007Zi-2a for submit@debbugs.gnu.org; Tue, 26 Feb 2019 11:07:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyfG5-0007ZC-Kq for 34569@debbugs.gnu.org; Tue, 26 Feb 2019 11:07:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyfFt-0002Vh-Ia; Tue, 26 Feb 2019 11:06:55 -0500 Received: from [176.228.60.248] (port=2735 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gyfFr-0005df-RW; Tue, 26 Feb 2019 11:06:53 -0500 Date: Tue, 26 Feb 2019 18:07:05 +0200 Message-Id: <83wolmleja.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <5C73BFB9.8010109@gmx.at> (message from martin rudalics on Mon, 25 Feb 2019 11:13:13 +0100) Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> <83lg26phzg.fsf@gnu.org> <5C725939.5010208@gmx.at> <83y365np7i.fsf@gnu.org> <5C72E313.8080205@gmx.at> <83d0nhnh3t.fsf@gnu.org> <5C73BFB9.8010109@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Mon, 25 Feb 2019 11:13:13 +0100 > From: martin rudalics > CC: 34569@debbugs.gnu.org > > I wanted to know which value to assign when a frame does not have > vertical scroll bars. We could try with > > store_in_alist (alistptr, Qscroll_bar_width, > (FRAME_CONFIG_SCROLL_BAR_WIDTH (f) > 0 > ? make_fixnum (FRAME_CONFIG_SCROLL_BAR_WIDTH (f)) > /* nil means "use default width" > for non-toolkit scroll bar. > ruler-mode.el depends on this. */ > : Qnil)); > > but I'm not sure whether that's what you meant. It would work for me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 04 05:14:52 2019 Received: (at 34569) by debbugs.gnu.org; 4 Mar 2019 10:14:52 +0000 Received: from localhost ([127.0.0.1]:58978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0kcV-0002l2-Nm for submit@debbugs.gnu.org; Mon, 04 Mar 2019 05:14:51 -0500 Received: from mout.gmx.net ([212.227.17.21]:60097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0kcT-0002kl-HI; Mon, 04 Mar 2019 05:14:49 -0500 Received: from [192.168.1.101] ([213.162.73.185]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MNuwp-1guwvI0q1D-007Sfg; Mon, 04 Mar 2019 11:14:43 +0100 Message-ID: <5C7CFA8F.2090705@gmx.at> Date: Mon, 04 Mar 2019 11:14:39 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#34569: 26.1.90; Zero wide scroll bars References: <5C6BC77F.6020104@gmx.at> <83sgweq1d6.fsf@gnu.org> <5C715252.1060104@gmx.at> <83lg26phzg.fsf@gnu.org> <5C725939.5010208@gmx.at> <83y365np7i.fsf@gnu.org> In-Reply-To: <83y365np7i.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:bgSFJP0q+1gmZMW5lVKD56YIV0f9AaPWnBBc5oVridvQuRjgPIg lHgfM3jNJbQ3/zG8x7hN0jpFaPIzYNXcl+FgJMp4TvITux/Fl8XJuQ809H7VG6pVT9+VTQL EjzeKoxGeX327KGfwCwWgf/gaGTgAnVUCsJ0+nCHi8USzjVf577VezbhrxGE6CI765rcuFZ DSvBKhfoBrQKMIWqFJ5lg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XZIXdgZ4XZ4=:lJ4QZuSET/O820HC2OdR+i G2edJcEexu8y75zRvcTIbrJfp0rLAaqsUPnQdJi2HT+bICKBLXeec4i+kwhVmOiZz9O8DWUdu BYRIaqntPLilhfAhIBTnh2uPyLbDZo8C35QrlzB0AtJdtUepPa5hgIGgvVFJA7eAmC1ojsK6e aXJ7mZYDnkb5HP+lXvk/8gEaxjGRS4VxLlN+bGLZXkutGQsUQ7cJT9xIbC1bg+RErg9bxTnwe ovX8hg8f9Qf3McQs+HzJMoQxORhEckEe2DBbOm3B/YCej0Td7mu1rbT3GQbNDebgSlS9dlWCj bi3qaEZ/zCIGAxvcUyekuO1GPBp7oQVIesJmgkjNX+luGSQNzPkqAHZWCqTvC2Lz2Wznoqdq+ uPAIQRJe5P3A5dRoNU4yenlkqwnF0vJZ8dz/J7ChWff1VkcBr3Vyc3NsjMEz94JI+tgj9XgZu vMnAmg1l0YGMVEkNyOPOF6ea9sBiJI1x5WXNtGZVuD4Yb1z1lkt5iJAxNDTqJ4p2HaWevqkE3 YBtX161NJmQda5qgZOPBnCE7na4w+N34DCfO66NoYOdIUw62StKuAF5PsQlyuMHwZHJn7ccG1 EUf6IATXFmhE3RO6Amz9luQpDWjg9pTdGGTVGEb8kq1C07UpxXqMnfrHj2FMm8aP7ZIJJgnR2 LE80wvxJ5BX7b1OyzzLKOu35Ra4ycXLhP2bOaB80moT5MpVXc2Y/4jUfTGEDgoeJjNTmC7Tyf 3AYVHqtFKrU7JYtSXkQJ/baLUt/+I6YpOZd5L8fibLyrEbwQPxObMDCn76BVIxfb0yS63gwFk AOsGflZ/hVR6nuGMgba+zmrMHHd1Hjq2+0nCAse59skALT3XxYolFJuTTIRgAnyBfMcVDRFV0 mgD8JdRrUDknsUlZ6EPAbgtUe8GuxHkS36eUm/0KXIXn75D0oUvhkHAvNZLxJu4gCwoR5i6ka pezhKysMMjQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34569 Cc: 34569@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) fixed 34569 27.1 quit >> It means though that we have to do some non-standard surgery in the >> frame parameters area. > > That's okay, we already do similar things with some parameters. I now installed the most comprehensive fix I came up with. Marking bug as done. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 22:56:48 2019 Received: (at control) by debbugs.gnu.org; 30 Mar 2019 02:56:48 +0000 Received: from localhost ([127.0.0.1]:36112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hA4Aq-0004sz-IW for submit@debbugs.gnu.org; Fri, 29 Mar 2019 22:56:48 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:41776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hA4Ao-0004si-Cu; Fri, 29 Mar 2019 22:56:46 -0400 Received: by mail-qk1-f171.google.com with SMTP id o129so2564764qke.8; Fri, 29 Mar 2019 19:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=JfvZLhMN0I98LUvlPPss5iHEM2My5Qyy7tk6VCRCnCs=; b=R8qpdl7h/qUSPgd47JqRQEnIhlDoPGvyFNA6xC0hfCgYdffmK/UMR1CcHGd0t7odjC VhkkfMGsYrTXMTstZ7sGmBJzg5XKRZ7GEX+HbrAIiZDNOhyipg5oOgA1sHZBQDgx3dzj YiZ5t7b+V2o0kMsjj3Hv2m/fMvHn7URr48Uz4TOwb4L78AWwEk+zDt5I3X5oJF7DPLiK r/q9QmiVJR4m4Zrg9SR850OPKgljLvBwUlEy86mFZoMiLhxnWWi+4r72pN3bMJzFnkGa q0OB9otBxW+/CQxpczIf4R6RHC5G2YEPjvSfbmATNI2oz/9aqxs4MluzefT+4m5Pfis2 860g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=JfvZLhMN0I98LUvlPPss5iHEM2My5Qyy7tk6VCRCnCs=; b=tW7bmhVLMsgvfd41N/438SeWGYS+JxZp9OpPrb9xGxjpsQw8LeTC9EsXzy5eJ5ouao oEekNeh5CtiGC/JQQcD5XS15vkbCg1jIluIAW3af/021ypkvHylMqtCn0wg3dwRdPsSL ZnEFckBChLBqr53QHky7fY5xIEw5xteNvm3191yBTxiRqzAMyoH3bKekstkt6agEnjdO J1AlJT8k/M77F50W987Tnq3fXXm5d9532jZ29TMh3uFzXgtxDcbk93JWuB6yWqzTzOZ3 goA4foGO4VbcU0nAcDDaFWPsXqFjOv19O/4i7dW/ptpLEaVKUOFARiR3yRN6Sw9/7+oX ay/Q== X-Gm-Message-State: APjAAAWY/Y0YlYOOhZnqw5pX/RDGiucT1KcV6agALxnSIG7wLJEWlDLf xjvcfQzpfgnGkdEfJ+gczZAolcPI X-Google-Smtp-Source: APXvYqzxM3q3j5zMqhaFKT0EwU4rA7f2FS1E/L0Hi69La8nHH418e5tn4NCmN43gZCJ/oj49jGumPg== X-Received: by 2002:a37:5088:: with SMTP id e130mr17695179qkb.206.1553914600541; Fri, 29 Mar 2019 19:56:40 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id t69sm1980757qke.38.2019.03.29.19.56.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 19:56:39 -0700 (PDT) From: Noam Postavsky To: martin rudalics Subject: Re: bug#34138: 27.0.50; Delayed display of PDF file images References: <871s58e4gh.fsf@gmx.net> <83lg3e9dd6.fsf@gnu.org> <87womxdgdq.fsf@gmx.net> <83fttlam3b.fsf@gnu.org> <87sgxlrfgg.fsf@hochschule-trier.de> <83bm49aj3q.fsf@gnu.org> <87a7jtd4sx.fsf@gmx.net> <834la0accs.fsf@gnu.org> <87lg3cfjef.fsf@gmx.net> <83lg3b8i8a.fsf@gnu.org> <5C48B20C.9030100@gmx.at> <8336pj8bhx.fsf@gnu.org> <5C4980A5.90902@gmx.at> <83sgxi6sjq.fsf@gnu.org> <5C4C263D.5020803@gmx.at> <83h8dv668x.fsf@gnu.org> <5C4C77BD.5070701@gmx.at> <877eerxwlp.fsf@gmx.net> <5C5562BD.8050403@gmx.at> <871s4qpcqn.fsf@gmx.net> <5C6BC0EE.3040009@gmx.at> Date: Fri, 29 Mar 2019 22:56:38 -0400 In-Reply-To: <5C6BC0EE.3040009@gmx.at> (martin rudalics's message of "Tue, 19 Feb 2019 09:40:14 +0100") Message-ID: <87sgv583yx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , Stephen Berman , 34138@debbugs.gnu.org, politza@hochschule-trier.de, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # Delayed display of PDF file images /#34202 Opening a pdf shows raw file at first close 34138 27.1 # message hangs when buffer with process visible close 34179 27.1 # Emacs randomly hangs during redisplay close 34260 27.1 # Zero wide scroll bars close 34569 27.1 # Wrong unbinding order in x_consider_frame_title close 34317 27.1 quit martin rudalics writes: > fixed 34138 27.1 > quit > >> FTR, I also just updated and rebuilt and all is fine (I've been viewing >> PDF files daily with no problem with the patch you had posted). Thanks. > > Fine. Closing this bug now. So, this doesn't quite close the bug, it just marks it fixed. You should use "close" instead of "fixed" to close a bug ("close" does also accept a version argument to mark as fixed at the same time). From unknown Sun Jun 22 04:00:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Apr 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator