GNU bug report logs - #34532
Unhandled errors in vc

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Subject: bug#34532: closed (Re: bug#34532: Unhandled errors in vc)
Date: Tue, 19 Mar 2019 21:54:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#34532: Unhandled errors in vc

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34532 <at> debbugs.gnu.org.

-- 
34532: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34532
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: 34532-done <at> debbugs.gnu.org
Subject: Re: bug#34532: Unhandled errors in vc
Date: Tue, 19 Mar 2019 23:52:47 +0200

> This is now fixed.
>
> Another problem is that ‘vc-root-version-diff’ can't be used when
> fileset is not available.  But this command doesn't use fileset,
> it uses the root directory, so this patch adds an optional
> arg ‘fileset’ to ‘vc-diff-build-argument-list-internal’,
> so ‘vc-root-version-diff’ can provide its own fake fileset
> with the root directory:

Fixed as well.

[Message part 3 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Unhandled errors in vc
Date: Mon, 18 Feb 2019 23:37:44 +0200

[Message part 4 (text/plain, inline)]

After ‘C-x v g’ (vc-annotate) typing ‘a’ (vc-annotate-revision-previous-to-line)
in the *Annotate* buffer on the earliest (initial) revision fails with:

  Debugger entered--Lisp error: (error "Invalid argument to vc-annotate-warp-revision")
    signal(error ("Invalid argument to vc-annotate-warp-revision"))
    error("Invalid argument to vc-annotate-warp-revision")
    vc-annotate-warp-revision(nil "...")

This patch provides a nicer message:

[vc-annotate.el.patch (text/x-diff, inline)]

diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el
index 86fc8686c3..84838135fc 100644
--- a/lisp/vc/vc-annotate.el
+++ b/lisp/vc/vc-annotate.el
@@ -541,7 +541,9 @@ vc-annotate-revision-previous-to-line
 	(setq prev-rev
 	      (vc-call-backend vc-annotate-backend 'previous-revision
                                fname rev))
-	(vc-annotate-warp-revision prev-rev fname)))))
+	(if (not prev-rev)
+            (message "No previous revisions")
+          (vc-annotate-warp-revision prev-rev fname))))))
 
 (defvar log-view-vc-backend)
 (defvar log-view-vc-fileset)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.