From unknown Mon Jun 23 07:50:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34532: Unhandled errors in vc Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Feb 2019 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 34532@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155052606532656 (code B ref -1); Mon, 18 Feb 2019 21:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Feb 2019 21:41:05 +0000 Received: from localhost ([127.0.0.1]:53306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvqev-0008Ue-43 for submit@debbugs.gnu.org; Mon, 18 Feb 2019 16:41:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvqet-0008Tw-4H for submit@debbugs.gnu.org; Mon, 18 Feb 2019 16:41:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:48400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gvqen-0005EF-7c for submit@debbugs.gnu.org; Mon, 18 Feb 2019 16:40:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvqem-0006vs-BA for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2019 16:40:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvqeg-0005Cc-Ek for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2019 16:40:54 -0500 Received: from bird.maple.relay.mailchannels.net ([23.83.214.17]:56578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gvqeZ-0005AK-Ju for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2019 16:40:45 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 698D23E503A for ; Mon, 18 Feb 2019 21:40:35 +0000 (UTC) Received: from pdx1-sub0-mail-a49.g.dreamhost.com (unknown [100.96.33.121]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1FC493E47B2 for ; Mon, 18 Feb 2019 21:40:35 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a49.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Mon, 18 Feb 2019 21:40:35 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Cellar-Continue: 375b6dbb2fe89ddc_1550526035225_4086277830 X-MC-Loop-Signature: 1550526035224:2455555261 X-MC-Ingress-Time: 1550526035224 Received: from pdx1-sub0-mail-a49.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTP id B95847F5FA for ; Mon, 18 Feb 2019 13:40:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=lKxzYlORofSpPssECwclYT1kGCY=; b=dSe2eDd5jyDRJ8Etk 0JVqunsoL+pAxOp0u4s/x9XOs9qPL/LtPRVPd9RGGKAw6HyubB/LJVa6mu5OegzA g30X0INY1U6MKpYI2/KXr+tm84mN5jkrf9osnqY+mi3/1+1KDqDsrZAUfiCIBOwh CDo1kfh7ep3BBCOneY5mKh+qvQ= Received: from mail.jurta.org (m91-129-96-50.cust.tele2.ee [91.129.96.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTPSA id 8BD0E7F1DE for ; Mon, 18 Feb 2019 13:40:32 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a49 From: Juri Linkov Organization: LINKOV.NET Date: Mon, 18 Feb 2019 23:37:44 +0200 Message-ID: <87mumssrpz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrtddugdduvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohffkfgfgggtsehmtderredtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirdehtdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrhedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 23.83.214.17 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable After =E2=80=98C-x v g=E2=80=99 (vc-annotate) typing =E2=80=98a=E2=80=99 = (vc-annotate-revision-previous-to-line) in the *Annotate* buffer on the earliest (initial) revision fails with: Debugger entered--Lisp error: (error "Invalid argument to vc-annotate-w= arp-revision") signal(error ("Invalid argument to vc-annotate-warp-revision")) error("Invalid argument to vc-annotate-warp-revision") vc-annotate-warp-revision(nil "...") This patch provides a nicer message: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-annotate.el.patch diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el index 86fc8686c3..84838135fc 100644 --- a/lisp/vc/vc-annotate.el +++ b/lisp/vc/vc-annotate.el @@ -541,7 +541,9 @@ vc-annotate-revision-previous-to-line (setq prev-rev (vc-call-backend vc-annotate-backend 'previous-revision fname rev)) - (vc-annotate-warp-revision prev-rev fname))))) + (if (not prev-rev) + (message "No previous revisions") + (vc-annotate-warp-revision prev-rev fname)))))) (defvar log-view-vc-backend) (defvar log-view-vc-fileset) --=-=-=-- From unknown Mon Jun 23 07:50:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34532: Unhandled errors in vc Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Feb 2019 21:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 34532@debbugs.gnu.org Received: via spool by 34532-submit@debbugs.gnu.org id=B34532.155130246320378 (code B ref 34532); Wed, 27 Feb 2019 21:22:01 +0000 Received: (at 34532) by debbugs.gnu.org; 27 Feb 2019 21:21:03 +0000 Received: from localhost ([127.0.0.1]:54443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz6dS-0005Ic-TY for submit@debbugs.gnu.org; Wed, 27 Feb 2019 16:21:03 -0500 Received: from insect.birch.relay.mailchannels.net ([23.83.209.93]:51521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz6dQ-0005Ht-M5 for 34532@debbugs.gnu.org; Wed, 27 Feb 2019 16:21:01 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 30B02283A53 for <34532@debbugs.gnu.org>; Wed, 27 Feb 2019 21:20:59 +0000 (UTC) Received: from pdx1-sub0-mail-a65.g.dreamhost.com (unknown [100.96.20.153]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D5666284838 for <34532@debbugs.gnu.org>; Wed, 27 Feb 2019 21:20:58 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a65.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.3); Wed, 27 Feb 2019 21:20:59 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Spicy-Wiry: 3ce4529b29402c77_1551302459009_3824808804 X-MC-Loop-Signature: 1551302459009:2444408122 X-MC-Ingress-Time: 1551302459009 Received: from pdx1-sub0-mail-a65.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTP id A432B819A6 for <34532@debbugs.gnu.org>; Wed, 27 Feb 2019 13:20:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=8aTpXteKOgnKq+dX1UNBQWTtTO0=; b= XYPrTaqz/Bx8Z47lI9LO+KEZuiWSdIfap/2HDwH6jGdBdAIfbJYFVcd+VG9cZo1p wOA5rsLk2M5RXZ4X/ehIQ0YvVfKJvoAh7b2CTMsVK3dDds14767+6nH2TFiIxRnf quraoAf6+CHrX/YOWJ7xgd5HWR6HWEf4hQFcsXfAyN0= Received: from mail.jurta.org (m91-129-98-103.cust.tele2.ee [91.129.98.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTPSA id E5EBA8199B for <34532@debbugs.gnu.org>; Wed, 27 Feb 2019 13:20:53 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a65 From: Juri Linkov Organization: LINKOV.NET References: <87mumssrpz.fsf@mail.linkov.net> Date: Wed, 27 Feb 2019 23:20:35 +0200 In-Reply-To: <87mumssrpz.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 18 Feb 2019 23:37:44 +0200") Message-ID: <87zhqhszf6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrvddugddugeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtsehmtderredtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleekrddutdefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleekrddutdefpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepfeegheefvdesuggvsggsuhhgshdrghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > After =E2=80=98C-x v g=E2=80=99 (vc-annotate) typing =E2=80=98a=E2=80=99= (vc-annotate-revision-previous-to-line) > in the *Annotate* buffer on the earliest (initial) revision fails with: > > Debugger entered--Lisp error: (error "Invalid argument to vc-annotate= -warp-revision") > signal(error ("Invalid argument to vc-annotate-warp-revision")) > error("Invalid argument to vc-annotate-warp-revision") > vc-annotate-warp-revision(nil "...") This is now fixed. Another problem is that =E2=80=98vc-root-version-diff=E2=80=99 can't be u= sed when fileset is not available. But this command doesn't use fileset, it uses the root directory, so this patch adds an optional arg =E2=80=98fileset=E2=80=99 to =E2=80=98vc-diff-build-argument-list-int= ernal=E2=80=99, so =E2=80=98vc-root-version-diff=E2=80=99 can provide its own fake filese= t with the root directory: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-diff-build-argument-list-internal.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index aae21ec45a..0a638ec7d7 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1762,9 +1762,9 @@ vc-read-revision nil nil initial-input 'vc-revision-history default) (read-string prompt initial-input nil default)))) -(defun vc-diff-build-argument-list-internal () +(defun vc-diff-build-argument-list-internal (&optional fileset) "Build argument list for calling internal diff functions." - (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: why t? --Stef + (let* ((vc-fileset (or fileset (vc-deduce-fileset t))) ;FIXME: why t? --Stef (files (cadr vc-fileset)) (backend (car vc-fileset)) (first (car files)) @@ -1815,7 +1815,11 @@ vc-version-diff ;;;###autoload (defun vc-root-version-diff (_files rev1 rev2) "Report diffs between REV1 and REV2 revisions of the whole tree." - (interactive (vc-diff-build-argument-list-internal)) + (interactive + (vc-diff-build-argument-list-internal + (or (ignore-errors (vc-deduce-fileset t)) + (let ((backend (or (vc-deduce-backend) (vc-responsible-backend default-directory)))) + (list backend (list (vc-call-backend backend 'root default-directory))))))) ;; This is a mix of `vc-root-diff' and `vc-version-diff' (when (and (not rev1) rev2) (error "Not a valid revision range")) --=-=-=-- From unknown Mon Jun 23 07:50:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#34532: closed (Re: bug#34532: Unhandled errors in vc) Message-ID: References: <87lg1aedlc.fsf@mail.linkov.net> <87mumssrpz.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 34532 X-Gnu-PR-Package: emacs Reply-To: 34532@debbugs.gnu.org Date: Tue, 19 Mar 2019 21:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1553032442-25644-1" This is a multi-part message in MIME format... ------------=_1553032442-25644-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #34532: Unhandled errors in vc which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 34532@debbugs.gnu.org. --=20 34532: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34532 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1553032442-25644-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 34532-done) by debbugs.gnu.org; 19 Mar 2019 21:53:28 +0000 Received: from localhost ([127.0.0.1]:51003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6Mfn-0006er-JL for submit@debbugs.gnu.org; Tue, 19 Mar 2019 17:53:27 -0400 Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:7599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6Mfj-0006ee-7g for 34532-done@debbugs.gnu.org; Tue, 19 Mar 2019 17:53:26 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8CB3A5C47E8 for <34532-done@debbugs.gnu.org>; Tue, 19 Mar 2019 21:53:19 +0000 (UTC) Received: from pdx1-sub0-mail-a70.g.dreamhost.com (unknown [100.96.20.50]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2772F5C554B for <34532-done@debbugs.gnu.org>; Tue, 19 Mar 2019 21:53:19 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a70.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 19 Mar 2019 21:53:19 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Attack-Coil: 67609a0c4ed04844_1553032399350_105318376 X-MC-Loop-Signature: 1553032399349:3796166905 X-MC-Ingress-Time: 1553032399349 Received: from pdx1-sub0-mail-a70.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTP id 9000D80651 for <34532-done@debbugs.gnu.org>; Tue, 19 Mar 2019 14:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=u+5xNa QnrWNFXhtY1Rl9759HKVs=; b=cBP/A86puTN5Wgp1+r1kcox25UdoiJsomAa+Rb GoaMprlkWoZJhSweLwoH1VlP1amG05gwafhS4NTLHmxNJ7isqwCjjHhg34lnBmZI gQy7l9C82r7lataEkrL3DRQi3ReHpNzlozxSc1Ahl+wlIX1ERWRaZi1qB76P6VTZ 1nsBo= Received: from mail.jurta.org (m91-129-106-13.cust.tele2.ee [91.129.106.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTPSA id 2323780641 for <34532-done@debbugs.gnu.org>; Tue, 19 Mar 2019 14:53:16 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a70 From: Juri Linkov To: 34532-done@debbugs.gnu.org Subject: Re: bug#34532: Unhandled errors in vc Organization: LINKOV.NET References: <87mumssrpz.fsf@mail.linkov.net> <87zhqhszf6.fsf@mail.linkov.net> Date: Tue, 19 Mar 2019 23:52:47 +0200 In-Reply-To: <87zhqhszf6.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 27 Feb 2019 23:20:35 +0200") Message-ID: <87lg1aedlc.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrieeggdduheejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdeirddufeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdeirddufedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopeefgeehfedvqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34532-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > This is now fixed. > > Another problem is that =E2=80=98vc-root-version-diff=E2=80=99 can't be= used when > fileset is not available. But this command doesn't use fileset, > it uses the root directory, so this patch adds an optional > arg =E2=80=98fileset=E2=80=99 to =E2=80=98vc-diff-build-argument-list-i= nternal=E2=80=99, > so =E2=80=98vc-root-version-diff=E2=80=99 can provide its own fake file= set > with the root directory: Fixed as well. ------------=_1553032442-25644-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Feb 2019 21:41:05 +0000 Received: from localhost ([127.0.0.1]:53306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvqev-0008Ue-43 for submit@debbugs.gnu.org; Mon, 18 Feb 2019 16:41:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvqet-0008Tw-4H for submit@debbugs.gnu.org; Mon, 18 Feb 2019 16:41:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:48400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gvqen-0005EF-7c for submit@debbugs.gnu.org; Mon, 18 Feb 2019 16:40:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvqem-0006vs-BA for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2019 16:40:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvqeg-0005Cc-Ek for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2019 16:40:54 -0500 Received: from bird.maple.relay.mailchannels.net ([23.83.214.17]:56578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gvqeZ-0005AK-Ju for bug-gnu-emacs@gnu.org; Mon, 18 Feb 2019 16:40:45 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 698D23E503A for ; Mon, 18 Feb 2019 21:40:35 +0000 (UTC) Received: from pdx1-sub0-mail-a49.g.dreamhost.com (unknown [100.96.33.121]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1FC493E47B2 for ; Mon, 18 Feb 2019 21:40:35 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a49.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Mon, 18 Feb 2019 21:40:35 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Cellar-Continue: 375b6dbb2fe89ddc_1550526035225_4086277830 X-MC-Loop-Signature: 1550526035224:2455555261 X-MC-Ingress-Time: 1550526035224 Received: from pdx1-sub0-mail-a49.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTP id B95847F5FA for ; Mon, 18 Feb 2019 13:40:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=lKxzYlORofSpPssECwclYT1kGCY=; b=dSe2eDd5jyDRJ8Etk 0JVqunsoL+pAxOp0u4s/x9XOs9qPL/LtPRVPd9RGGKAw6HyubB/LJVa6mu5OegzA g30X0INY1U6MKpYI2/KXr+tm84mN5jkrf9osnqY+mi3/1+1KDqDsrZAUfiCIBOwh CDo1kfh7ep3BBCOneY5mKh+qvQ= Received: from mail.jurta.org (m91-129-96-50.cust.tele2.ee [91.129.96.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTPSA id 8BD0E7F1DE for ; Mon, 18 Feb 2019 13:40:32 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a49 From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Unhandled errors in vc Organization: LINKOV.NET Date: Mon, 18 Feb 2019 23:37:44 +0200 Message-ID: <87mumssrpz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrtddugdduvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohffkfgfgggtsehmtderredtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirdehtdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrhedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 23.83.214.17 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable After =E2=80=98C-x v g=E2=80=99 (vc-annotate) typing =E2=80=98a=E2=80=99 = (vc-annotate-revision-previous-to-line) in the *Annotate* buffer on the earliest (initial) revision fails with: Debugger entered--Lisp error: (error "Invalid argument to vc-annotate-w= arp-revision") signal(error ("Invalid argument to vc-annotate-warp-revision")) error("Invalid argument to vc-annotate-warp-revision") vc-annotate-warp-revision(nil "...") This patch provides a nicer message: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-annotate.el.patch diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el index 86fc8686c3..84838135fc 100644 --- a/lisp/vc/vc-annotate.el +++ b/lisp/vc/vc-annotate.el @@ -541,7 +541,9 @@ vc-annotate-revision-previous-to-line (setq prev-rev (vc-call-backend vc-annotate-backend 'previous-revision fname rev)) - (vc-annotate-warp-revision prev-rev fname))))) + (if (not prev-rev) + (message "No previous revisions") + (vc-annotate-warp-revision prev-rev fname)))))) (defvar log-view-vc-backend) (defvar log-view-vc-fileset) --=-=-=-- ------------=_1553032442-25644-1--