GNU bug report logs - #34531
Guix profile fails on Overdrive 1000

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34531 <at> debbugs.gnu.org, Andreas Enge <andreas <at> enge.fr>
Subject: bug#34531: Guix profile fails on Overdrive 1000
Date: Sun, 24 Feb 2019 13:12:07 +0100

[Message part 1 (text/plain, inline)]

Hi Ricardo,

On Sun, 24 Feb 2019 12:45:34 +0100
Ricardo Wurmus <rekado <at> elephly.net> wrote:

> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
> 
> > Final version attached.  Works fine now.  
> 
> The loop looks a bit more complicated than it needs to be, I think.  Did
> my version not work for you?

It did, but I wanted to make sure the port did exactly the same as the
original generate.py--maybe I overdid it, but I didn't want to break it
by porting it.

What skip_comments in the original does is strip comments, but not strip
"comment-like things" that are in string literals ("/*blah*/").
(as far as I can tell, at least)

I agree your version is easier but does it do the same thing?

Attached a v2 where I fixed a bug in literal handling related to that (oops).

WDYT?

[generate.scm (text/x-scheme, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.