GNU bug report logs - #34523
Add tetrinet

Previous Next

Full log

View this message in rfc822 format

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: pkill9 <at> runbox.com
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 34523 <at> debbugs.gnu.org
Subject: [bug#34523] Add tetrinet
Date: Mon, 18 Feb 2019 15:11:37 +0100

pkill -9, Ricardo,

Ricardo Wurmus wrote:
> pkill9 <at> runbox.com writes:
>> +     `(#:tests? #f ; No tests.

Only nitpicks:

+     `(#:tests? #f                      ; no tests

If you're using emacs, running C-M-q on the whole definition will 
automatically indent your code.  There's a way to do the same 
without emacs, but I forget how.

>> +       #:phases (modify-phases %standard-phases
>> +                  (delete 'configure)

+                  (delete 'configure)   ; no configure script

>> +                  (add-after 'unpack 'fix-install-dir
>> +                    (lambda* (#:key outputs 
>> #:allow-other-keys)
>> +                      (let ((out (assoc-ref outputs "out")))
>> +                        (mkdir-p (string-append out "/bin"))
>> +                        (substitute* "Makefile"
>> +                          (("/usr/games") (string-append out 
>> "/bin")))))))))
>
> Can this patching be avoided by passing a make flag instead?

Nope, it's hard-coded in the Makefile target :-(

Considering the lack of a man(ual) page, how about adding 
something like:

 (add-after 'install 'install-documentation
   (lambda* (#:key outputs #:allow-other-keys)
     (let* ((out (assoc-ref outputs "out"))
            (doc (string-append out "/share/doc/"
                                ,name "-" ,version)))
       (for-each (lambda (file)
                   (install-file file doc))
                 (list "README" "tetrinet.txt"))
       #t))))))

Thanks!

T G-R

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.