Subject: [bug#34515] [PATCH 13/13] gnu: Add Magic-Wormhole.

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 18 Feb 2019 09:51:11 +0100

Leo Famulari <[email-masked]> writes:

> * gnu/packages/magic-wormhole.scm (magic-wormhole): New variable.
[…]
> +         ;; XXX I can't figure out how to build the docs properly.
> +         (add-after 'install 'install-docs
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (man (string-append out "/share/man/man1")))
> +               (install-file "docs/wormhole.1" man))
> +             #t)))))

What does it mean to build them properly?  Should anything besides the
man pages be built?

> +    (native-inputs
> +     `(("python-mock" ,python-mock)
> +       ;; XXX These are required for the test suite but end up being referenced
> +       ;; by the built package.
> +       ("magic-wormhole-mailbox-server" ,magic-wormhole-mailbox-server)
> +       ("magic-wormhole-transit-relay" ,magic-wormhole-transit-relay)))

Are they not supposed to be referenced by the built package?
If they are supposed to be used by the built package is it enough to
have them as inputs and not as propagated inputs?

> +    (description "Magic-Wormhole is a library and a command-line tool named
> +wormhole, which makes it possible to securely transfer arbitrary-sized files and
> +directories (or short pieces of text) from one computer to another.  The two
> +endpoints are identified by using identical \"wormhole codes\": in general, the
> +sending machine generates and displays the code, which must then be typed into
> +the receiving machine.
> +
> +The codes are short and human-pronounceable, using a phonetically-distinct
> +wordlist.  The receiving side offers tab-completion on the codewords, so usually
> +only a few characters must be typed.  Wormhole codes are single-use and do not
> +need to be memorized.")

Neat!

LGTM.  Thank you for this patch set!

-- 
Ricardo