Subject: Re: [bug#34515] [PATCH 11/13] gnu: Add magic-wormhole-mailbox-server.

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 18 Feb 2019 09:44:27 +0100

Leo Famulari <[email-masked]> writes:

> * gnu/packages/magic-wormhole.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

Okay.

> +    (arguments
> +      ;; Tests seem to be Python 2 only...
> +      ;; "TypeError: a bytes-like object is required, not 'str'"
> +     '(#:tests? #f))

This seems to be a problem with Python 3.7.  Scons suffers from the same
problem.

Could it be that the tests use the “imp” module?  If so they might be
fixed by using importlib instead.

> +    (synopsis "Magic-Wormhole central server")

Maybe “Magic-Wormhole central mailbox server”?

LGTM!

--
Ricardo