GNU bug report logs - #34514
[PATCH 00/34] Add more Ruby gems, some Rails related

Previous Next

Full log

Message #158 received at 34514 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34514 <at> debbugs.gnu.org
Subject: Re: [bug#34514] [PATCH 06/34] gnu: Add ruby-jwt.
Date: Sat, 02 Mar 2019 12:34:00 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/packages/ruby.scm (ruby-jwt): New variable.
>> ---
>>  gnu/packages/ruby.scm | 37 +++++++++++++++++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>>
>> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
>> index b17a03e7cc..5b4d52ac4a 100644
>> --- a/gnu/packages/ruby.scm
>> +++ b/gnu/packages/ruby.scm
>> @@ -3952,6 +3952,43 @@ a native C extension.")
>>      (home-page "https://flori.github.com/json")
>>      (license license:ruby)))
>>
>> +(define-public ruby-jwt
>> +  (package
>> +    (name "ruby-jwt")
>> +    (version "2.1.0")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (rubygems-uri "jwt" version))
>> +       (sha256
>> +        (base32
>> +         "1w0kaqrbl71cq9sbnixc20x5lqah3hs2i93xmhlfdg2y3by7yzky"))))
>> +    (build-system ruby-build-system)
>> +    (arguments
>> +     '(#:test-target "test"
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'remove-unnecessary-dependencies
>> +           (lambda _
>> +             (substitute* "spec/spec_helper.rb"
>> +               (("require 'simplecov.*") "\n")
>> +               ;; Use [].each to disable running the SimpleCov configuration
>> +               ;; block
>> +               (("SimpleCov\\.configure") "[].each")
>> +               (("require 'codeclimate-test-reporter'") "")
>> +               (("require 'codacy-coverage'") "")
>> +               (("Codacy::Reporter\\.start") "")))))))
>
> Please end this lambda with #T.

Good spot, I'll add #t.

>> +     "This package provides a pure Ruby implementation of the RFC 7519 OAuth
>> +@acronym{JWT, JSON Web Token} standard.")
>
> If ’guix lint’ doesn’t complain about the use of @acronym (I’ve never
> used it in a description) it’s all good.

Yep, it seems to be fine with it :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.