GNU bug report logs - #34514
[PATCH 00/34] Add more Ruby gems, some Rails related

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34514 <at> debbugs.gnu.org
Subject: [bug#34514] [PATCH 03/34] gnu: Add ruby-terraform.
Date: Tue, 19 Feb 2019 22:43:55 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/packages/ruby.scm (ruby-terraform): New variable.
> […]
>> +(define-public ruby-terraform
>> +  (package
>> +  (name "ruby-terraform")
>> +  (version "0.20.0")
>> +  (source
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (rubygems-uri "ruby-terraform" version))
>> +      (sha256
>> +        (base32
>> +          "1czpak24v570ysnk8waj1sblfm1vqh1sdwh934x4ai90ribhlbzf"))))
>
> The indentation isn’t right here.

Good spot, I've fixed this now.

>> +  (build-system ruby-build-system)
>> +  (arguments
>> +   '(;; No included tests
>> +     #:tests? #f))
>
> Could you please put this all on one line?

Ok. I've taken to putting the comment inline, as this is syntactically
next to the #:tests? argument and this makes it easier to add additional
arguments, as you don't have to shuffle the comment around. I'm happy to
just put it inline though.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.