GNU bug report logs - #34514
[PATCH 00/34] Add more Ruby gems, some Rails related

Previous Next

Full log

Message #110 received at 34514 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 34514 <at> debbugs.gnu.org
Subject: Re: [bug#34514] [PATCH 01/34] gnu: Add ruby-hamster.
Date: Mon, 18 Feb 2019 23:40:53 +0100

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/ruby.scm (ruby-hamster): New variable.
[…]
> +       (add-after 'unpack 'remove-unnecessary-dependencies
> +         (lambda _
> +           ;; pry is a debugging tool, and is unnecessary when running the
> +           ;; tests
> +           (substitute* "spec/lib/hamster/vector/insert_spec.rb"
> +             (("require 'pry'") ""))
> +           (substitute* "spec/spec_helper.rb"
> +             (("require \"pry\"") "")

We have a ruby-pry package.  Wouldn’t it be nicer to add it instead of
patching the sources?

> +             ;; CodeClimate is an online service, and is unnecessary for
> +             ;; running the tests
> +             (("require \"codeclimate-test-reporter\"") "")
> +             (("CodeClimate.*\n") ""))

Okay.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.