GNU bug report logs - #34497
Add odamex

Previous Next

Full log

View this message in rfc822 format

From: <pkill9 <at> runbox.com>
To: "Ricardo Wurmus" <rekado <at> elephly.net>
Cc: 34497 <34497 <at> debbugs.gnu.org>, Efraim Flashner <efraim <at> flashner.co.il>
Subject: [bug#34497] Add odamex
Date: Thu, 21 Feb 2019 13:04:51 +0000 (GMT)

[Message part 1 (text/plain, inline)]

Here is an updated patch.

On Wed, 20 Feb 2019 21:47:00 +0100, Ricardo Wurmus <rekado <at> elephly.net> wrote:

> 
> Hi pkill9,
> 
> > * gnu/packages/games.scm (odamex): New variable.
> […]
> > +       (uri (string-append
> > +             "mirror://sourceforge/odamex/Odamex/"
> > +             version
> > +             "/odamex-src-"
> > +             version
> > +             ".tar.gz"))
> 
> Please put this on fewer lines.
> 
> > +       (sha256
> > +        (base32
> > +         "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
> > +    (build-system cmake-build-system)
> > +    (arguments `(#:tests? #f)) ;; No tests
> 
> Please use just one semicolon.
> 
> > +    (inputs
> > +     `(("sdl" ,(@ (gnu packages sdl) sdl))
> > +       ("sdl-mixer" ,(@ (gnu packages sdl) sdl-mixer))
> > +       ("zlib" ,(@ (gnu packages compression) zlib))
> > +       ("libpng" ,(@ (gnu packages image) libpng))
> > +       ("alsa-lib" ,(@ (gnu packages linux) alsa-lib))))
> 
> This is not okay.  Please just use the plain variable names.
> 
> > +    (home-page "https://odamex.net/")
> > +    (synopsis "Multiplayer Doom port")
> > +    (description "Odamex is a free, cross-platform modification of the Doom
> > +engine that allows players to easily join servers dedicated to playing Doom
> > +online.")
> 
> Please remove “free” — all software in Guix is Free Software.
> 
> > +    (license license:gpl2)))
> 
> Looks like this is actually gpl2+ as evidenced by files like this:
> 
>     https://github.com/odamex/odamex/blob/master/server/src/d_netinfo.cpp#L12
> 
> Could you please send an updated patch?
> 
> -- 
> Ricardo

[0001-gnu-Add-odamex.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.