From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 15 13:24:12 2019 Received: (at submit) by debbugs.gnu.org; 15 Feb 2019 18:24:12 +0000 Received: from localhost ([127.0.0.1]:49778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gui9k-0000w2-E0 for submit@debbugs.gnu.org; Fri, 15 Feb 2019 13:24:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gui9h-0000vp-VX for submit@debbugs.gnu.org; Fri, 15 Feb 2019 13:24:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:52862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gui9c-0003VR-0H for submit@debbugs.gnu.org; Fri, 15 Feb 2019 13:24:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gui9b-0008Hr-9H for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2019 13:24:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gui9a-0003Tu-IT for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2019 13:24:03 -0500 Received: from mail231c50.megamailservers.eu ([91.136.10.241]:53996 helo=mail37c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gui9Z-0003Qb-Vo for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2019 13:24:02 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1550255039; bh=7UmGRP0xspsdwVJlB168r9FO+5mkgWyXVqpbeYkOgmc=; h=From:Subject:Date:To:From; b=TmySxn0l9z8uKky7VcLUNmNYBIlgh8Ej1kf1PjwhFrYTZXLVk1nZDOLvH5TOKKRoa 0U56sHrBsq3nsz7L2fgvwcKqusWAPBRPy6HiLnbctDKta5orSSIRjNoxWeZGRNmY8Q oY2KCr9GYrzdCj265f9Koj9ZvRqkJCT8abAzCUm0= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c83-251-8-17.bredband.comhem.se [83.251.8.17]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x1FINuFU000977 for ; Fri, 15 Feb 2019 18:23:59 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: rx: ASCII-raw byte ranges comprise all of Unicode Message-Id: Date: Fri, 15 Feb 2019 19:23:56 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B0204.5C6703BF.0030, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=J+uEEjvS c=1 sm=1 tr=0 a=NAHmi3I8mP0S/Y8gRKeQyA==:117 a=NAHmi3I8mP0S/Y8gRKeQyA==:17 a=IkcTkHD0fZMA:10 a=aFYkK34zXO-9mYGBXWIA:9 a=QEXdDO2ut3YA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.241 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) `rx' incorrectly considers character ranges between ASCII and raw bytes = to cover all codes in-between, which includes all non-ASCII Unicode = chars. This causes (any "\000-\377" ?=C3=85) to be simplified to (any = "\000-\377"), which is not at all the same thing: [\000-\377] really = means [\000-\177\200-\377] -- the transformation is normally made by the = Emacs regexp engine. The two ranges are not contiguous on the character = code level. It's a sleeper bug that was awakened by my fixing bug#33205, so I'm to = blame for not checking this. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 15 13:29:35 2019 Received: (at 34492) by debbugs.gnu.org; 15 Feb 2019 18:29:35 +0000 Received: from localhost ([127.0.0.1]:49787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guiEx-00014O-EI for submit@debbugs.gnu.org; Fri, 15 Feb 2019 13:29:35 -0500 Received: from mail154c50.megamailservers.eu ([91.136.10.164]:56076 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guiEw-00014E-0B for 34492@debbugs.gnu.org; Fri, 15 Feb 2019 13:29:34 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1550255371; bh=4X2nKlGETbsxxTj205YZ8/OwVF40N4/wRUAF/jXcM6E=; h=From:Subject:Date:References:To:In-Reply-To:From; b=CiKZhcJ6AlAAlHkp+ZIU9nUzVW9MIfYzbV36BcZEmBuNu27tZWmcCfmGg/dYz0N5C YTXL4Vv/rDma2mB1UeNK06IKErI+SsjJUpLrK0yGHciUDk4KrvQ/6+zVDKSqFBJvTD V5yK4Viw4YOx3t4/XmqAOk2PEdZiXJhllwPxwRUg= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c83-251-8-17.bredband.comhem.se [83.251.8.17]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x1FITTcl030272 for <34492@debbugs.gnu.org>; Fri, 15 Feb 2019 18:29:31 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_FAFA7525-D146-4730-BC43-1F7B3A70EBF9" Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: bug#34492: Acknowledgement (rx: ASCII-raw byte ranges comprise all of Unicode) Date: Fri, 15 Feb 2019 19:29:28 +0100 References: To: 34492@debbugs.gnu.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B0203.5C67050B.005A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=a4UeC3aF c=1 sm=1 tr=0 a=NAHmi3I8mP0S/Y8gRKeQyA==:117 a=NAHmi3I8mP0S/Y8gRKeQyA==:17 a=Z2r6JAP30GX68kRhCWMA:9 a=CjuIK1q_8ugA:10 a=6GrPJ2433-pt5zGezrkA:9 a=B2y7HmGcmWMA:10 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34492 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_FAFA7525-D146-4730-BC43-1F7B3A70EBF9 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Patch. --Apple-Mail=_FAFA7525-D146-4730-BC43-1F7B3A70EBF9 Content-Disposition: attachment; filename=0001-Prevent-over-eager-rx-character-range-condensation.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Prevent-over-eager-rx-character-range-condensation.patch" Content-Transfer-Encoding: quoted-printable =46rom=2039a593336d00c3418f52fbe205b4dc284e8b65ce=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Fri,=2015=20Feb=202019=2019:27:48=20+0100=0A= Subject:=20[PATCH]=20Prevent=20over-eager=20rx=20character=20range=20= condensation=0AMIME-Version:=201.0=0AContent-Type:=20text/plain;=20= charset=3DUTF-8=0AContent-Transfer-Encoding:=208bit=0A=0A`rx'=20= incorrectly=20considers=20character=20ranges=20between=20ASCII=20and=20= raw=20bytes=20to=0Acover=20all=20codes=20in-between,=20which=20includes=20= all=20non-ASCII=20Unicode=20chars.=0AThis=20causes=20(any=20"\000-\377"=20= ?=C3=85)=20to=20be=20simplified=20to=20(any=20"\000-\377"),=0Awhich=20is=20= not=20at=20all=20the=20same=20thing:=20[\000-\377]=20really=20means=0A= [\000-\177\200-\377]=20(Bug#34492).=0A=0A*=20lisp/emacs-lisp/rx.el=20= (rx-any-condense-range):=20Split=20ranges=20going=0Afrom=20ASCII=20to=20= raw=20bytes.=0A*=20test/lisp/emacs-lisp/rx-tests.el=20= (rx-char-any-raw-byte):=20Add=20test=20case.=0A---=0A=20= lisp/emacs-lisp/rx.el=20=20=20=20=20=20=20=20=20=20=20=20|=207=20+++++++=0A= =20test/lisp/emacs-lisp/rx-tests.el=20|=206=20+++++-=0A=202=20files=20= changed,=2012=20insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/emacs-lisp/rx.el=20b/lisp/emacs-lisp/rx.el=0Aindex=20= b2299030a1..715cd608c4=20100644=0A---=20a/lisp/emacs-lisp/rx.el=0A+++=20= b/lisp/emacs-lisp/rx.el=0A@@=20-429,6=20+429,13=20@@=20Only=20both=20= edges=20of=20each=20range=20is=20checked."=0A=20=20=20=20=20;;=20set=20L=20= list=20of=20all=20ranges=0A=20=20=20=20=20(mapc=20(lambda=20(e)=20(cond=20= ((stringp=20e)=20(push=20e=20str))=0A=20=09=09=09=20=20=20=20((numberp=20= e)=20(push=20(cons=20e=20e)=20l))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Ranges=20between=20= ASCII=20and=20raw=20bytes=20are=20split,=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20to=20prevent=20= accidental=20inclusion=20of=20Unicode=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20characters=20= later=20on.=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20((and=20(<=3D=20(car=20e)=20#x7f)=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(>=3D=20(cdr=20e)=20#x3fff80))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(push=20= (cons=20(car=20e)=20#x7f)=20l)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(push=20(cons=20#x3fff80=20= (cdr=20e))=20l))=0A=20=09=09=09=20=20=20=20(t=20(push=20e=20l))))=0A=20=09= =20=20args)=0A=20=20=20=20=20;;=20condense=20overlapped=20ranges=20in=20= L=0Adiff=20--git=20a/test/lisp/emacs-lisp/rx-tests.el=20= b/test/lisp/emacs-lisp/rx-tests.el=0Aindex=20f15e1016f7..e14feda347=20= 100644=0A---=20a/test/lisp/emacs-lisp/rx-tests.el=0A+++=20= b/test/lisp/emacs-lisp/rx-tests.el=0A@@=20-53,7=20+53,11=20@@=0A=20=20=20= ;;=20Range=20of=20raw=20characters,=20multibyte.=0A=20=20=20(should=20= (equal=20(string-match-p=20(rx=20(any=20"=C3=85\211\326-\377\177"))=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20"XY\355\177\327")=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=202)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=202))=0A+=20=20;;=20Split=20range;=20\177-\377=C3=BF=20should=20not=20= be=20optimised=20to=20\177-\377.=0A+=20=20(should=20(equal=20= (string-match-p=20(rx=20(any=20"\177-\377"=20?=C3=BF))=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20"=C3=BFA\310B")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=200)))=0A=20=0A=20(ert-deftest=20rx-pcase=20()=0A=20=20=20(should=20= (equal=20(pcase=20"a=201=202=203=201=201=20b"=0A--=20=0A2.17.2=20(Apple=20= Git-113)=0A=0A= --Apple-Mail=_FAFA7525-D146-4730-BC43-1F7B3A70EBF9-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 02:21:00 2019 Received: (at 34492) by debbugs.gnu.org; 16 Feb 2019 07:21:00 +0000 Received: from localhost ([127.0.0.1]:49963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guuHS-0002um-U0 for submit@debbugs.gnu.org; Sat, 16 Feb 2019 02:20:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guuHQ-0002ua-Ru for 34492@debbugs.gnu.org; Sat, 16 Feb 2019 02:20:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guuHI-0005gC-1m; Sat, 16 Feb 2019 02:20:49 -0500 Received: from [176.228.60.248] (port=4791 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1guuHH-0000uT-Qa; Sat, 16 Feb 2019 02:20:47 -0500 Date: Sat, 16 Feb 2019 09:20:48 +0200 Message-Id: <83a7iwmc6n.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-reply-to: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Fri, 15 Feb 2019 19:29:28 +0100) Subject: Re: bug#34492: Acknowledgement (rx: ASCII-raw byte ranges comprise all of Unicode) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34492 Cc: 34492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Mattias Engdegård > Date: Fri, 15 Feb 2019 19:29:28 +0100 > > Patch. Thanks, this LGTM, but I think this should be in NEWS. It's arguably a bug, but only arguably, and it changes user-visible behavior. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 03:08:20 2019 Received: (at 34492) by debbugs.gnu.org; 16 Feb 2019 08:08:20 +0000 Received: from localhost ([127.0.0.1]:49980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guv1H-00042y-2Y for submit@debbugs.gnu.org; Sat, 16 Feb 2019 03:08:20 -0500 Received: from mail237c50.megamailservers.eu ([91.136.10.247]:35920 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guv1D-00042m-Jj for 34492@debbugs.gnu.org; Sat, 16 Feb 2019 03:08:17 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1550304493; bh=O5TnoR6IvS+tpTS/SW+9X18qs1S3Y5pFxSF5CgG9c5w=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=d6bHEyhn36c31TQOtxecAd5fICxa85wwUnFVbtWc4DDJGYqUNyVhNG2zJcBtZ6lDy Z7CdWQjXjkeFfWXvRLKHaPnWzVt2Sb0Nh5xiZ2TkSqgp/9/7acVp7WKa/SU9B/UF0f V5Uk9zUr4nVhET2M08Xx0xalLelh89d5kslo7Wls= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c83-251-8-17.bredband.comhem.se [83.251.8.17]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x1G88Bxk017699; Sat, 16 Feb 2019 08:08:13 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: bug#34492: Acknowledgement (rx: ASCII-raw byte ranges comprise all of Unicode) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83a7iwmc6n.fsf@gnu.org> Date: Sat, 16 Feb 2019 09:08:11 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <81D26A8A-9C0B-4868-91F9-B9695999DBBE@acm.org> References: <83a7iwmc6n.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B020C.5C67C4ED.0060, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=EarmvsuC c=1 sm=1 tr=0 a=NAHmi3I8mP0S/Y8gRKeQyA==:117 a=NAHmi3I8mP0S/Y8gRKeQyA==:17 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=Autm5cQGgp3vbe8TB8QA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34492 Cc: 34492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 16 feb. 2019 kl. 08.20 skrev Eli Zaretskii : >=20 > Thanks, this LGTM, but I think this should be in NEWS. It's arguably > a bug, but only arguably, and it changes user-visible behavior. I'll be happy to write a NEWS item, but for what? The change of bug = #33205, or this change, which is not visible unless the other change is = already applied (and it hasn't made it into a release yet)? If you mean the #33205 fix, it might result in something like the = following: ** `rx' now handles raw bytes in character alternatives correctly when given in a string. Previously, `(any "\x80-\xff")' would match = characters U+0080...U+00FF. Now the expression matches raw bytes in the 128...255 = range, as expected. Is that what you had in mind? If so, in what subsection would it go? * Changes in Specialized Modes and Packages * Incompatible Lisp Changes * Lisp Changes From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 05:15:07 2019 Received: (at 34492) by debbugs.gnu.org; 16 Feb 2019 10:15:07 +0000 Received: from localhost ([127.0.0.1]:50006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guwzy-0006zC-Nr for submit@debbugs.gnu.org; Sat, 16 Feb 2019 05:15:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guwzw-0006yQ-SC for 34492@debbugs.gnu.org; Sat, 16 Feb 2019 05:15:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guwzr-0006rg-DV; Sat, 16 Feb 2019 05:14:59 -0500 Received: from [176.228.60.248] (port=3866 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1guwzr-0004JU-2E; Sat, 16 Feb 2019 05:14:59 -0500 Date: Sat, 16 Feb 2019 12:14:57 +0200 Message-Id: <831s48m44e.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-reply-to: <81D26A8A-9C0B-4868-91F9-B9695999DBBE@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sat, 16 Feb 2019 09:08:11 +0100) Subject: Re: bug#34492: Acknowledgement (rx: ASCII-raw byte ranges comprise all of Unicode) References: <83a7iwmc6n.fsf@gnu.org> <81D26A8A-9C0B-4868-91F9-B9695999DBBE@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34492 Cc: 34492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Mattias Engdegård > Date: Sat, 16 Feb 2019 09:08:11 +0100 > Cc: 34492@debbugs.gnu.org > > 16 feb. 2019 kl. 08.20 skrev Eli Zaretskii : > > > > Thanks, this LGTM, but I think this should be in NEWS. It's arguably > > a bug, but only arguably, and it changes user-visible behavior. > > I'll be happy to write a NEWS item, but for what? The change of bug #33205, or this change, which is not visible unless the other change is already applied (and it hasn't made it into a release yet)? I mean both. > If you mean the #33205 fix, it might result in something like the following: > > ** `rx' now handles raw bytes in character alternatives correctly when > given in a string. Previously, `(any "\x80-\xff")' would match characters > U+0080...U+00FF. Now the expression matches raw bytes in the 128...255 range, > as expected. > > Is that what you had in mind? Yes. > If so, in what subsection would it go? Either make a new section for rx under "Changes in Specialized Modes and Packages", or put it under "Incompatible Lisp Changes". Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 06:05:15 2019 Received: (at 34492) by debbugs.gnu.org; 16 Feb 2019 11:05:15 +0000 Received: from localhost ([127.0.0.1]:50022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guxmV-0008AL-Cl for submit@debbugs.gnu.org; Sat, 16 Feb 2019 06:05:15 -0500 Received: from mail222c50.megamailservers.eu ([91.136.10.232]:59540 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guxmT-0008AA-3w for 34492@debbugs.gnu.org; Sat, 16 Feb 2019 06:05:14 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1550315111; bh=uzveUQwYwWJl1lkKzZjpRZbW/zSSq5XG7cZ9DbNSBQo=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=MYC4s2rAIq5Wl3apxlt8Iff/+87C+VtjRmP6/vYSs59pZV8WilLEoWYD5xw4+6BrO u2Jpk1bFEACVxVfYd6ur5K21jSasIsK+uT9wC26VHzyKLOBCdPdr8lg6U67/NZHyG2 /h4v3xW/8Oaz3SCB/SY2swtYpzIewxrma8yYwbYs= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c83-251-8-17.bredband.comhem.se [83.251.8.17]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x1GB59w5002423; Sat, 16 Feb 2019 11:05:11 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_4D86E417-EA53-4808-9AC0-6D0D3CDA93AD" Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: bug#34492: Acknowledgement (rx: ASCII-raw byte ranges comprise all of Unicode) Date: Sat, 16 Feb 2019 12:05:09 +0100 In-Reply-To: <831s48m44e.fsf@gnu.org> To: Eli Zaretskii References: <83a7iwmc6n.fsf@gnu.org> <81D26A8A-9C0B-4868-91F9-B9695999DBBE@acm.org> <831s48m44e.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B0209.5C67EE67.003C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=fZaDNXYF c=1 sm=1 tr=0 a=NAHmi3I8mP0S/Y8gRKeQyA==:117 a=NAHmi3I8mP0S/Y8gRKeQyA==:17 a=mDV3o1hIAAAA:8 a=9wuvkdbEPJmABLsTOpMA:9 a=CjuIK1q_8ugA:10 a=kLlZNtOeHvVIu2fArTsA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34492 Cc: 34492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_4D86E417-EA53-4808-9AC0-6D0D3CDA93AD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 16 feb. 2019 kl. 11.14 skrev Eli Zaretskii : >=20 > Either make a new section for rx under "Changes in Specialized Modes > and Packages", or put it under "Incompatible Lisp Changes". I picked the former --- thanks for reviewing. Since it's my first change to NEWS, I'm attaching the modified patch = here for a final look. --Apple-Mail=_4D86E417-EA53-4808-9AC0-6D0D3CDA93AD Content-Disposition: attachment; filename=0001-Prevent-over-eager-rx-character-range-condensation.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Prevent-over-eager-rx-character-range-condensation.patch" Content-Transfer-Encoding: quoted-printable =46rom=20b3e549114ab705d3efd866adea6a0cce76febb49=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Fri,=2015=20Feb=202019=2019:27:48=20+0100=0A= Subject:=20[PATCH]=20Prevent=20over-eager=20rx=20character=20range=20= condensation=0AMIME-Version:=201.0=0AContent-Type:=20text/plain;=20= charset=3DUTF-8=0AContent-Transfer-Encoding:=208bit=0A=0A`rx'=20= incorrectly=20considers=20character=20ranges=20between=20ASCII=20and=20= raw=20bytes=20to=0Acover=20all=20codes=20in-between,=20which=20includes=20= all=20non-ASCII=20Unicode=20chars.=0AThis=20causes=20(any=20"\000-\377"=20= ?=C3=85)=20to=20be=20simplified=20to=20(any=20"\000-\377"),=0Awhich=20is=20= not=20at=20all=20the=20same=20thing:=20[\000-\377]=20really=20means=0A= [\000-\177\200-\377]=20(Bug#34492).=0A=0A*=20lisp/emacs-lisp/rx.el=20= (rx-any-condense-range):=20Split=20ranges=20going=0Afrom=20ASCII=20to=20= raw=20bytes.=0A*=20test/lisp/emacs-lisp/rx-tests.el=20= (rx-char-any-raw-byte):=20Add=20test=20case.=0A*=20etc/NEWS:=20Mention=20= the=20overall=20change=20(Bug#33205).=0A---=0A=20etc/NEWS=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=208=20= ++++++++=0A=20lisp/emacs-lisp/rx.el=20=20=20=20=20=20=20=20=20=20=20=20|=20= 7=20+++++++=0A=20test/lisp/emacs-lisp/rx-tests.el=20|=206=20+++++-=0A=20= 3=20files=20changed,=2020=20insertions(+),=201=20deletion(-)=0A=0Adiff=20= --git=20a/etc/NEWS=20b/etc/NEWS=0Aindex=2070a50c02c4..987e661044=20= 100644=0A---=20a/etc/NEWS=0A+++=20b/etc/NEWS=0A@@=20-1101,6=20+1101,14=20= @@=20subexpression.=0A=20When=20there=20is=20no=20menu=20for=20a=20mode,=20= display=20the=20mode=20name=20after=20the=0A=20indicator=20instead=20of=20= just=20the=20indicator=20(which=20is=20sometimes=20cryptic).=0A=20=0A+**=20= rx=0A+=0A+---=0A+***=20rx=20now=20handles=20raw=20bytes=20in=20character=20= alternatives=20correctly,=0A+when=20given=20in=20a=20string.=20=20= Previously,=20`(any=20"\x80-\xff")'=20would=20match=0A+characters=20= U+0080...U+00FF.=20=20Now=20the=20expression=20matches=20raw=20bytes=20= in=0A+the=20128...255=20range,=20as=20expected.=0A+=0A=20=0C=0A=20*=20= New=20Modes=20and=20Packages=20in=20Emacs=2027.1=0A=20=0Adiff=20--git=20= a/lisp/emacs-lisp/rx.el=20b/lisp/emacs-lisp/rx.el=0Aindex=20= b2299030a1..715cd608c4=20100644=0A---=20a/lisp/emacs-lisp/rx.el=0A+++=20= b/lisp/emacs-lisp/rx.el=0A@@=20-429,6=20+429,13=20@@=20Only=20both=20= edges=20of=20each=20range=20is=20checked."=0A=20=20=20=20=20;;=20set=20L=20= list=20of=20all=20ranges=0A=20=20=20=20=20(mapc=20(lambda=20(e)=20(cond=20= ((stringp=20e)=20(push=20e=20str))=0A=20=09=09=09=20=20=20=20((numberp=20= e)=20(push=20(cons=20e=20e)=20l))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Ranges=20between=20= ASCII=20and=20raw=20bytes=20are=20split,=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20to=20prevent=20= accidental=20inclusion=20of=20Unicode=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20characters=20= later=20on.=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20((and=20(<=3D=20(car=20e)=20#x7f)=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(>=3D=20(cdr=20e)=20#x3fff80))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(push=20= (cons=20(car=20e)=20#x7f)=20l)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(push=20(cons=20#x3fff80=20= (cdr=20e))=20l))=0A=20=09=09=09=20=20=20=20(t=20(push=20e=20l))))=0A=20=09= =20=20args)=0A=20=20=20=20=20;;=20condense=20overlapped=20ranges=20in=20= L=0Adiff=20--git=20a/test/lisp/emacs-lisp/rx-tests.el=20= b/test/lisp/emacs-lisp/rx-tests.el=0Aindex=20f15e1016f7..e14feda347=20= 100644=0A---=20a/test/lisp/emacs-lisp/rx-tests.el=0A+++=20= b/test/lisp/emacs-lisp/rx-tests.el=0A@@=20-53,7=20+53,11=20@@=0A=20=20=20= ;;=20Range=20of=20raw=20characters,=20multibyte.=0A=20=20=20(should=20= (equal=20(string-match-p=20(rx=20(any=20"=C3=85\211\326-\377\177"))=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20"XY\355\177\327")=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=202)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=202))=0A+=20=20;;=20Split=20range;=20\177-\377=C3=BF=20should=20not=20= be=20optimised=20to=20\177-\377.=0A+=20=20(should=20(equal=20= (string-match-p=20(rx=20(any=20"\177-\377"=20?=C3=BF))=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20"=C3=BFA\310B")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=200)))=0A=20=0A=20(ert-deftest=20rx-pcase=20()=0A=20=20=20(should=20= (equal=20(pcase=20"a=201=202=203=201=201=20b"=0A--=20=0A2.17.2=20(Apple=20= Git-113)=0A=0A= --Apple-Mail=_4D86E417-EA53-4808-9AC0-6D0D3CDA93AD-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 06:41:03 2019 Received: (at 34492) by debbugs.gnu.org; 16 Feb 2019 11:41:04 +0000 Received: from localhost ([127.0.0.1]:50038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guyL9-0000co-LG for submit@debbugs.gnu.org; Sat, 16 Feb 2019 06:41:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guyL7-0000cC-Cs for 34492@debbugs.gnu.org; Sat, 16 Feb 2019 06:41:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guyKx-0008NM-2d; Sat, 16 Feb 2019 06:40:52 -0500 Received: from [176.228.60.248] (port=1815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1guyKv-0004ef-Df; Sat, 16 Feb 2019 06:40:50 -0500 Date: Sat, 16 Feb 2019 13:40:49 +0200 Message-Id: <83zhqwklku.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-reply-to: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sat, 16 Feb 2019 12:05:09 +0100) Subject: Re: bug#34492: Acknowledgement (rx: ASCII-raw byte ranges comprise all of Unicode) References: <83a7iwmc6n.fsf@gnu.org> <81D26A8A-9C0B-4868-91F9-B9695999DBBE@acm.org> <831s48m44e.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34492 Cc: 34492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Mattias Engdegård > Date: Sat, 16 Feb 2019 12:05:09 +0100 > Cc: 34492@debbugs.gnu.org > > +** rx > + > +--- > +*** rx now handles raw bytes in character alternatives correctly, > +when given in a string. Previously, `(any "\x80-\xff")' would match > +characters U+0080...U+00FF. Now the expression matches raw bytes in > +the 128...255 range, as expected. This is OK, but we use quoting 'like this' in NEWS. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 06:46:24 2019 Received: (at 34492-done) by debbugs.gnu.org; 16 Feb 2019 11:46:25 +0000 Received: from localhost ([127.0.0.1]:50042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guyQK-0001sd-Bf for submit@debbugs.gnu.org; Sat, 16 Feb 2019 06:46:24 -0500 Received: from mail72c50.megamailservers.eu ([91.136.10.82]:50030 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guyQG-0001pU-M1 for 34492-done@debbugs.gnu.org; Sat, 16 Feb 2019 06:46:21 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1550317578; bh=O2Nctu9Gw1daXBU/SYeOi4JWSz5IE3H++aoJ1OE42ts=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=EdedwNTaVPJEROefCIB6Zm+cXldODVSOubZHcEAs0LCv8zVd/vVUu69po/QaqZYCz NtnIOnfR/o5/GG/SANVdHentCak9XUxQtHYjil2l4x5hJ+E6L3l/DQhnpq9g9nSiOY k4IMJokbGySI5OrmSgl2spkb8GyiajGQSHF7G6rU= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c83-251-8-17.bredband.comhem.se [83.251.8.17]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x1GBkHRx009485; Sat, 16 Feb 2019 11:46:18 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: bug#34492: Acknowledgement (rx: ASCII-raw byte ranges comprise all of Unicode) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83zhqwklku.fsf@gnu.org> Date: Sat, 16 Feb 2019 12:46:16 +0100 Content-Transfer-Encoding: 7bit Message-Id: <3FF91096-B760-4012-B207-512C173E254E@acm.org> References: <83a7iwmc6n.fsf@gnu.org> <81D26A8A-9C0B-4868-91F9-B9695999DBBE@acm.org> <831s48m44e.fsf@gnu.org> <83zhqwklku.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B0207.5C67F80A.0040, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=EN4oLWRC c=1 sm=1 tr=0 a=NAHmi3I8mP0S/Y8gRKeQyA==:117 a=NAHmi3I8mP0S/Y8gRKeQyA==:17 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=Bwg9DuvlHavtwY1ZFKQA:9 a=CjuIK1q_8ugA:10 a=ncZ9vwaUYPMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34492-done Cc: 34492-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 16 feb. 2019 kl. 12.40 skrev Eli Zaretskii : > > This is OK, but we use quoting 'like this' in NEWS. Thank you, pushed with that modification. From unknown Wed Jun 18 23:09:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 17 Mar 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator