GNU bug report logs - #34489
25.2; pdb fails if directory contains '++'

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: a.soroa <at> ehu.eus, 34489 <at> debbugs.gnu.org
Subject: bug#34489: 25.2; pdb fails if directory contains '++'
Date: Wed, 03 Jul 2019 08:39:19 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Tue, 2 Jul 2019 21:42:31 +0200
> Cc: a.soroa <at> ehu.eus, 34489 <at> debbugs.gnu.org
> 
> 
> [1:text/plain Hide]
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Hmm... I wonder why the code bothers specifying the allowed characters
> > explicitly, and in particular why it only allows ASCII characters.
> >
> > Does the code work if the directory has non-ASCII characters instead
> > of "++"?
> 
> No, it breaks.  For now, I've attached a patch to use "[:alnum:]",
> which fixes that use case for me.
> 
> Regarding your first question, I'm not exactly sure why.  Maybe we
> could go as far as just doing "[[:print:]]*" for that part - or
> simply ".*".  What do you think?

I think both [:print:] and .* would be too radical, as I'm not sure
including control characters and arbitrary whitespace will not break
something.  But maybe [:graph:] is better than [:alnum:].

In any case, I think we want a comment there saying that this is to
allow more characters in file names shown in the prompt.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.