GNU bug report logs - #34479
Incorrect classification of messages in compilation-mode buffer

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tobias Bading <tbading <at> web.de>
Cc: daniel.lopez999 <at> gmail.com, 34479 <at> debbugs.gnu.org
Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer
Date: Fri, 01 Mar 2019 12:07:24 +0200

> From: Tobias Bading <tbading <at> web.de>
> Date: Mon, 25 Feb 2019 14:26:38 +0100
> Cc: Daniel Lopez <daniel.lopez999 <at> gmail.com>,
>  Eli Zaretskii <eliz <at> gnu.org>
> 
> I also discovered this bug a few days ago and came up with the same fix as Daniel. However, there’s a small mistake in his patch which results in incorrect error numbers in the mode line. The compilation--note-type call should look like this:
> 
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 146af5a..368b088 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1441,7 +1441,7 @@ compilation-parse-errors
>                (let ((this-type (if (consp type)
>                                     (compilation-type type)
>                                   (or type 2))))
> -                (compilation--note-type type)
> +                (compilation--note-type this-type)
>  
>                  (compilation--put-prop
>                   file 'font-lock-face

Thanks, pushed to the emacs-26 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.