GNU bug report logs - #34479
Incorrect classification of messages in compilation-mode buffer

Previous Next

Package: emacs;

Reported by: Daniel Lopez <daniel.lopez999 <at> gmail.com>

Date: Thu, 14 Feb 2019 16:03:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Daniel Lopez <daniel.lopez999 <at> gmail.com>
To: Tobias Bading <tbading <at> web.de>, 34479 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer
Date: Mon, 25 Feb 2019 16:03:58 +0000
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 146af5a..368b088 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1441,7 +1441,7 @@ compilation-parse-errors
>                 (let ((this-type (if (consp type)
>                                      (compilation-type type)
>                                    (or type 2))))
> -                (compilation--note-type type)
> +                (compilation--note-type this-type)
>
>                   (compilation--put-prop
>                    file 'font-lock-face

Hi Tobias,

Just verified it here - I agree, that should be changed as well.

(In fact, the copy of the function that's currently in my init file to
replace the original just for now, already has that extra change. Not
sure why that didn't make it into my original patch. Thanks for spotting.)

Daniel




This bug report was last modified 6 years and 85 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.