From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 14 11:03:00 2019 Received: (at submit) by debbugs.gnu.org; 14 Feb 2019 16:03:00 +0000 Received: from localhost ([127.0.0.1]:48337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guJTX-0004TS-6m for submit@debbugs.gnu.org; Thu, 14 Feb 2019 11:03:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guJTV-0004TE-Rj for submit@debbugs.gnu.org; Thu, 14 Feb 2019 11:02:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:44784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1guJTK-0008C9-H2 for submit@debbugs.gnu.org; Thu, 14 Feb 2019 11:02:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guJTJ-00079h-Hv for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2019 11:02:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1guJT3-000843-Gj for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2019 11:02:37 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:50546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1guJSx-0007mL-Vw for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2019 11:02:26 -0500 Received: by mail-wm1-x330.google.com with SMTP id x7so6822337wmj.0 for ; Thu, 14 Feb 2019 08:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=PcO9Hu/aXT9TQ0FMYEa0U3raJyntaCm4ioW4o+DOvFU=; b=Xh2FgPKCQ9gd45VM7waMOGta/GWdbASaFjA3yn5o6BmcYyQyFM6n2M5r5CwqgVpTKc vIz+w9MNwPnl1PsKYxLh7rSZNnfwAjxtnBHNLvW+My85P2LRObK+WOwgMmRPm2XjHtnx FvGvgEgs6n1lNfeTPeSGTDduauEkcyCBb72bNuo/V8ayML/OiQEjWxSLGtY6RKbHDnjV uSI7sFyuq0mH+HpuLaqpgx81vopZAoJTGDzLAeq+RnjhDmsbUlPF08vpN0f/QS1sb0qb v01Y4Udn4rVwH+3yth10Qqxe3N42213wmbuafre5lYWsMBFhAVWDcoS3A0U+RgHcKxWH iJyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=PcO9Hu/aXT9TQ0FMYEa0U3raJyntaCm4ioW4o+DOvFU=; b=aDJ7pgG70YVrnOXvD/nVYJkI2vLDXCWytFms/UV4xOFTXbPv5LJurHtCQLil6aqmiE zavnMYdtXQmQtm+1Q4SHC563/6rS1hk5YMUJW99qD3VzZhXKg93EkB1vZT1ZPkb211Ao fx4f9kQE7M2u6F53ASTscjd2YP5A4U6i4ec8wyCK9B4TPf2/LunkkC+8OUW55lLYg49D f7BP9Ur17yGEsq+8PKSUyRKT20KEwSiaUBH7yStbTKRbZcYHk6WhT/wh3ceaO6E+ajj9 yWsIkkfIbqxZV8eTo0gvtrs+OJKeWzXCl2JLPnCQBgH7XFzf0/m7LzmfQLSJLiawzPOf ru/A== X-Gm-Message-State: AHQUAuYMz1zx5PxrTUbORka5ptQaBgVLBTZn3GUO6Sjff8lNO9dUCHiN 65q4rypMzoUC3uQ/BnUc8itJKNoQ X-Google-Smtp-Source: AHgI3IYozZyAcYT2j7VfMSaKyJm+rHyDGDKdRjH2IwMOWiIMWQTRhMEAx973RUmoVJMrNn916IaYIw== X-Received: by 2002:a1c:80c4:: with SMTP id b187mr3052402wmd.23.1550160113080; Thu, 14 Feb 2019 08:01:53 -0800 (PST) Received: from [192.168.2.2] (w-79.cust-5765.ip.static.uno.uk.net. [95.172.231.79]) by smtp.googlemail.com with ESMTPSA id e75sm166880wmg.32.2019.02.14.08.01.51 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 08:01:52 -0800 (PST) To: bug-gnu-emacs@gnu.org From: Daniel Lopez Subject: Incorrect classification of messages in compilation-mode buffer Message-ID: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> Date: Thu, 14 Feb 2019 16:00:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------3C42D8B903B4B035A2FC3AA1" Content-Language: en-US-large X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::330 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Reproduce: - Open the attached test program compilation_test.c in Emacs - M-x compile - Enter compile command "gcc -c compilation_test.c" In the resulting *compilation* buffer, there should be a mixture of "error", "warning" and "note" messages. Trouble is they're all parsed as errors - hence they're all coloured in red, and querying an [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (daniel.lopez999[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (daniel.lopez999[at]gmail.com) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) This is a multi-part message in MIME format. --------------3C42D8B903B4B035A2FC3AA1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Reproduce: - Open the attached test program compilation_test.c in Emacs - M-x compile - Enter compile command "gcc -c compilation_test.c" In the resulting *compilation* buffer, there should be a mixture of "error", "warning" and "note" messages. Trouble is they're all parsed as errors - hence they're all coloured in red, and querying any one's type by moving point onto it and evaluating "(compilation--message->type (get-text-property (point) 'compilation-message))" always returns 2, though warnings should return 1 and notes should return 0. Commands that jump between previous/next error also behave correspondingly wrongly. Fix: The attached fix_compilation_message_type.patch, applied to Git master, fixes it for me. It seems like the old code was accidentally using the same variable for the TYPE field of the current rule from compilation-error-regexp-alist, and in an inner loop, the actual type that the current message from the compilation buffer was resolved to be, so the resolved type of the first message tends to get carried down into the following ones. Daniel --------------3C42D8B903B4B035A2FC3AA1 Content-Type: text/x-csrc; name="compilation_test.c" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="compilation_test.c" int main(int argc, char ** argv) { int v = something; int w = something_else; int x = 4/0; #define MM w[10] int y = MM; return "abc"; } --------------3C42D8B903B4B035A2FC3AA1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 14 11:07:04 2019 Received: (at 34479) by debbugs.gnu.org; 14 Feb 2019 16:07:04 +0000 Received: from localhost ([127.0.0.1]:48342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guJXU-0004bM-3T for submit@debbugs.gnu.org; Thu, 14 Feb 2019 11:07:04 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:35332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guJXQ-0004an-Hz for 34479@debbugs.gnu.org; Thu, 14 Feb 2019 11:07:03 -0500 Received: by mail-wm1-f54.google.com with SMTP id t200so6650318wmt.0 for <34479@debbugs.gnu.org>; Thu, 14 Feb 2019 08:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=iq4TOxXpA6fJ3VI2jTeC0BtyMJV62Nxy8DDG6/zZFao=; b=KcuankFhh2XyczJikaRBdgl8/vY9xpuDFg2TcpYgtzVTm+OYtByphTERAcUm/m10JW T68dIWDH1rU55uiEyZDldR3YIpC18GrjFUHJ0IP4+9MvI2X6Iv2I6DJZva9j6iS9rMOF VfZqdroqE0fFlfhyPMxPhr35aIyn1XWQMAGW8kWGq2WS51lRrcr8hFZaukL6lK2nUxha XdXFPMDdjf4kF7GxYNUufK53Oz/Qi4UQ8QSEGIfLGHIgjCWCK0HqT1bKDzNGzpegM1fi PyrHy6v3LZIj+KDNZP+qWjQpiqTIGywuUde5ztejTf/1BG+yEqSIy1poW0rhJdlAxFQ2 k4lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=iq4TOxXpA6fJ3VI2jTeC0BtyMJV62Nxy8DDG6/zZFao=; b=g+YmcWEu+S/fCjlkMGQCZEfkzrBhp9njoGnAxEjU25M4fDh7ZdJwAHVwBWmTKAb1G8 0NVM6AX0J1wVkGnOrQztK7oBn+C2MrVNAsL+DfXJgE1iFU/IxAYFX2JxGgCD/tELEDMI FoqpuxxkpZPT4vba1CMiuoQB2iwgZMHcvHf0H6xQsGyc87exko1FnvJmIsg3kJwJzyOD 5HrQ5Bl6+kRrl46Fd2R5GhYLTT/wNOlB0v4wtSwF5aa0ajhEritUA60JolbjNBoH88Re OHycEfIM/eVSQiympqD4GuVUbm7LNOPD/6J+cXLfequdPMytgKI2ogc0RN0QI2BmCuBB 8SvA== X-Gm-Message-State: AHQUAubkSX/U9TMDXgbKfAIzo4gVl18Q2QeCvoyeFRWWw11Reduea0Bh RYdY3SjEYm/SFoW9u7SSlorJYiPS X-Google-Smtp-Source: AHgI3IZxzmR7HriqLnWv60LbnVajtSsoKJBSDcwY0tsbfw1t66PHD4C4XO8fE1+8qhsnapPOmfo0Pg== X-Received: by 2002:a1c:4844:: with SMTP id v65mr3505910wma.66.1550160414184; Thu, 14 Feb 2019 08:06:54 -0800 (PST) Received: from [192.168.2.2] (w-79.cust-5765.ip.static.uno.uk.net. [95.172.231.79]) by smtp.googlemail.com with ESMTPSA id 126sm3599849wmd.1.2019.02.14.08.06.52 for <34479@debbugs.gnu.org> (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 08:06:53 -0800 (PST) To: 34479@debbugs.gnu.org From: Daniel Lopez Subject: Incorrect classification of messages in compilation-mode buffer Message-ID: <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> Date: Thu, 14 Feb 2019 16:05:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8B668070BB89DD156950B088" Content-Language: en-US-large X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 34479 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This is a multi-part message in MIME format. --------------8B668070BB89DD156950B088 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Argh, I forgot to attach the patch. Here it is! Daniel --------------8B668070BB89DD156950B088 Content-Type: text/x-patch; name="fix_compilation_message_type.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_compilation_message_type.patch" diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 581a98d56c..0303314c59 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1425,17 +1425,17 @@ compilation-parse-errors file line end-line col end-col (or type 2) fmt)) (when (integerp file) - (setq type (if (consp type) - (compilation-type type) - (or type 2))) - (compilation--note-type type) - - (compilation--put-prop - file 'font-lock-face - (symbol-value (aref [compilation-info-face - compilation-warning-face - compilation-error-face] - type)))) + (let ((this-type (if (consp type) + (compilation-type type) + (or type 2)))) + (compilation--note-type type) + + (compilation--put-prop + file 'font-lock-face + (symbol-value (aref [compilation-info-face + compilation-warning-face + compilation-error-face] + this-type))))) (compilation--put-prop line 'font-lock-face compilation-line-face) --------------8B668070BB89DD156950B088-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 15 03:02:40 2019 Received: (at 34479-done) by debbugs.gnu.org; 15 Feb 2019 08:02:40 +0000 Received: from localhost ([127.0.0.1]:48547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guYSF-0004Oz-VU for submit@debbugs.gnu.org; Fri, 15 Feb 2019 03:02:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guYSE-0004Oe-LO for 34479-done@debbugs.gnu.org; Fri, 15 Feb 2019 03:02:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guYS7-0004Yf-Ix; Fri, 15 Feb 2019 03:02:33 -0500 Received: from [176.228.60.248] (port=1791 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1guYRz-0000lZ-VV; Fri, 15 Feb 2019 03:02:27 -0500 Date: Fri, 15 Feb 2019 10:02:19 +0200 Message-Id: <838syho4xg.fsf@gnu.org> From: Eli Zaretskii To: Daniel Lopez In-reply-to: <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> (message from Daniel Lopez on Thu, 14 Feb 2019 16:05:10 +0000) Subject: Re: bug#34479: Incorrect classification of messages in compilation-mode buffer References: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34479-done Cc: 34479-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Daniel Lopez > Date: Thu, 14 Feb 2019 16:05:10 +0000 > > Argh, I forgot to attach the patch. Here it is! Thanks. This is a relatively recent regression, so I pushed it to the emacs-26 branch. Please in the future include a ChangeLog-style commit log message with your patches. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 25 08:26:52 2019 Received: (at 34479) by debbugs.gnu.org; 25 Feb 2019 13:26:52 +0000 Received: from localhost ([127.0.0.1]:50936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyGHS-00021Z-6D for submit@debbugs.gnu.org; Mon, 25 Feb 2019 08:26:52 -0500 Received: from mout.web.de ([212.227.15.4]:59385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyGHQ-00021M-AN for 34479@debbugs.gnu.org; Mon, 25 Feb 2019 08:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1551101200; bh=+xpDIrqmOcbC8n0HURDWhzObvlj5iUyENlmt2oVGRI0=; h=X-UI-Sender-Class:Subject:From:In-Reply-To:Date:Cc:References:To; b=fn/cLrL2jHy2fTMjFaSeD8u/Dy3cp7ebC6YhLt1bjOlXORbYMBY5qyPWM4UsMAWtJ xrEmtMub3t2R65wGmaixQU5h0mgxL5vADuuHpQZ+nkmUwTc5w81F/0L6c6GMDN5opH BgOveDFuYjRp8e9AIAyrzy1aHqmC2M/YoQYqZ4r0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.107] ([84.143.148.53]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M09uu-1hIwSi1mP6-00uLjQ; Mon, 25 Feb 2019 14:26:40 +0100 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: bug#34479: Incorrect classification of messages in compilation-mode buffer From: Tobias Bading In-Reply-To: <838syho4xg.fsf@gnu.org> Date: Mon, 25 Feb 2019 14:26:38 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> <838syho4xg.fsf@gnu.org> To: 34479@debbugs.gnu.org X-Mailer: Apple Mail (2.3124) X-Provags-ID: V03:K1:n4sj2QA03A8WEH4TuqJR0tCVC5Uht+tT9SJL/+KpIoGrPq0np4R Kdsh8VYukT2aPB+oyFuWQG8hzcxsKR750La+YJYqAnjok/KI/etZ53bBVES5pBzXoD+tLJV I9d7jpLWSoIEL8XJCxl9zk5gc8bgzvIJ+Y3X94h0TDpTBDZ2r4EM7FvkuMrokP3ktTnVN5T 09EYl4bdJ9e89vrW2OMkA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:uHu8tRRLKd0=:X0kyLhUClPnGnNFiJyPBLZ nmWKlNlw0gNJk2rReU3fTxtG430I1Lugsmrvvtdq5yK6D486hL2Q4fibrUEFLnp0tjSR67Jks INDaS1n5B30CtcAzD9g/AwUoMRVjqkwps5C8rU4IVps7TetEvtYWvo9y/Z02IFmCjRBdOWCeL 3i/CJQfHcSqEzsBssaCU7hQaMmTKBvNoPDtLUnlcBnw8i6SCJDfwdhrN5nq4eT8MXOn/rVT8m RnKlEMe2a1SKh66OJBYVgoxx5jkp0N4gqiYSGhFA+toI7BOiwshw+ZFo3MajONx78BCYZnjlX VS85/U5mBhRf/ReTbCvoXivi9u5bUjwndCgOZ/pC8Qi4d7ZKeYm01QJHR2Fc2kSbTmmDkNAEY bRXBOaMJdeXexcmxTAtejclnZ4uoUlG0Vokt6YsonYO9xOWF7kSSXC2EDlZdmJE56EStp2kde XEjXVmr6FyAgA5iigC7EjBWdv6zXbT00SSv1tLDTiXtN+2CBpeALrqND+qFC3miCzNBEgdvkM iIIjO+ahwSFYrELe9SGY6F8pxsLcVrzuEyyQTyqVaIghi55scOJNxG5+wiJzcwEUqj3PlmnoX 91EFFvCDhm+dh19TbDf6RRfspuBZojyXQfdorGmlxiFYlI2qd4nkTP7NUYZhZMRCSr/w35e3e UTmYzsIxxM2CgFYlo3FHGgKu+/vcPxCXsHGR2zxngV6GfElWTTl2bekyHGKCxoBzLVcG3aSVo ol77IAy8ZpPtvhx+w/6fUOClf6W65WxrnhbXnOoMKP96NQiU26MZdqAYadNueOJU3185fcmdW c3MLqPOEanybShn6ClcyoxU4ERvcy9sZC9XbWw54UpyTj0ho7uaV5LSqQjKOA2z2HZedTejkw SDdMyDDJ7IB5YGSizdw49jj7TxE+bXbdWViC0BcNu8OhLbBHOBtLgwOW7rP27iKLVZLckCAZN chP3HO90YyA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34479 Cc: Eli Zaretskii , Daniel Lopez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I also discovered this bug a few days ago and came up with the same fix = as Daniel. However, there=E2=80=99s a small mistake in his patch which = results in incorrect error numbers in the mode line. The = compilation--note-type call should look like this: diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 146af5a..368b088 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1441,7 +1441,7 @@ compilation-parse-errors (let ((this-type (if (consp type) (compilation-type type) (or type 2)))) - (compilation--note-type type) + (compilation--note-type this-type) =20 (compilation--put-prop file 'font-lock-face Regards, Tobias From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 25 11:06:05 2019 Received: (at 34479) by debbugs.gnu.org; 25 Feb 2019 16:06:05 +0000 Received: from localhost ([127.0.0.1]:51669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyIlY-00062k-FJ for submit@debbugs.gnu.org; Mon, 25 Feb 2019 11:06:04 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:36102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyIlW-00062B-QY for 34479@debbugs.gnu.org; Mon, 25 Feb 2019 11:06:03 -0500 Received: by mail-wm1-f45.google.com with SMTP id j125so8628535wmj.1 for <34479@debbugs.gnu.org>; Mon, 25 Feb 2019 08:06:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7+A9cYd8RrJVr88eAefkobBOI4xruog0IQDmg2iP6Ko=; b=Q9TsqDch1AvraInBpoUdQOAefIe5o1vtS60nxlk0iNqnJYEK637IrraTb5zQ13Yho8 Ztbiq9Ms7Df3UXvrOw4OYsOEQo68ZWceqDLkDkpzG4HREqcJWA/2UalKdXYJybvSusPl OlIC/9Tb7eCwfbQ9nPDGcpzbbMhSUotTo7a1ao0w++JF1Oggiqcm/Foa1ua9VzhCoOMw 8yrVWVV7JxENNE3uE57qupW3d25AchsdfpIqQIh1xCgWLeV2D8QSmROj6tV8vQU7j+yJ gYmU8kG0DxKHg4M1O9sVbHjd3GdyE6sZwJDmohcUWloay5KVv47JIdUJQpbwiCLLSi1n iHcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7+A9cYd8RrJVr88eAefkobBOI4xruog0IQDmg2iP6Ko=; b=BaoFawiOLR16qpo49oJkVF4DH56Yd5anxYaH0NNCTHEykxQwy2c3UkHZc5bkAXwuGM SVELc30qeIB4LAJZtSPdV45+VQfkO1aWEgLVfD3BU3Opz/UqzG5HjfhDQ4GNEvwehT/T 9WSw46MLy/9cH9E/wu7Ix70Su4q72oozPs0AC16wWkhAXd315bi3MUMdJxEMKkeaH8sd d/dT/X2xFMKuByudeM/wbOzfR8Z2VdB57jAVfwHaOFI2Z/UsM+O2AdWYmHqYYeQV+Arv km+yyBvdp+xItx1RHg/bFECdV26Nb2cgOiQTrZxS1Kus/DMYEBjFWJbD0lTYb+h5lx/3 /mPA== X-Gm-Message-State: AHQUAuYovGoL0OgEmglG81MNk6frrUEUMdW8pupaagEqaAVS6S6KweVX HuSJztouQw/mCsCDH2iUJRU= X-Google-Smtp-Source: AHgI3IYOyID0vmTC5ke8H2jXaAmptGyd4+lCMGr6uH6IQA+gp556xUbH/hFnDhEJJi0kNBGpGuorLw== X-Received: by 2002:a7b:c34c:: with SMTP id l12mr10799825wmj.147.1551110756921; Mon, 25 Feb 2019 08:05:56 -0800 (PST) Received: from [192.168.2.2] (w-79.cust-5765.ip.static.uno.uk.net. [95.172.231.79]) by smtp.googlemail.com with ESMTPSA id o30sm9963482wro.57.2019.02.25.08.05.55 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 08:05:56 -0800 (PST) Subject: Re: bug#34479: Incorrect classification of messages in compilation-mode buffer To: Tobias Bading , 34479@debbugs.gnu.org References: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> <838syho4xg.fsf@gnu.org> From: Daniel Lopez Message-ID: <47a35443-96a2-be73-1aed-8e85b91ed186@gmail.com> Date: Mon, 25 Feb 2019 16:03:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 34479 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index 146af5a..368b088 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -1441,7 +1441,7 @@ compilation-parse-errors > (let ((this-type (if (consp type) > (compilation-type type) > (or type 2)))) > - (compilation--note-type type) > + (compilation--note-type this-type) > > (compilation--put-prop > file 'font-lock-face Hi Tobias, Just verified it here - I agree, that should be changed as well. (In fact, the copy of the function that's currently in my init file to replace the original just for now, already has that extra change. Not sure why that didn't make it into my original patch. Thanks for spotting.) Daniel From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 01 05:07:48 2019 Received: (at 34479) by debbugs.gnu.org; 1 Mar 2019 10:07:48 +0000 Received: from localhost ([127.0.0.1]:55808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzf52-0004WX-E9 for submit@debbugs.gnu.org; Fri, 01 Mar 2019 05:07:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzf50-0004WK-W4 for 34479@debbugs.gnu.org; Fri, 01 Mar 2019 05:07:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzf4s-00047C-L5; Fri, 01 Mar 2019 05:07:39 -0500 Received: from [176.228.60.248] (port=1140 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzf4s-0003WH-8r; Fri, 01 Mar 2019 05:07:38 -0500 Date: Fri, 01 Mar 2019 12:07:24 +0200 Message-Id: <83k1hij4bn.fsf@gnu.org> From: Eli Zaretskii To: Tobias Bading In-reply-to: (message from Tobias Bading on Mon, 25 Feb 2019 14:26:38 +0100) Subject: Re: bug#34479: Incorrect classification of messages in compilation-mode buffer References: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> <838syho4xg.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34479 Cc: daniel.lopez999@gmail.com, 34479@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Tobias Bading > Date: Mon, 25 Feb 2019 14:26:38 +0100 > Cc: Daniel Lopez , > Eli Zaretskii > > I also discovered this bug a few days ago and came up with the same fix as Daniel. However, there’s a small mistake in his patch which results in incorrect error numbers in the mode line. The compilation--note-type call should look like this: > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index 146af5a..368b088 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -1441,7 +1441,7 @@ compilation-parse-errors > (let ((this-type (if (consp type) > (compilation-type type) > (or type 2)))) > - (compilation--note-type type) > + (compilation--note-type this-type) > > (compilation--put-prop > file 'font-lock-face Thanks, pushed to the emacs-26 branch. From unknown Fri Jun 20 18:14:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 29 Mar 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator