GNU bug report logs - #34476
fluffy whitespace in the mode-line, despite it running off the screen

Previous Next

Packages: emacs, gnus;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Thu, 14 Feb 2019 13:53:01 UTC

Severity: wishlist

Tags: fixed

Found in version 5.13

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: contovob <at> tcd.ie, 34476 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: bug#34476: fluffy whitespace in the mode-line, despite it running off the screen
Date: Fri, 07 Aug 2020 14:15:21 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

>> > And it formats the mode-line twice: once in format-mode-line, then
>> > again in display_string, right?
>> 
>> No, display_string just displays the string, I think?
>
> Which is a non-trivial amount of work: loading all the font glyphs
> again and accounting for their metrics, considering the faces, etc.
> All of which was already done.

I'm not very familiar with that code, but from my reading of it, none of
that has been done at this point.

I call Fformat_mode_line (format, Qnil, Qnil, Qnil); instead of
display_mode_element.  Fformat_mode_line sets

  mode_line_target = MODE_LINE_STRING;

or the like, and then calls display_mode_element, which then won't call
display_string at all, but just put all the computed elements in a list.

So nothing is displayed until that call to display_string, in my reading
of the code.

OK, I've now done some more testing -- I removed my call to
display_string, and no mode line is displayed at all, which kinda
supports my reading of the code?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 140 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.