From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:10:02 2019 Received: (at submit) by debbugs.gnu.org; 13 Feb 2019 19:10:02 +0000 Received: from localhost ([127.0.0.1]:47307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtzv0-0001PW-0S for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:10:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtzuy-0001Oz-7c for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:10:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:42587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gtzut-0001Bn-1p for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:09:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtzus-0007ET-0O for guix-patches@gnu.org; Wed, 13 Feb 2019 14:09:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtzuq-00014d-Ux for guix-patches@gnu.org; Wed, 13 Feb 2019 14:09:54 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44243) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gtzuo-0000ZO-Ok for guix-patches@gnu.org; Wed, 13 Feb 2019 14:09:51 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D3BFD24A70 for ; Wed, 13 Feb 2019 14:09:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:09:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=P+NjPm BgyVw3Sd0Ju83pSg0N8EGQ5dLSwT8Kz6WfQFk=; b=2UNVrh19b7FBkBlCxZGQ1R tdR12vxKJSj09AlhURh3xi35YALNl4g+KQSVc82Ef1Rtza8HGtJTOcmrRhkCLF2d iO1rkb1oUR7zjXu5rDzAbd8XZdqDf18Daoz0VdDlOstxoRktR8YVcrVCOZRi1isb sbghmaseEbOWMhoc1fPxcZdtngS9uU9nUjfdiHj9+OdXiBXGYyG7Wo+uOQIoNHKB piMX2XJppDYREfGGdkmlMqiPFvPTxJ34LPTtJsh2kZzLBw9TvcgzoYUvJRbc2upx kTTaHOEcm0heiDo0+DpQZjUyT3FtAuuo6lOTTvcHu0jFKJ3KIsEgy+eUOrpCYQZQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpe fvihhmohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeen ucffohhmrghinhepghhnuhdrohhrghenucfkphepjeegrdduudeirddukeeirdeggeenuc frrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 144B7100E5 for ; Wed, 13 Feb 2019 14:09:44 -0500 (EST) From: Timothy Sample To: guix-patches@gnu.org Subject: [PATCH 0/8] GDM without GNOME Desktop Date: Wed, 13 Feb 2019 14:09:42 -0500 Message-ID: <87o97fijyh.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hi Guix, This patch series fixes up a few things with GDM. The main one is that GDM no longer requires the GNOME Desktop service to be included in the system services. It no longer blindly hopes that everything it needs happens to be in =E2=80=9C/run/current-system/profile=E2=80=9D. Now it mos= tly knows where to find its dependencies directly, and in the cases it doesn=E2=80=99= t, it makes sure that what it needs is in the system profile. Around this, I did some cleaning. GDM now looks directly at its configuration file in the store rather than at a link in =E2=80=9C/etc=E2= =80=9D, and a repetitive section of messy substitutions is now a loop. I added a D-Bus wrapper script as discussed before [1]. It doesn=E2=80=99t= do much, but it is there to be improved if needed. This series also includes the user X session scripts that were recently discussed [2]. -- Tim [1] https://lists.gnu.org/archive/html/guix-devel/2019-01/msg00047.html [2] https://lists.gnu.org/archive/html/guix-devel/2019-02/msg00198.html Timothy Sample (8): services: gdm: Remove etc service. gnu: gnome-session: Use absolute paths in .desktop files. gnu: gdm: Add links to required login-session files. gnu: gdm: Use absolute path for gnome-session. gnu: gdm: Simplify pre-configure phase. gnu: gdm: Run dbus-daemon via a wrapper script. services: gdm: Make dependencies explicit. services: gdm: Allow for custom X session scripts. gnu/packages/gnome.scm | 96 +++++++++++++++++++++------------- gnu/services/xorg.scm | 113 +++++++++++++++++++++++++---------------- 2 files changed, 130 insertions(+), 79 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:22:56 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:22:56 +0000 Received: from localhost ([127.0.0.1]:47314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07P-0001he-H1 for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:22:56 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07M-0001hQ-Lh for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:22:50 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4570B21F4F; Wed, 13 Feb 2019 14:22:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:22:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=KgRBokNmfDbqpnMQGwfpGWOYzbQWuxiyVu+Xn2FId NY=; b=EIDZhscfXJbS5WthMCd5R74meUM51RFDB8AtPO2F2SSaz6JAghc2ZRZnh FpLlJdYbxA+S7WZZumP1XkG9xJtj7a6LHOrxdD9SgnmCrnaEHaMOHCOqVRzZPjMi oWWetW6zUwfsP23A7riGbAQk8hxySLF5HHhIb8IS9OsQVW4rX7bLlxShwZPKAzl4 /2qouX3Tm1CRKDWO1iAbIoeffy1n1+xRfiJwNP4uTljb3v9YdpIuJ1D3EGa4DqVp ie/AZob9PDEyyMD/B1rNxGbvUhjN8heE1Ka7PtxoXCmTT5jWhu8ptv3bzwLqtXiA pp2asSOUrJkZja+subx8v5t5hub2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhroh hmpefvihhmohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhm qeenucfkphepjeegrdduudeirddukeeirdeggeenucfrrghrrghmpehmrghilhhfrhhomh epshgrmhhplhgvthesnhhghihrohdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 66BA2E4543; Wed, 13 Feb 2019 14:22:42 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 1/8] services: gdm: Remove etc service. Date: Wed, 13 Feb 2019 14:22:14 -0500 Message-Id: <20190213192221.26599-1-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/gnome.scm (gdm)[arguments]: Update pre-configure phase to make GDM get the configuration file path from an environment variable. * gnu/services/xorg.scm (gdm-etc-service): Remove function. (gdm-configuration-file): New function. (gdm-shepherd-service): Set GDM_CUSTOM_CONF before invoking GDM. (gdm-service-type)[extensions]: Remove etc-service-type extension. --- gnu/packages/gnome.scm | 9 ++++-- gnu/services/xorg.scm | 67 ++++++++++++++++++++---------------------- 2 files changed, 39 insertions(+), 37 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 367d5de16c..b2c7aa60cc 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -32,7 +32,7 @@ ;;; Copyright © 2018 Jovany Leandro G.C ;;; Copyright © 2018 Vasile Dumitrascu ;;; Copyright © 2018 Björn Höfling -;;; Copyright © 2018 Timothy Sample +;;; Copyright © 2018, 2019 Timothy Sample ;;; ;;; This file is part of GNU Guix. ;;; @@ -5380,6 +5380,9 @@ libxml2.") ;; processes. "gdm_session_set_environment_variable (self, \"GDM_X_SERVER\",\n" " g_getenv (\"GDM_X_SERVER\"));\n" + ;; Propagate the GDM_CUSTOM_CONF environment variable. + "gdm_session_set_environment_variable (self, \"GDM_CUSTOM_CONF\",\n" + " g_getenv (\"GDM_CUSTOM_CONF\"));\n" ;; FIXME: Really glib should be declaring XDG_CONFIG_DIRS as a ;; variable, but it doesn't do that right now. Anyway ;; /run/current-system/profile/share/gnome-session/sessions/gnome.desktop @@ -5399,7 +5402,9 @@ libxml2.") ;; Look for custom GDM conf in /run/current-system. (substitute* '("common/gdm-settings-desktop-backend.c") (("GDM_CUSTOM_CONF") - "\"/run/current-system/etc/gdm/custom.conf\"")) + (string-append "(g_getenv(\"GDM_CUSTOM_CONF\") != NULL" + " ? g_getenv(\"GDM_CUSTOM_CONF\")" + " : GDM_CUSTOM_CONF)"))) ;; Use service-supplied path to X. (substitute* '("daemon/gdm-server.c") (("\\(X_SERVER X_SERVER_ARG_FORMAT") diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index 1efb275794..de5438e3fe 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -2,7 +2,7 @@ ;;; Copyright © 2017 Andy Wingo ;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2019 Ludovic Courtès ;;; Copyright © 2015 Sou Bunnbu -;;; Copyright © 2018 Timothy Sample +;;; Copyright © 2018, 2019 Timothy Sample ;;; ;;; This file is part of GNU Guix. ;;; @@ -633,38 +633,34 @@ makes the good ol' XlockMore usable." (x-server gdm-configuration-x-server (default (xorg-wrapper)))) -(define (gdm-etc-service config) - (define gdm-configuration-file - (mixed-text-file "gdm-custom.conf" - "[daemon]\n" - "#User=gdm\n" - "#Group=gdm\n" - (if (gdm-configuration-auto-login? config) - (string-append - "AutomaticLoginEnable=true\n" - "AutomaticLogin=" - (or (gdm-configuration-default-user config) - (error "missing default user for auto-login")) - "\n") - (string-append - "AutomaticLoginEnable=false\n" - "#AutomaticLogin=\n")) - "#TimedLoginEnable=false\n" - "#TimedLogin=\n" - "#TimedLoginDelay=0\n" - "#InitialSetupEnable=true\n" - ;; Enable me once X is working. - "WaylandEnable=false\n" - "\n" - "[debug]\n" - "#Enable=true\n" - "\n" - "[security]\n" - "#DisallowTCP=true\n" - "#AllowRemoteAutoLogin=false\n")) - `(("gdm" ,(file-union - "gdm" - `(("custom.conf" ,gdm-configuration-file)))))) +(define (gdm-configuration-file config) + (mixed-text-file "gdm-custom.conf" + "[daemon]\n" + "#User=gdm\n" + "#Group=gdm\n" + (if (gdm-configuration-auto-login? config) + (string-append + "AutomaticLoginEnable=true\n" + "AutomaticLogin=" + (or (gdm-configuration-default-user config) + (error "missing default user for auto-login")) + "\n") + (string-append + "AutomaticLoginEnable=false\n" + "#AutomaticLogin=\n")) + "#TimedLoginEnable=false\n" + "#TimedLogin=\n" + "#TimedLoginDelay=0\n" + "#InitialSetupEnable=true\n" + ;; Enable me once X is working. + "WaylandEnable=false\n" + "\n" + "[debug]\n" + "#Enable=true\n" + "\n" + "[security]\n" + "#DisallowTCP=true\n" + "#AllowRemoteAutoLogin=false\n")) (define (gdm-pam-service config) "Return a PAM service for @command{gdm}." @@ -698,6 +694,9 @@ makes the good ol' XlockMore usable." "/bin/gdm")) #:environment-variables (list (string-append + "GDM_CUSTOM_CONF=" + #$(gdm-configuration-file config)) + (string-append "GDM_X_SERVER=" #$(gdm-configuration-x-server config)) ;; XXX: GDM requires access to a handful of @@ -719,8 +718,6 @@ makes the good ol' XlockMore usable." (const %gdm-accounts)) (service-extension pam-root-service-type gdm-pam-service) - (service-extension etc-service-type - gdm-etc-service) (service-extension dbus-root-service-type (compose list gdm-configuration-gdm)))) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:22:57 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:22:57 +0000 Received: from localhost ([127.0.0.1]:47318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07V-0001hx-95 for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:22:57 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07T-0001hd-Oz for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:22:56 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9C9CF24608; Wed, 13 Feb 2019 14:22:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:22:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=xOEVe0I1XPP2qv+/Me0xmtUfAHpol0tOvkz3Yr1HIjU=; b=vDmjQF86 e+7tWUIfaScCruNZG/qc5LWxgkKYs3K/+EfIn2efuxrzlREHMxIcdRLBZYwl7/0h T0yeTv30nozP7MlvgLF7yZ0maYrz7PMuCKfNr/CYDoXzPvLEN/eA1/9VZvN8UHp0 wnbyCAglIHdSWVxreSgwyeSMVZQdZDV1uWGaXfQBtYxng2vQ+z6J1rabYDXXEYUi wE4hgQEyOZ48a6ui7hvGq0twPGcFuDa96XNBuzqLqud2X/ua+ru0oeXfeqlDjS7c EnVxcAMNHT9O6PybWk2E+nb580vpp6p4eiiFYqHYAltHUweG0D5PXtWAv1fHYFe2 6Ds8171nvmOgKA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomh epvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheq necukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id EC0EFE409D; Wed, 13 Feb 2019 14:22:49 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 2/8] gnu: gnome-session: Use absolute paths in .desktop files. Date: Wed, 13 Feb 2019 14:22:15 -0500 Message-Id: <20190213192221.26599-2-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This makes the gnome-session .desktop files usable even if gnome-session is not available from the PATH variable. * gnu/packages/gnome.scm (gnome-session)[arguments]: Add a phase that adds the absolute path of gnome-session in its .desktop files. --- gnu/packages/gnome.scm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index b2c7aa60cc..59e1011a8f 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -4575,6 +4575,14 @@ such as gzip tarballs.") (out (assoc-ref outputs "out"))) (wrap-program (string-append out "/bin/gnome-session") `("PATH" ":" prefix (,(string-append glib "/bin")))) + #t))) + (add-after 'install 'add-absolute-paths-to-desktop-files + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out"))) + (substitute* (map (lambda (x) + (string-append out "/share/xsessions/" x)) + '("gnome.desktop" "gnome-xorg.desktop")) + (("gnome-session") (string-append out "/bin/gnome-session"))) #t)))) #:configure-flags -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:23:04 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:23:04 +0000 Received: from localhost ([127.0.0.1]:47324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07b-0001iy-KF for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:04 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07Z-0001hw-Un for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:02 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BA07F2481E; Wed, 13 Feb 2019 14:22:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:22:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=1+aPujHTLN+wbg78DX05Irg9DCUqE08lCnrduj8EQb0=; b=G0OxnYkL 0db/Y/3k1Vex9AhVCNBw1ep2sQz67n8Xl2MprabxcttKrEyhf0o1mdleytV/UOOa QWmKt8kiRiO1Cf7Q1b0ibMF+fgZDNMAC8fCTAVdOcLw4R6d4OcsaJYCSN/oyEfRh HB6OId76cE+TvlTcN/Ze0H1v/YbAWpERQhUsZ2DrYTCRpa2EogCcatKbtueaNdJU TBUHcJgQTAHlme0D8HsyNpxCCyksR7EZ2gyU+mhFQW9/5fONmd1prGyuNd8T6Jgq lGSENiROxxJuzCZ4ShtRWBsXq7HBzz5cM+TfmmV5VnWVfmyft6s9pUdUJ0Perfpm B4ZhdpT5RIZTeA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomh epvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheq necukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 449AAE409D; Wed, 13 Feb 2019 14:22:56 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 3/8] gnu: gdm: Add links to required login-session files. Date: Wed, 13 Feb 2019 14:22:16 -0500 Message-Id: <20190213192221.26599-3-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/gnome.scm (gdm)[arguments]: Add a phase that creates symbolic links to required files from gnome-settings-daemon; do not set XDG_CONFIG_DIRS in the session environment. [inputs]: Add gnome-settings-daemon. --- gnu/packages/gnome.scm | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 59e1011a8f..ac49ca7f2d 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5391,16 +5391,6 @@ libxml2.") ;; Propagate the GDM_CUSTOM_CONF environment variable. "gdm_session_set_environment_variable (self, \"GDM_CUSTOM_CONF\",\n" " g_getenv (\"GDM_CUSTOM_CONF\"));\n" - ;; FIXME: Really glib should be declaring XDG_CONFIG_DIRS as a - ;; variable, but it doesn't do that right now. Anyway - ;; /run/current-system/profile/share/gnome-session/sessions/gnome.desktop - ;; requires that a number of .desktop files be present, and - ;; these special .desktop files are in $XDG_CONFIG_DIRS (which - ;; defaults to /etc/xdg if it's not set). Here we need to - ;; provide a value such that the GNOME session's requirements - ;; are met (provided GNOME is installed of course). - "gdm_session_set_environment_variable (self, \"XDG_CONFIG_DIRS\",\n" - " \"/run/current-system/profile/etc/xdg\");\n" ;; The session bus (which GDM will initialize from the this ;; session environment) needs to know where to find the system ;; service files. @@ -5420,7 +5410,25 @@ libxml2.") (substitute* '("daemon/gdm-x-session.c") (("X_SERVER") "g_getenv (\"GDM_X_SERVER\")")) - #t))))) + #t)) + ;; GDM needs GNOME Session to run these applications. We link + ;; their autostart files in `share/gdm/greeter/autostart' + ;; because GDM explicitly tells GNOME Session to look there. + ;; + ;; XXX: GNOME Shell should be linked here too, but currently + ;; GNOME Shell depends on GDM. + (add-after 'install 'link-autostart-files + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (autostart (string-append out "/share/gdm/" + "greeter/autostart")) + (settings (assoc-ref inputs "gnome-settings-daemon"))) + (mkdir-p autostart) + (with-directory-excursion autostart + (for-each (lambda (desktop) + (symlink desktop (basename desktop))) + (find-files (string-append settings "/etc/xdg")))) + #t)))))) (native-inputs `(("dconf" ,dconf) ("glib:bin" ,glib "bin") ; for glib-compile-schemas, etc. @@ -5433,6 +5441,7 @@ libxml2.") `(("accountsservice" ,accountsservice) ("check" ,check) ; for testing ("elogind" ,elogind) + ("gnome-settings-daemon" ,gnome-settings-daemon) ("gtk+" ,gtk+) ("iso-codes" ,iso-codes) ("libcanberra" ,libcanberra) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:23:08 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:23:08 +0000 Received: from localhost ([127.0.0.1]:47328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07f-0001jL-99 for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:07 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07d-0001i7-6d for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:05 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 14CBF247EB; Wed, 13 Feb 2019 14:23:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:23:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=ORzKtiIw7eAh10hvHqaNnI1894Drzy3VgDAbOl/vn+g=; b=IUw7py0n Hk2gznRUpTwjy4bMJPXht09A8sloQnyHwyPPdmKTgLJaXx6BUtFDKLt47zHETkaO fvzbwWPBHKvCNeTRoVSTLF7v7wyRrbNbYx2nhHvpKW6JHXGIqJf0DZkJ2hhITUKG 5YG8CE71QYdTL4i8Sef1JjcVNI+/0auKkqn/JokixEOeNBk+ranzaIiTZe24gAG/ 2fb6KUPWP0veV9XoTHpopak0NP03kjVorbbWWREgSQkNYp73h61yQbtxUjYt9o0I kLrHDsDHnxPQOO9wjetKmSwAFqxBMUJC3Sb0A0x8Wjs9+jR9RQSEAD54C0/JY4NT 6KPZoICdKVfIkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomh epvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheq necukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E853E4412; Wed, 13 Feb 2019 14:22:59 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 4/8] gnu: gdm: Use absolute path for gnome-session. Date: Wed, 13 Feb 2019 14:22:17 -0500 Message-Id: <20190213192221.26599-4-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/gnome.scm (gdm)[arguments]: Modify the pre-configure phase to substitute in the absolute path of gnome-session. [inputs]: Add gnome-session. --- gnu/packages/gnome.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index ac49ca7f2d..fdc5b68ef6 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5349,7 +5349,7 @@ libxml2.") (modify-phases %standard-phases (add-before 'configure 'pre-configure - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) ;; We don't have . (substitute* '("common/gdm-log.c" "daemon/gdm-server.c" @@ -5410,6 +5410,11 @@ libxml2.") (substitute* '("daemon/gdm-x-session.c") (("X_SERVER") "g_getenv (\"GDM_X_SERVER\")")) + ;; Use an absolute path for GNOME Session. + (substitute* "daemon/gdm-launch-environment.c" + (("\"gnome-session\"") + (string-append "\"" (assoc-ref inputs "gnome-session") + "/bin/gnome-session\""))) #t)) ;; GDM needs GNOME Session to run these applications. We link ;; their autostart files in `share/gdm/greeter/autostart' @@ -5441,6 +5446,7 @@ libxml2.") `(("accountsservice" ,accountsservice) ("check" ,check) ; for testing ("elogind" ,elogind) + ("gnome-session" ,gnome-session) ("gnome-settings-daemon" ,gnome-settings-daemon) ("gtk+" ,gtk+) ("iso-codes" ,iso-codes) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:23:11 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:23:11 +0000 Received: from localhost ([127.0.0.1]:47332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07j-0001jd-5c for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:11 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07h-0001j3-9m for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:09 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3D630243CF; Wed, 13 Feb 2019 14:23:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:23:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=kboH7UXzMCoW4+HWEkK6beZL59mZ5Ese6C7Q/6U6MzM=; b=CARsXXU8 lNKk00z3ruzGo++0bqaFRn7RAdme7CvHdUZlaENotCZtntP/IzKXgBKH7c+8VooA 6xvxxoLcMbAIhQ5lwp3dB+Ra9Puj+lxXATHcNHdzDeWRYif4L2h1bsGLBpdjRCDi k0lmdE4hj9/iOuUtIiL/V5zm+j/AnR8CfysD2OKu/sRkgdenZZEdy3N/9oFppSJ2 HVTDQBF/MUnfjOpX9MvkOKmRm1MZ7GMkf2EGXWsnvMheez1NpZh9Q2Bcf9a4Fla8 0ZkVlEWTOnsXz70cWYIg1WEhOj6/tIX0g3yk8ByCCN15til2UekXoGn486F0h8Cd 1CnlHzKNW+jLjw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomh epvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheq necuffhomhgrihhnpehlihgsgihmlhdvrdhruhhnnecukfhppeejgedrudduiedrudekie drgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgt ohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id B4613E409D; Wed, 13 Feb 2019 14:23:03 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 5/8] gnu: gdm: Simplify pre-configure phase. Date: Wed, 13 Feb 2019 14:22:18 -0500 Message-Id: <20190213192221.26599-5-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/gnome.scm (gdm)[arguments]: Simplify the pre-configure phase. --- gnu/packages/gnome.scm | 34 +++++++++++++++------------------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index fdc5b68ef6..da1c976e07 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5378,25 +5378,21 @@ libxml2.") "\"/run/current-system/profile/share/wayland") (("DATADIR \"/gnome") "\"/run/current-system/profile/share/gnome")) - (substitute* '("daemon/gdm-session.c") - (("set_up_session_environment \\(self\\);") - (string-append - "set_up_session_environment (self);\n" - ;; Propagate GDM_X_SERVER environment variable (which is set - ;; by the GDM service, as it's a function of what X modules - ;; the user decides to have available) down to worker - ;; processes. - "gdm_session_set_environment_variable (self, \"GDM_X_SERVER\",\n" - " g_getenv (\"GDM_X_SERVER\"));\n" - ;; Propagate the GDM_CUSTOM_CONF environment variable. - "gdm_session_set_environment_variable (self, \"GDM_CUSTOM_CONF\",\n" - " g_getenv (\"GDM_CUSTOM_CONF\"));\n" - ;; The session bus (which GDM will initialize from the this - ;; session environment) needs to know where to find the system - ;; service files. - "gdm_session_set_environment_variable (self, \"XDG_DATA_DIRS\",\n" - " \"/run/current-system/profile/share\");\n" - ))) + (let ((propagate '("GDM_CUSTOM_CONF" + "GDM_X_SERVER" + ;; XXX: Remove this once GNOME Shell is + ;; a dependency of GDM. + "XDG_DATA_DIRS"))) + (substitute* "daemon/gdm-session.c" + (("set_up_session_environment \\(self\\);") + (apply string-append + "set_up_session_environment (self);\n" + (map (lambda (name) + (string-append + "gdm_session_set_environment_variable " + "(self, \"" name "\"," + "g_getenv (\"" name "\"));\n")) + propagate))))) ;; Look for custom GDM conf in /run/current-system. (substitute* '("common/gdm-settings-desktop-backend.c") (("GDM_CUSTOM_CONF") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:23:15 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:23:15 +0000 Received: from localhost ([127.0.0.1]:47336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07n-0001jv-HK for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:15 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07l-0001jS-89 for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:14 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2FCF324608; Wed, 13 Feb 2019 14:23:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:23:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=FfBLhJ+x2z98o9h8F33JKk2+P8ACKEEPYO6vsZteZ7E=; b=gzbpk/UW D+VUHz8ovzcfEM72ylHRyjdLnttdGgzf8lkXB9tlf5hc8MyuVyn4YiA9QjKdrABI 2B6RdfVMs7iLhvkqrEJCLoVTd6Ax2y2tuk6xtyNiKcJEFKwqb4A4HKIg1+ATdyjA 4mQfAfQMy4iTfLdPuoCutOO0qltokrgb2oCrw75Io3AwcoWVsJFo7VN5R0TtAugL Bmk/G+MwsWcRE+4u+EuTRACarywkMxRXxZVVYfoHh6Lhgwc/GMQzvckZu4Z7SfEY TmspxU5hK+Tu3ztEkT7Zryh6KNLUJl05nj+q92ZS6cgl2nSGOQgvmdaL0F/0jHtD bjghUFPMPUwPSw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomh epvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheq necukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id C9BDEE423B; Wed, 13 Feb 2019 14:23:07 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 6/8] gnu: gdm: Run dbus-daemon via a wrapper script. Date: Wed, 13 Feb 2019 14:22:19 -0500 Message-Id: <20190213192221.26599-6-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/gnome.scm (gdm)[arguments]: Modify the pre-configure phase so that GDM propagates the GDM_DBUS_DAEMON variable into the session environment and uses its value to invoke dbus-daemon. * gnu/services/xorg.scm (dbus-daemon-wrapper): New variable. (): Add 'dbus-daemon' field. (gdm-shepherd-service): Set GDM_DBUS_DAEMON before invoking gdm. --- gnu/packages/gnome.scm | 3 +++ gnu/services/xorg.scm | 15 +++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index da1c976e07..3c09d6b30a 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5379,6 +5379,7 @@ libxml2.") (("DATADIR \"/gnome") "\"/run/current-system/profile/share/gnome")) (let ((propagate '("GDM_CUSTOM_CONF" + "GDM_DBUS_DAEMON" "GDM_X_SERVER" ;; XXX: Remove this once GNOME Shell is ;; a dependency of GDM. @@ -5404,6 +5405,8 @@ libxml2.") (("\\(X_SERVER X_SERVER_ARG_FORMAT") "(\"%s\" X_SERVER_ARG_FORMAT, g_getenv (\"GDM_X_SERVER\")")) (substitute* '("daemon/gdm-x-session.c") + (("\"dbus-daemon\"") + "g_getenv (\"GDM_DBUS_DAEMON\")") (("X_SERVER") "g_getenv (\"GDM_X_SERVER\")")) ;; Use an absolute path for GNOME Session. diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index de5438e3fe..6a589779b9 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -29,6 +29,7 @@ #:use-module (gnu packages guile) #:use-module (gnu packages xorg) #:use-module (gnu packages gl) + #:use-module (gnu packages glib) #:use-module (gnu packages display-managers) #:use-module (gnu packages gnustep) #:use-module (gnu packages gnome) @@ -623,12 +624,23 @@ makes the good ol' XlockMore usable." (home-directory "/var/lib/gdm") (shell (file-append shadow "/sbin/nologin"))))) +(define dbus-daemon-wrapper + (program-file "gdm-dbus-wrapper" + #~(begin + (setenv "XDG_CONFIG_DIRS" + "/run/current-system/profile/etc/xdg") + (setenv "XDG_DATA_DIRS" + "/run/current-system/profile/share") + (apply execl (string-append #$dbus "/bin/dbus-daemon") + (program-arguments))))) + (define-record-type* gdm-configuration make-gdm-configuration gdm-configuration? (gdm gdm-configuration-gdm (default gdm)) (allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t)) (auto-login? gdm-configuration-auto-login? (default #f)) + (dbus-daemon gdm-configuration-dbus-daemon (default dbus-daemon-wrapper)) (default-user gdm-configuration-default-user (default #f)) (x-server gdm-configuration-x-server (default (xorg-wrapper)))) @@ -696,6 +708,9 @@ makes the good ol' XlockMore usable." (list (string-append "GDM_CUSTOM_CONF=" #$(gdm-configuration-file config)) + (string-append + "GDM_DBUS_DAEMON=" + #$(gdm-configuration-dbus-daemon config)) (string-append "GDM_X_SERVER=" #$(gdm-configuration-x-server config)) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:23:18 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:23:18 +0000 Received: from localhost ([127.0.0.1]:47340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07p-0001kA-SX for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:18 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07n-0001jc-Sp for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:16 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id CC8E224808; Wed, 13 Feb 2019 14:23:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:23:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=bgVBgsalaIxZjiETaZ8cmlQhADaabUxB4h1KzlF8rMk=; b=qVfnM/4h MbLMtZ7E9NBlMM/rp5hWDzJoK/D+/Ocij45izsJCsPgkY37qB5Sl8eQOXVdPTkA2 dBC12nA71ws3wsM/tZ7duoMOyldCFv+At6h3hWgsbvEEZCR24h1HLy+2Oo+mWRNd Q+X1PXG6HSuLxRE2ZuHnhE8p7AYG79nyahM9kui8j4zEPqBzBp2fTjgDK5T6l4IO hAjfIFFJ873RE/PxGLE3dWl5zil6m1zFVBBzVCRnUViGyHTm2KlS6oiiFqKrDABZ YKvijzg+XlF7Haz7MmZt6TpCKDOw8fgMjrXu5CCJwzW/Lha90yhJPRsOJSCY/9ZA uTNsZhyPF//RPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomh epvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheq necukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A801E409D; Wed, 13 Feb 2019 14:23:10 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 7/8] services: gdm: Make dependencies explicit. Date: Wed, 13 Feb 2019 14:22:20 -0500 Message-Id: <20190213192221.26599-7-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This commit removes the remaining implicit dependencies that the GDM service had on the GNOME Desktop service. * gnu/services/xorg.scm (gdm-configuration): Add a gnome-shell-assets field for specifying any icons or fonts that the GNOME Shell theme needs. (gdm-shepherd-service): Remove environment variables pointing to '/run/current-system' and set XDG_DATA_DIRS so that it points to 'gnome-shell' and its assets. (gdm-service-type): Extend 'profile-service-type' to ensure that necessary fonts are installed in the system profile. --- gnu/services/xorg.scm | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index 6a589779b9..4e6f5ad44f 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -28,6 +28,7 @@ #:use-module ((gnu packages base) #:select (canonical-package)) #:use-module (gnu packages guile) #:use-module (gnu packages xorg) + #:use-module (gnu packages fonts) #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages display-managers) @@ -642,6 +643,8 @@ makes the good ol' XlockMore usable." (auto-login? gdm-configuration-auto-login? (default #f)) (dbus-daemon gdm-configuration-dbus-daemon (default dbus-daemon-wrapper)) (default-user gdm-configuration-default-user (default #f)) + (gnome-shell-assets gdm-configuration-gnome-shell-assets + (default (list adwaita-icon-theme font-cantarell))) (x-server gdm-configuration-x-server (default (xorg-wrapper)))) @@ -714,13 +717,16 @@ makes the good ol' XlockMore usable." (string-append "GDM_X_SERVER=" #$(gdm-configuration-x-server config)) - ;; XXX: GDM requires access to a handful of - ;; programs and components from Gnome (gnome-shell, - ;; dbus, and gnome-session among others). The - ;; following variables only work provided Gnome is - ;; installed. - "XDG_DATA_DIRS=/run/current-system/profile/share" - "PATH=/run/current-system/profile/bin")))) + (string-append + "XDG_DATA_DIRS=" + ((lambda (ls) (string-join ls ":")) + (map (lambda (path) + (string-append path "/share")) + ;; XXX: Remove gnome-shell below when GDM + ;; can depend on GNOME Shell directly. + (cons #$gnome-shell + '#$(gdm-configuration-gnome-shell-assets + config))))))))) (stop #~(make-kill-destructor)) (respawn? #t)))) @@ -733,6 +739,8 @@ makes the good ol' XlockMore usable." (const %gdm-accounts)) (service-extension pam-root-service-type gdm-pam-service) + (service-extension profile-service-type + gdm-configuration-gnome-shell-assets) (service-extension dbus-root-service-type (compose list gdm-configuration-gdm)))) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 14:23:21 2019 Received: (at 34470) by debbugs.gnu.org; 13 Feb 2019 19:23:21 +0000 Received: from localhost ([127.0.0.1]:47344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07t-0001kP-7Q for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:21 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu07r-0001jn-A9 for 34470@debbugs.gnu.org; Wed, 13 Feb 2019 14:23:19 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 40A46247E5; Wed, 13 Feb 2019 14:23:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 13 Feb 2019 14:23:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=1W6e9WQpmaLAD3CB7vrd9z7l3Oik/KfPa+4krzq6IBo=; b=Dvebo0Wp H/lS9sEWkqNE1O/vKaQ0Q48MBCt0JOJf+ztYn6YJymOWhZTkrsIO4mNS+VEVnWUy Fi5F7yDSlGcE+QHtML7ZkWTx8ox+0sBp3PNI5EWG17VI+X/faEEnS7ayL/NOG0QM IkxXNCUTvuenPQvVH8bLXaHPUlAw3RWIzi+OlyJOhBzVnCwbiDS3g/mcE6pe5HO3 VdF+leJsMuTnDoihkIkzlquevcOzT9uMdgUES4Mt5jS2QQGBRLHX3dI/G4CIozBc /Kc7tYW3E6MqJ2OZcccmY9ferbcf9P/DBFrPbNM82TPE/2Oect5/8gUZLTQ/zaTF tb+hXWL9FykqQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomh epvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheq necukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id B287DE4662; Wed, 13 Feb 2019 14:23:13 -0500 (EST) From: Timothy Sample To: 34470@debbugs.gnu.org Subject: [PATCH 8/8] services: gdm: Allow for custom X session scripts. Date: Wed, 13 Feb 2019 14:22:21 -0500 Message-Id: <20190213192221.26599-8-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87o97fijyh.fsf@ngyro.com> References: <87o97fijyh.fsf@ngyro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/gnome.scm (gdm)[arguments]: Update pre-configure phase so that GDM runs an X session script specified by the variable GDM_X_SESSION; remove the '--enable-gdm-xsession' configuration option. * gnu/services/xorg.scm (): Add 'x-session' field. (gdm-shepherd-service): Set the GDM_X_SESSION variable. --- gnu/packages/gnome.scm | 9 ++++----- gnu/services/xorg.scm | 7 ++++++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 3c09d6b30a..a4563617d9 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5328,10 +5328,6 @@ libxml2.") ;; service for TTY 1 before starting GDM). "--with-initial-vt=7" - ;; By default, GDM expects distributions to install a custom Xsession - ;; script. It provides a generic one if --enable-gdm-xsession is set. - "--enable-gdm-xsession" - ;; Use '/etc/environment' for locale settings instead of the ;; systemd-specific '/etc/locale.conf'. "--with-lang-file=/etc/environment" @@ -5381,6 +5377,7 @@ libxml2.") (let ((propagate '("GDM_CUSTOM_CONF" "GDM_DBUS_DAEMON" "GDM_X_SERVER" + "GDM_X_SESSION" ;; XXX: Remove this once GNOME Shell is ;; a dependency of GDM. "XDG_DATA_DIRS"))) @@ -5408,7 +5405,9 @@ libxml2.") (("\"dbus-daemon\"") "g_getenv (\"GDM_DBUS_DAEMON\")") (("X_SERVER") - "g_getenv (\"GDM_X_SERVER\")")) + "g_getenv (\"GDM_X_SERVER\")") + (("GDMCONFDIR \"/Xsession\"") + "g_getenv (\"GDM_X_SESSION\")")) ;; Use an absolute path for GNOME Session. (substitute* "daemon/gdm-launch-environment.c" (("\"gnome-session\"") diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index 4e6f5ad44f..f7d07b309e 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -646,7 +646,9 @@ makes the good ol' XlockMore usable." (gnome-shell-assets gdm-configuration-gnome-shell-assets (default (list adwaita-icon-theme font-cantarell))) (x-server gdm-configuration-x-server - (default (xorg-wrapper)))) + (default (xorg-wrapper))) + (x-session gdm-configuration-x-session + (default (xinitrc)))) (define (gdm-configuration-file config) (mixed-text-file "gdm-custom.conf" @@ -717,6 +719,9 @@ makes the good ol' XlockMore usable." (string-append "GDM_X_SERVER=" #$(gdm-configuration-x-server config)) + (string-append + "GDM_X_SESSION=" + #$(gdm-configuration-x-session config)) (string-append "XDG_DATA_DIRS=" ((lambda (ls) (string-join ls ":")) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 11:14:19 2019 Received: (at 34470) by debbugs.gnu.org; 16 Feb 2019 16:14:19 +0000 Received: from localhost ([127.0.0.1]:50473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gv2bb-0003NR-2W for submit@debbugs.gnu.org; Sat, 16 Feb 2019 11:14:19 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:57606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gv2bZ-0003NK-B4 for 34470@debbugs.gnu.org; Sat, 16 Feb 2019 11:14:17 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B5E5E10669; Sat, 16 Feb 2019 17:14:16 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lEi-60sI-fNd; Sat, 16 Feb 2019 17:14:15 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9C00110666; Sat, 16 Feb 2019 17:14:15 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: [bug#34470] [PATCH 4/8] gnu: gdm: Use absolute path for gnome-session. References: <87o97fijyh.fsf@ngyro.com> <20190213192221.26599-4-samplet@ngyro.com> Date: Sat, 16 Feb 2019 17:14:14 +0100 In-Reply-To: <20190213192221.26599-4-samplet@ngyro.com> (Timothy Sample's message of "Wed, 13 Feb 2019 14:22:17 -0500") Message-ID: <87d0nrhfs9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 34470 Cc: 34470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi! Timothy Sample skribis: > * gnu/packages/gnome.scm (gdm)[arguments]: Modify the pre-configure > phase to substitute in the absolute path of gnome-session. > [inputs]: Add gnome-session. This patch means that we=E2=80=99re pulling in GNOME even when we don=E2=80= =99t actually need it: --8<---------------cut here---------------start------------->8--- $ guix size gdm |tail -1 total: 909.4 MiB $ guix size gdm gnome-session |tail -1 total: 1011.8 MiB --8<---------------cut here---------------end--------------->8--- Do you think we could avoid that? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 16 18:09:13 2019 Received: (at 34470) by debbugs.gnu.org; 16 Feb 2019 23:09:13 +0000 Received: from localhost ([127.0.0.1]:50613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gv957-0000Sv-1E for submit@debbugs.gnu.org; Sat, 16 Feb 2019 18:09:13 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:33416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gv955-0000Sn-EZ for 34470@debbugs.gnu.org; Sat, 16 Feb 2019 18:09:11 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DB5F8107DF; Sun, 17 Feb 2019 00:09:10 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ICnGSlT9WHhM; Sun, 17 Feb 2019 00:09:10 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C97C7EAC3; Sun, 17 Feb 2019 00:09:09 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: [bug#34470] [PATCH 0/8] GDM without GNOME Desktop References: <87o97fijyh.fsf@ngyro.com> Date: Sun, 17 Feb 2019 00:09:09 +0100 In-Reply-To: <87o97fijyh.fsf@ngyro.com> (Timothy Sample's message of "Wed, 13 Feb 2019 14:09:42 -0500") Message-ID: <875ztjfi0a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 34470 Cc: 34470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, Timothy Sample skribis: > services: gdm: Remove etc service. > gnu: gnome-session: Use absolute paths in .desktop files. > gnu: gdm: Add links to required login-session files. > gnu: gdm: Use absolute path for gnome-session. > gnu: gdm: Simplify pre-configure phase. > gnu: gdm: Run dbus-daemon via a wrapper script. > services: gdm: Make dependencies explicit. > services: gdm: Allow for custom X session scripts. Very nice! I=E2=80=99ve pushed everything but patch #4 (=E2=80=9CUse absol= ute path for gnome-session.=E2=80=9D) for the reason given in my other message. Let=E2=80=99s see if we can avoid it this last patch. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 17 10:13:25 2019 Received: (at 34470) by debbugs.gnu.org; 17 Feb 2019 15:13:25 +0000 Received: from localhost ([127.0.0.1]:51460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvO8B-0002mT-46 for submit@debbugs.gnu.org; Sun, 17 Feb 2019 10:13:24 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvO88-0002mE-5V for 34470@debbugs.gnu.org; Sun, 17 Feb 2019 10:13:20 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1FF2521C57; Sun, 17 Feb 2019 10:13:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 17 Feb 2019 10:13:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=2QX7ceCmKzWM4y/1LJNuQFYXKTu7DsXwUVezlhH+crc=; b=3HBBoOLx Ls9zgMvxuJN0SUK++zItcD7gTovgXEkKgWkvDasg4nWvv9kWHwls/nO/7l7icqnN BNsTJuVWvrpXMjrqKKXhVoIMIIBX8wW7oIKWbRMvnVrE2pMeRJCVVs4upjiNsAxa X355+x5XD4RerSIMbWhSomZ1QZmVuT1JT63RzR+OTIwVnguEJ1Q/LRpMcxqJ9E7I O9Jp8pUZGo8pOiKHzd5O9jAjKFCntIWxOkqcqw/5nhbySgpggOIQdCoqevT6PH8f WSoAkI7rxaz0n/wktYDcOAs2vWcefshiOORdsxrxYsU30nNRMWv/Zn7Qrg2Kfiv7 J1oMPPwQwcNFVA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrudduuddgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffkf gfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhhothhhhicuufgrmhhplhgvuceo shgrmhhplhgvthesnhhghihrohdrtghomheqnecukfhppeejgedrudduiedrudekiedrge egnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgtohhm necuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 41F511030F; Sun, 17 Feb 2019 10:13:14 -0500 (EST) From: Timothy Sample To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#34470] [PATCH 4/8] gnu: gdm: Use absolute path for gnome-session. References: <87o97fijyh.fsf@ngyro.com> <20190213192221.26599-4-samplet@ngyro.com> <87d0nrhfs9.fsf@gnu.org> Date: Sun, 17 Feb 2019 10:13:12 -0500 Message-ID: <877edyih2v.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: 34470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Ludo, Ludovic Court=C3=A8s writes: > Hi! > > Timothy Sample skribis: > >> * gnu/packages/gnome.scm (gdm)[arguments]: Modify the pre-configure >> phase to substitute in the absolute path of gnome-session. >> [inputs]: Add gnome-session. > > This patch means that we=E2=80=99re pulling in GNOME even when we don=E2= =80=99t actually > need it: > > $ guix size gdm |tail -1 > total: 909.4 MiB > $ guix size gdm gnome-session |tail -1 > total: 1011.8 MiB > > Do you think we could avoid that? My understanding is that the login screen is more or less a normal user session brought up by gnome-session for the =E2=80=9Cgdm=E2=80=9D user. Sh= y of re-implementing the parts of gnome-session we need, I don=E2=80=99t have any ideas on how to avoid this dependency. I know that GDM sends it a list of components to initialize (e.g., GNOME Shell), but I don=E2=80=99t know w= hat else it does for GDM. My guess is that it would be possible to trim down some of these packages to recover the space. GDM is very heavy-weight software, but 1G seems like a lot. :( -- Tim From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 04 05:38:34 2019 Received: (at 34470) by debbugs.gnu.org; 4 Mar 2019 10:38:34 +0000 Received: from localhost ([127.0.0.1]:58994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0kzS-0005MH-H7 for submit@debbugs.gnu.org; Mon, 04 Mar 2019 05:38:34 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:34010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0kzQ-0005M6-Dr for 34470@debbugs.gnu.org; Mon, 04 Mar 2019 05:38:32 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 2088B9ACF; Mon, 4 Mar 2019 11:38:31 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YYSXvbjO9tWO; Mon, 4 Mar 2019 11:38:30 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 027719ACD; Mon, 4 Mar 2019 11:38:29 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: [bug#34470] [PATCH 4/8] gnu: gdm: Use absolute path for gnome-session. References: <87o97fijyh.fsf@ngyro.com> <20190213192221.26599-4-samplet@ngyro.com> <87d0nrhfs9.fsf@gnu.org> <877edyih2v.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 =?utf-8?Q?Vent=C3=B4se?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 04 Mar 2019 11:38:29 +0100 In-Reply-To: <877edyih2v.fsf@ngyro.com> (Timothy Sample's message of "Sun, 17 Feb 2019 10:13:12 -0500") Message-ID: <87pnr6sz4q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 34470 Cc: 34470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Timothy, Timothy Sample skribis: > Ludovic Court=C3=A8s writes: > >> Hi! >> >> Timothy Sample skribis: >> >>> * gnu/packages/gnome.scm (gdm)[arguments]: Modify the pre-configure >>> phase to substitute in the absolute path of gnome-session. >>> [inputs]: Add gnome-session. >> >> This patch means that we=E2=80=99re pulling in GNOME even when we don=E2= =80=99t actually >> need it: >> >> $ guix size gdm |tail -1 >> total: 909.4 MiB >> $ guix size gdm gnome-session |tail -1 >> total: 1011.8 MiB >> >> Do you think we could avoid that? > > My understanding is that the login screen is more or less a normal user > session brought up by gnome-session for the =E2=80=9Cgdm=E2=80=9D user. = Shy of > re-implementing the parts of gnome-session we need, I don=E2=80=99t have = any > ideas on how to avoid this dependency. I know that GDM sends it a list > of components to initialize (e.g., GNOME Shell), but I don=E2=80=99t know= what > else it does for GDM. GDM does seem to work without that dependency though (on current master); or is there missing functionality? If we must have it though, let=E2=80=99s have it, and we can then see how to trim that closure. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 04 11:47:34 2019 Received: (at 34470) by debbugs.gnu.org; 4 Mar 2019 16:47:34 +0000 Received: from localhost ([127.0.0.1]:60135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0qkX-0000IS-Vo for submit@debbugs.gnu.org; Mon, 04 Mar 2019 11:47:34 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0qkW-0000ID-01 for 34470@debbugs.gnu.org; Mon, 04 Mar 2019 11:47:32 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D42C322127; Mon, 4 Mar 2019 11:47:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 04 Mar 2019 11:47:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=oV6+dDN2Sc+wVz1fUMlnisiZjnM0DhT+lgm//wh2r po=; b=EauMKbcJNm8oGkd7hMEtBBOBBQbk4mESxbVRIsrwLw4z1NbTrgRh1MJUW 6cpJnc1LFjm43fTrkPD7ZZw2QhlJGxPXn3Tdqvva7+bYgZqAaQ1WPq9dNAMD1jq9 kpjbQDyK176uqwEhsMbGkuSrb+vncHdDNG0C4+lCB0aizVC642zh6jxAP9HewWij n+C7Cl5eBF0L+e69VcLuwAEnRHCZkARg5ktksOwzNNYvIyEgh3Hai0JhkAhmdDfr 6mDxm0QI96DaReAyyb6o4ICxhrb9K27m6d+PWHT9qzyI7slewc85Z7vLUQz5nWyv SefGv5cUin3MV4YhdBR5P/TDNKQRg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfedugdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucfkphepje egrdduudeirddukeeirdeggeenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgv thesnhhghihrohdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 1162310318; Mon, 4 Mar 2019 11:47:26 -0500 (EST) From: Timothy Sample To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#34470] [PATCH 4/8] gnu: gdm: Use absolute path for gnome-session. References: <87o97fijyh.fsf@ngyro.com> <20190213192221.26599-4-samplet@ngyro.com> <87d0nrhfs9.fsf@gnu.org> <877edyih2v.fsf@ngyro.com> <87pnr6sz4q.fsf@gnu.org> Date: Mon, 04 Mar 2019 11:47:25 -0500 In-Reply-To: <87pnr6sz4q.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 04 Mar 2019 11:38:29 +0100") Message-ID: <87r2bmk2n6.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34470 Cc: 34470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Ludo, Ludovic Court=C3=A8s writes: > [...] > >>>> * gnu/packages/gnome.scm (gdm)[arguments]: Modify the pre-configure >>>> phase to substitute in the absolute path of gnome-session. >>>> [inputs]: Add gnome-session. > > [...] > > GDM does seem to work without that dependency though (on current > master); or is there missing functionality? It turns out you committed this patch to master as def6d6b61685f69421df80cb524ba94da5dadd42. If I revert the commit, GDM does not work (without GNOME installed in the system profile). If there is a way to work around GNOME Session, I=E2=80=99m not clever enou= gh to think of it. :( > If we must have it though, let=E2=80=99s have it, and we can then see how= to > trim that closure. I looked at this briefly when you first brought it up, because I thought there would be something blindingly obvious that I could cut out. Unfortunately, I didn=E2=80=99t find anything. It probably can be tightene= d up, it just needs to examined a bit more carefully. -- Tim From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 04 16:08:54 2019 Received: (at 34470-done) by debbugs.gnu.org; 4 Mar 2019 21:08:54 +0000 Received: from localhost ([127.0.0.1]:60288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0upR-0000FZ-Q0 for submit@debbugs.gnu.org; Mon, 04 Mar 2019 16:08:54 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0upQ-0000FR-5g for 34470-done@debbugs.gnu.org; Mon, 04 Mar 2019 16:08:53 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DDF7E11CD4; Mon, 4 Mar 2019 22:08:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BEXwo1z8SebN; Mon, 4 Mar 2019 22:08:50 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id BCFE511C65; Mon, 4 Mar 2019 22:08:49 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: [bug#34470] [PATCH 4/8] gnu: gdm: Use absolute path for gnome-session. References: <87o97fijyh.fsf@ngyro.com> <20190213192221.26599-4-samplet@ngyro.com> <87d0nrhfs9.fsf@gnu.org> <877edyih2v.fsf@ngyro.com> <87pnr6sz4q.fsf@gnu.org> <87r2bmk2n6.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 =?utf-8?Q?Vent=C3=B4se?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 04 Mar 2019 22:08:49 +0100 In-Reply-To: <87r2bmk2n6.fsf@ngyro.com> (Timothy Sample's message of "Mon, 04 Mar 2019 11:47:25 -0500") Message-ID: <87fts2pcta.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 34470-done Cc: 34470-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello! Timothy Sample skribis: > Ludovic Court=C3=A8s writes: > >> [...] >> >>>>> * gnu/packages/gnome.scm (gdm)[arguments]: Modify the pre-configure >>>>> phase to substitute in the absolute path of gnome-session. >>>>> [inputs]: Add gnome-session. >> >> [...] >> >> GDM does seem to work without that dependency though (on current >> master); or is there missing functionality? > > It turns out you committed this patch to master as > def6d6b61685f69421df80cb524ba94da5dadd42. Oh, true; two weeks of vacations and everything is forgotten. :-) > If I revert the commit, GDM does not work (without GNOME installed in > the system profile). > > If there is a way to work around GNOME Session, I=E2=80=99m not clever en= ough to > think of it. :( Alright, well so be it. Then I guess the next step is to stare at =E2=80=98guix size gdm=E2=80=99 i= n search of ways to trim the closure. It might not be that hard actually: --8<---------------cut here---------------start------------->8--- $ guix size gdm |head store item total s= elf /gnu/store/bvnj04sqiwc1gcis29swk6likyc5dw8f-llvm-6.0.1 268.1 = 104.5 7.7% /gnu/store/n2p1zs14y89lwkg9da68y12pc10c6sw9-gcc-5.5.0 161.9 = 93.7 6.9% /gnu/store/b7fqhszxl02g6pfm3vw6b3cjz472qrly-python-3.7.0 182.8 = 74.6 5.5% /gnu/store/j6g996l8kxxv8c76a9c61n3gi4s0wvdr-mesa-18.3.1 360.5 = 63.8 4.7% /gnu/store/dna8kpb00kq176rz8x69yy4j33my2q55-perl-5.28.0 146.3 = 58.2 4.3% /gnu/store/g87hamjyipk1j6dfq5pjfzfnfb64spbv-python2-2.7.15 163.6 = 56.6 4.2% /gnu/store/fh42kncsw279yn24kcqiydmqbzg3iv3a-mozjs-52.0-1.6507e63 209.6 = 54.0 4.0% /gnu/store/f2y93basw0ykg7spgxbxsy95l64fhbc9-gtk+-3.24.2 702.4 = 45.5 3.4% /gnu/store/9alic3caqhay3h8mx4iihpmyj6ymqpcx-guile-2.2.4 121.9 = 44.4 3.3% --8<---------------cut here---------------end--------------->8--- That GCC is out of place and that LLVM is surely too big. >> If we must have it though, let=E2=80=99s have it, and we can then see ho= w to >> trim that closure. > > I looked at this briefly when you first brought it up, because I thought > there would be something blindingly obvious that I could cut out. > Unfortunately, I didn=E2=80=99t find anything. It probably can be tighte= ned up, > it just needs to examined a bit more carefully. Yup, we=E2=80=99ll see. Closing this issue now anyway. Thank you! Ludo=E2=80=99. From unknown Sun Jun 15 01:08:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Apr 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator