From unknown Fri Jun 13 06:10:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34466 <34466@debbugs.gnu.org> To: bug#34466 <34466@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add coq-equations. Reply-To: bug#34466 <34466@debbugs.gnu.org> Date: Fri, 13 Jun 2025 13:10:38 +0000 retitle 34466 [PATCH] gnu: Add coq-equations. reassign 34466 guix-patches submitter 34466 Dan Frumin severity 34466 normal tag 34466 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 05:42:10 2019 Received: (at submit) by debbugs.gnu.org; 13 Feb 2019 10:42:10 +0000 Received: from localhost ([127.0.0.1]:45773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtrzW-0007nx-Fl for submit@debbugs.gnu.org; Wed, 13 Feb 2019 05:42:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtrzU-0007nh-Df for submit@debbugs.gnu.org; Wed, 13 Feb 2019 05:42:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:55472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gtrzP-0007rS-7j for submit@debbugs.gnu.org; Wed, 13 Feb 2019 05:42:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtrzJ-0002eM-I2 for guix-patches@gnu.org; Wed, 13 Feb 2019 05:42:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtrzI-0007kj-MF for guix-patches@gnu.org; Wed, 13 Feb 2019 05:41:57 -0500 Received: from smtp2.science.ru.nl ([131.174.16.145]:56702) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gtrzI-0007dg-Dx for guix-patches@gnu.org; Wed, 13 Feb 2019 05:41:56 -0500 Received: from localhost.localdomain (n142220.science.ru.nl [131.174.142.220]) (authen=dfrumin@cs.ru.nl) by smtp2.science.ru.nl (8.14.4/5.32) with ESMTP id x1DAfIO1032271; Wed, 13 Feb 2019 11:41:49 +0100 From: Dan Frumin To: guix-patches@gnu.org Subject: [PATCH] gnu: Add coq-equations. Date: Wed, 13 Feb 2019 11:40:24 +0100 Message-Id: <20190213104024.1963-1-dfrumin@cs.ru.nl> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 131.174.16.145 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Dan Frumin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --- gnu/packages/coq.scm | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm index fa02f85cd..494c3404b 100644 --- a/gnu/packages/coq.scm +++ b/gnu/packages/coq.scm @@ -500,3 +500,43 @@ work on a decision procedure for the equational theory of an extension of the sigma-calculus by Abadi et al. The library is completely written in Coq and uses Ltac to synthesize the substitution operation.") (license license:bsd-3)))) + +(define-public coq-equations + (package + (name "coq-equations") + (synopsis "Equations - a function definition plugin") + (version "1.2-beta") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/mattam82/Coq-Equations/archive/v" + version "-8.8.tar.gz")) + (file-name (string-append name "-v" version "8.8.tar.gz")) + (sha256 + (base32 "1j7yarhddk2c2l4b6h8g5n0xz5vfy1bqmgh832g01di5gjwshy3f")))) + (build-system gnu-build-system) + (native-inputs + `(("findlib" ,ocaml) + ("coq" ,coq) + ("camlp5" ,camlp5))) + (arguments + `(#:test-target "test-suite" + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (invoke "coq_makefile" "-f" "_CoqProject" "-o" "Makefile"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (setenv "COQLIB" (string-append (assoc-ref outputs "out") "/lib/coq/")) + (invoke "make" + (string-append "COQLIB=" (assoc-ref outputs "out") + "/lib/coq/") + "install")))))) + (description "Equations provides a notation for writing programs +by dependent pattern-matching and (well-founded) recursion in Coq. It +compiles everything down to eliminators for inductive types, equality +and accessibility, providing a definitional extension to the Coq +kernel.") + (home-page "https://mattam82.github.io/Coq-Equations/") + (license license:lgpl2.1))) -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 06:05:03 2019 Received: (at 34466) by debbugs.gnu.org; 13 Feb 2019 11:05:03 +0000 Received: from localhost ([127.0.0.1]:45782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtsLe-0008OR-Cm for submit@debbugs.gnu.org; Wed, 13 Feb 2019 06:05:02 -0500 Received: from lepiller.eu ([89.234.186.109]:51254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtsLc-0008Nt-BD for 34466@debbugs.gnu.org; Wed, 13 Feb 2019 06:05:01 -0500 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 46147ae5 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 13 Feb 2019 11:04:49 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 13 Feb 2019 12:04:48 +0100 From: Julien Lepiller To: Dan Frumin Subject: Re: [bug#34466] [PATCH] gnu: Add coq-equations. In-Reply-To: <20190213104024.1963-1-dfrumin@cs.ru.nl> References: <20190213104024.1963-1-dfrumin@cs.ru.nl> Message-ID: X-Sender: julien@lepiller.eu User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34466 Cc: 34466@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 2019-02-13 11:40, Dan Frumin a écrit : > --- > gnu/packages/coq.scm | 40 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm > index fa02f85cd..494c3404b 100644 > --- a/gnu/packages/coq.scm > +++ b/gnu/packages/coq.scm > @@ -500,3 +500,43 @@ work on a decision procedure for the equational > theory of an extension of the > sigma-calculus by Abadi et al. The library is completely written in > Coq and > uses Ltac to synthesize the substitution operation.") > (license license:bsd-3)))) Hi Dan, thanks for this patch! I have some comments below to help improve the quality of future patches, as well as two questions you need to answer before I can push that patch. > + > +(define-public coq-equations > + (package > + (name "coq-equations") > + (synopsis "Equations - a function definition plugin") Could you put this just before the description field, so this package definition looks more like the rest of guix? A better synopsis would be "Function definiton plugin for coq" I think. > + (version "1.2-beta") Why a beta version? We try to stick to stable releases in Guix. Please add a comment explaining the reason. > + (source (origin > + (method url-fetch) > + (uri (string-append > + > "https://github.com/mattam82/Coq-Equations/archive/v" > + version "-8.8.tar.gz")) > + (file-name (string-append name "-v" version > "8.8.tar.gz")) We cannot use auto-generated tarballs from github, because we found that they sometimes get regenerated in an unreproducible way, so it breaks the checksum test. You can use this instead: (method git-fetch) (uri (git-reference (url "https://githu.com/mattam82/Coq-Equations.git") (commit (string-append "v" version "-8.8")))) and update the sha256 accordingly. As an added bonus, this means that we can always fetch from the software heritage in case the repo disappears one day :) > + (sha256 > + (base32 > "1j7yarhddk2c2l4b6h8g5n0xz5vfy1bqmgh832g01di5gjwshy3f")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("findlib" ,ocaml) ocaml doesn't provide findlib directly, ocaml-findlib does. What do you want to do here? > + ("coq" ,coq) > + ("camlp5" ,camlp5))) > + (arguments > + `(#:test-target "test-suite" > + #:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (invoke "coq_makefile" "-f" "_CoqProject" "-o" > "Makefile"))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (setenv "COQLIB" (string-append (assoc-ref outputs > "out") "/lib/coq/")) > + (invoke "make" > + (string-append "COQLIB=" (assoc-ref outputs > "out") > + "/lib/coq/") > + "install")))))) Please make sure that these two phases both return #t. > + (description "Equations provides a notation for writing programs > +by dependent pattern-matching and (well-founded) recursion in Coq. It > +compiles everything down to eliminators for inductive types, equality > +and accessibility, providing a definitional extension to the Coq > +kernel.") Please make sure that each sentence is separated by two spaces. `guix lint coq-equations` should be able to tell you about it. > + (home-page "https://mattam82.github.io/Coq-Equations/") > + (license license:lgpl2.1))) Thanks again! I really only need an answer for the beta version and ocaml/findlib questions. I can take care of the rest, but I would appreciate it if you could do it yourself ;) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 06:35:35 2019 Received: (at 34466) by debbugs.gnu.org; 13 Feb 2019 11:35:35 +0000 Received: from localhost ([127.0.0.1]:45798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtspC-0000n2-Vk for submit@debbugs.gnu.org; Wed, 13 Feb 2019 06:35:35 -0500 Received: from smtp1.science.ru.nl ([131.174.16.143]:44266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtsp9-0000mq-FL for 34466@debbugs.gnu.org; Wed, 13 Feb 2019 06:35:33 -0500 Received: from [131.174.142.220] (n142220.science.ru.nl [131.174.142.220]) (authen=dfrumin) by smtp1.science.ru.nl (8.14.4/5.32) with ESMTP id x1DBZTkW015602; Wed, 13 Feb 2019 12:35:29 +0100 Subject: Re: [bug#34466] [PATCH] gnu: Add coq-equations. To: Julien Lepiller References: <20190213104024.1963-1-dfrumin@cs.ru.nl> From: Dan Frumin Message-ID: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> Date: Wed, 13 Feb 2019 12:35:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------B0CDD451A694E34845E8EFF7" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34466 Cc: 34466@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------B0CDD451A694E34845E8EFF7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien. Thank you for your thorough comments, I really appreciate it! I hope that the quality of my patches increase in time so please bear with me for a bit :) On 13-02-19 12:04, Julien Lepiller wrote: > Le 2019-02-13 11:40, Dan Frumin a écrit : >> --- >>  gnu/packages/coq.scm | 40 ++++++++++++++++++++++++++++++++++++++++ >>  1 file changed, 40 insertions(+) >> >> diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm >> index fa02f85cd..494c3404b 100644 >> --- a/gnu/packages/coq.scm >> +++ b/gnu/packages/coq.scm >> @@ -500,3 +500,43 @@ work on a decision procedure for the equational >> theory of an extension of the >>  sigma-calculus by Abadi et al.  The library is completely written in Coq and >>  uses Ltac to synthesize the substitution operation.") >>        (license license:bsd-3)))) > > Hi Dan, thanks for this patch! I have some comments below to help improve the > quality of future patches, as well as two questions you need to answer before > I can push that patch. > >> + >> +(define-public coq-equations >> +  (package >> +    (name "coq-equations") >> +    (synopsis "Equations - a function definition plugin") > > Could you put this just before the description field, so this package definition > looks more like the rest of guix? A better synopsis would be "Function definiton > plugin for coq" I think. I've reordered the fields to match the rest of the package definitions in guix. > >> +    (version "1.2-beta") > > Why a beta version? We try to stick to stable releases in Guix. Please add a > comment explaining the reason. > Oh, I just wanted to use the latest released version. I can replace it with the version 1.1 while I wait for the non-beta 1.2 releas. >> +    (source (origin >> +              (method url-fetch) >> +              (uri (string-append >> + "https://github.com/mattam82/Coq-Equations/archive/v" >> +                    version "-8.8.tar.gz")) >> +              (file-name (string-append name "-v" version "8.8.tar.gz")) > > We cannot use auto-generated tarballs from github, because we found that > they sometimes get regenerated in an unreproducible way, so it breaks the > checksum test. You can use this instead: > > (method git-fetch) > (uri (git-reference >        (url "https://githu.com/mattam82/Coq-Equations.git") >        (commit (string-append "v" version "-8.8")))) > > and update the sha256 accordingly. As an added bonus, this means that we > can always fetch from the software heritage in case the repo disappears > one day :) I was not aware of that. How can I get the sha256 hash in this case? Normally I would do `guix download `. > >> +              (sha256 >> +               (base32 >> "1j7yarhddk2c2l4b6h8g5n0xz5vfy1bqmgh832g01di5gjwshy3f")))) >> +    (build-system gnu-build-system) >> +    (native-inputs >> +     `(("findlib" ,ocaml) > > ocaml doesn't provide findlib directly, ocaml-findlib does. What do you > want to do here? Sorry, I think I was confused here. I've corrected this in the updated patch. > >> +       ("coq"     ,coq) >> +       ("camlp5"  ,camlp5))) >> +    (arguments >> +     `(#:test-target "test-suite" >> +       #:phases >> +       (modify-phases %standard-phases >> +         (replace 'configure >> +           (lambda* (#:key outputs #:allow-other-keys) >> +             (invoke "coq_makefile" "-f" "_CoqProject" "-o" "Makefile"))) >> +         (replace 'install >> +           (lambda* (#:key outputs #:allow-other-keys) >> +             (setenv "COQLIB" (string-append (assoc-ref outputs >> "out") "/lib/coq/")) >> +             (invoke "make" >> +                     (string-append "COQLIB=" (assoc-ref outputs "out") >> +                                    "/lib/coq/") >> +                     "install")))))) > > Please make sure that these two phases both return #t. I thought that `invoke' automatically checks that the return code is correct? > >> +    (description "Equations provides a notation for writing programs >> +by dependent pattern-matching and (well-founded) recursion in Coq. It >> +compiles everything down to eliminators for inductive types, equality >> +and accessibility, providing a definitional extension to the Coq >> +kernel.") > > Please make sure that each sentence is separated by two spaces. > `guix lint coq-equations` should be able to tell you about it. > >> +    (home-page "https://mattam82.github.io/Coq-Equations/") >> +    (license license:lgpl2.1))) > > Thanks again! I really only need an answer for the beta version and > ocaml/findlib questions. I can take care of the rest, but I would > appreciate it if you could do it yourself ;) --------------B0CDD451A694E34845E8EFF7 Content-Type: text/x-patch; name="0001-gnu-Add-coq-equations.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-Add-coq-equations.patch" >From ebbb6e1cb1f667f33cc4e4320fdb91edf33264dc Mon Sep 17 00:00:00 2001 From: Dan Frumin Date: Wed, 13 Feb 2019 12:34:40 +0100 Subject: [PATCH] gnu: Add coq-equations. --- gnu/packages/coq.scm | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm index fa02f85cd..b7eadc2fd 100644 --- a/gnu/packages/coq.scm +++ b/gnu/packages/coq.scm @@ -500,3 +500,43 @@ work on a decision procedure for the equational theory of an extension of the sigma-calculus by Abadi et al. The library is completely written in Coq and uses Ltac to synthesize the substitution operation.") (license license:bsd-3)))) + +(define-public coq-equations + (package + (name "coq-equations") + (version "1.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mattam82/Coq-Equations.git") + (commit (string-append "v" version "-8.8")))) + (file-name (git-file-name name version)) + (sha256 + (base32 "129rxsdsf88vjcw0xhm74yax1hmnk6f8n9ksg0hcyyjq1ijddiwa")))) + (build-system gnu-build-system) + (native-inputs + `(("ocaml" ,ocaml) + ("coq" ,coq) + ("camlp5" ,camlp5))) + (arguments + `(#:test-target "test-suite" + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (invoke "coq_makefile" "-f" "_CoqProject" "-o" "Makefile"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (setenv "COQLIB" (string-append (assoc-ref outputs "out") "/lib/coq/")) + (invoke "make" + (string-append "COQLIB=" (assoc-ref outputs "out") + "/lib/coq/") + "install")))))) + (home-page "https://mattam82.github.io/Coq-Equations/") + (synopsis "Function definition plugin for Coq") + (description "Equations provides a notation for writing programs +by dependent pattern-matching and (well-founded) recursion in Coq. It +compiles everything down to eliminators for inductive types, equality +and accessibility, providing a definitional extension to the Coq +kernel.") + (license license:lgpl2.1))) -- 2.17.1 --------------B0CDD451A694E34845E8EFF7-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 06:37:03 2019 Received: (at 34466) by debbugs.gnu.org; 13 Feb 2019 11:37:03 +0000 Received: from localhost ([127.0.0.1]:45802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtsqc-0000ph-JT for submit@debbugs.gnu.org; Wed, 13 Feb 2019 06:37:03 -0500 Received: from smtp1.science.ru.nl ([131.174.16.143]:44372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtsqa-0000pI-PI for 34466@debbugs.gnu.org; Wed, 13 Feb 2019 06:37:01 -0500 Received: from [131.174.142.220] (n142220.science.ru.nl [131.174.142.220]) (authen=dfrumin) by smtp1.science.ru.nl (8.14.4/5.32) with ESMTP id x1DBaxjE015965 for <34466@debbugs.gnu.org>; Wed, 13 Feb 2019 12:37:00 +0100 Subject: Fwd: Re: [bug#34466] [PATCH] gnu: Add coq-equations. References: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> To: 34466@debbugs.gnu.org From: Dan Frumin X-Forwarded-Message-Id: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> Message-ID: Date: Wed, 13 Feb 2019 12:36:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> Content-Type: multipart/mixed; boundary="------------5FEB6685F411C921127FF702" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34466 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------5FEB6685F411C921127FF702 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit (sorry, sending this again because I forgot to CC the bugtracker) Hi Julien. Thank you for your thorough comments, I really appreciate it! I hope that the quality of my patches increase in time so please bear with me for a bit :) On 13-02-19 12:04, Julien Lepiller wrote: > Le 2019-02-13 11:40, Dan Frumin a écrit : >> --- >>  gnu/packages/coq.scm | 40 ++++++++++++++++++++++++++++++++++++++++ >>  1 file changed, 40 insertions(+) >> >> diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm >> index fa02f85cd..494c3404b 100644 >> --- a/gnu/packages/coq.scm >> +++ b/gnu/packages/coq.scm >> @@ -500,3 +500,43 @@ work on a decision procedure for the equational >> theory of an extension of the >>  sigma-calculus by Abadi et al.  The library is completely written in Coq and >>  uses Ltac to synthesize the substitution operation.") >>        (license license:bsd-3)))) > > Hi Dan, thanks for this patch! I have some comments below to help improve the > quality of future patches, as well as two questions you need to answer before > I can push that patch. > >> + >> +(define-public coq-equations >> +  (package >> +    (name "coq-equations") >> +    (synopsis "Equations - a function definition plugin") > > Could you put this just before the description field, so this package definition > looks more like the rest of guix? A better synopsis would be "Function definiton > plugin for coq" I think. I've reordered the fields to match the rest of the package definitions in guix. > >> +    (version "1.2-beta") > > Why a beta version? We try to stick to stable releases in Guix. Please add a > comment explaining the reason. > Oh, I just wanted to use the latest released version. I can replace it with the version 1.1 while I wait for the non-beta 1.2 releas. >> +    (source (origin >> +              (method url-fetch) >> +              (uri (string-append >> + "https://github.com/mattam82/Coq-Equations/archive/v" >> +                    version "-8.8.tar.gz")) >> +              (file-name (string-append name "-v" version "8.8.tar.gz")) > > We cannot use auto-generated tarballs from github, because we found that > they sometimes get regenerated in an unreproducible way, so it breaks the > checksum test. You can use this instead: > > (method git-fetch) > (uri (git-reference >        (url "https://githu.com/mattam82/Coq-Equations.git") >        (commit (string-append "v" version "-8.8")))) > > and update the sha256 accordingly. As an added bonus, this means that we > can always fetch from the software heritage in case the repo disappears > one day :) I was not aware of that. How can I get the sha256 hash in this case? Normally I would do `guix download `. > >> +              (sha256 >> +               (base32 >> "1j7yarhddk2c2l4b6h8g5n0xz5vfy1bqmgh832g01di5gjwshy3f")))) >> +    (build-system gnu-build-system) >> +    (native-inputs >> +     `(("findlib" ,ocaml) > > ocaml doesn't provide findlib directly, ocaml-findlib does. What do you > want to do here? Sorry, I think I was confused here. I've corrected this in the updated patch. > >> +       ("coq"     ,coq) >> +       ("camlp5"  ,camlp5))) >> +    (arguments >> +     `(#:test-target "test-suite" >> +       #:phases >> +       (modify-phases %standard-phases >> +         (replace 'configure >> +           (lambda* (#:key outputs #:allow-other-keys) >> +             (invoke "coq_makefile" "-f" "_CoqProject" "-o" "Makefile"))) >> +         (replace 'install >> +           (lambda* (#:key outputs #:allow-other-keys) >> +             (setenv "COQLIB" (string-append (assoc-ref outputs >> "out") "/lib/coq/")) >> +             (invoke "make" >> +                     (string-append "COQLIB=" (assoc-ref outputs "out") >> +                                    "/lib/coq/") >> +                     "install")))))) > > Please make sure that these two phases both return #t. I thought that `invoke' automatically checks that the return code is correct? > >> +    (description "Equations provides a notation for writing programs >> +by dependent pattern-matching and (well-founded) recursion in Coq. It >> +compiles everything down to eliminators for inductive types, equality >> +and accessibility, providing a definitional extension to the Coq >> +kernel.") > > Please make sure that each sentence is separated by two spaces. > `guix lint coq-equations` should be able to tell you about it. > >> +    (home-page "https://mattam82.github.io/Coq-Equations/") >> +    (license license:lgpl2.1))) > > Thanks again! I really only need an answer for the beta version and > ocaml/findlib questions. I can take care of the rest, but I would > appreciate it if you could do it yourself ;) --------------5FEB6685F411C921127FF702 Content-Type: text/x-patch; name="0001-gnu-Add-coq-equations.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-Add-coq-equations.patch" >From ebbb6e1cb1f667f33cc4e4320fdb91edf33264dc Mon Sep 17 00:00:00 2001 From: Dan Frumin Date: Wed, 13 Feb 2019 12:34:40 +0100 Subject: [PATCH] gnu: Add coq-equations. --- gnu/packages/coq.scm | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm index fa02f85cd..b7eadc2fd 100644 --- a/gnu/packages/coq.scm +++ b/gnu/packages/coq.scm @@ -500,3 +500,43 @@ work on a decision procedure for the equational theory of an extension of the sigma-calculus by Abadi et al. The library is completely written in Coq and uses Ltac to synthesize the substitution operation.") (license license:bsd-3)))) + +(define-public coq-equations + (package + (name "coq-equations") + (version "1.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mattam82/Coq-Equations.git") + (commit (string-append "v" version "-8.8")))) + (file-name (git-file-name name version)) + (sha256 + (base32 "129rxsdsf88vjcw0xhm74yax1hmnk6f8n9ksg0hcyyjq1ijddiwa")))) + (build-system gnu-build-system) + (native-inputs + `(("ocaml" ,ocaml) + ("coq" ,coq) + ("camlp5" ,camlp5))) + (arguments + `(#:test-target "test-suite" + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (invoke "coq_makefile" "-f" "_CoqProject" "-o" "Makefile"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (setenv "COQLIB" (string-append (assoc-ref outputs "out") "/lib/coq/")) + (invoke "make" + (string-append "COQLIB=" (assoc-ref outputs "out") + "/lib/coq/") + "install")))))) + (home-page "https://mattam82.github.io/Coq-Equations/") + (synopsis "Function definition plugin for Coq") + (description "Equations provides a notation for writing programs +by dependent pattern-matching and (well-founded) recursion in Coq. It +compiles everything down to eliminators for inductive types, equality +and accessibility, providing a definitional extension to the Coq +kernel.") + (license license:lgpl2.1))) -- 2.17.1 --------------5FEB6685F411C921127FF702-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 07:19:37 2019 Received: (at 34466) by debbugs.gnu.org; 13 Feb 2019 12:19:37 +0000 Received: from localhost ([127.0.0.1]:45833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gttVp-0001wl-DE for submit@debbugs.gnu.org; Wed, 13 Feb 2019 07:19:37 -0500 Received: from lepiller.eu ([89.234.186.109]:51260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gttVm-0001wa-PI for 34466@debbugs.gnu.org; Wed, 13 Feb 2019 07:19:35 -0500 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id b4749aec (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 13 Feb 2019 12:19:32 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 13 Feb 2019 13:19:32 +0100 From: Julien Lepiller To: Dan Frumin Subject: Re: [bug#34466] Fwd: Re: [bug#34466] [PATCH] gnu: Add coq-equations. In-Reply-To: References: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> Message-ID: <3d6474b5553bfe4480dcbfbb558c3b3b@lepiller.eu> X-Sender: julien@lepiller.eu User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34466 Cc: 34466@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 2019-02-13 12:36, Dan Frumin a écrit : > (sorry, sending this again because I forgot to CC the bugtracker) > > > Hi Julien. > > Thank you for your thorough comments, I really appreciate it! > I hope that the quality of my patches increase in time so please bear > with me for a bit :) > > On 13-02-19 12:04, Julien Lepiller wrote: >> >> We cannot use auto-generated tarballs from github, because we found >> that >> they sometimes get regenerated in an unreproducible way, so it breaks >> the >> checksum test. You can use this instead: >> >> (method git-fetch) >> (uri (git-reference >>        (url "https://githu.com/mattam82/Coq-Equations.git") >>        (commit (string-append "v" version "-8.8")))) >> >> and update the sha256 accordingly. As an added bonus, this means that >> we >> can always fetch from the software heritage in case the repo >> disappears >> one day :) > > I was not aware of that. How can I get the sha256 hash in this case? > Normally I would do `guix download `. you can always try to build the package, which will fail and tell you what the correct hash was. I forgot, the filename should be: (file-name (git-file-name name version)) >> >> Please make sure that these two phases both return #t. > > I thought that `invoke' automatically checks that the return code is > correct? It does, and when the code is not correct, it throws an exception. When it is correct, it returns #, so we need to explicitly return #t. Thank you! I'll try to build the package and take care of the rest before pushing your patch later today. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 07:39:34 2019 Received: (at 34466) by debbugs.gnu.org; 13 Feb 2019 12:39:34 +0000 Received: from localhost ([127.0.0.1]:45852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gttp8-0004TS-8B for submit@debbugs.gnu.org; Wed, 13 Feb 2019 07:39:34 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:59706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gttp6-0004TJ-9X for 34466@debbugs.gnu.org; Wed, 13 Feb 2019 07:39:32 -0500 Received: from localhost (178.113.214.100.wireless.dyn.drei.com [178.113.214.100]) by dd26836.kasserver.com (Postfix) with ESMTPSA id A89D63360CEC; Wed, 13 Feb 2019 13:39:30 +0100 (CET) Date: Wed, 13 Feb 2019 13:39:24 +0100 From: Danny Milosavljevic To: Julien Lepiller Subject: Re: [bug#34466] Fwd: Re: [bug#34466] [PATCH] gnu: Add coq-equations. Message-ID: <20190213133924.2435f0dd@scratchpost.org> In-Reply-To: <3d6474b5553bfe4480dcbfbb558c3b3b@lepiller.eu> References: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> <3d6474b5553bfe4480dcbfbb558c3b3b@lepiller.eu> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/yx=cl4XiG.C1ZkC.uRgrrIC"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34466 Cc: 34466@debbugs.gnu.org, Dan Frumin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/yx=cl4XiG.C1ZkC.uRgrrIC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Julien, > When [invoke's child return status] is correct, [invoke] returns #, so we need to explicitly return #t. That's not true. invoke returns #t in the successful case--I designed it t= hat way mostly to get rid of the many vestigal #t's in phases. (I hope that in a future version of guix, the necessity of using #t to end = phases will be gone entirely) --Sig_/yx=cl4XiG.C1ZkC.uRgrrIC Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlxkD/wACgkQ5xo1VCww uqUpEgf/foMEkdmWnl3Vf8ijMuzCJwRI2ipDoRvDmPcVgkyCRg7t5ik5UGDibSKY rPaZB194CJLS/hQ/Zs8RitZyNVvLluyDbheclXh2BAOeTQENGdSaJ/voP5T7SKmK EoP8LOBhy5xQPRuoMPYIaMkIvtmAn2qhSI5+t8PAv4SbP+EiBuDyXcJoENRRm5/P tKKsxCNu0PMUPu+/mj0DCXzcA412cvqfNQSwd9lx/0T2eR9MxyhOUQNYjBspBg5E /xA41FMHsa+b8OQSTd1sGF0E4YpPOCctIffT3oqMeNug4IFakXIPIs5ZdbUw2Tn3 Q6lfNJLGEtd6YjWX23D6zyxsUjjPtQ== =Xj8K -----END PGP SIGNATURE----- --Sig_/yx=cl4XiG.C1ZkC.uRgrrIC-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 07:45:49 2019 Received: (at 34466) by debbugs.gnu.org; 13 Feb 2019 12:45:49 +0000 Received: from localhost ([127.0.0.1]:45856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gttvA-0004cg-Vk for submit@debbugs.gnu.org; Wed, 13 Feb 2019 07:45:49 -0500 Received: from lepiller.eu ([89.234.186.109]:51264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gttv9-0004cY-ME for 34466@debbugs.gnu.org; Wed, 13 Feb 2019 07:45:48 -0500 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id df23fefa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 13 Feb 2019 12:45:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 13 Feb 2019 13:45:43 +0100 From: Julien Lepiller To: Danny Milosavljevic Subject: Re: [bug#34466] Fwd: Re: [bug#34466] [PATCH] gnu: Add coq-equations. In-Reply-To: <20190213133924.2435f0dd@scratchpost.org> References: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> <3d6474b5553bfe4480dcbfbb558c3b3b@lepiller.eu> <20190213133924.2435f0dd@scratchpost.org> Message-ID: X-Sender: julien@lepiller.eu User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34466 Cc: 34466@debbugs.gnu.org, Dan Frumin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 2019-02-13 13:39, Danny Milosavljevic a écrit : > Hi Julien, > >> When [invoke's child return status] is correct, [invoke] returns >> #, so we need to explicitly return #t. > > That's not true. invoke returns #t in the successful case--I designed > it that way mostly to get rid of the many vestigal #t's in phases. > > (I hope that in a future version of guix, the necessity of using #t to > end phases will be gone entirely) Ah, thanks for the info! So I guess we don't need to end any phase with #t in that package definition, correct? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 08:23:36 2019 Received: (at 34466) by debbugs.gnu.org; 13 Feb 2019 13:23:36 +0000 Received: from localhost ([127.0.0.1]:45892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtuVj-0007b7-Kr for submit@debbugs.gnu.org; Wed, 13 Feb 2019 08:23:35 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:35344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtuVh-0007av-RD for 34466@debbugs.gnu.org; Wed, 13 Feb 2019 08:23:34 -0500 Received: from localhost (178.113.214.100.wireless.dyn.drei.com [178.113.214.100]) by dd26836.kasserver.com (Postfix) with ESMTPSA id B751A33613AB; Wed, 13 Feb 2019 14:23:31 +0100 (CET) Date: Wed, 13 Feb 2019 14:23:23 +0100 From: Danny Milosavljevic To: Julien Lepiller Subject: Re: [bug#34466] Fwd: Re: [bug#34466] [PATCH] gnu: Add coq-equations. Message-ID: <20190213142323.0aba6301@scratchpost.org> In-Reply-To: References: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl> <3d6474b5553bfe4480dcbfbb558c3b3b@lepiller.eu> <20190213133924.2435f0dd@scratchpost.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/zPxMMl_3xzKwKdyHfQcFtv6"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34466 Cc: 34466@debbugs.gnu.org, Dan Frumin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/zPxMMl_3xzKwKdyHfQcFtv6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 13 Feb 2019 13:45:43 +0100 Julien Lepiller wrote: > Ah, thanks for the info! So I guess we don't need to end any phase with=20 > #t > in that package definition, correct? Correct. --Sig_/zPxMMl_3xzKwKdyHfQcFtv6 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlxkGksACgkQ5xo1VCww uqVXmQf+NAaFsqa61oOWYCKF/6znsUiU7FcrqYDkzBY1qQ//TgyJzmUonHXZwwRL CoWRdsW3NkXUXR7/9Nv38klLnwpag/7Go0bbeAicFjlOoX0V7uO5ZxZFkIEARSRo 99NN0BFL3GVc/75XksJiOeM/wtJGUTO0iNjGMjHzeUEBFT40tUmcHwcfzikXW86x Y+wwTqB8JPbgJtjRadxZr5vp4xfhghgCtC2wJ9ZKd6sD90xaHbXnrQL7ugd2gqFa +OX7H6zXwrn+Mgu6/6+Ry28zoBlq+7N52QMNoSe2E45H1Vcg78/fDEasFoFQBBh1 g81dSBQJcPXgc6hnRPgwVdi3b4iNxQ== =a2Qz -----END PGP SIGNATURE----- --Sig_/zPxMMl_3xzKwKdyHfQcFtv6-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 13 16:23:20 2019 Received: (at 34466-done) by debbugs.gnu.org; 13 Feb 2019 21:23:20 +0000 Received: from localhost ([127.0.0.1]:47393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu1zz-0004k4-Hm for submit@debbugs.gnu.org; Wed, 13 Feb 2019 16:23:19 -0500 Received: from lepiller.eu ([89.234.186.109]:51274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gu1zx-0004jt-Mk for 34466-done@debbugs.gnu.org; Wed, 13 Feb 2019 16:23:18 -0500 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id cee7be4b (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <34466-done@debbugs.gnu.org>; Wed, 13 Feb 2019 21:23:04 +0000 (UTC) Date: Wed, 13 Feb 2019 22:22:54 +0100 From: Julien Lepiller To: 34466-done@debbugs.gnu.org Subject: Re: [bug#34466] [PATCH] gnu: Add coq-equations. Message-ID: <20190213222254.730b1244@lepiller.eu> In-Reply-To: <20190213104024.1963-1-dfrumin@cs.ru.nl> References: <20190213104024.1963-1-dfrumin@cs.ru.nl> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34466-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pushed as ec23bae682ab144179fad8d5ed6c2545d85384ad, thank you! From unknown Fri Jun 13 06:10:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Mar 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator