GNU bug report logs - #34435
[PATCH 0/3] KDE updates

Previous Next

Full log

View this message in rfc822 format

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Marius Bakke <mbakke <at> fastmail.com>, 34435 <at> debbugs.gnu.org
Subject: [bug#34435] [PATCH 3/3] gnu: Add kscreenlocker.
Date: Tue, 12 Feb 2019 09:45:41 +0100

Am 11.02.19 um 16:18 schrieb Marius Bakke:
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)
> +

Empty line.


> +       ("logind" ,elogind)        ;optional loginctl support

According to my notes (for 5.13.5) this is a run-time dependency. Why do
we need to list it here and not later in some "service"?

Another thing: I suggest keeping al l Plasma related packages in a
module of it's own. This will help keeping modules small, easy to spot
and easier to maintain.

Otherwise LGTM

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.