Subject: [bug#34434] [PATCH] gnu: Add frrouting.

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 11 Feb 2019 21:37:53 +0100

Gábor Boskovits <[email-masked]> writes:

> * gnu/packages/networking.scm (frrouting): New variable.
> ---
>  gnu/packages/networking.scm | 38 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index c71ae4a24d..f58e1d7548 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -16,7 +16,7 @@
>  ;;; Copyright © 2017 Leo Famulari <[email-masked]>
>  ;;; Copyright © 2017, 2018, 2019 Efraim Flashner <[email-masked]>
>  ;;; Copyright © 2017, 2018, 2019 Rutger Helling <[email-masked]>
> -;;; Copyright © 2017 Gábor Boskovits <[email-masked]>
> +;;; Copyright © 2017, 2018 Gábor Boskovits <[email-masked]>

The current year is 2019.

>  ;;; Copyright © 2017 Thomas Danckaert <[email-masked]>
>  ;;; Copyright © 2018 Adam Van Ymeren <[email-masked]>
>  ;;; Copyright © 2018 Fis Trivial <[email-masked]>
> @@ -98,6 +98,7 @@
>    #:use-module (gnu packages textutils)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages valgrind)
> +  #:use-module (gnu packages web)
>    #:use-module (gnu packages wm)
>    #:use-module (gnu packages wxwidgets)
>    #:use-module (gnu packages xml)
> @@ -2367,3 +2368,38 @@ communication over HTTP.")
>  be used to manage peer-to-peer network connections as needed for real time
>  communication.")
>      (license license:gpl3+)))
> +
> +(define-public frrouting
> +  (package
> +    (name "frrouting")
> +    (version "6.0.2")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/FRRouting/frr.git")
> +                    (commit (string-append "frr-" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "15ycl0maak55n9xvlz3zbsskqc7901sy5h67jz0068hxc0kh6jpj"))))

Have you seen that they have official release tarballs?

    https://github.com/FRRouting/frr/releases/download/frr-6.0.2/frr-6.0.2.tar.xz

> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("c-ares" ,c-ares)
> +       ("json-c" ,json-c)
> +       ("readline" ,readline)))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)

You might not need these when using the release tarball.

> +    (description "FRRouting (FRR) is an IP routing protocol suite for Linux and
> +Unix platforms which includes protocol daemons for BGP, IS-IS, LDP, OSPF, PIM,
> +and RIP. ")

I’d remove “for Linux and Unix platforms”.

-- 
Ricardo