GNU bug report logs - #34433
[PATCH 1/1] gnu: Fix aegisub.

Previous Next

Full log

Message #8 received at 34433 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 34433 <at> debbugs.gnu.org
Subject: Re: [bug#34433] [PATCH 1/1] gnu: Fix aegisub.
Date: Mon, 11 Feb 2019 13:42:44 +0100

Hi Björn,

> * gnu/packages/video.scm (aegisub)[arguments]: Add phase to fix
> boost headers.

Thanks!

> +         (add-after 'unpack 'fix-boost-headers
> +               (lambda _
> +                 (for-each
> +                  (lambda (f)
> +                    (substitute* f
> +                      (("#include <boost/gil/gil_all.hpp>")
> +                       "#include <boost/gil.hpp>")))
> +                  (list
> +                   "src/subtitles_provider_libass.cpp"
> +                   "src/colour_button.cpp"
> +                   "src/video_provider_dummy.cpp"
> +                   "./src/video_frame.cpp"))
> +                 #t)))))

It’s better to give “substitute*” a list of files instead of using
“for-each”.

      (lambda _
        (substitute* '("src/subtitles_provider_libass.cpp"
                       "src/colour_button.cpp"
                       "src/video_provider_dummy.cpp"
                       "src/video_frame.cpp")
          (("#include <boost/gil/gil_all.hpp>")
           "#include <boost/gil.hpp>"))
        #t)

Okay with these changes.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.