GNU bug report logs - #34419
27.0.50; [PATCH] Use lexical-binding in conf-mode.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex Branham <alex.branham <at> gmail.com>
Subject: bug#34419: closed (Re: bug#34419: 27.0.50; [PATCH] Use
 lexical-binding in conf-mode.el)
Date: Tue, 19 Feb 2019 15:53:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34419 <at> debbugs.gnu.org.

-- 
34419: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34419
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34419-done <at> debbugs.gnu.org
Subject: Re: bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el
Date: Tue, 19 Feb 2019 09:52:36 -0600

[Message part 3 (text/plain, inline)]

On Mon 18 Feb 2019 at 11:44, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Thanks, this fixes the failure.

Thanks, I'll close the bug report then.

Alex

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el
Date: Sun, 10 Feb 2019 14:37:26 -0600

Hi -

I'd like to apply the following patch to enable lexical binding in
conf-mode.el. OK to apply to master, or should I split the documentation
changes into a separate commit and apply it to emacs-26?

Thanks,
Alex


From 33cd3bc0655dd861a63854bfc0762990da46a7cc Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham <at> gmail.com>
Date: Sun, 10 Feb 2019 14:32:29 -0600
Subject: [PATCH] * lisp/textmodes/conf-mode.el: Use lexical binding

(conf-align-assignments):
(conf-quote-normal):
(conf-mode-initialize): Fix documentation
---
 lisp/textmodes/conf-mode.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/textmodes/conf-mode.el b/lisp/textmodes/conf-mode.el
index ad79ca4c26..ad9f60fabc 100644
--- a/lisp/textmodes/conf-mode.el
+++ b/lisp/textmodes/conf-mode.el
@@ -1,4 +1,4 @@
-;;; conf-mode.el --- Simple major mode for editing conf/ini/properties files
+;;; conf-mode.el --- Simple major mode for editing conf/ini/properties files  -*- lexical-binding: t; -*-

 ;; Copyright (C) 2004-2019 Free Software Foundation, Inc.

@@ -281,10 +281,10 @@ whitespace.")
 ;; If anybody can figure out how to get the same effect by configuring
 ;; `align', I'd be glad to hear.
 (defun conf-align-assignments (&optional arg)
-  (interactive "P")
   "Align the assignments in the buffer or active region.
 In Transient Mark mode, if the mark is active, operate on the
 contents of the region.  Otherwise, operate on the whole buffer."
+  (interactive "P")
   (setq arg (if arg
 		(prefix-numeric-value arg)
 	      conf-assignment-column))
@@ -323,7 +323,7 @@ contents of the region.  Otherwise, operate on the whole buffer."

 (defun conf-quote-normal (arg)
   "Set the syntax of \\=' and \" to punctuation.
-With prefix arg, only do it for \\=' if 1, or only for \" if 2.
+With prefix ARG, only do it for \\=' if 1, or only for \" if 2.
 This only affects the current buffer.  Some conf files use quotes
 to delimit strings, while others allow quotes as simple parts of
 the assigned value.  In those files font locking will be wrong,
@@ -442,7 +442,7 @@ See also `conf-space-mode', `conf-colon-mode', `conf-javaprop-mode',
     (run-mode-hooks 'conf-mode-hook)))

 (defun conf-mode-initialize (comment &optional font-lock)
-  "Initializations for sub-modes of conf-mode.
+  "Initializations for sub-modes of `conf-mode'.
 COMMENT initializes `comment-start' and `comment-start-skip'.
 The optional arg FONT-LOCK is the value for FONT-LOCK-KEYWORDS."
   (set (make-local-variable 'comment-start) comment)
--
2.19.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.