GNU bug report logs - #34419
27.0.50; [PATCH] Use lexical-binding in conf-mode.el

Previous Next

Full log

View this message in rfc822 format

From: Alex Branham <alex.branham <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34419 <at> debbugs.gnu.org
Subject: bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el
Date: Mon, 18 Feb 2019 11:17:30 -0600

[Message part 1 (text/plain, inline)]

On Fri 15 Feb 2019 at 08:10, Eli Zaretskii <eliz <at> gnu.org> wrote:

>  Maybe bind indent-tabs-mode to the value you want when
> running this test.

Sorry for taking a while to respond; the attached patch should fix the issue.

Thanks,
Alex

[0001-Fix-a-conf-mode-test.patch (text/x-patch, inline)]

From 08027a320721ed52ef92672caf832e089bd7ac25 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham <at> gmail.com>
Date: Fri, 15 Feb 2019 07:17:49 -0600
Subject: [PATCH] Fix a conf-mode test

* test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments):
  Set `conf-assignment-column' and `indent-tabs-mode'.

Bug#34419
---
 test/lisp/textmodes/conf-mode-tests.el | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/test/lisp/textmodes/conf-mode-tests.el b/test/lisp/textmodes/conf-mode-tests.el
index 5d79ceec96..33009215bb 100644
--- a/test/lisp/textmodes/conf-mode-tests.el
+++ b/test/lisp/textmodes/conf-mode-tests.el
@@ -29,11 +29,13 @@
 (ert-deftest conf-test-align-assignments ()
   "Test for `conf-align-assignments'."
   (with-temp-buffer
-    (insert "foo: bar\nbar: baz")
-    (conf-colon-mode)
-    (conf-align-assignments)
-    (should (equal (buffer-string)
-                   "foo:                    bar\nbar:                    baz"))))
+    (let ((conf-assignment-column 24)
+          indent-tabs-mode)
+      (insert "foo: bar\nbar: baz")
+      (conf-colon-mode)
+      (conf-align-assignments)
+      (should (equal (buffer-string)
+                     "foo:                    bar\nbar:                    baz")))))
 
 (ert-deftest conf-test-font-lock ()
   (with-temp-buffer
-- 
2.19.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.