From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 10 08:40:53 2019 Received: (at submit) by debbugs.gnu.org; 10 Feb 2019 13:40:53 +0000 Received: from localhost ([127.0.0.1]:41834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gspLp-00011B-FK for submit@debbugs.gnu.org; Sun, 10 Feb 2019 08:40:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gspLo-00010z-7F for submit@debbugs.gnu.org; Sun, 10 Feb 2019 08:40:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:51305) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gspLi-0006tI-5h for submit@debbugs.gnu.org; Sun, 10 Feb 2019 08:40:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gspLh-0000YT-3j for guix-patches@gnu.org; Sun, 10 Feb 2019 08:40:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gspLf-0006qw-8q for guix-patches@gnu.org; Sun, 10 Feb 2019 08:40:45 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:34651) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gspLc-0006mN-Jk for guix-patches@gnu.org; Sun, 10 Feb 2019 08:40:41 -0500 Received: by mail-wm1-x32e.google.com with SMTP id y185so11743729wmd.1 for ; Sun, 10 Feb 2019 05:40:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=YM4oEQsdeVQv+IkJ/Q/Xg/z3QuehgGgn6szSixkyLU0=; b=MUX2xhx0bctsWmImu+SmTAyRP728Wlz7TeNQUznzoNzfuyh8aoeMoyhaZeu26JGZDW 6jASPPQ7Rkj9SamA0tAdfVWIWF3MXtN+Tnp9RKE9DGtZssASM4QMzCydL0QhzvXJVlP+ IXLH05Cu2hUAvVeuwcCoNhYX4ojuycuPIyh3VyENWzKC/WaHPZlytr/2Wotf3+TVQ4oT oWkNtfPPkHbRNsWXKz47S8+q2Z1nwp7eAGuKeNwgQDXY5bMub1BzgzV9NwTe1zqt9jD1 EZ6sYdEJRBWSLL8+dDJi21+HXdCj9MXJM0cnk+EKG8XcPBt3oj+hETTDECsmVlHgKANw df4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=YM4oEQsdeVQv+IkJ/Q/Xg/z3QuehgGgn6szSixkyLU0=; b=fu6YHe6zAwLHrBrqloYAaF8t7si7aoi3G8GyP9X5nPjjrjJiDzt53FrLAu3vQC4JO9 ePupfSz5fFF9pQfCR3GZS6cx64zqEVvQhmCm95eK7Vu4d7S/OS537wbFR9xfo9AOMu3m buO/rfXlVU7cmY7lgV11l+lOJaESaBDFs8pRzLvVGkBoGhHjmelINNCcWCPwUID54i2Q 2BttTCP52a8vJ/CEyhKqWYivUNEb2zapfgZSVQgLti+gA7NjoFcNwACOQUkV8o3YwxZj AiBz08dmCOWruYWc4awy/IXr1JPhe9twlFLi2wD58D/EnEh4yfrkupulbDW80ygtrFcY PGSQ== X-Gm-Message-State: AHQUAuYJtdc8KaKwARnXmQwVYT0V2Rw08w6qdHXp0unBY+j9xGUuFxI7 IJz81lUwOGyhgq78zKWVNOWIJ3x9 X-Google-Smtp-Source: AHgI3IaUg8SE34GDfYg5eV3AaM2fgopQQo7z5rUmU8XHuDJZhzSMkmRYfLiZaQzYNB0RvZHHloNHTw== X-Received: by 2002:a7b:c75a:: with SMTP id w26mr6137006wmk.35.1549806031275; Sun, 10 Feb 2019 05:40:31 -0800 (PST) Received: from glht-aurore.gmail.com (2a01cb04062c860082fa5bfffe3823d7.ipv6.abo.wanadoo.fr. [2a01:cb04:62c:8600:82fa:5bff:fe38:23d7]) by smtp.gmail.com with ESMTPSA id m4sm4308820wml.2.2019.02.10.05.40.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Feb 2019 05:40:30 -0800 (PST) User-agent: mu4e 1.0; emacs 26.1 From: Gabriel Hondet To: guix-patches@gnu.org Subject: [PATCH] gnu: ocaml-merlin: Added tests Date: Sun, 10 Feb 2019 14:36:15 +0100 Message-ID: <877ee74v93.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * gnu/packages/ocaml.scm (ocaml-merlin): Added tests =2D-- gnu/packages/ocaml.scm | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index 07fcf92ae..0b33c257a 100644 =2D-- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -66,6 +66,7 @@ #:use-module (gnu packages version-control) #:use-module (gnu packages virtualization) #:use-module (gnu packages web-browsers) + #:use-module (gnu packages web) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) #:use-module (guix build-system dune) @@ -4785,6 +4786,11 @@ format}. @code{craml} is released as a single binar= y (called @code{craml}).") (url "https://github.com/ocaml/merlin.git") (commit (string-append "v" version)))) (file-name (git-file-name name version)) + (modules '((guix build utils))) + (snippet '(begin + ;; fix a dune file calling missing dependencies + (substitute* "tests/locate/partial-cmt/dune" + (("a.ml a.mli") "")))) (sha256 (base32 "15ssgmwdxylbwhld9p1cq8x6kadxyhll5bfyf11dddj6cldna3hb")))) @@ -4794,9 +4800,22 @@ format}. @code{craml} is released as a single binar= y (called @code{craml}).") ("ocaml-yojson" ,ocaml-yojson) ("ocaml-easy-format" ,ocaml-easy-format))) (native-inputs =2D `(("ocaml-findlib" ,ocaml-findlib))) + `(("ocaml-findlib" ,ocaml-findlib) + ("ocaml-craml" ,ocaml-craml) + ("jq" ,jq))) (arguments =2D '(#:tests? #f)) ;; Errors in tests in version 3.2.2 + '(#:phases + (modify-phases %standard-phases + (add-before 'check 'remove-failing + (lambda _ + (delete-file-recursively "tests/warnings/") + (delete-file-recursively ;fail because of shebang patching + "tests/locate/context-detection/") + #t)) + (replace 'check + (lambda _ + (invoke "make" "test") + #t))))) (synopsis "Context sensitive completion for OCaml in Vim and Emacs") (description "Merlin is an editor service that provides modern IDE features for OCaml. Emacs and Vim support is provided out-of-the-box. =2D-=20 2.20.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5ercJXBcjd3P1FcAMbyBBfZZ1CUFAlxgKcgACgkQMbyBBfZZ 1CUsOxAAlUJXBUPn8RlU7Y0lgK0FH2JVP2ijGIoZ/dKKVtisCE4o2AXpUvgBfiBI oO2agUvgerKbX2li7+zULVDTjEo8n3QDkvLlfMJQVAAHmiW0dSyX1gHgIIO0oyOp AgKRXTLRutovDG+ClI/CWv8UGeTRMqCaQKgRGUxEPN39eLbn6yLw+dyYMINTWbJD RvufzZlMSoT8xl4aVI6a73+AmgnizWIr+pPjWeY19DzHXvlfFGupymCDtZO6RMRX UgqeHoRI5BUjuHLa9GpJhaBUYtGmQ/1ehusNU8dlGExOSayY/fLsh+DmBkG9EpO8 FWnFVldXI6b9WVfeucCHmvS6o3v56nFL0cNJxCXp21L0kJIoOSADta9o0KGt0L4O c8mTdxLxxvcWxjKhM9GK+h1mUwjgSw4cjagKoclEMrUhToLKlQjXc4RI3Szbr+UM HphQ8yk9gpINdgDqokLtUdLPA5LLAClLRfBE70Y8+GzPmkTBRDoZGM18x8MWJsc7 vGou9UeMuw5Rp7FQDPSkPe2t3fm0PSmhQvJNDCJi2QAaANwSPbb8nmC8gsdodVYD V+GCPcxwbmH/S3sWG34sx7NKkpPh7rNzt8ABVUK75REWMbOsluYT/cTSJidQ1i/1 3guv0hXO2K99INjBIXY4S0cG2XGlz3mict4JoowrFwIkAwQ4x+o= =SbZd -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 01:41:51 2019 Received: (at submit) by debbugs.gnu.org; 28 Jun 2019 05:41:51 +0000 Received: from localhost ([127.0.0.1]:40238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgjdv-00025N-Hq for submit@debbugs.gnu.org; Fri, 28 Jun 2019 01:41:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:41799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgjdt-00025F-O6 for submit@debbugs.gnu.org; Fri, 28 Jun 2019 01:41:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59105) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgjds-0001H6-9s for guix-patches@gnu.org; Fri, 28 Jun 2019 01:41:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgjdo-0001os-7m for guix-patches@gnu.org; Fri, 28 Jun 2019 01:41:46 -0400 Received: from mx1.riseup.net ([198.252.153.129]:36968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgjdn-0001nP-WE for guix-patches@gnu.org; Fri, 28 Jun 2019 01:41:44 -0400 Received: from capuchin.riseup.net (capuchin-pn.riseup.net [10.0.1.176]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 997551A1C82 for ; Thu, 27 Jun 2019 22:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1561700501; bh=0JrnWpkXp+360NcuxSLdD1ZPiFozka5gc+ChXV4uO4E=; h=Subject:To:References:From:Date:In-Reply-To:From; b=eCk8HHoL1xSUCjZBBXg2KIhlRQdJjRdDnjoSL5eR+yltm7WAIyMm7UmARQVsItnA+ ud4NfDh8RwKzPVF0Pl70fFfs2py9h0SCb381O7kxC8QkxiY5k9/SHyVHW4k7XCdGi9 xIFrJtB/8PqtugihU5dGzITxnN7KN/XDPP+q4DQk= X-Riseup-User-ID: E7F224B5CE6C7B101CA9C74894021C24CED9966551029CF36BE29263BC6E2FF2 Received: from [127.0.0.1] (localhost [127.0.0.1]) by capuchin.riseup.net (Postfix) with ESMTPSA id CC9D9120320 for ; Thu, 27 Jun 2019 22:41:40 -0700 (PDT) Subject: Re: [bug#34412] [PATCH] gnu: ocaml-merlin: Added tests To: guix-patches@gnu.org References: <877ee74v93.fsf@gmail.com> From: swedebugia Message-ID: Date: Fri, 28 Jun 2019 07:41:38 +0200 MIME-Version: 1.0 In-Reply-To: <877ee74v93.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 198.252.153.129 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 2019-02-10 14:36, Gabriel Hondet wrote: > * gnu/packages/ocaml.scm (ocaml-merlin): Added tests > --- > gnu/packages/ocaml.scm | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm > index 07fcf92ae..0b33c257a 100644 > --- a/gnu/packages/ocaml.scm > +++ b/gnu/packages/ocaml.scm > @@ -66,6 +66,7 @@ > #:use-module (gnu packages version-control) > #:use-module (gnu packages virtualization) > #:use-module (gnu packages web-browsers) > + #:use-module (gnu packages web) > #:use-module (gnu packages xml) > #:use-module (gnu packages xorg) > #:use-module (guix build-system dune) > @@ -4785,6 +4786,11 @@ format}. @code{craml} is released as a single binary (called @code{craml}).") > (url"https://github.com/ocaml/merlin.git") > (commit (string-append "v" version)))) > (file-name (git-file-name name version)) > + (modules '((guix build utils))) > + (snippet '(begin > + ;; fix a dune file calling missing dependencies > + (substitute* "tests/locate/partial-cmt/dune" > + (("a.ml a.mli") "")))) > (sha256 > (base32 > "15ssgmwdxylbwhld9p1cq8x6kadxyhll5bfyf11dddj6cldna3hb")))) > @@ -4794,9 +4800,22 @@ format}. @code{craml} is released as a single binary (called @code{craml}).") > ("ocaml-yojson" ,ocaml-yojson) > ("ocaml-easy-format" ,ocaml-easy-format))) > (native-inputs > - `(("ocaml-findlib" ,ocaml-findlib))) > + `(("ocaml-findlib" ,ocaml-findlib) > + ("ocaml-craml" ,ocaml-craml) > + ("jq" ,jq))) > (arguments > - '(#:tests? #f)) ;; Errors in tests in version 3.2.2 > + '(#:phases > + (modify-phases %standard-phases > + (add-before 'check 'remove-failing > + (lambda _ > + (delete-file-recursively "tests/warnings/") > + (delete-file-recursively ;fail because of shebang patching > + "tests/locate/context-detection/") > + #t)) > + (replace 'check > + (lambda _ > + (invoke "make" "test") > + #t))))) > (synopsis "Context sensitive completion for OCaml in Vim and Emacs") > (description "Merlin is an editor service that provides modern IDE > features for OCaml. Emacs and Vim support is provided out-of-the-box. > -- 2.20.1 > This has slipped through the cracks. Could you rebase to current master and send an updated patch? -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 02:18:32 2019 Received: (at submit) by debbugs.gnu.org; 28 Jun 2019 06:18:32 +0000 Received: from localhost ([127.0.0.1]:40259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgkDP-0002xj-P3 for submit@debbugs.gnu.org; Fri, 28 Jun 2019 02:18:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:46540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgkDO-0002xc-8O for submit@debbugs.gnu.org; Fri, 28 Jun 2019 02:18:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36985) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgkDM-00059J-EK for guix-patches@gnu.org; Fri, 28 Jun 2019 02:18:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgkDK-0001WL-45 for guix-patches@gnu.org; Fri, 28 Jun 2019 02:18:28 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:52692) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgkDJ-0001TX-PH for guix-patches@gnu.org; Fri, 28 Jun 2019 02:18:26 -0400 Received: from [10.205.39.33] (tor01.zencurity.dk [185.129.62.62]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 8ea47d92 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 28 Jun 2019 06:18:17 +0000 (UTC) Date: Fri, 28 Jun 2019 08:17:54 +0200 User-Agent: K-9 Mail for Android In-Reply-To: References: <877ee74v93.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [bug#34412] [PATCH] gnu: ocaml-merlin: Added tests To: guix-patches@gnu.org, swedebugia , 34412@debbugs.gnu.org From: Julien Lepiller Message-ID: <670267B2-5EA9-44E4-85DB-D48206DBED4A@lepiller.eu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:5884:8208::1 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sorry for not having seen that! Le 28 juin 2019 07:41:38 GMT+02:00, swedebugia a= =C3=A9crit : >On 2019-02-10 14:36, Gabriel Hondet wrote: >> * gnu/packages/ocaml=2Escm (ocaml-merlin): Added tests >> --- >> gnu/packages/ocaml=2Escm | 23 +++++++++++++++++++++-- >> 1 file changed, 21 insertions(+), 2 deletions(-) >>=20 >> diff --git a/gnu/packages/ocaml=2Escm b/gnu/packages/ocaml=2Escm >> index 07fcf92ae=2E=2E0b33c257a 100644 >> --- a/gnu/packages/ocaml=2Escm >> +++ b/gnu/packages/ocaml=2Escm >> @@ -66,6 +66,7 @@ >> #:use-module (gnu packages version-control) >> #:use-module (gnu packages virtualization) >> #:use-module (gnu packages web-browsers) >> + #:use-module (gnu packages web) >> #:use-module (gnu packages xml) >> #:use-module (gnu packages xorg) >> #:use-module (guix build-system dune) >> @@ -4785,6 +4786,11 @@ format}=2E @code{craml} is released as a single >binary (called @code{craml})=2E") >> (url"https://github=2Ecom/ocaml/merlin=2Egit") >> (commit (string-append "v" version)))) >> (file-name (git-file-name name version)) >> + (modules '((guix build utils))) >> + (snippet '(begin >> + ;; fix a dune file calling missing dependencies >> + (substitute* "tests/locate/partial-cmt/dune" >> + (("a=2Eml a=2Emli") "")))) >> (sha256 >> (base32 >> "15ssgmwdxylbwhld9p1cq8x6kadxyhll5bfyf11dddj6cldna3hb")))) >> @@ -4794,9 +4800,22 @@ format}=2E @code{craml} is released as a single >binary (called @code{craml})=2E") >> ("ocaml-yojson" ,ocaml-yojson) >> ("ocaml-easy-format" ,ocaml-easy-format))) >> (native-inputs >> - `(("ocaml-findlib" ,ocaml-findlib))) >> + `(("ocaml-findlib" ,ocaml-findlib) >> + ("ocaml-craml" ,ocaml-craml) >> + ("jq" ,jq))) >> (arguments >> - '(#:tests? #f)) ;; Errors in tests in version 3=2E2=2E2 >> + '(#:phases >> + (modify-phases %standard-phases >> + (add-before 'check 'remove-failing >> + (lambda _ >> + (delete-file-recursively "tests/warnings/") >> + (delete-file-recursively ;fail because of shebang >patching >> + "tests/locate/context-detection/") Can we try and fix the shebang then? >> + #t)) >> + (replace 'check >> + (lambda _ >> + (invoke "make" "test") >> + #t))))) I think #:test-target "test" would be enough, no? >> (synopsis "Context sensitive completion for OCaml in Vim and >Emacs") >> (description "Merlin is an editor service that provides modern >IDE >> features for OCaml=2E Emacs and Vim support is provided >out-of-the-box=2E >> -- 2=2E20=2E1 >>=20 > >This has slipped through the cracks=2E Could you rebase to current master > >and send an updated patch? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 07:41:07 2020 Received: (at 34412) by debbugs.gnu.org; 28 Dec 2020 12:41:07 +0000 Received: from localhost ([127.0.0.1]:34505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktrpj-0003iV-Ar for submit@debbugs.gnu.org; Mon, 28 Dec 2020 07:41:07 -0500 Received: from mout02.posteo.de ([185.67.36.66]:54423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktrpd-0003he-7N for 34412@debbugs.gnu.org; Mon, 28 Dec 2020 07:41:05 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 69D9A2400FC for <34412@debbugs.gnu.org>; Mon, 28 Dec 2020 13:40:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1609159254; bh=VGVJl4osEmrF5RvQJsv51FvVNkB2zrkbYovX4d3df/4=; h=From:To:Cc:Subject:Date:From; b=fzcrLOx5aVbQaLw1Tz1Ef7wj4g0cnqwnU3UqLOSUJWDdg0Q9Gg+BVPO37KGRQK1nG ViQT0S59pkNPFk19YuBzqCzDcv/T/ntaUdVHlqmpKAEECzR8po+wE+k4gjWGlC1B+1 vCCTpjp9H6ddc564BxZ56gwXKLYIqxuRROabBP+C3YKdXHATeF3dRUAYfSxPK24lMi nm9Qx+Z8jbbfuqoT9YhLvR9Etn33muwOrthyTUNEKKfWL4ZgBtBHymeYAT7o7yUFT1 pWbm16hA+WbOjexrzZITValoeht5wjnSkFszp0GQqReOnr2tUFKMOpH0RHyqlI4Mnw 8kiUowjr8RbHw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4D4HGF3ffbz6tmF; Mon, 28 Dec 2020 13:40:53 +0100 (CET) From: pukkamustard To: guix-patches@gnu.org Subject: [PATCH 00/12] Add ocaml-merlin. Date: Mon, 28 Dec 2020 13:40:17 +0100 Message-Id: <20201228124017.24295-1-pukkamustard@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34412 Cc: pukkamustard , 34412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Guix, This adds ocaml-merlin, a development tool for OCaml (and dependencies). Some notes and questions: - ocaml4.07-merlin is already available (version 3.2.2). This version has not been updated (but changed to inherit from ocaml-merlin). - There are many ocaml4.07-* packages in Guix. The reason for this is that some packages need to be built with OCaml 4.07 but some newer versions of libraries do no longer support OCaml 4.07 (or the old version of dune), requiring older versions of the same packages. See also commit message 9ada1555. This is quite cumbersome as two trees of OCaml packages need to be maintained. A nice solution would be to upgrade packages requiring OCaml 4.07 to also build with the default OCaml (4.11). Packages that are not dependencies of other packages that require OCaml 4.07 seem to be: `bap`, `ocaml-earley` and `pplacer`. Maybe this should be opened as an issue? - Some OCaml libraries have dependencies in `inputs` that seem to be required from packages using the libraries. E.g. `ocaml-yojson` depends on `ocaml-biniou`. Packages depending on `ocaml-yojson` need to manually add `ocaml-biniou` to their inputs. Would it work/make sense to add `ocaml-biniou` to `propagated-inputs` of `ocaml-yojson`? - Test for ocaml-merlin (version 3.4.2) work. This resolves issue #34412 (alltough ocaml4.07-merlin still can not run tests). Thanks! -pukkamustard pukkamustard (12): gnu: Remove ocaml-js-build-tools. gnu: Add ocaml-sexplib. gnu: Add ocaml-base. gnu: Add ocaml-parsexp. gnu: Add ocaml-sexplib. gnu: Add ocaml-ounit2. gnu: ocaml-tyxml: Update to 4.4.0. gnu: ocaml-markup: Update to 1.0.0. gnu: Add ocaml-odoc. gnu: Add ocaml-version. gnu: Add ocaml-mdx. gnu: Add ocaml-merlin. gnu/packages/ocaml.scm | 527 ++++++++++++++++++++++++++++------------- 1 file changed, 359 insertions(+), 168 deletions(-) -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 09:07:09 2020 Received: (at 34412) by debbugs.gnu.org; 28 Dec 2020 14:07:09 +0000 Received: from localhost ([127.0.0.1]:34668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kttAy-0005uf-Vd for submit@debbugs.gnu.org; Mon, 28 Dec 2020 09:07:09 -0500 Received: from lepiller.eu ([89.234.186.109]:58612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kttAw-0005uM-DK; Mon, 28 Dec 2020 09:07:07 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id eff938db; Mon, 28 Dec 2020 14:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=cxORErbEDRx6 OzQGOBkt/a4Ut25ot8cLY1g2cWa7jRA=; b=daxNnhDaJOK87s437tpKL3CfeNDx m9Adbktk+LlvDht81/QSz6UcuodW4fISsCONZago+sgg4IDvtqhBwwzLphjh5wjc dcHST0pRJ8ANqzkHuLNksxL8cCxfmyQmCKiaCUkaWcfADpXMhRXLWQ+9aHksoI2Q GsUMFy9259WXXPjjy72j9o0y1hSWU52OCyWeSZYlUeAI/BNv992RO3ndtgbvNUt5 c/QvrS3FxIf7vn6QxYAcGK7lR8L06XDe2jgnOW5utjo6gV5I5h8nIafiMBL0L47r pPFI2IsaTlOvzK/+6EwZi/P5ejQS8Jh3l4OpDcZKpMqdGR6H1hU0bT8D9Q== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 131c7be1 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 28 Dec 2020 14:07:04 +0000 (UTC) Date: Mon, 28 Dec 2020 15:06:55 +0100 From: Julien Lepiller To: pukkamustard Subject: Re: [bug#45498] [PATCH 00/12] Add ocaml-merlin. Message-ID: <20201228150655.101e4704@tachikoma.lepiller.eu> In-Reply-To: <20201228124017.24295-1-pukkamustard@posteo.net> References: <20201228124017.24295-1-pukkamustard@posteo.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34412 Cc: 45498@debbugs.gnu.org, 34412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Mon, 28 Dec 2020 13:40:17 +0100, pukkamustard a =C3=A9crit : > Hi Guix, >=20 > This adds ocaml-merlin, a development tool for OCaml (and > dependencies). Thanks for the patches! >=20 > Some notes and questions: >=20 > - ocaml4.07-merlin is already available (version 3.2.2). This version > has not been updated (but changed to inherit from ocaml-merlin). >=20 > - There are many ocaml4.07-* packages in Guix. The reason for this is > that some packages need to be built with OCaml 4.07 but some newer > versions of libraries do no longer support OCaml 4.07 (or the old > version of dune), requiring older versions of the same packages. See > also commit message 9ada1555. Have you tried updating dune to the latest version that builds with ocaml 4.07? >=20 > This is quite cumbersome as two trees of OCaml packages need to be > maintained. Actually 3, there are ocaml 4.07, 4.09 and 4.11 currently. I'm working on a bootstrap for ocaml 4.07 (ocaml builds from a binary version of itself), so I don't think it'll disappear soon, but at least we can try and make ocaml4.07-* packages disappear :) >=20 > A nice solution would be to upgrade packages requiring OCaml 4.07 > to also build with the default OCaml (4.11). Packages that are not > dependencies of other packages that require OCaml 4.07 seem to be: > `bap`, `ocaml-earley` and `pplacer`. Maybe this should be opened as > an issue? pretty sure they build with at least ocaml-4.09 now, I'll see what I can do :) >=20 > - Some OCaml libraries have dependencies in `inputs` that seem to be > required from packages using the libraries. E.g. `ocaml-yojson` > depends on `ocaml-biniou`. Packages depending on `ocaml-yojson` need > to manually add `ocaml-biniou` to their inputs. Would it work/make > sense to add `ocaml-biniou` to `propagated-inputs` of `ocaml-yojson`? Yeah, could you provide an additional patch for that? >=20 > - Test for ocaml-merlin (version 3.4.2) work. This resolves issue > #34412 (alltough ocaml4.07-merlin still can not run tests). >=20 > Thanks! > -pukkamustard Thank you! I've sent some remarks to your patches, but generally LGTM :) >=20 > pukkamustard (12): > gnu: Remove ocaml-js-build-tools. > gnu: Add ocaml-sexplib. > gnu: Add ocaml-base. > gnu: Add ocaml-parsexp. > gnu: Add ocaml-sexplib. > gnu: Add ocaml-ounit2. > gnu: ocaml-tyxml: Update to 4.4.0. > gnu: ocaml-markup: Update to 1.0.0. > gnu: Add ocaml-odoc. > gnu: Add ocaml-version. > gnu: Add ocaml-mdx. > gnu: Add ocaml-merlin. >=20 > gnu/packages/ocaml.scm | 527 > ++++++++++++++++++++++++++++------------- 1 file changed, 359 > insertions(+), 168 deletions(-) >=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 07 22:57:29 2021 Received: (at 34412) by debbugs.gnu.org; 8 Oct 2021 02:57:29 +0000 Received: from localhost ([127.0.0.1]:48833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYg4f-0008Kk-Eq for submit@debbugs.gnu.org; Thu, 07 Oct 2021 22:57:29 -0400 Received: from lepiller.eu ([89.234.186.109]:34366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYg4d-0008Kc-J4 for 34412@debbugs.gnu.org; Thu, 07 Oct 2021 22:57:28 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 64fceca6 for <34412@debbugs.gnu.org>; Fri, 8 Oct 2021 02:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:mime-version:content-type :content-transfer-encoding; s=dkim; bh=WF2D1nzZZN/e1M3Rwy5BMT7jd sWBSFb6RKRDtaO+izI=; b=RuTJOCOfDfiq8JcAIJi77RY6PenpZKXVr5CxzGn9C 9ZsbqfG1OEfglxqrKlec9WhWXEX+1QgQetFVCtFqe5hBFbzFO3OImwg+1N/NTqHZ 618plyRk1U6vWauZoFIiL35Pf4SeT/wQnSNJsf5IMAk8vU5ZG1lwajjKPPduaOnc qlkMGQ6cUv82lp/kGDujV/eGuhA1KtM+Tg4QJK+mdF6UsyZ6K9D4MQ0XwV2weMWc mMLgrWkqZOV/WioYioz/+oxuJzeKnMHFmdg51ncsfIK7JIrD5OrJdI0pypdQoToO 6tBkhdJ1BU/xFDDyCzJQMZibCvn0ajyPCxsBbOtD7qFcg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id f04e8699 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for <34412@debbugs.gnu.org>; Fri, 8 Oct 2021 02:57:25 +0000 (UTC) Date: Fri, 8 Oct 2021 04:57:16 +0200 From: Julien Lepiller To: 34412@debbugs.gnu.org Subject: Re: [PATCH] gnu: ocaml-merlin: Added tests Message-ID: <20211008045716.6836bd2a@tachikoma.lepiller.eu> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34412 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! So, since we have ocaml-merlin now, and since ocaml4.07-merlin is not required by any other package, should we get rid of it? Or do we still have a use for it? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 07:35:52 2021 Received: (at 34412) by debbugs.gnu.org; 11 Oct 2021 11:35:52 +0000 Received: from localhost ([127.0.0.1]:56764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZtay-0004nf-1r for submit@debbugs.gnu.org; Mon, 11 Oct 2021 07:35:52 -0400 Received: from mail-qv1-f44.google.com ([209.85.219.44]:37496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZtav-0004nR-FZ for 34412@debbugs.gnu.org; Mon, 11 Oct 2021 07:35:49 -0400 Received: by mail-qv1-f44.google.com with SMTP id o13so10755767qvm.4 for <34412@debbugs.gnu.org>; Mon, 11 Oct 2021 04:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mlgGSS5NMiVHqRqvY6aPx9d7SeeEnDZ03/eqP/WJbQU=; b=QNn7eZciFYykfo4JwQFnwiDIT39LYNkgQEmNYrPc+01Bu5HbR1oeNBoLC9gRB0PzX1 jw/muiuNdJYh+r5FPfaAF50txhvnXV3EdbupjpqJ3jonEFzSlVDG8ln0xtNqXUHCUOr7 8HQm669ib3jBnBDxoclj2SSa3H950Vq44K+XD0L6wfT/XApo1Ru7NabwM7EuNGCxhwlP nVcubU/V2hweY+FQIklCxOxFghwgRWkyKinuira2BGgLzcCApVZO/QCcEJdFa0zty2pU iuL3AfGvvH2nBJnHpo/eCEmOJEDFoSyfuvtZiHLKThUvxAHpYzQX2SFPLq0D8hFd1jDK GIHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mlgGSS5NMiVHqRqvY6aPx9d7SeeEnDZ03/eqP/WJbQU=; b=0JtOBkeWTCqbQk3drWNAQ1P20F3z/uFEj6UyCUhNEJoPGMSgLz2JbpbiHRDitIdNXk R1OTdbzQR6FUMkpD35h4Vz5w7OjScX61vAjRZNicuLu4P1fD7sHznGSnuf1IoxmnK6qX JOrxz+Td6fNT8m34L/0uAX2qmn9HccjlslWnk0QGMJFtKeVWN41OVAB+ku67RiDqu/HR EUmtNe5bU/fhbeIDMvXBNl6Sfnc9k9tqn3c3O5wQjfnxnUuPHk/eQbOpDnmx5G3wBWDK hDUiNfSE7KcqD+HP68EIviiKGIy3PP0mAr9b0P05ENPRXzAH3dJumhJ5kiIQw2sJajCA x3NA== X-Gm-Message-State: AOAM532/ER5HJgsgAZxGVEXXZaNgZFlgSxvDiJEvH2tOPEO8raPcEQfX aRPW2ar2eGbpSIlDcuNuWDkY3MtADmsfwM+mxx4bIDRK X-Google-Smtp-Source: ABdhPJxzVnSn6L14YQjiiAshZiP3xpCCn1AKxhPE01/gKHckMYoz++1YZFq5LmadNTWvjO0vBgZsJ6thiLEepNrVkKI= X-Received: by 2002:a05:6214:c64:: with SMTP id t4mr22889242qvj.5.1633952143994; Mon, 11 Oct 2021 04:35:43 -0700 (PDT) MIME-Version: 1.0 References: <877ee74v93.fsf@gmail.com> <20211008045716.6836bd2a@tachikoma.lepiller.eu> In-Reply-To: <20211008045716.6836bd2a@tachikoma.lepiller.eu> From: zimoun Date: Mon, 11 Oct 2021 13:35:32 +0200 Message-ID: Subject: Re: [bug#34412] [PATCH] gnu: ocaml-merlin: Added tests To: Julien Lepiller Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34412 Cc: 34412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Julien What is the plan for removing ocaml4.07 packages? BTW, this patch submission could be closed, IMHO. Because as you said, ocaml-merlin is in and ocaml4.07-merlin is not required by any other package. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 07 08:16:32 2022 Received: (at 34412-done) by debbugs.gnu.org; 7 Apr 2022 12:16:32 +0000 Received: from localhost ([127.0.0.1]:60097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncR3v-0006QW-MH for submit@debbugs.gnu.org; Thu, 07 Apr 2022 08:16:31 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:33173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncR3r-0006I5-I5 for 34412-done@debbugs.gnu.org; Thu, 07 Apr 2022 08:16:27 -0400 Received: by mail-wm1-f51.google.com with SMTP id l9-20020a05600c4f0900b0038ccd1b8642so4463284wmq.0 for <34412-done@debbugs.gnu.org>; Thu, 07 Apr 2022 05:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=gB08/kBBAH+nhChTYHGeRAHZogOMHqD0Y2fqvdKYGmQ=; b=oJHu8vrQuEY2JwJI/oVWgsGwsS+tcU9VLoilQTJOOV6/OYW57m1K7KqbHofnMaDz7m UFLxLiqSc7A+qNSHzIvTFNyXp4FmQAdZK1Z9hhpGRsXGgMG251bo8G9mwdsXM1aTIfg8 3I7npGol7CRVi6BDsNzakshd4prrW7K2jFMfVZNmAqQnRsX1fxtZA5GZFp5Ywb+Qn27s MAgUAiy+b70uxIScyzslvTT3+u40oA0vRyJYHMn0GIJ4Armr29U/DDUI1UY4lMLcRncL YPjAPcTPKouQNpF/xHfA1/OMlZzoSmOlq+oVVXTOcRACuiQ5yqrlGdGF68KiE35NWexK engQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=gB08/kBBAH+nhChTYHGeRAHZogOMHqD0Y2fqvdKYGmQ=; b=7BUGfQKvGD2UboXMd6M5J1vvCTi2NBIhCssOe2SRMb8e77kACtHD1+uco7u/Hgwi3i 6s7BdSWL7r0xpP/YvHxsDJJDPRb2AWjIE38GRRhfLCGvDR0Mos+P2fFDtlCgmsW39Um7 OxD58XPEo8zSOgUm7W6Zzv8puHcJEUTgCbKodjOXQEW4wPPA0ruAHQXEGikcO0iHr0ma 5Tkg6MHTCPp9XELphF8qMtzFKJrklVWVJNpSQDkEHCInr2MqZHwRDL8LE0UNoldN66xU ODj9pUcVkLg/ZD0s2Jhm8R9VvSeJwNZppTuMAjVhOvil4JEKGTKq5KrPxsZeGoXIJepb O5yQ== X-Gm-Message-State: AOAM530sUebClGqoXVKsorpP2f4h5QoU96lXMJdvGVSWj6azGVqwzSoa kf9Ixr0Bvo4ZJjkWXmYD1xCtH0KbD9Y= X-Google-Smtp-Source: ABdhPJz/8l089bFwXrbw3JAZnGzCmjxiWZFiH8Fm/15kdgcyL0+W9benHL1+wERI0gGDmSz/TMp1lw== X-Received: by 2002:a05:600c:1e1f:b0:38e:7073:3439 with SMTP id ay31-20020a05600c1e1f00b0038e70733439mr12101774wmb.120.1649333781846; Thu, 07 Apr 2022 05:16:21 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id m187-20020a1c26c4000000b0038e9a8b2139sm519044wmm.11.2022.04.07.05.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 05:16:21 -0700 (PDT) From: zimoun To: Gabriel Hondet Subject: Re: bug#34412: [PATCH] gnu: ocaml-merlin: Added tests References: <877ee74v93.fsf@gmail.com> Date: Thu, 07 Apr 2022 14:14:28 +0200 In-Reply-To: <877ee74v93.fsf@gmail.com> (Gabriel Hondet's message of "Sun, 10 Feb 2019 14:36:15 +0100") Message-ID: <86tub52iqj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34412-done Cc: 34412-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thanks for your contribution with patch#34412 [1]. The =E2=80=99ocaml-merl= in=E2=80=99 contains this: --8<---------------cut here---------------start------------->8--- (modify-phases %standard-phases (replace 'check (lambda* (#:key tests? #:allow-other-keys) (when tests? (invoke "dune" "runtest" "-p" "merlin,dot-merlin-reader"))))= ))) --8<---------------cut here---------------end--------------->8--- added by 980c33bd3f16e44a123ef21408a56e59ebb76373. And the package =E2=80=99ocaml4.07-merlin=E2=80=99 had been removed by 188e3e2e6878346b0bdc8b46084f458abe86826c. Therefore, closing. Cheers, simon 1: From unknown Tue Jun 24 01:38:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 06 May 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator