GNU bug report logs - #34393
[PATCH] gnu: terminals: Add termbox-truecolor

Previous Next

Full log

View this message in rfc822 format

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Amirouche Boubekki <amirouche <at> hypermove.net>
Cc: 34393 <at> debbugs.gnu.org
Subject: [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
Date: Fri, 8 Feb 2019 22:38:30 -0600

[Message part 1 (text/plain, inline)]

> +(define-public termbox-truecolor
> +  (package
> +    (name "termbox-truecolor")
> +    (version "2019.01.06-c3afbfd")

Could you include a revision number here too?  (See "Version Numbers"
in the manual)

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/amirouche/termbox-truecolor.git")
> +                    (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "179py858dhhxkj6la84b224r2fjwavygf4daw4dgl3gvv8i07ryj"))))
> +    (build-system waf-build-system)
> +    (arguments
> +     `(#:tests? #f))
> +    (synopsis "Library for writing text-based user interfaces (with true-color support)")

Maybe: "Text-based user interface library"

The true-color support can be mentioned in the description.

> +    (description "Termbox is a library that provides minimalistic API which

"...provides a minimalistic ..."
             ^

> +allows the programmer to write text-based user interfaces.
> +
> +It is based on a simple abstraction: viewing terminals as a table of

I think the paragraph break isn't necessary here.

> +fixed-size cells and input being a stream of structured messages.  Copy &
> +pasting and wide characters (mostly Chinese, Japanese, Korean (CJK)
> +characters) are not really supported.")
> +    (home-page "https://github.com/amirouche/termbox-truecolor/tree/truecolor")
> +    (license license:expat)))

Otherwise looks good to me,

`~Eric

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.