Subject: Re: [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor

From: Ricardo Wurmus <[email-masked]>
Date: Sat, 09 Feb 2019 09:58:00 +0100

Hi Amirouche,

> From c97de00efc8dfe17a2cedda69033eaa710c42a6e Mon Sep 17 00:00:00 2001
> From: Amirouche <[email-masked]>
> Date: Sat, 9 Feb 2019 00:07:48 +0100
> Subject: [PATCH] gnu: Add termbox-truecolor.
>
> * gnu/packages/terminals.scm (termbox-truecolor): New variable.

Thanks for the patch!

[…]
> +(define-public termbox-truecolor
> +  (package
> +    (name "termbox-truecolor")
> +    (version "2019.01.06-c3afbfd")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/amirouche/termbox-truecolor.git")
> +                    (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))

It’s better to let-bind the commit and then use (git-version "1.1.0"
commit), because the last release was 1.1.0.

“2019.01.06” is not a version string and it would always be considered a
more recent version than other releases because 2019 is larger than most
major release numbers.
> +    (arguments
> +     `(#:tests? #f))

Could you tell us why the tests are disabled?  If there are no tests
please add a comment “; there are no tests”.

> +    (synopsis "Library for writing text-based user interfaces (with true-color support)")

I think “guix lint” said something about this synopsis being too long.
Could you shorten it a bit?

> +    (home-page
> "https://github.com/amirouche/termbox-truecolor/tree/truecolor")

I think the “tree/truecolor” bit can be removed.

-- 
Ricardo