GNU bug report logs - #34376
How to submit a bug fix?

Previous Next

To reply to this bug, email your comments to 34376 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Gering <Richard.Gering <at> microfocus.com>
To: "bug-diffutils <at> gnu.org" <bug-diffutils <at> gnu.org>
Subject: How to submit a bug fix?
Date: Fri, 8 Feb 2019 00:40:38 +0000

[Message part 1 (text/plain, inline)]

Greetings,

I discovered a bug in GNU diff 3.7 that causes it to not report differences on Windows if two files have the same size and timestamp.

A fix for this bug was made. I also had to make some changes to allow the code to get cross-compiled via Mingw64.

Are you interested in receiving these fixes? If so, how would you like me to submit them? Create a patch file or send the modified source files (small) in their entirety.

Unrelated, but I'm curious how gnulib-tests/setlocale.c is supposed to get compiled, as the code relies on a localename.h file that is neither included nor generated, and I couldn't find any documentation towards this file either. It is easily solved by creating a stub localename.h file, but is that the expected solution?

Thanks in advance for your reply. I look forward to hearing from you.

With kind regards,

- Richard.

[Message part 2 (text/html, inline)]

Message #8 received at 34376 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Richard Gering <Richard.Gering <at> microfocus.com>, 34376 <at> debbugs.gnu.org
Subject: [bug-diffutils] bug#34376: How to submit a bug fix?
Date: Fri, 19 Jul 2019 14:12:02 -0700

[Message part 1 (text/plain, inline)]

Richard Gering wrote:
> Are you interested in receiving these fixes? If so, how would you like me to submit them? Create a patch file or send the modified source files (small) in their entirety.

A patch file would be better. 'git format-patch' generates a good format; the 
attached patch uses that format.

system.h says this:

   It's possible for two distinct files on a buggy file system to have
   the same attributes, but it's not worth slowing down all
   implementations (or complicating the configuration) to cater to
   these rare cases in buggy implementations.

Please keep that in mind when proposing a patch.

> I'm curious how gnulib-tests/setlocale.c is supposed to get compiled, as the code relies on a localename.h file that is neither included nor generated, and I couldn't find any documentation towards this file either

Thanks for reporting that. I installed the attached patch to work around the 
problem.

[0001-maint-avoid-Gnulib-setlocale-module.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.