GNU bug report logs - #34373
26.1; Missing range check in rx-submatch-n

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34373: closed (26.1; Missing range check in rx-submatch-n)
Date: Sun, 23 Jun 2019 18:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 23 Jun 2019 20:34:07 +0200
with message-id <DC6162F8-B2D6-412D-9902-A84A1189C3B4 <at> acm.org>
and subject line Re: bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n)
has caused the debbugs.gnu.org bug report #34373,
regarding 26.1; Missing range check in rx-submatch-n
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34373: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34373
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; Missing range check in rx-submatch-n
Date: Thu, 7 Feb 2019 19:01:33 +0100

`rx' should protect its own abstractions and never generate an invalid regexp, but will if given a bad submatch number:

(rx (group-n 0 "x"))
=> "\\(?0:x\\)"

It's a missing range check in rx-submatch-n.

In GNU Emacs 26.1 (build 1, x86_64-apple-darwin14.5.0, NS appkit-1348.17 Version 10.10.5 (Build 14F2511))
 of 2018-05-31 built on builder10-10.porkrind.org
Windowing system distributor 'Apple', version 10.3.1671

[Message part 3 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 34373-done <at> debbugs.gnu.org
Subject: Re: bug#34373: Acknowledgement (26.1; Missing range check in
 rx-submatch-n)
Date: Sun, 23 Jun 2019 20:34:07 +0200

23 juni 2019 kl. 20.20 skrev Lars Ingebrigtsen <larsi <at> gnus.org>:
> 
> This looks like an eminently reasonable sanity check to me, but I'm
> quite unfamiliar with the rx machinery.  Just push the change?

Thank you, pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.