Subject: bug#34371: closed (Re: [bug#34371] [PATCH] gnu: emacs: Add modules support.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 04 Mar 2019 13:41:02 +0000

Your bug report

#34371: [PATCH] gnu: emacs: Add modules support.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34371: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34371
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#34371] [PATCH] gnu: emacs: Add modules support.
From: Ludovic Courtès <[email-masked]>
To: Ricardo Wurmus <[email-masked]>
Cc: [email-masked], Pierre-Antoine Rouby <[email-masked]>
Date: Mon, 04 Mar 2019 14:40:28 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Ricardo Wurmus <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>
>> Hello Pierre-Antoine,
>>
>> Pierre-Antoine Rouby <[email-masked]> skribis:
>>
>>> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
>>> ---
>>>  gnu/packages/emacs.scm | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 7e8dcadf9..40d280f3e 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -115,6 +115,7 @@
>>>      (build-system glib-or-gtk-build-system)
>>>      (arguments
>>>       `(#:tests? #f  ; no check target
>>> +       #:configure-flags (list "--with-modules")
>>
>> What effect does it have?  (I guess I’m a noob!)
>>
>> If the Emacsfolks among us are fine with it, then so be it!
>
> This allows one to build and load native C modules.  It’s a heavy-weight
> extension mechanism (that one could use to extend Emacs with Guile
> support, for example).
>
> I don’t object to this change.

Alright, applied.

Thanks Ricardo and Brett for chiming in!

Ludo’.

Subject: [PATCH] gnu: emacs: Add modules support.
From: Pierre-Antoine Rouby <[email-masked]>
To: [email-masked]
Cc: Pierre-Antoine Rouby <[email-masked]>
Date: Thu, 7 Feb 2019 17:43:47 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
---
 gnu/packages/emacs.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7e8dcadf9..40d280f3e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -115,6 +115,7 @@
     (build-system glib-or-gtk-build-system)
     (arguments
      `(#:tests? #f  ; no check target
+       #:configure-flags (list "--with-modules")
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'fix-/bin/pwd
-- 
2.20.1